[{"id":24122,"web_url":"https://patchwork.libcamera.org/comment/24122/","msgid":"","date":"2022-07-25T19:57:18","subject":"Re: [libcamera-devel] [PATCH 05/15] DNI: ipa: raspberrypi: Code\n\trefactoring to match style guidelines","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Mon, Jul 25, 2022 at 02:46:29PM +0100, Naushir Patuck via libcamera-devel wrote:\n> Refactor the source files under src/ipa/raspberrypi/controller/d* to match the\n> recommended formatting guidelines for the libcamera project. The vast majority\n> of changes in this commit comprise of switching from snake_case to CamelCase,\n> and starting class member functions with a lower case character.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> .../controller/denoise_algorithm.hpp | 2 +-\n> .../raspberrypi/controller/device_status.cpp | 18 +++++++++---------\n> src/ipa/raspberrypi/controller/device_status.h | 16 ++++++++--------\n> 3 files changed, 18 insertions(+), 18 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1C22CC3275\n\tfor ;\n\tMon, 25 Jul 2022 19:57:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 313FB63312;\n\tMon, 25 Jul 2022 21:57:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D54A96330A\n\tfor ;\n\tMon, 25 Jul 2022 21:57:23 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 49C3E6D1;\n\tMon, 25 Jul 2022 21:57:23 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658779045;\n\tbh=eFLvxgOxSZxiTrTglUX4ZUGRZDJNV1KcMD7uhHfZuFU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=t2YPjGath73T6rTsX6EMG5aqf4xTnaUZJO+pph2KJw8/CneWH0VlDqKJYiL0uv8bg\n\tAC5CQoLMP/MTG5vq91/yRHRvqxICjmzpLZx+DmEeFQyuSYjAJP1iL4OaW/5NI1OfHk\n\tXcIQ0KK+fpuVAzJ8/cmAR8KtRCf2CSy7IWXMBV4T2/uM1arQfVDdkBbb/ChYOoU8kV\n\tM2EA7F8gARLOKASxZDXKL9LHsh/+0NclmbisFOupgVgL4iPUHAGgrT9stVTX5QcBYQ\n\tm6wTcoKY9Lj12J92eiQ3eM5//k4e/SiDHTdPpMIMMSVs6YnDXheg0BSIu1eUFTVx9b\n\t9M548xe3XkGMQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658779043;\n\tbh=eFLvxgOxSZxiTrTglUX4ZUGRZDJNV1KcMD7uhHfZuFU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=If3r8NRQy+fe+xFCNrxbZ2fFn7YoqcwH49LehlHGrh/vGmEaLYkuuXYxbDmaN5P/L\n\tWjmXV37dgFbbrv+QrjGESOVn9TGCGXmoE/dAQZg9BAvUn3uruUcWCjTgsDdBKKxoRm\n\tUGL4VUOFZeeBZBI/h+6ERsaBCi5TzMPjm4ENekJw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"If3r8NRQ\"; dkim-atps=neutral","Date":"Mon, 25 Jul 2022 22:57:18 +0300","To":"Naushir Patuck ","Message-ID":"","References":"<20220725134639.4572-1-naush@raspberrypi.com>\n\t<20220725134639.4572-6-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220725134639.4572-6-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 05/15] DNI: ipa: raspberrypi: Code\n\trefactoring to match style guidelines","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]