[{"id":24121,"web_url":"https://patchwork.libcamera.org/comment/24121/","msgid":"","date":"2022-07-25T19:54:09","subject":"Re: [libcamera-devel] [PATCH 04/15] DNI: ipa: raspberrypi: Code\n\trefactoring to match style guidelines","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Mon, Jul 25, 2022 at 02:46:28PM +0100, Naushir Patuck via libcamera-devel wrote:\n> Refactor the source files under src/ipa/raspberrypi/controller/c* to match the\n> recommended formatting guidelines for the libcamera project. The vast majority\n> of changes in this commit comprise of switching from snake_case to CamelCase,\n> and starting class member functions with a lower case character.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/controller/camera_mode.h | 16 ++--\n> .../raspberrypi/controller/ccm_algorithm.hpp | 2 +-\n> .../controller/contrast_algorithm.hpp | 4 +-\n> src/ipa/raspberrypi/controller/controller.cpp | 74 ++++++++++---------\n> src/ipa/raspberrypi/controller/controller.hpp | 22 +++---\n> 5 files changed, 60 insertions(+), 58 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C33DFC3275\n\tfor ;\n\tMon, 25 Jul 2022 19:54:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12CC463312;\n\tMon, 25 Jul 2022 21:54:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A2996330A\n\tfor ;\n\tMon, 25 Jul 2022 21:54:14 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DECA36D1;\n\tMon, 25 Jul 2022 21:54:13 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658778856;\n\tbh=4lzgJce93JkTRKgEp8Gkht9jpHiGBZpeTQVCs61TCgU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=0ON2YVHzPGqWZbmzlq93FnkV0emaioLXCFp7pIHbjiX4YMxE65MKluPI8JU4mif4U\n\tl3RTglbBJc34d5fBJNfPd/8/pr8jeq2MCamEY9X2qzIuoFkc0Op5GBT2ZQpTJ8B7fG\n\tGRI5NNsRaZTXtfPOe98O4L14WWRK0bjxWl7D9IEmwu/VJI39a3KijbiNyerj+i38h1\n\thgE+8kFLP6ZwDRd79IM6/d2sC7pW2bIXu/MyHnS1oWIK6rvDVNgpO0FpJSd5/pt0+2\n\tZkRDZGuy+/XMfgURzdmOGnO0VHOU7ih/1u/b5H9GxoXNlh/5vLSn2C6EyNfQR7RVYK\n\twBrPAeWsh4YCw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658778854;\n\tbh=4lzgJce93JkTRKgEp8Gkht9jpHiGBZpeTQVCs61TCgU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jurj14upQJ95HMKZaVKWAHKjfKmZ94jmInqryS/XP24D52segAswkiB12MqceK2BB\n\tZ9OzbZl4GVJO0CYyvFTN1K6d2XihbMiyjQF3nRLBs/6yN1eBEQsdeuYXnTJWKD8Mwy\n\t7C3dH9WSrG1hVnnMmPEhK4YtzVUw6KFUpgs69QLI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"jurj14up\"; dkim-atps=neutral","Date":"Mon, 25 Jul 2022 22:54:09 +0300","To":"Naushir Patuck ","Message-ID":"","References":"<20220725134639.4572-1-naush@raspberrypi.com>\n\t<20220725134639.4572-5-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220725134639.4572-5-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 04/15] DNI: ipa: raspberrypi: Code\n\trefactoring to match style guidelines","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]