[{"id":24120,"web_url":"https://patchwork.libcamera.org/comment/24120/","msgid":"","date":"2022-07-25T19:50:14","subject":"Re: [libcamera-devel] [PATCH 03/15] DNI: ipa: raspberrypi: Code\n\trefactoring to match style guidelines","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Mon, Jul 25, 2022 at 02:46:27PM +0100, Naushir Patuck via libcamera-devel wrote:\n> Refactor the source files under src/ipa/raspberrypi/controller/a* to match the\n> recommended formatting guidelines for the libcamera project. The vast majority\n> of changes in this commit comprise of switching from snake_case to CamelCase,\n> and starting class member functions with a lower case character.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> .../raspberrypi/controller/agc_algorithm.hpp | 19 +++++++-------\n> src/ipa/raspberrypi/controller/agc_status.h | 22 ++++++++--------\n> src/ipa/raspberrypi/controller/algorithm.cpp | 20 +++++++-------\n> src/ipa/raspberrypi/controller/algorithm.hpp | 26 +++++++++----------\n> .../raspberrypi/controller/awb_algorithm.hpp | 6 ++---\n> src/ipa/raspberrypi/controller/awb_status.h | 8 +++---\n> 6 files changed, 51 insertions(+), 50 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 94C1BBE173\n\tfor ;\n\tMon, 25 Jul 2022 19:50:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D80E963312;\n\tMon, 25 Jul 2022 21:50:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 75C046330A\n\tfor ;\n\tMon, 25 Jul 2022 21:50:19 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E3FD96D1;\n\tMon, 25 Jul 2022 21:50:18 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658778620;\n\tbh=RL94QwyOfU03+TL3wgpUsV7eLzFBPMz1/NF3Da/BHdA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=RhJ+e3JE6dWr9wbK9Cdeq7IvrErNHrWru6E2KLiitNZU7BZs7VctvB7GnnRs9EEiR\n\tHWSwRVMc5lZOWKCm8mOtpd6CxfKO3ia7rFZKBiVdYiKLcYUpkltbV7k5EkE0VWlgcz\n\tyEvgIQ9PjM795APkL03URPjeG//G6++iEzCiG0YNonzlm39L4swd2w3r2hihd1SH33\n\tG5XFT1X9UZTpyuyyhQ8WdJUbHWcDB3pNebka1qCLjtSDLpWzqMrQFC9iRaTLdMte0k\n\tlG7nKQSt+RrP+ZLMThIyfL+kBzgVFJuPOYRq5R5Q9oFQOGFuNlH2OSqvIlhWLHTEAZ\n\ty6XhwhIiU913g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658778619;\n\tbh=RL94QwyOfU03+TL3wgpUsV7eLzFBPMz1/NF3Da/BHdA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UVn4x6Lf27ltrJPWZM2X1hZLMAPt3jsalOIxcbn6DPoylmbmxwaB+RQaJECwyvKJs\n\tYOJ6Vf/Yp1KB0FSvjgaEuO0ja2s4/eY78UG3HX77MWtxSZ6nC4ea2J6LMMRjLYZbR4\n\tYY77GuCVgHTMPgjUCFmKeXN5mC1gL6OXtoDAb8jM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"UVn4x6Lf\"; dkim-atps=neutral","Date":"Mon, 25 Jul 2022 22:50:14 +0300","To":"Naushir Patuck ","Message-ID":"","References":"<20220725134639.4572-1-naush@raspberrypi.com>\n\t<20220725134639.4572-4-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220725134639.4572-4-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 03/15] DNI: ipa: raspberrypi: Code\n\trefactoring to match style guidelines","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]