[{"id":24119,"web_url":"https://patchwork.libcamera.org/comment/24119/","msgid":"","date":"2022-07-25T19:47:33","subject":"Re: [libcamera-devel] [PATCH 02/15] DNI: ipa: raspberrypi: Code\n\trefactoring to match style guidelines","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Mon, Jul 25, 2022 at 02:46:26PM +0100, Naushir Patuck via libcamera-devel wrote:\n> Refactor the source files src/ipa/raspberrypi/cam_helper* to match the\n> recommended formatting guidelines for the libcamera project. The vast majority\n> of changes in this commit comprise of switching from snake_case to CamelCase,\n> and starting class member functions with a lower case character.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/cam_helper.cpp | 88 +++++++++++------------\n> src/ipa/raspberrypi/cam_helper.hpp | 40 +++++------\n> src/ipa/raspberrypi/cam_helper_imx219.cpp | 34 ++++-----\n> src/ipa/raspberrypi/cam_helper_imx290.cpp | 32 ++++-----\n> src/ipa/raspberrypi/cam_helper_imx296.cpp | 24 +++----\n> src/ipa/raspberrypi/cam_helper_imx477.cpp | 72 +++++++++----------\n> src/ipa/raspberrypi/cam_helper_imx519.cpp | 70 +++++++++---------\n> src/ipa/raspberrypi/cam_helper_ov5647.cpp | 44 ++++++------\n> src/ipa/raspberrypi/cam_helper_ov9281.cpp | 28 ++++----\n> 9 files changed, 216 insertions(+), 216 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B3B2CC3275\n\tfor ;\n\tMon, 25 Jul 2022 19:47:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EC92163312;\n\tMon, 25 Jul 2022 21:47:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DD3BE6330A\n\tfor ;\n\tMon, 25 Jul 2022 21:47:38 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6456F6D1;\n\tMon, 25 Jul 2022 21:47:38 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658778461;\n\tbh=VfHyiKOAi6PxljG3zz35jXw4QZFYFdW0VpF2y+UxYvY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=oaiTKXt6ZFM86oABRwxpZl4hJ9tOYP6KdBBsOjTlpUUo8uR8F+cY4M//MurlzA9TA\n\tgyOO277/JTAF6JzwKPaEy1BDJzNd7c9Xdcvsy/M661KzGt1vGPtKoLtfYElWXl0Xof\n\tdEjb/w5CETSwIb16XlTmLkfKQwq6tTDMZFlDp7DZXoqrxeFUNklw9aG4qZQecGBCfZ\n\tJAjK30H54hTBPe3itThxoro4XvDDRUs53978Q5WGaxrNtAoQIXDOjBuhaRagYtbA3q\n\tBLq0WqsGO2OMhdCPUh/LtYMJS/hMbxozvYP8IRItMrrWwGq6lVDLqXVadcEnwsGpBs\n\t7J4itZssqKb4w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658778458;\n\tbh=VfHyiKOAi6PxljG3zz35jXw4QZFYFdW0VpF2y+UxYvY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Zw60Lokr2RgLWijESSjo2jW6UOkhLoE8moxrFiDhQgDTkUv0Rzz1i2W4ZncsobWN9\n\tHffHutwZUzIGGBfRzSA/mg+xK2/bFz5QEcGPvWQ5k6RQeL539EERBpnwND3e2+91NO\n\tZ1QGSKfUx+nNdWIbrXfkzlrVY7xqC4wcRy3UlvXQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Zw60Lokr\"; dkim-atps=neutral","Date":"Mon, 25 Jul 2022 22:47:33 +0300","To":"Naushir Patuck ","Message-ID":"","References":"<20220725134639.4572-1-naush@raspberrypi.com>\n\t<20220725134639.4572-3-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220725134639.4572-3-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 02/15] DNI: ipa: raspberrypi: Code\n\trefactoring to match style guidelines","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]