[{"id":24161,"web_url":"https://patchwork.libcamera.org/comment/24161/","msgid":"","date":"2022-07-26T22:32:19","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: camera: Fix\n\tdocumentation typo","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Sun, Jul 24, 2022 at 08:13:53PM +0530, Umang Jain via libcamera-devel wrote:\n> Signed-off-by: Umang Jain \n> ---\n> src/libcamera/camera.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 2a8ef60e..3910915c 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -358,8 +358,8 @@ bool isRaw(const PixelFormat &pixFmt)\n> * \\return A CameraConfiguration::Status value that describes the validation\n> * status.\n> * \\retval CameraConfigutation::Adjusted The configuration has been adjusted\n> - * and is now valid. The color space of some or all of the streams may bave\n> - * benn changed. The caller shall check the color spaces carefully.\n> + * and is now valid. The color space of some or all of the streams may have\n\nIt took me a while to see the s/b/h/\n\nReviewed-by: Laurent Pinchart \n\nYou can push this already.\n\n> + * been changed. The caller shall check the color spaces carefully.\n> * \\retval CameraConfiguration::Valid The configuration was already valid and\n> * hasn't been adjusted.\n> */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 873BEC3275\n\tfor ;\n\tTue, 26 Jul 2022 22:32:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E1AE663312;\n\tWed, 27 Jul 2022 00:32:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC27E6330A\n\tfor ;\n\tWed, 27 Jul 2022 00:32:21 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2298856D;\n\tWed, 27 Jul 2022 00:32:21 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658874742;\n\tbh=qdKxx3Dk1ab4yXZuAG+JSw1m2QZ4rWZT4UNthoul45E=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=0hdfnGzJT6MTi4l0vgea8pyJtQxJitQ4Jd9kRI0RuYSsaZlmfdtVnTw0lW3kYsDcE\n\tgiENKkAkg6bKWP77wSiQY64pDWsN0XO2/ZkR21N49BbmiD5XPjgIdIytnLfxVEI1yR\n\t2b0gSGEJaFkLJkj3+kySIdCe3R8irtDojhW4511kkle/FPRD7WnllH25IEaC1R8/CN\n\tdearMKao8nCD2F3cDW0HWNn1eESMq4u6hWXi1Kwnu9I+o4v76qud2nUojxRPKaH9ow\n\topfffg4VnxkTkWd0xGIzRGK3l+KmeMsxAXw2adzrnJ9dOjupaTZQ0HyR9qHm5Rfbma\n\tNcBr5er2QzP3w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658874741;\n\tbh=qdKxx3Dk1ab4yXZuAG+JSw1m2QZ4rWZT4UNthoul45E=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=idNBDZyi+A9KSESEF9hi8udUkYw+mCEziWIFDZDqGN6nXTyfFyiXDEFpQ2xDcQsEG\n\tDBVmjdEZZtBKUz6N7N0AlQQWS0TFK75Eef3EKK86SLyd+8LgVgO99f+6gVXNit3oRz\n\tM7khd4iW2vIzB0UBg3o8O50e7LEDd0ZBIZZnmedw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"idNBDZyi\"; dkim-atps=neutral","Date":"Wed, 27 Jul 2022 01:32:19 +0300","To":"Umang Jain ","Message-ID":"","References":"<20220724144355.104978-1-umang.jain@ideasonboard.com>\n\t<20220724144355.104978-2-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220724144355.104978-2-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: camera: Fix\n\tdocumentation typo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"rishikeshdonadkar@gmail.com, libcamera-devel@lists.libcamera.org,\n\tvedantparanjape160201@gmail.com, nicolas.dufresne@collabora.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]