[{"id":24078,"web_url":"https://patchwork.libcamera.org/comment/24078/","msgid":"","date":"2022-07-23T17:49:02","subject":"Re: [libcamera-devel] [PATCH v2 8/8] libcamera: v4l2_pixelformat:\n\tMap formats::MJPEG to V4L2_PIX_FMT_JPEG","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Sat, Jul 23, 2022 at 11:53:30AM +0200, Jacopo Mondi via libcamera-devel wrote:\n> Map the application visibile formats::MJPEG format to the V4L2_PIX_FMT_JPEG\n> format.\n> \n> Both V4L2_PIX_FMT_JPEG and V4L2_PIX_FMT_MJPEG map to the same libcamera\n> MJPEG format.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/v4l2_pixelformat.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index 7ab63f092a28..8d3bc5d534c5 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -183,6 +183,8 @@ const std::map vpf2pf{\n> \t/* Compressed formats. */\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_MJPEG),\n> \t\t{ formats::MJPEG, \"Motion-JPEG\" } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_JPEG),\n> +\t\t{ formats::MJPEG, \"JPEG JFIF\" } },\n\nMaybe swapped for alphabetical order ?\n\nOtherwise it looks good to me, but I'd squash it with 7/8.\n\n> };\n> \n> } /* namespace */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 48360BE173\n\tfor ;\n\tSat, 23 Jul 2022 17:49:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 043C063312;\n\tSat, 23 Jul 2022 19:49:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E9C8603F8\n\tfor ;\n\tSat, 23 Jul 2022 19:49:05 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 389429F7;\n\tSat, 23 Jul 2022 19:49:05 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658598547;\n\tbh=A8gRyS703TYAjWJtwF4VL+3qt1STF1Zx13IyhNpwwhw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=V0nkfCrD3Xl1mMQ8z0puMFxg/jg8eHUBqX8kr559E6/LWkEA+TWzHhlQo2MB9oiMd\n\t04zQcQP5u/vq14QatOaMLZiOMIogCvSKP3WdHuaveoutX0uEQ1eZLwqMOABaopykcL\n\tgz1fTwNoNybLXXV0Mfnnxb7vnihFq99wtUU7qWjdTjSd23r5arqDgvLcjInW/oDs9G\n\tzUVUx+qc5mh6eed8u6ftNitA8ZXWzmghYfSrQnqaCVu8r6mVBoyPPifknUr6idbDAF\n\tJNKJ1QhSNK6i+yAynmPVEwc3XlMdApGf5SqNsaAZgGEiZZ3M1aj9bqjwPHT9jhr6y7\n\t6pCR6LPJsLBmQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658598545;\n\tbh=A8gRyS703TYAjWJtwF4VL+3qt1STF1Zx13IyhNpwwhw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fwtx0vQBG70pAbdlLPBLXHqy2cPlzoOqxyAmCud3pAKOFrKLtFUF6qbmf9a0siqKI\n\tIZhOG6EXPSwBT+gi7PgDePGsOBcNDIlvqgeWrfP8DMha3VWtY/uDX/ROQwME/3Bcy0\n\tQODpeebMmonRTgIVZLUv0a8iMCGPj6p7CJewJvOg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"fwtx0vQB\"; dkim-atps=neutral","Date":"Sat, 23 Jul 2022 20:49:02 +0300","To":"Jacopo Mondi ","Message-ID":"","References":"<20220723095330.43542-1-jacopo@jmondi.org>\n\t<20220723095330.43542-9-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220723095330.43542-9-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 8/8] libcamera: v4l2_pixelformat:\n\tMap formats::MJPEG to V4L2_PIX_FMT_JPEG","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, jozef@mlich.cz,\n\tPavel Machek ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]