[{"id":24077,"web_url":"https://patchwork.libcamera.org/comment/24077/","msgid":"","date":"2022-07-23T17:47:35","subject":"Re: [libcamera-devel] [PATCH v2 7/8] libcamera: formats: Map\n\tV4L2_PIX_FMT_JPEG to formats::MJPEG","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Sat, Jul 23, 2022 at 11:53:29AM +0200, Jacopo Mondi via libcamera-devel wrote:\n> The V4L2_PIX_FMT_JPEG and V4L2_PIX_FMT_MJPEG formats are under-specified\n> and are used interchangeably by kernel drivers.\n> \n> Map both of them to formats::MJPEG and use the newly re-introduced\n> V4L2VideoDevice::toV4L2PixelFormat() to map to the one actually used by\n> the video device.\n> \n> Signed-off-by: Jacopo Mondi \n\nWith the two vectors merged as proposed in the review of an earlier\npatch,\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/formats.cpp | 5 ++++-\n> 1 file changed, 4 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 86fc698a0f4e..564ccc1b5a62 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -948,7 +948,10 @@ const std::map pixelFormatInfo{\n> \t\t.name = \"MJPEG\",\n> \t\t.format = formats::MJPEG,\n> \t\t.v4l2Formats = {\n> -\t\t\t.single = { V4L2PixelFormat(V4L2_PIX_FMT_MJPEG) },\n> +\t\t\t.single = {\n> +\t\t\t\t\tV4L2PixelFormat(V4L2_PIX_FMT_MJPEG),\n> +\t\t\t\t\tV4L2PixelFormat(V4L2_PIX_FMT_JPEG),\n> +\t\t\t},\n> \t\t\t.multi = { V4L2PixelFormat() },\n> \t\t},\n> \t\t.bitsPerPixel = 0,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 90F27BE173\n\tfor ;\n\tSat, 23 Jul 2022 17:47:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4B88D63312;\n\tSat, 23 Jul 2022 19:47:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E742603F8\n\tfor ;\n\tSat, 23 Jul 2022 19:47:38 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 131019F7;\n\tSat, 23 Jul 2022 19:47:38 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658598460;\n\tbh=LxqLtA82BIWEuB+82d1S1ojJcTVyZVC1khnApGhXvC0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=PAz/pYTT7y0Hed4Sl0ejl8Owz+ENje/0ts9hWvklOItj8jps4438vMaAMKdiIioH6\n\tfjtM+gwS+a6SfHLVbHO8BwkI4+CEFdk0nPjqb+AT3pkk6ShQ9YO9joxtpCQKYCFvrm\n\tw2KVC8auc/wf1iJsEEig583XQxAdcBjevq5tncRE0Y6n6SKER40XHKOyxA5hjkleCd\n\tiHD1uXsCVRrS/RSYzABKycZvq0dh3liWbSD7KHFAdOzLK02xfZHmdp6E04+SZXiic2\n\tAxfg78k6fN+wUsmDEpoia2MgF4P18rn5Z3aN8QY8LvblYzzsneIG+RiQPmTGvrMK9q\n\tTJ+lE87CNI6Fg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658598458;\n\tbh=LxqLtA82BIWEuB+82d1S1ojJcTVyZVC1khnApGhXvC0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=M5P9FmpNZe87b3NVes8dIINq6GR9CkKV0u5ZYf4X8APQJpi34zZlFpjl7C84yPrri\n\tKR4eB851InUZ+AHHTZ2JMhK5YntTN0sOhETNr9imkiexWbwCESf0vRVJ1+GTnnxMrC\n\tCnx9ihfd0lDMqncLlgHuqDU9HHhZlg1MFEzKoOBg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"M5P9FmpN\"; dkim-atps=neutral","Date":"Sat, 23 Jul 2022 20:47:35 +0300","To":"Jacopo Mondi ","Message-ID":"","References":"<20220723095330.43542-1-jacopo@jmondi.org>\n\t<20220723095330.43542-8-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220723095330.43542-8-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 7/8] libcamera: formats: Map\n\tV4L2_PIX_FMT_JPEG to formats::MJPEG","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, jozef@mlich.cz,\n\tPavel Machek ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]