[{"id":24073,"web_url":"https://patchwork.libcamera.org/comment/24073/","msgid":"","date":"2022-07-23T17:14:04","subject":"Re: [libcamera-devel] [PATCH v2 3/8] libcamera: v4l2_pixelformat:\n\tReturn a format list in fromPixelFormat()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Sat, Jul 23, 2022 at 11:53:25AM +0200, Jacopo Mondi via libcamera-devel wrote:\n> As we prepare to associate multiple V4L2 FourCC to a single libcamera\n> format, make the V4L2PixelFormat::fromPixelFormat() return a list of\n> formats and convert all its users to pick the first one.\n> \n> This change prepares to re-introduce V4L2VideoDevice::toV4L2PixelFormat()\n> which will instead match the list of V4L2 FourCC against the formats\n> supported by the video device.\n\nI think it would be easier to first re-introduce\nV4L2VideoDevice::toV4L2PixelFormat(), so that changing\nV4L2PixelFormat::fromPixelFormat() will not have to update a large\nnumber of callers.\n\n> While at it, reword the V4L2PixelFormat::fromPixelFormat() documentation\n> to distinguish between planar/multiplanar and contiguous/non-contiguous.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> include/libcamera/internal/v4l2_pixelformat.h | 6 ++++--\n> src/libcamera/pipeline/ipu3/cio2.cpp | 2 +-\n> src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-\n> .../pipeline/raspberrypi/raspberrypi.cpp | 12 +++++------\n> src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 6 +++---\n> src/libcamera/pipeline/simple/converter.cpp | 8 ++++----\n> src/libcamera/pipeline/simple/simple.cpp | 4 ++--\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 6 +++---\n> src/libcamera/pipeline/vimc/vimc.cpp | 8 ++++----\n> src/libcamera/v4l2_pixelformat.cpp | 20 +++++++++----------\n> src/v4l2/v4l2_camera_proxy.cpp | 6 +++---\n> test/libtest/buffer_source.cpp | 2 +-\n> 12 files changed, 42 insertions(+), 40 deletions(-)\n> \n> diff --git a/include/libcamera/internal/v4l2_pixelformat.h b/include/libcamera/internal/v4l2_pixelformat.h\n> index fb2d5d0b93df..750f31fc1926 100644\n> --- a/include/libcamera/internal/v4l2_pixelformat.h\n> +++ b/include/libcamera/internal/v4l2_pixelformat.h\n> @@ -11,6 +11,7 @@\n> #include \n> #include \n> #include \n> +#include \n> \n> #include \n> \n> @@ -44,8 +45,9 @@ public:\n> \tconst char *description() const;\n> \n> \tPixelFormat toPixelFormat() const;\n> -\tstatic V4L2PixelFormat fromPixelFormat(const PixelFormat &pixelFormat,\n> -\t\t\t\t\t bool multiplanar = false);\n> +\tstatic std::vector\n> +\t\tfromPixelFormat(const PixelFormat &pixelFormat,\n> +\t\t\t\tbool multiplanar = false);\n> \n> private:\n> \tuint32_t fourcc_;\n> diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp\n> index 08e254f75eee..4a13d16973e9 100644\n> --- a/src/libcamera/pipeline/ipu3/cio2.cpp\n> +++ b/src/libcamera/pipeline/ipu3/cio2.cpp\n> @@ -203,7 +203,7 @@ int CIO2Device::configure(const Size &size, V4L2DeviceFormat *outputFormat)\n> \tif (itInfo == mbusCodesToPixelFormat.end())\n> \t\treturn -EINVAL;\n> \n> -\toutputFormat->fourcc = V4L2PixelFormat::fromPixelFormat(itInfo->second);\n> +\toutputFormat->fourcc = V4L2PixelFormat::fromPixelFormat(itInfo->second)[0];\n> \toutputFormat->size = sensorFormat.size;\n> \toutputFormat->planesCount = 1;\n> \n> diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\n> index 59305f85073c..251164001ffd 100644\n> --- a/src/libcamera/pipeline/ipu3/imgu.cpp\n> +++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n> @@ -558,7 +558,7 @@ int ImgUDevice::configureVideoDevice(V4L2VideoDevice *dev, unsigned int pad,\n> \t\treturn 0;\n> \n> \t*outputFormat = {};\n> -\toutputFormat->fourcc = V4L2PixelFormat::fromPixelFormat(formats::NV12);\n> +\toutputFormat->fourcc = V4L2PixelFormat::fromPixelFormat(formats::NV12)[0];\n> \toutputFormat->size = cfg.size;\n> \toutputFormat->planesCount = 2;\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 9d5614152430..6e813bcb094a 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -96,7 +96,7 @@ V4L2DeviceFormat toV4L2DeviceFormat(const V4L2SubdeviceFormat &format,\n> \tconst PixelFormat pix = mbusCodeToPixelFormat(format.mbus_code, packingReq);\n> \tV4L2DeviceFormat deviceFormat;\n> \n> -\tdeviceFormat.fourcc = V4L2PixelFormat::fromPixelFormat(pix);\n> +\tdeviceFormat.fourcc = V4L2PixelFormat::fromPixelFormat(pix)[0];\n> \tdeviceFormat.size = format.size;\n> \tdeviceFormat.colorSpace = format.colorSpace;\n> \treturn deviceFormat;\n> @@ -516,14 +516,14 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n> \n> \t\tV4L2VideoDevice::Formats fmts = dev->formats();\n> \n> -\t\tif (fmts.find(V4L2PixelFormat::fromPixelFormat(cfgPixFmt)) == fmts.end()) {\n> +\t\tif (fmts.find(V4L2PixelFormat::fromPixelFormat(cfgPixFmt)[0]) == fmts.end()) {\n> \t\t\t/* If we cannot find a native format, use a default one. */\n> \t\t\tcfgPixFmt = formats::NV12;\n> \t\t\tstatus = Adjusted;\n> \t\t}\n> \n> \t\tV4L2DeviceFormat format;\n> -\t\tformat.fourcc = V4L2PixelFormat::fromPixelFormat(cfgPixFmt);\n> +\t\tformat.fourcc = V4L2PixelFormat::fromPixelFormat(cfgPixFmt)[0];\n> \t\tformat.size = cfg.size;\n> \t\tformat.colorSpace = cfg.colorSpace;\n> \n> @@ -783,7 +783,7 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n> \t\tRPi::Stream *stream = i == maxIndex ? &data->isp_[Isp::Output0]\n> \t\t\t\t\t\t : &data->isp_[Isp::Output1];\n> \n> -\t\tV4L2PixelFormat fourcc = V4L2PixelFormat::fromPixelFormat(cfg.pixelFormat);\n> +\t\tV4L2PixelFormat fourcc = V4L2PixelFormat::fromPixelFormat(cfg.pixelFormat)[0];\n> \t\tformat.size = cfg.size;\n> \t\tformat.fourcc = fourcc;\n> \t\tformat.colorSpace = cfg.colorSpace;\n> @@ -829,7 +829,7 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n> \t\tmaxSize = Size(320, 240);\n> \t\tformat = {};\n> \t\tformat.size = maxSize;\n> -\t\tformat.fourcc = V4L2PixelFormat::fromPixelFormat(formats::YUV420);\n> +\t\tformat.fourcc = V4L2PixelFormat::fromPixelFormat(formats::YUV420)[0];\n> \t\t/* No one asked for output, so the color space doesn't matter. */\n> \t\tformat.colorSpace = ColorSpace::Jpeg;\n> \t\tret = data->isp_[Isp::Output0].dev()->setFormat(&format);\n> @@ -862,7 +862,7 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n> \n> \t\toutput1Format.size = (format.size / 2).boundedTo(limit).alignedDownTo(2, 2);\n> \t\toutput1Format.colorSpace = format.colorSpace;\n> -\t\toutput1Format.fourcc = V4L2PixelFormat::fromPixelFormat(formats::YUV420);\n> +\t\toutput1Format.fourcc = V4L2PixelFormat::fromPixelFormat(formats::YUV420)[0];\n> \n> \t\tLOG(RPI, Debug) << \"Setting ISP Output1 (internal) to \"\n> \t\t\t\t<< output1Format;\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> index 6f175758665d..f4e71bab00ed 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> @@ -81,7 +81,7 @@ CameraConfiguration::Status RkISP1Path::validate(StreamConfiguration *cfg)\n> \tcfg->bufferCount = RKISP1_BUFFER_COUNT;\n> \n> \tV4L2DeviceFormat format;\n> -\tformat.fourcc = V4L2PixelFormat::fromPixelFormat(cfg->pixelFormat);\n> +\tformat.fourcc = V4L2PixelFormat::fromPixelFormat(cfg->pixelFormat)[0];\n> \tformat.size = cfg->size;\n> \n> \tint ret = video_->tryFormat(&format);\n> @@ -147,7 +147,7 @@ int RkISP1Path::configure(const StreamConfiguration &config,\n> \n> \tconst PixelFormatInfo &info = PixelFormatInfo::info(config.pixelFormat);\n> \tV4L2DeviceFormat outputFormat;\n> -\toutputFormat.fourcc = V4L2PixelFormat::fromPixelFormat(config.pixelFormat);\n> +\toutputFormat.fourcc = V4L2PixelFormat::fromPixelFormat(config.pixelFormat)[0];\n> \toutputFormat.size = config.size;\n> \toutputFormat.planesCount = info.numPlanes();\n> \n> @@ -156,7 +156,7 @@ int RkISP1Path::configure(const StreamConfiguration &config,\n> \t\treturn ret;\n> \n> \tif (outputFormat.size != config.size ||\n> -\t outputFormat.fourcc != V4L2PixelFormat::fromPixelFormat(config.pixelFormat)) {\n> +\t outputFormat.fourcc != V4L2PixelFormat::fromPixelFormat(config.pixelFormat)[0]) {\n> \t\tLOG(RkISP1, Error)\n> \t\t\t<< \"Unable to configure capture in \" << config.toString();\n> \t\treturn -EINVAL;\n> diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\n> index 62d173bb6cd1..47e2150b4332 100644\n> --- a/src/libcamera/pipeline/simple/converter.cpp\n> +++ b/src/libcamera/pipeline/simple/converter.cpp\n> @@ -46,7 +46,7 @@ int SimpleConverter::Stream::configure(const StreamConfiguration &inputCfg,\n> \t\t\t\t const StreamConfiguration &outputCfg)\n> {\n> \tV4L2PixelFormat videoFormat =\n> -\t\tV4L2PixelFormat::fromPixelFormat(inputCfg.pixelFormat);\n> +\t\tV4L2PixelFormat::fromPixelFormat(inputCfg.pixelFormat)[0];\n> \n> \tV4L2DeviceFormat format;\n> \tformat.fourcc = videoFormat;\n> @@ -71,7 +71,7 @@ int SimpleConverter::Stream::configure(const StreamConfiguration &inputCfg,\n> \t}\n> \n> \t/* Set the pixel format and size on the output. */\n> -\tvideoFormat = V4L2PixelFormat::fromPixelFormat(outputCfg.pixelFormat);\n> +\tvideoFormat = V4L2PixelFormat::fromPixelFormat(outputCfg.pixelFormat)[0];\n> \tformat = {};\n> \tformat.fourcc = videoFormat;\n> \tformat.size = outputCfg.size;\n> @@ -210,7 +210,7 @@ std::vector SimpleConverter::formats(PixelFormat input)\n> \t * enumerate the conversion capabilities on its output (V4L2 capture).\n> \t */\n> \tV4L2DeviceFormat v4l2Format;\n> -\tv4l2Format.fourcc = V4L2PixelFormat::fromPixelFormat(input);\n> +\tv4l2Format.fourcc = V4L2PixelFormat::fromPixelFormat(input)[0];\n> \tv4l2Format.size = { 1, 1 };\n> \n> \tint ret = m2m_->output()->setFormat(&v4l2Format);\n> @@ -287,7 +287,7 @@ SimpleConverter::strideAndFrameSize(const PixelFormat &pixelFormat,\n> \t\t\t\t const Size &size)\n> {\n> \tV4L2DeviceFormat format;\n> -\tformat.fourcc = V4L2PixelFormat::fromPixelFormat(pixelFormat);\n> +\tformat.fourcc = V4L2PixelFormat::fromPixelFormat(pixelFormat)[0];\n> \tformat.size = size;\n> \n> \tint ret = m2m_->capture()->tryFormat(&format);\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index bc0cb1a00c2a..33a7b4e57deb 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -918,7 +918,7 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n> \t\t\t\treturn Invalid;\n> \t\t} else {\n> \t\t\tV4L2DeviceFormat format;\n> -\t\t\tformat.fourcc = V4L2PixelFormat::fromPixelFormat(cfg.pixelFormat);\n> +\t\t\tformat.fourcc = V4L2PixelFormat::fromPixelFormat(cfg.pixelFormat)[0];\n> \t\t\tformat.size = cfg.size;\n> \n> \t\t\tint ret = data_->video_->tryFormat(&format);\n> @@ -1028,7 +1028,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> \t\treturn ret;\n> \n> \t/* Configure the video node. */\n> -\tV4L2PixelFormat videoFormat = V4L2PixelFormat::fromPixelFormat(pipeConfig->captureFormat);\n> +\tV4L2PixelFormat videoFormat = V4L2PixelFormat::fromPixelFormat(pipeConfig->captureFormat)[0];\n> \n> \tV4L2DeviceFormat captureFormat;\n> \tcaptureFormat.fourcc = videoFormat;\n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 53b2f23ab029..338aff02aff0 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -149,7 +149,7 @@ CameraConfiguration::Status UVCCameraConfiguration::validate()\n> \tcfg.bufferCount = 4;\n> \n> \tV4L2DeviceFormat format;\n> -\tformat.fourcc = V4L2PixelFormat::fromPixelFormat(cfg.pixelFormat);\n> +\tformat.fourcc = V4L2PixelFormat::fromPixelFormat(cfg.pixelFormat)[0];\n> \tformat.size = cfg.size;\n> \n> \tint ret = data_->video_->tryFormat(&format);\n> @@ -205,7 +205,7 @@ int PipelineHandlerUVC::configure(Camera *camera, CameraConfiguration *config)\n> \tint ret;\n> \n> \tV4L2DeviceFormat format;\n> -\tformat.fourcc = V4L2PixelFormat::fromPixelFormat(cfg.pixelFormat);\n> +\tformat.fourcc = V4L2PixelFormat::fromPixelFormat(cfg.pixelFormat)[0];\n> \tformat.size = cfg.size;\n> \n> \tret = data->video_->setFormat(&format);\n> @@ -213,7 +213,7 @@ int PipelineHandlerUVC::configure(Camera *camera, CameraConfiguration *config)\n> \t\treturn ret;\n> \n> \tif (format.size != cfg.size ||\n> -\t format.fourcc != V4L2PixelFormat::fromPixelFormat(cfg.pixelFormat))\n> +\t format.fourcc != V4L2PixelFormat::fromPixelFormat(cfg.pixelFormat)[0])\n> \t\treturn -EINVAL;\n> \n> \tcfg.setStream(&data->stream_);\n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index 3379ac5cd47d..b88b30fff108 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -171,7 +171,7 @@ CameraConfiguration::Status VimcCameraConfiguration::validate()\n> \tcfg.bufferCount = 4;\n> \n> \tV4L2DeviceFormat format;\n> -\tformat.fourcc = V4L2PixelFormat::fromPixelFormat(cfg.pixelFormat);\n> +\tformat.fourcc = V4L2PixelFormat::fromPixelFormat(cfg.pixelFormat)[0];\n> \tformat.size = cfg.size;\n> \n> \tint ret = data_->video_->tryFormat(&format);\n> @@ -275,7 +275,7 @@ int PipelineHandlerVimc::configure(Camera *camera, CameraConfiguration *config)\n> \t\treturn ret;\n> \n> \tV4L2DeviceFormat format;\n> -\tformat.fourcc = V4L2PixelFormat::fromPixelFormat(cfg.pixelFormat);\n> +\tformat.fourcc = V4L2PixelFormat::fromPixelFormat(cfg.pixelFormat)[0];\n> \tformat.size = cfg.size;\n> \n> \tret = data->video_->setFormat(&format);\n> @@ -283,7 +283,7 @@ int PipelineHandlerVimc::configure(Camera *camera, CameraConfiguration *config)\n> \t\treturn ret;\n> \n> \tif (format.size != cfg.size ||\n> -\t format.fourcc != V4L2PixelFormat::fromPixelFormat(cfg.pixelFormat))\n> +\t format.fourcc != V4L2PixelFormat::fromPixelFormat(cfg.pixelFormat)[0])\n> \t\treturn -EINVAL;\n> \n> \t/*\n> @@ -598,7 +598,7 @@ int VimcCameraData::allocateMockIPABuffers()\n> \tconstexpr unsigned int kBufCount = 2;\n> \n> \tV4L2DeviceFormat format;\n> -\tformat.fourcc = V4L2PixelFormat::fromPixelFormat(formats::BGR888);\n> +\tformat.fourcc = V4L2PixelFormat::fromPixelFormat(formats::BGR888)[0];\n> \tformat.size = Size (160, 120);\n> \n> \tint ret = video_->setFormat(&format);\n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index cf6c1858bd1a..7ab63f092a28 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -302,26 +302,26 @@ PixelFormat V4L2PixelFormat::toPixelFormat() const\n> }\n> \n> /**\n> - * \\brief Convert \\a pixelFormat to its corresponding V4L2PixelFormat\n> + * \\brief Convert \\a pixelFormat to a list of corresponding V4L2PixelFormat\n> * \\param[in] pixelFormat The PixelFormat to convert\n> * \\param[in] multiplanar V4L2 Multiplanar API support flag\n> *\n> - * Multiple V4L2 formats may exist for one PixelFormat when the format uses\n> - * multiple planes, as V4L2 defines separate 4CCs for contiguous and separate\n> - * planes formats. Set the \\a multiplanar parameter to false to select a format\n> - * with contiguous planes, or to true to select a format with non-contiguous\n> - * planes.\n> + * Multiple V4L2 formats may exist for one PixelFormat. This function returns\n> + * the list of V4L2 formats and distinguish if the format describes contiguous\n> + * or non-contiguous planes as V4L2 defines separate 4CCs for the two variants.\n> + * This function uses the \\a multiplanar argument, defaulted to false,\n> + * to select formats with non-contiguous or contiguous planes.\n> *\n> * \\return The V4L2PixelFormat corresponding to \\a pixelFormat\n> */\n> -V4L2PixelFormat V4L2PixelFormat::fromPixelFormat(const PixelFormat &pixelFormat,\n> -\t\t\t\t\t\t bool multiplanar)\n> +std::vector V4L2PixelFormat::fromPixelFormat(const PixelFormat &pixelFormat,\n> +\t\t\t\t\t\t\t bool multiplanar)\n> {\n> \tconst PixelFormatInfo &info = PixelFormatInfo::info(pixelFormat);\n> \tif (!info.isValid())\n> -\t\treturn V4L2PixelFormat();\n> +\t\treturn {};\n> \n> -\treturn multiplanar ? info.v4l2Formats.multi[0] : info.v4l2Formats.single[0];\n> +\treturn multiplanar ? info.v4l2Formats.multi : info.v4l2Formats.single;\n> }\n> \n> /**\n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index 26a227da6db2..55ff62cdb430 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -182,7 +182,7 @@ void V4L2CameraProxy::setFmtFromConfig(const StreamConfiguration &streamConfig)\n> \n> \tv4l2PixFormat_.width = size.width;\n> \tv4l2PixFormat_.height = size.height;\n> -\tv4l2PixFormat_.pixelformat = V4L2PixelFormat::fromPixelFormat(streamConfig.pixelFormat);\n> +\tv4l2PixFormat_.pixelformat = V4L2PixelFormat::fromPixelFormat(streamConfig.pixelFormat)[0];\n> \tv4l2PixFormat_.field = V4L2_FIELD_NONE;\n> \tv4l2PixFormat_.bytesperline = streamConfig.stride;\n> \tv4l2PixFormat_.sizeimage = streamConfig.frameSize;\n> @@ -290,7 +290,7 @@ int V4L2CameraProxy::vidioc_enum_fmt(V4L2CameraFile *file, struct v4l2_fmtdesc *\n> \t\treturn -EINVAL;\n> \n> \tPixelFormat format = streamConfig_.formats().pixelformats()[arg->index];\n> -\tV4L2PixelFormat v4l2Format = V4L2PixelFormat::fromPixelFormat(format);\n> +\tV4L2PixelFormat v4l2Format = V4L2PixelFormat::fromPixelFormat(format)[0];\n> \n> \targ->flags = format == formats::MJPEG ? V4L2_FMT_FLAG_COMPRESSED : 0;\n> \tutils::strlcpy(reinterpret_cast(arg->description),\n> @@ -333,7 +333,7 @@ int V4L2CameraProxy::tryFormat(struct v4l2_format *arg)\n> \n> \targ->fmt.pix.width = config.size.width;\n> \targ->fmt.pix.height = config.size.height;\n> -\targ->fmt.pix.pixelformat = V4L2PixelFormat::fromPixelFormat(config.pixelFormat);\n> +\targ->fmt.pix.pixelformat = V4L2PixelFormat::fromPixelFormat(config.pixelFormat)[0];\n> \targ->fmt.pix.field = V4L2_FIELD_NONE;\n> \targ->fmt.pix.bytesperline = config.stride;\n> \targ->fmt.pix.sizeimage = config.frameSize;\n> diff --git a/test/libtest/buffer_source.cpp b/test/libtest/buffer_source.cpp\n> index 1b261697279a..84f1169c9f5f 100644\n> --- a/test/libtest/buffer_source.cpp\n> +++ b/test/libtest/buffer_source.cpp\n> @@ -72,7 +72,7 @@ int BufferSource::allocate(const StreamConfiguration &config)\n> \t}\n> \n> \tformat.size = config.size;\n> -\tformat.fourcc = V4L2PixelFormat::fromPixelFormat(config.pixelFormat);\n> +\tformat.fourcc = V4L2PixelFormat::fromPixelFormat(config.pixelFormat)[0];\n> \tif (video->setFormat(&format)) {\n> \t\tstd::cout << \"Failed to set format on output device\" << std::endl;\n> \t\treturn TestFail;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA43FC3275\n\tfor ;\n\tSat, 23 Jul 2022 17:14:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9136F63312;\n\tSat, 23 Jul 2022 19:14:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B8F63603F8\n\tfor ;\n\tSat, 23 Jul 2022 19:14:07 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 50D489F7;\n\tSat, 23 Jul 2022 19:14:07 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658596449;\n\tbh=j91PSOMFJpJ0zaWpZlNKt34hHn0H96URYbzeBgIkjAU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=w2rdMI6Th9fw8zSkVwKkwe4y7CtuVLaN/8zLiCVxVlAxYAgDA1o0GjCJvwRXDkezN\n\txo1XyErSPgDNxcPIJEE+lcE8AB8PuzCsI+vDbsG3PlILuqG4uApuOgEEEtbPYjpGko\n\tW1XHAuWR201Ct0nE+6udUCKWYM0UfJwB5UbIPtvf9qYL2dAGwvmi3E9V+Qr5A38PPT\n\tYPqKZyQs2GT+r+UTpcSygm7/3JfwzH0mrBE0/44Fn36yp746OL89MFP36/uKqrziMw\n\tkUSs1IIL4gJHHKhYCluUvGO/klzzOWCjKjW0xiWjPmvrRS3UAayUHbbLbRKTo0fSdn\n\tSbAUVGhJiT1gQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658596447;\n\tbh=j91PSOMFJpJ0zaWpZlNKt34hHn0H96URYbzeBgIkjAU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZIxcdF1s9TE01WwkTHVHgsmg8tFuPAi1t9DC6WJaxcgW36u6t5+/TdGWbZJORYKT/\n\tLc+kEQKRafMKm4fnaW+TCxpG7Fe/tIXFTMgA9u8e0mgijHUDLsMh9w4kosIAMTbBLL\n\tXjm+GJ7UcoOeyQTsTZclszmlTgddv5sKley+ZAu8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ZIxcdF1s\"; dkim-atps=neutral","Date":"Sat, 23 Jul 2022 20:14:04 +0300","To":"Jacopo Mondi ","Message-ID":"","References":"<20220723095330.43542-1-jacopo@jmondi.org>\n\t<20220723095330.43542-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220723095330.43542-4-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 3/8] libcamera: v4l2_pixelformat:\n\tReturn a format list in fromPixelFormat()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, jozef@mlich.cz,\n\tPavel Machek ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]