{"id":16738,"url":"https://patchwork.libcamera.org/api/patches/16738/?format=json","web_url":"https://patchwork.libcamera.org/patch/16738/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220722151635.239221-6-fsylvestre@baylibre.com>","date":"2022-07-22T15:16:35","name":"[libcamera-devel,v2,5/5] ipa: rkisp1: Add support of Defect Pixel Cluster Correction control","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"8d9c13dd3e3e429cf0968ec781d5607366b9d6d9","submitter":{"id":123,"url":"https://patchwork.libcamera.org/api/people/123/?format=json","name":"Florian Sylvestre","email":"fsylvestre@baylibre.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16738/mbox/","series":[{"id":3319,"url":"https://patchwork.libcamera.org/api/series/3319/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3319","date":"2022-07-22T15:16:30","name":"Add GSL, LSC and DPCC tuning support for rkisp1","version":2,"mbox":"https://patchwork.libcamera.org/series/3319/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16738/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16738/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4EB70BD1F1\n\tfor ;\n\tFri, 22 Jul 2022 15:16:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1014563321;\n\tFri, 22 Jul 2022 17:16:53 +0200 (CEST)","from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com\n\t[IPv6:2a00:1450:4864:20::42e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C4AF563315\n\tfor ;\n\tFri, 22 Jul 2022 17:16:48 +0200 (CEST)","by mail-wr1-x42e.google.com with SMTP id d8so6912978wrp.6\n\tfor ;\n\tFri, 22 Jul 2022 08:16:48 -0700 (PDT)","from BL087.. ([2a01:e34:eea9:e630:e9da:4076:6aa:6cd2])\n\tby smtp.gmail.com with ESMTPSA id\n\tb1-20020a5d4d81000000b0021e4fd8e10bsm4871557wru.11.2022.07.22.08.16.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 22 Jul 2022 08:16:47 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658503013;\n\tbh=bFyW4JUEnCaSackTx56yzW4CEXURmCpaUklJwVdeSnM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=gqQ5jRRm5UAEznLqO+EU3VtrlMHFOBo0zJFOmuOTs2WLJq52rQB+GbjvhnoWI3H4S\n\tyv9yJ66G095CSrBENh+5NPs8OM+sQR/A0FmE8JVhJBJsTIw7rG6czyrZldD904ctjm\n\tkk/AoUe1k8Q1K4q9FXhQ77iO/nz+KiNpx/pHgpJF4uOEoocc2RB3EEU5hnogzuh+7/\n\t5rGbILrMwRYWVR5OdwuPT08vBmoy7MoFG8pOM35Sg+wvaeHHkErZjsnKASGPI1x36k\n\t1x2i9QOtvXlK8f+3XJ8+DTK+TW3NzR07933EACElaujDFxuPAKJU68IpGOOA0FCJz/\n\tnQ/W8flbhwk9g==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=baylibre-com.20210112.gappssmtp.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=Wi42NH23iXD/ebJYrLMxC/2ih+jeQJgZqeQSk6mmsDY=;\n\tb=CZRAqHMbsJVdb56efB2omDhHRiMhO//7u8r6svXTOnHme88KA2N4rucrbrM5z57Nym\n\t15P+dgt4+zuJHv/7YsM6mesBYsMXoCQl8AHLpdnlZdnPnokI37GoTGJs4ucGpy2sk0ed\n\t2xI8YiWdvLo9QRckw9IyY4tY+Go7uHTBa07OnTcuE0gvQzO/JfYcnE8iDgwsFvucEv0V\n\tvx/BFLIhcN+eGgnAqHx2qJ9i8RZg1FGSh2FeskJQ+S1fkWxYPymaRgCbPP2diqxX2yYi\n\tFPzUdSvjQsEPg7UviTcDyaN7n72xeZHDa1bu8yzw7JVx3MvmsCQLdEzhJqO1a9FmNX/Y\n\t9yFA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=baylibre-com.20210112.gappssmtp.com\n\theader.i=@baylibre-com.20210112.gappssmtp.com header.b=\"CZRAqHMb\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=Wi42NH23iXD/ebJYrLMxC/2ih+jeQJgZqeQSk6mmsDY=;\n\tb=lVD+dqvWjazpo9RjHSLtWtxASQ1xbH3mCQQfKXAb96K0OPbjN3siXiBnvegDKGXL4H\n\tUjlz4PwJadJ/wPSB2Bj3fMAjwYekiekdhx1LLqh3hqXbjk43/YUJulkDTyOMu5G6bdav\n\t18qQ2xSgd9kv0vz2xSCJZ/ys/+auIPLi1LgXbUkLHxFyPyVnmsHV8wsNAZtKzHEyWO99\n\tFsLE3fX2586PpAhEEJmPL2JHi4TfYddOzftIygmvydXDkZa2/ARaBUiq9mjfP3yDR0dx\n\tnj+1J5I5Ek+2VUEvr6qbKjoHH2LntDx1AhQRQOlANa9z4Dpa8GBagGSsWHzOjbBPtJsV\n\tBIwA==","X-Gm-Message-State":"AJIora9daoA9SjKUllrreqKloOSnVZFSeUoTrZiAbEg1k4NqbG0iH0zN\n\tYwe42bMcjr/KpCP/TFfAyLxtezr/WnmjyJ5B","X-Google-Smtp-Source":"AGRyM1uujGO4AiGIXrBaf7wCoCdnhZQBlcLAulcB3+htaekdY8C+Z/iumQFcdiU0qA3Foiuy3/ZzKQ==","X-Received":"by 2002:adf:e54a:0:b0:21e:61f3:de49 with SMTP id\n\tz10-20020adfe54a000000b0021e61f3de49mr290413wrm.25.1658503008092; \n\tFri, 22 Jul 2022 08:16:48 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 22 Jul 2022 17:16:35 +0200","Message-Id":"<20220722151635.239221-6-fsylvestre@baylibre.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220722151635.239221-1-fsylvestre@baylibre.com>","References":"<20220722151635.239221-1-fsylvestre@baylibre.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 5/5] ipa: rkisp1: Add support of Defect\n\tPixel Cluster Correction control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Florian Sylvestre via libcamera-devel\n\t","Reply-To":"Florian Sylvestre ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The Defect Pixel Cluster Correction algorithm is responsible to minimize\nthe impact of defective pixels. The on-the-fly method is actually used,\nbased on coefficient provided by the tuning file.\n\nSigned-off-by: Florian Sylvestre \n---\n src/ipa/rkisp1/algorithms/dpcc.cpp | 262 ++++++++++++++++++++++++++\n src/ipa/rkisp1/algorithms/dpcc.h | 31 +++\n src/ipa/rkisp1/algorithms/meson.build | 1 +\n src/ipa/rkisp1/data/ov5640.yaml | 60 ++++++\n src/ipa/rkisp1/rkisp1.cpp | 1 +\n 5 files changed, 355 insertions(+)\n create mode 100644 src/ipa/rkisp1/algorithms/dpcc.cpp\n create mode 100644 src/ipa/rkisp1/algorithms/dpcc.h","diff":"diff --git a/src/ipa/rkisp1/algorithms/dpcc.cpp b/src/ipa/rkisp1/algorithms/dpcc.cpp\nnew file mode 100644\nindex 00000000..c1598b6c\n--- /dev/null\n+++ b/src/ipa/rkisp1/algorithms/dpcc.cpp\n@@ -0,0 +1,262 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2021-2022, Ideas On Board\n+ *\n+ * dpcc.cpp - RkISP1 Defect Pixel Cluster Correction control\n+ */\n+\n+#include \"dpcc.h\"\n+\n+#include \n+\n+#include \"libcamera/internal/yaml_parser.h\"\n+\n+#include \"linux/rkisp1-config.h\"\n+\n+/**\n+ * \\file dpcc.h\n+ */\n+\n+namespace libcamera {\n+\n+namespace ipa::rkisp1::algorithms {\n+\n+/**\n+ * \\class DefectPixelClusterCorrection\n+ * \\brief RkISP1 Defect Pixel Cluster Correction control\n+ *\n+ * Depending of the sensor quality, some pixels can be defective and then\n+ * appear significantly brighter or darker than the other pixels.\n+ *\n+ * The Defect Pixel Cluster Correction algorithms is responsible to minimize\n+ * the impact of the pixels.\n+ * This can be done with algorithms applied at run time (on-the-fly method) or\n+ * with a table of defective pixels. Only first method is supported for the\n+ * moment.\n+ */\n+\n+LOG_DEFINE_CATEGORY(RkISP1Dpcc)\n+\n+DefectPixelClusterCorrection::DefectPixelClusterCorrection()\n+\t: initialized_(false), config_({})\n+{\n+}\n+\n+/**\n+ * \\copydoc libcamera::ipa::Algorithm::init\n+ */\n+int DefectPixelClusterCorrection::init([[maybe_unused]] IPAContext &context,\n+\t\t\t\t const YamlObject &tuningData)\n+{\n+\tconfig_.mode =\n+\t\tRKISP1_CIF_ISP_DPCC_MODE_STAGE1_ENABLE;\n+\tconfig_.output_mode =\n+\t\tRKISP1_CIF_ISP_DPCC_OUTPUT_MODE_STAGE1_INCL_G_CENTER |\n+\t\tRKISP1_CIF_ISP_DPCC_OUTPUT_MODE_STAGE1_INCL_RB_CENTER;\n+\n+\tconfig_.set_use = tuningData[\"fixed-set\"].get(false)\n+\t\t\t\t ? RKISP1_CIF_ISP_DPCC_SET_USE_STAGE1_USE_FIX_SET\n+\t\t\t\t : 0;\n+\n+\t/* Get all defined sets to apply (up to 3). */\n+\tconst YamlObject &setsObject = tuningData[\"sets\"];\n+\tif (!setsObject.isList()) {\n+\t\tLOG(RkISP1Dpcc, Error)\n+\t\t\t<< \"'sets' parameter not found in tuning file\";\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (setsObject.size() > RKISP1_CIF_ISP_DPCC_METHODS_MAX) {\n+\t\tLOG(RkISP1Dpcc, Error)\n+\t\t\t<< \"'sets' size in tuning file (\" << setsObject.size()\n+\t\t\t<< \") exceeds the maximum hardware capacity (3)\";\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tfor (std::size_t i = 0; i < setsObject.size(); ++i) {\n+\t\tstruct rkisp1_cif_isp_dpcc_methods_config &method = config_.methods[i];\n+\t\tconst YamlObject &set = setsObject[i];\n+\t\tuint16_t value;\n+\n+\t\t/* Enable set if described in Yaml tuning file. */\n+\t\tconfig_.set_use |= 1 << i;\n+\n+\t\t/* PG Method */\n+\t\tconst YamlObject &pgObject = set[\"pg-factor\"];\n+\n+\t\tif (pgObject.contains(\"green\")) {\n+\t\t\tmethod.method |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_PG_GREEN_ENABLE;\n+\n+\t\t\tvalue = pgObject[\"green\"].get(0);\n+\t\t\tmethod.pg_fac |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_PG_FAC_G(value);\n+\t\t}\n+\n+\t\tif (pgObject.contains(\"red-blue\")) {\n+\t\t\tmethod.method |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_PG_RED_BLUE_ENABLE;\n+\n+\t\t\tvalue = pgObject[\"red-blue\"].get(0);\n+\t\t\tmethod.pg_fac |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_PG_FAC_RB(value);\n+\t\t}\n+\n+\t\t/* RO Method */\n+\t\tconst YamlObject &roObject = set[\"ro-limits\"];\n+\n+\t\tif (roObject.contains(\"green\")) {\n+\t\t\tmethod.method |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_RO_GREEN_ENABLE;\n+\n+\t\t\tvalue = roObject[\"green\"].get(0);\n+\t\t\tconfig_.ro_limits |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_RO_LIMITS_n_G(i, value);\n+\t\t}\n+\n+\t\tif (roObject.contains(\"red-blue\")) {\n+\t\t\tmethod.method |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_RO_RED_BLUE_ENABLE;\n+\n+\t\t\tvalue = roObject[\"red-blue\"].get(0);\n+\t\t\tconfig_.ro_limits |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_RO_LIMITS_n_RB(i, value);\n+\t\t}\n+\n+\t\t/* RG Method */\n+\t\tconst YamlObject &rgObject = set[\"rg-factor\"];\n+\t\tmethod.rg_fac = 0;\n+\n+\t\tif (rgObject.contains(\"green\")) {\n+\t\t\tmethod.method |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_RG_GREEN_ENABLE;\n+\n+\t\t\tvalue = rgObject[\"green\"].get(0);\n+\t\t\tmethod.rg_fac |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_RG_FAC_G(value);\n+\t\t}\n+\n+\t\tif (rgObject.contains(\"red-blue\")) {\n+\t\t\tmethod.method |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_RG_RED_BLUE_ENABLE;\n+\n+\t\t\tvalue = rgObject[\"red-blue\"].get(0);\n+\t\t\tmethod.rg_fac |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_RG_FAC_RB(value);\n+\t\t}\n+\n+\t\t/* RND Method */\n+\t\tconst YamlObject &rndOffsetsObject = set[\"rnd-offsets\"];\n+\n+\t\tif (rndOffsetsObject.contains(\"green\")) {\n+\t\t\tmethod.method |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_RND_GREEN_ENABLE;\n+\n+\t\t\tvalue = rndOffsetsObject[\"green\"].get(0);\n+\t\t\tconfig_.rnd_offs |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_RND_OFFS_n_G(i, value);\n+\t\t}\n+\n+\t\tif (rndOffsetsObject.contains(\"red-blue\")) {\n+\t\t\tmethod.method |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_RND_RED_BLUE_ENABLE;\n+\n+\t\t\tvalue = rndOffsetsObject[\"red-blue\"].get(0);\n+\t\t\tconfig_.rnd_offs |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_RND_OFFS_n_RB(i, value);\n+\t\t}\n+\n+\t\tconst YamlObject &rndThresholdObject = set[\"rnd-threshold\"];\n+\t\tmethod.rnd_thresh = 0;\n+\n+\t\tif (rndThresholdObject.contains(\"green\")) {\n+\t\t\tmethod.method |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_RND_GREEN_ENABLE;\n+\n+\t\t\tvalue = rndThresholdObject[\"green\"].get(0);\n+\t\t\tmethod.rnd_thresh |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_RND_THRESH_G(value);\n+\t\t}\n+\n+\t\tif (rndThresholdObject.contains(\"red-blue\")) {\n+\t\t\tmethod.method |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_RND_RED_BLUE_ENABLE;\n+\n+\t\t\tvalue = rndThresholdObject[\"red-blue\"].get(0);\n+\t\t\tmethod.rnd_thresh |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_RND_THRESH_RB(value);\n+\t\t}\n+\n+\t\t/* LC Method */\n+\t\tconst YamlObject &lcThresholdObject = set[\"line-threshold\"];\n+\t\tmethod.line_thresh = 0;\n+\n+\t\tif (lcThresholdObject.contains(\"green\")) {\n+\t\t\tmethod.method |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_LC_GREEN_ENABLE;\n+\n+\t\t\tvalue = lcThresholdObject[\"green\"].get(0);\n+\t\t\tmethod.line_thresh |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_LINE_THRESH_G(value);\n+\t\t}\n+\n+\t\tif (lcThresholdObject.contains(\"red-blue\")) {\n+\t\t\tmethod.method |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_LC_RED_BLUE_ENABLE;\n+\n+\t\t\tvalue = lcThresholdObject[\"red-blue\"].get(0);\n+\t\t\tmethod.line_thresh |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_LINE_THRESH_RB(value);\n+\t\t}\n+\n+\t\tconst YamlObject &lcTMadFactorObject = set[\"line-mad-factor\"];\n+\t\tmethod.line_mad_fac = 0;\n+\n+\t\tif (lcTMadFactorObject.contains(\"green\")) {\n+\t\t\tmethod.method |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_LC_GREEN_ENABLE;\n+\n+\t\t\tvalue = lcTMadFactorObject[\"green\"].get(0);\n+\t\t\tmethod.line_mad_fac |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_LINE_MAD_FAC_G(value);\n+\t\t}\n+\n+\t\tif (lcTMadFactorObject.contains(\"red-blue\")) {\n+\t\t\tmethod.method |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_METHODS_SET_LC_RED_BLUE_ENABLE;\n+\n+\t\t\tvalue = lcTMadFactorObject[\"red-blue\"].get(0);\n+\t\t\tmethod.line_mad_fac |=\n+\t\t\t\tRKISP1_CIF_ISP_DPCC_LINE_MAD_FAC_RB(value);\n+\t\t}\n+\t}\n+\n+\tinitialized_ = true;\n+\n+\treturn 0;\n+}\n+\n+/**\n+ * \\copydoc libcamera::ipa::Algorithm::prepare\n+ */\n+void DefectPixelClusterCorrection::prepare(IPAContext &context,\n+\t\t\t\t\t rkisp1_params_cfg *params)\n+{\n+\tif (context.frameContext.frameCount > 0)\n+\t\treturn;\n+\n+\tif (!initialized_)\n+\t\treturn;\n+\n+\tparams->others.dpcc_config = config_;\n+\n+\tparams->module_en_update |= RKISP1_CIF_ISP_MODULE_DPCC;\n+\tparams->module_ens |= RKISP1_CIF_ISP_MODULE_DPCC;\n+\tparams->module_cfg_update |= RKISP1_CIF_ISP_MODULE_DPCC;\n+}\n+\n+REGISTER_IPA_ALGORITHM(DefectPixelClusterCorrection, \"DefectPixelClusterCorrection\")\n+\n+} /* namespace ipa::rkisp1::algorithms */\n+\n+} /* namespace libcamera */\ndiff --git a/src/ipa/rkisp1/algorithms/dpcc.h b/src/ipa/rkisp1/algorithms/dpcc.h\nnew file mode 100644\nindex 00000000..ce332c3a\n--- /dev/null\n+++ b/src/ipa/rkisp1/algorithms/dpcc.h\n@@ -0,0 +1,31 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2021-2022, Ideas On Board\n+ *\n+ * dpcc.h - RkISP1 Defect Pixel Cluster Correction control\n+ */\n+\n+#pragma once\n+\n+#include \"algorithm.h\"\n+\n+namespace libcamera {\n+\n+namespace ipa::rkisp1::algorithms {\n+\n+class DefectPixelClusterCorrection : public Algorithm\n+{\n+public:\n+\tDefectPixelClusterCorrection();\n+\t~DefectPixelClusterCorrection() = default;\n+\n+\tint init(IPAContext &context, const YamlObject &tuningData) override;\n+\tvoid prepare(IPAContext &context, rkisp1_params_cfg *params) override;\n+\n+private:\n+\tbool initialized_;\n+\trkisp1_cif_isp_dpcc_config config_;\n+};\n+\n+} /* namespace ipa::rkisp1::algorithms */\n+} /* namespace libcamera */\ndiff --git a/src/ipa/rkisp1/algorithms/meson.build b/src/ipa/rkisp1/algorithms/meson.build\nindex 64e11dce..87007493 100644\n--- a/src/ipa/rkisp1/algorithms/meson.build\n+++ b/src/ipa/rkisp1/algorithms/meson.build\n@@ -4,6 +4,7 @@ rkisp1_ipa_algorithms = files([\n 'agc.cpp',\n 'awb.cpp',\n 'blc.cpp',\n+ 'dpcc.cpp',\n 'gsl.cpp',\n 'lsc.cpp',\n ])\ndiff --git a/src/ipa/rkisp1/data/ov5640.yaml b/src/ipa/rkisp1/data/ov5640.yaml\nindex fa2ae436..2315ec43 100644\n--- a/src/ipa/rkisp1/data/ov5640.yaml\n+++ b/src/ipa/rkisp1/data/ov5640.yaml\n@@ -95,4 +95,64 @@ algorithms:\n 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1024,\n 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1024,\n ]\n+ - DefectPixelClusterCorrection:\n+ fixed-set: false\n+ sets:\n+ # PG, LC, RO, RND, RG\n+ - line-threshold:\n+ green: 8\n+ red-blue: 8\n+ line-mad-factor:\n+ green: 4\n+ red-blue: 4\n+ pg-factor:\n+ green: 8\n+ red-blue: 8\n+ rnd-threshold:\n+ green: 10\n+ red-blue: 10\n+ rg-factor:\n+ green: 32\n+ red-blue: 32\n+ ro-limits:\n+ green: 1\n+ red-blue: 1\n+ rnd-offsets:\n+ green: 2\n+ red-blue: 2\n+ # PG, LC, RO\n+ - line-threshold:\n+ green: 24\n+ red-blue: 32\n+ line-mad-factor:\n+ green: 16\n+ red-blue: 24\n+ pg-factor:\n+ green: 6\n+ red-blue: 8\n+ ro-limits:\n+ green: 2\n+ red-blue: 2\n+ # PG, LC, RO, RND, RG\n+ - line-threshold:\n+ green: 32\n+ red-blue: 32\n+ line-mad-factor:\n+ green: 4\n+ red-blue: 4\n+ pg-factor:\n+ green: 10\n+ red-blue: 10\n+ rnd-threshold:\n+ green: 6\n+ red-blue: 8\n+ rg-factor:\n+ green: 4\n+ red-blue: 4\n+ ro-limits:\n+ green: 1\n+ red-blue: 2\n+ rnd-offsets:\n+ green: 2\n+ red-blue: 2\n ...\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex af0f43f2..caa67cf0 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -31,6 +31,7 @@\n #include \"algorithms/algorithm.h\"\n #include \"algorithms/awb.h\"\n #include \"algorithms/blc.h\"\n+#include \"algorithms/dpcc.h\"\n #include \"algorithms/gsl.h\"\n #include \"algorithms/lsc.h\"\n #include \"libipa/camera_sensor_helper.h\"\n","prefixes":["libcamera-devel","v2","5/5"]}