[{"id":2236,"web_url":"https://patchwork.libcamera.org/comment/2236/","msgid":"<20190712202608.GC31080@localhost.localdomain>","date":"2019-07-12T20:26:08","subject":"Re: [libcamera-devel] [PATCH] test: v4l2_videodevice:\n\tbuffer_sharing: Lower resolution to speed up test","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nThanks for the patch.\n\nOn Fri, Jul 12, 2019 at 03:33:50PM +0300, Laurent Pinchart wrote:\n> Speed up the test by lowering the resolution to the smallest vivid\n> supports, 320x180.\n\nIt looks and runs fine, but I didn't get any speedup.\n\nAnyway, it looks like a step in the right direction.\n\nReviewed-by: Paul Elder \n\n> Signed-off-by: Laurent Pinchart \n> ---\n> test/v4l2_videodevice/buffer_sharing.cpp | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/test/v4l2_videodevice/buffer_sharing.cpp b/test/v4l2_videodevice/buffer_sharing.cpp\n> index ede6ec7984a9..7b6a28fffb77 100644\n> --- a/test/v4l2_videodevice/buffer_sharing.cpp\n> +++ b/test/v4l2_videodevice/buffer_sharing.cpp\n> @@ -58,6 +58,15 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> +\t\tformat.size.width = 320;\n> +\t\tformat.size.height = 180;\n> +\n> +\t\tret = capture_->setFormat(&format);\n> +\t\tif (ret) {\n> +\t\t\tstd::cout << \"Failed to set capture format\" << std::endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> \t\tret = output_->setFormat(&format);\n> \t\tif (ret) {\n> \t\t\tstd::cout << \"Failed to set output format\" << std::endl;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F404161607\n\tfor ;\n\tFri, 12 Jul 2019 22:26:19 +0200 (CEST)","from localhost.localdomain (softbank126209254147.bbtec.net\n\t[126.209.254.147])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 477112B2;\n\tFri, 12 Jul 2019 22:26:16 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562963177;\n\tbh=9rdlO8qdABwm+lmLSKRn/d9uPb2e2Vlrh95O6DiTqzo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Sb34iM2tsOnWxlh1jbH0+VzZQvELonoxD1NeSybMwMDeZb5Sz1OqTf05d+s0rPJk3\n\taj1QR/Y4LA+a2joazl33GIfuf9rjzLbD98EAujbb/SU9R9M6Jln1wMBnDopXhVnl43\n\tJyn+wviCpJQEyMTbvkMfR1hqSbaWUMDnleKQxFic=","Date":"Sat, 13 Jul 2019 05:26:08 +0900","From":"Paul Elder ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190712202608.GC31080@localhost.localdomain>","References":"<20190712123350.26354-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20190712123350.26354-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] test: v4l2_videodevice:\n\tbuffer_sharing: Lower resolution to speed up test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 12 Jul 2019 20:26:20 -0000"}},{"id":2238,"web_url":"https://patchwork.libcamera.org/comment/2238/","msgid":"<20190713044334.GB4839@pendragon.ideasonboard.com>","date":"2019-07-13T04:43:34","subject":"Re: [libcamera-devel] [PATCH] test: v4l2_videodevice:\n\tbuffer_sharing: Lower resolution to speed up test","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nOn Sat, Jul 13, 2019 at 05:26:08AM +0900, Paul Elder wrote:\n> On Fri, Jul 12, 2019 at 03:33:50PM +0300, Laurent Pinchart wrote:\n> > Speed up the test by lowering the resolution to the smallest vivid\n> > supports, 320x180.\n> \n> It looks and runs fine, but I didn't get any speedup.\n\nThat's because you also need to set the frame rate :-) We'll have to add\nthat to libcamera, but in the meantime it can be set externally through\nyavta or v4l2-ctl. I'll mention that in the commit message.\n\n> Anyway, it looks like a step in the right direction.\n> \n> Reviewed-by: Paul Elder \n> \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > test/v4l2_videodevice/buffer_sharing.cpp | 9 +++++++++\n> > 1 file changed, 9 insertions(+)\n> > \n> > diff --git a/test/v4l2_videodevice/buffer_sharing.cpp b/test/v4l2_videodevice/buffer_sharing.cpp\n> > index ede6ec7984a9..7b6a28fffb77 100644\n> > --- a/test/v4l2_videodevice/buffer_sharing.cpp\n> > +++ b/test/v4l2_videodevice/buffer_sharing.cpp\n> > @@ -58,6 +58,15 @@ protected:\n> > \t\t\treturn TestFail;\n> > \t\t}\n> > \n> > +\t\tformat.size.width = 320;\n> > +\t\tformat.size.height = 180;\n> > +\n> > +\t\tret = capture_->setFormat(&format);\n> > +\t\tif (ret) {\n> > +\t\t\tstd::cout << \"Failed to set capture format\" << std::endl;\n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> > \t\tret = output_->setFormat(&format);\n> > \t\tif (ret) {\n> > \t\t\tstd::cout << \"Failed to set output format\" << std::endl;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E13B16156A\n\tfor ;\n\tSat, 13 Jul 2019 06:44:02 +0200 (CEST)","from pendragon.ideasonboard.com (softbank126209254147.bbtec.net\n\t[126.209.254.147])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4B3A72B2;\n\tSat, 13 Jul 2019 06:44:00 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562993042;\n\tbh=bTHOHdx7gQyzjTPBXciEDva3+h64Wjmv/zcKSAz6Edo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VVfe80QYfsmSCS+SAd7LQpgxqfBNjXBXutygZMR3c2YRstbeHtEMQwehovdgrHlzP\n\tZSYSGqe9vBwo681tZi4tO0peE+h2wSPtsjQgQnRcje7Dtn0p1Q/o5hNW2iEcMKOAqQ\n\tkk2pCv3W5orN/dvnILpC34Hb7xZ8ZkXsNCN9VDE4=","Date":"Sat, 13 Jul 2019 07:43:34 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190713044334.GB4839@pendragon.ideasonboard.com>","References":"<20190712123350.26354-1-laurent.pinchart@ideasonboard.com>\n\t<20190712202608.GC31080@localhost.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190712202608.GC31080@localhost.localdomain>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] test: v4l2_videodevice:\n\tbuffer_sharing: Lower resolution to speed up test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 13 Jul 2019 04:44:03 -0000"}}]