[{"id":24031,"web_url":"https://patchwork.libcamera.org/comment/24031/","msgid":"<20220721142840.u7fl4ikqxdsj6jf7@uno.localdomain>","date":"2022-07-21T14:28:40","subject":"Re: [libcamera-devel] [PATCH 1/2] test: gstreamer: Drop internal\n\theader from base class","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Umang,\n\nOn Thu, Jul 21, 2022 at 07:15:30PM +0530, Umang Jain via libcamera-devel wrote:\n> The internal header isn't needed. The needed function\n> libcameraBuildPath() is exposed by libcamera/base/utils.h header.\n> At the same time, move the utils header to .cpp instead of including\n> it in the base class header itself.\n>\n> Signed-off-by: Umang Jain \n\nReviewed-by: Jacopo Mondi \n\n> ---\n> test/gstreamer/gstreamer_test.cpp | 2 ++\n> test/gstreamer/gstreamer_test.h | 4 ----\n> 2 files changed, 2 insertions(+), 4 deletions(-)\n>\n> diff --git a/test/gstreamer/gstreamer_test.cpp b/test/gstreamer/gstreamer_test.cpp\n> index 227a5c37..cfb8afc6 100644\n> --- a/test/gstreamer/gstreamer_test.cpp\n> +++ b/test/gstreamer/gstreamer_test.cpp\n> @@ -5,6 +5,8 @@\n> * libcamera Gstreamer element API tests\n> */\n>\n> +#include \n> +\n> #include \"gstreamer_test.h\"\n>\n> #include \"test.h\"\n> diff --git a/test/gstreamer/gstreamer_test.h b/test/gstreamer/gstreamer_test.h\n> index 9869d252..35adab0e 100644\n> --- a/test/gstreamer/gstreamer_test.h\n> +++ b/test/gstreamer/gstreamer_test.h\n> @@ -10,10 +10,6 @@\n> #include \n> #include \n>\n> -#include \n> -\n> -#include \"libcamera/internal/source_paths.h\"\n> -\n> #include \n>\n> class GstreamerTest\n> --\n> 2.31.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 11EE7BE173\n\tfor ;\n\tThu, 21 Jul 2022 14:28:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 656286330F;\n\tThu, 21 Jul 2022 16:28:44 +0200 (CEST)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 91BBF601B8\n\tfor ;\n\tThu, 21 Jul 2022 16:28:43 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 11A5820002;\n\tThu, 21 Jul 2022 14:28:42 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658413724;\n\tbh=y+fPkzHWRpqQmnqSYMd6Plt4VbkVHyRAYBC8W80sxKg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ReMWk1/MQ7+kbpc9TqIzB341geyGXvHtT9VFUGI6x0IhLgsgW/3rwbnHK+0J9Pwc5\n\t83YcDPPaAn7Jcle5+zV/N714olgM1C1+GDYYigBeUsGNQhOr/tqDH3NURAsJAfiulK\n\tsnvqdfiodQz68BJskMFzJjDckf0Vd07H5l9Vy0db4oxV5gD8ntaZEnuaYu8EX+Evm1\n\tectn3v+KTNefh+0daqA4JUpGLHG4V37GrfnZwUkOKlFfvCf7VkoL/Eyi+/Qb2eBDx/\n\tc9NPFYSHNF8pi39nY3Rm4TqUj8q4UTXwiq8syrZhPYvrWyAJK0fK2/xvCA2ErVxwTI\n\tZGbChgwEpnnHw==","Date":"Thu, 21 Jul 2022 16:28:40 +0200","To":"Umang Jain ","Message-ID":"<20220721142840.u7fl4ikqxdsj6jf7@uno.localdomain>","References":"<20220721134531.1091104-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220721134531.1091104-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] test: gstreamer: Drop internal\n\theader from base class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24032,"web_url":"https://patchwork.libcamera.org/comment/24032/","msgid":"","date":"2022-07-21T14:30:05","subject":"Re: [libcamera-devel] [PATCH 1/2] test: gstreamer: Drop internal\n\theader from base class","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Thu, Jul 21, 2022 at 07:15:30PM +0530, Umang Jain via libcamera-devel wrote:\n> The internal header isn't needed. The needed function\n> libcameraBuildPath() is exposed by libcamera/base/utils.h header.\n> At the same time, move the utils header to .cpp instead of including\n> it in the base class header itself.\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> test/gstreamer/gstreamer_test.cpp | 2 ++\n> test/gstreamer/gstreamer_test.h | 4 ----\n> 2 files changed, 2 insertions(+), 4 deletions(-)\n> \n> diff --git a/test/gstreamer/gstreamer_test.cpp b/test/gstreamer/gstreamer_test.cpp\n> index 227a5c37..cfb8afc6 100644\n> --- a/test/gstreamer/gstreamer_test.cpp\n> +++ b/test/gstreamer/gstreamer_test.cpp\n> @@ -5,6 +5,8 @@\n> * libcamera Gstreamer element API tests\n> */\n> \n> +#include \n> +\n> #include \"gstreamer_test.h\"\n> \n> #include \"test.h\"\n> diff --git a/test/gstreamer/gstreamer_test.h b/test/gstreamer/gstreamer_test.h\n> index 9869d252..35adab0e 100644\n> --- a/test/gstreamer/gstreamer_test.h\n> +++ b/test/gstreamer/gstreamer_test.h\n> @@ -10,10 +10,6 @@\n> #include \n> #include \n> \n> -#include \n> -\n> -#include \"libcamera/internal/source_paths.h\"\n> -\n> #include \n> \n> class GstreamerTest","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4A63DBE173\n\tfor ;\n\tThu, 21 Jul 2022 14:30:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F3B5C6330F;\n\tThu, 21 Jul 2022 16:30:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 67C63601B8\n\tfor ;\n\tThu, 21 Jul 2022 16:30:08 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D5E49496;\n\tThu, 21 Jul 2022 16:30:07 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658413810;\n\tbh=73UjgOZw6hGoX95hJ1G2RKHUtvxsclzHqr5MdknZwpI=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=EuCfN1Svg1rDktQnK3fOxTxUkm7kYt4RtpEa8hQLDA2Hdrh7OIB5xtDGAC1rkuDkk\n\tT6cRdwsqxFHT1LTELwm1fJmP2jms7zm9PpoLiy73zGZO+GksgjOUZlWfziAmrzVY23\n\tCAhWRhyt+nsQ3I2iyDxRunFHUB1R7OioyOPukZGe8GSF24h8zuLPNgzV2JnRrjj4S0\n\tgar/LEckfzHnw+mbSE5h9IDW50BBatKCcUTxJ7MlNN7Y0F35bu4dGyaHm9FXOo1Qym\n\tlCK1u5HfT8EFNG7Spr3JeL/VDSMgSlFsQwpj8/Pzkn77O9ccGx4/UKmXExX7pzZz+f\n\t8xu9lqBDMlZ+A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658413808;\n\tbh=73UjgOZw6hGoX95hJ1G2RKHUtvxsclzHqr5MdknZwpI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WVZ0Z6puJNkP2gBnjIDEb6mz/OuSWPjfSuNnzpVryTsCBCx9zN+h8FYCs7GOucmnh\n\txqN0d6TB1qZXC+S8BFhzf0XC0H6b9Eu0zq/etBK3Jl6JL7pF8pjcwiJYEUbDpmGfEL\n\tKjG6j28X80QHeF3zxiE5IxV9YtChnXS5GiK2TmdY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"WVZ0Z6pu\"; dkim-atps=neutral","Date":"Thu, 21 Jul 2022 17:30:05 +0300","To":"Umang Jain ","Message-ID":"","References":"<20220721134531.1091104-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220721134531.1091104-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] test: gstreamer: Drop internal\n\theader from base class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]