[{"id":24067,"web_url":"https://patchwork.libcamera.org/comment/24067/","msgid":"","date":"2022-07-22T21:21:39","subject":"Re: [libcamera-devel] [RFC PATCH 12/12] ipa: ipu3: Transfer\n\tqueueRequest() call to each algorithm","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Kieran,\n\nOn 7/21/22 17:43, Kieran Bingham via libcamera-devel wrote:\n> Implement the IPU3 queueRequest() function to allow each algorithm\n> to process the user controls that it supports.\n>\n> Signed-off-by: Kieran Bingham \n\n\nLooks good,\n\nCan you summarize follow up to this patch? I believe each algorithm \nwhich take up ownership of the associated controls it manages ? That bit \nshall follow, right?\n\n> ---\n> src/ipa/ipu3/ipu3.cpp | 6 ++----\n> 1 file changed, 2 insertions(+), 4 deletions(-)\n>\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index 4d7a54f8d1a5..ee28044fc40e 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -620,12 +620,10 @@ void IPAIPU3::processStatsBuffer(const uint32_t frame,\n> */\n> void IPAIPU3::queueRequest(const uint32_t frame, const ControlList &controls)\n> {\n> -\t/* \\todo Start processing for 'frame' based on 'controls'. */\n> \tIPU3FrameContext &frameContext = context_.frameContexts.initialise(frame);\n> \n> -\t/* \\todo Implement queueRequest to each algorithm. */\n> -\t(void)frameContext;\n> -\t(void)controls;\n> +\tfor (auto const &algo : algorithms_)\n> +\t\talgo->queueRequest(context_, frame, frameContext, controls);\n> }\n> \n> /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E7A2EBD1F1\n\tfor ;\n\tFri, 22 Jul 2022 21:21:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4DBEF6330F;\n\tFri, 22 Jul 2022 23:21:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 99B9C601B8\n\tfor ;\n\tFri, 22 Jul 2022 23:21:45 +0200 (CEST)","from [IPV6:2409:4041:6e47:d2fa:b133:20f6:8507:a3dd] (unknown\n\t[IPv6:2409:4041:6e47:d2fa:b133:20f6:8507:a3dd])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7E22E6D5;\n\tFri, 22 Jul 2022 23:21:44 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658524907;\n\tbh=0DYgLh6bL99xeUu04AUyWOynyWFVJQcrVimmGtAhJdo=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=4IwogRrJWTUOXIue6OqAd6JlIjz3K8tVfWTgaZ5lWz1mYQpGwkQ5sUkSTE+Pjr1GM\n\th7MuqV3RxbEmVBO0XsIejMqYhiz7zNL416VOPcV0d0Wjhk6sQgv9jhh+R7LsxB+S2+\n\tEIcXp0u3SAKy7Iv9ZxNUx6NAbqMuidhLmO0Y1uh7+/ZBy1qMTS06KqXWLh6MA9f9RN\n\thgwYob1U31NWknPuUUeGwUGpdf/k0YgyPFmaIWdq57xGgNCqLTt6cnhYx6lhtRd3kz\n\t9Cq+T6mPJD/22TibjSJDu+vWq8F5aIIHSm2VIr6ZIXotQsMR6y9Xh7wNbIFoFHbREu\n\tF1iCOubaYH5tA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658524905;\n\tbh=0DYgLh6bL99xeUu04AUyWOynyWFVJQcrVimmGtAhJdo=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=KqpwrgNxo1hC8amLNXlRwzOrF8UY2Ld4V4xtEaWvSLF4o0spJDdhm6QdGzpMBuIGw\n\tIJK9cK2NjUfqsQJjj3bKrpK4JHSdXFcE2+KykZhNWelTdmsASH0Cx1UpjNZd0S4p3E\n\t4QgjvTltSe1kgDHseS/NzQb5KljBAM1zK+KGPcb8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"KqpwrgNx\"; dkim-atps=neutral","Message-ID":"","Date":"Sat, 23 Jul 2022 02:51:39 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20220721121310.1286862-1-kieran.bingham@ideasonboard.com>\n\t<20220721121310.1286862-13-kieran.bingham@ideasonboard.com>","In-Reply-To":"<20220721121310.1286862-13-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [RFC PATCH 12/12] ipa: ipu3: Transfer\n\tqueueRequest() call to each algorithm","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24111,"web_url":"https://patchwork.libcamera.org/comment/24111/","msgid":"<165876404104.3981176.12630307721289414402@Monstersaurus>","date":"2022-07-25T15:47:21","subject":"Re: [libcamera-devel] [RFC PATCH 12/12] ipa: ipu3: Transfer\n\tqueueRequest() call to each algorithm","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Umang Jain (2022-07-22 22:21:39)\n> Hi Kieran,\n> \n> On 7/21/22 17:43, Kieran Bingham via libcamera-devel wrote:\n> > Implement the IPU3 queueRequest() function to allow each algorithm\n> > to process the user controls that it supports.\n> >\n> > Signed-off-by: Kieran Bingham \n> \n> \n> Looks good,\n> \n> Can you summarize follow up to this patch? I believe each algorithm \n> which take up ownership of the associated controls it manages ? That bit \n> shall follow, right?\n\nYes, we've been limited in processing controls for algorithms on the\nIPU3. I hope that this series will allow those patches to start flowing\nto add the specific control handling for IPU3.\n\n--\nKieran\n\n\n\n> \n> > ---\n> > src/ipa/ipu3/ipu3.cpp | 6 ++----\n> > 1 file changed, 2 insertions(+), 4 deletions(-)\n> >\n> > diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> > index 4d7a54f8d1a5..ee28044fc40e 100644\n> > --- a/src/ipa/ipu3/ipu3.cpp\n> > +++ b/src/ipa/ipu3/ipu3.cpp\n> > @@ -620,12 +620,10 @@ void IPAIPU3::processStatsBuffer(const uint32_t frame,\n> > */\n> > void IPAIPU3::queueRequest(const uint32_t frame, const ControlList &controls)\n> > {\n> > - /* \\todo Start processing for 'frame' based on 'controls'. */\n> > IPU3FrameContext &frameContext = context_.frameContexts.initialise(frame);\n> > \n> > - /* \\todo Implement queueRequest to each algorithm. */\n> > - (void)frameContext;\n> > - (void)controls;\n> > + for (auto const &algo : algorithms_)\n> > + algo->queueRequest(context_, frame, frameContext, controls);\n> > }\n> > \n> > /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 29005BE173\n\tfor ;\n\tMon, 25 Jul 2022 15:47:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A26C363312;\n\tMon, 25 Jul 2022 17:47:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3E8E46330A\n\tfor ;\n\tMon, 25 Jul 2022 17:47:23 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BCAA96D1;\n\tMon, 25 Jul 2022 17:47:22 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658764043;\n\tbh=tybQYosmnMAhiBg4oCTAP8x31yNanC/8Jr/SF/rHrvU=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=E0ZvrEOANvhjfKmhSA780RAWUoHoPKf/CqZTAM/+a5XwbUanRwuMQyK07qCsmVhAK\n\tUf0Yzpu7bfqqOdnCqu5VJq/766MsXSx/JRwotJNEpeEW3gu40zW53FGNsxOrkmVkJF\n\twOei5e36gbGFhTZz9hBhwQqCo4LZrsiLVaNLxPHTb9FF3/SYeQ4MlCcP6aQOBqVxDB\n\tji17y3vOBQSqoSjKwrb471LpuhqfDhF5XX7LahqWSoDm/vigyOYz6tSZNMiiQqVg3F\n\tSAGWxJh1ufwLAyRDN1sulSvo5mOXuDfP06ZyPe5wsFlGaVkFcvfcdjnJecm6r5S3mQ\n\tOCEXFsdJ0H+cQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658764042;\n\tbh=tybQYosmnMAhiBg4oCTAP8x31yNanC/8Jr/SF/rHrvU=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=TBRyw3kWlOg9S3D4azsv21ef4w9HB4NGYVNVjMELqjuttcJHXZQW+CYx9z8MaQ/D7\n\tJKnnvnGFIBq2Ehv4aRbfw8kmeOejPz5qExzUDrSaEnUbiFIpt2rP+aqAv70L2z3nXC\n\tg7BHpnDJdqqitQ/pLNGtStzh82On3g0hKrbFIWCM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"TBRyw3kW\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20220721121310.1286862-1-kieran.bingham@ideasonboard.com>\n\t<20220721121310.1286862-13-kieran.bingham@ideasonboard.com>\n\t","To":"Umang Jain ,\n\tlibcamera devel ","Date":"Mon, 25 Jul 2022 16:47:21 +0100","Message-ID":"<165876404104.3981176.12630307721289414402@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [RFC PATCH 12/12] ipa: ipu3: Transfer\n\tqueueRequest() call to each algorithm","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]