{"id":16724,"url":"https://patchwork.libcamera.org/api/patches/16724/?format=json","web_url":"https://patchwork.libcamera.org/patch/16724/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220721121310.1286862-13-kieran.bingham@ideasonboard.com>","date":"2022-07-21T12:13:10","name":"[libcamera-devel,RFC,12/12] ipa: ipu3: Transfer queueRequest() call to each algorithm","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"fa07595f333f231adf9f164230c6a29b84504f6b","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/16724/mbox/","series":[{"id":3313,"url":"https://patchwork.libcamera.org/api/series/3313/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3313","date":"2022-07-21T12:12:58","name":"libcamera: Align IPU3 and RKISP1 interfaces","version":1,"mbox":"https://patchwork.libcamera.org/series/3313/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16724/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16724/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52A5EC3274\n\tfor ;\n\tThu, 21 Jul 2022 12:13:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EBBBB63331;\n\tThu, 21 Jul 2022 14:13:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF86D63311\n\tfor ;\n\tThu, 21 Jul 2022 14:13:16 +0200 (CEST)","from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 74A49496;\n\tThu, 21 Jul 2022 14:13:16 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658405608;\n\tbh=IiWy8sLuefx8n77tSE4lJXPzHFE5gucSi08EqBnmJFM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=GN6wZIB2/s7AjWoHaDJZ84qul8VPP/Ql7DUVYwcX2XUTZl1cYHgIwGTQC7PEdHKnl\n\t9Z8BbdyeBQpCi8+iJF3GYnLWGAsTZyrDc/J/ob9TxA4gRgkaF9BB4QAboAWUM0snp6\n\tB+CMoK7P1BdaMnvAXM+QUXdbJHFkhDD2dp0vN7Fd2P8sy8ht+TjOhiceMY4XbB9n9L\n\t8NYKQYp/I1DM86/kMUpVKwetb54Lspkateb2rZ1itqboDI8aHwfAOwkaUIanp0YbvY\n\ttacePHUpzQFg3kMHRXUPZF3oWc1A8wf2vPbHd1pyQMS4DOUoofcH1JM6Cp/Uc4WEeP\n\tC/ycm7eAUmgvA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658405596;\n\tbh=IiWy8sLuefx8n77tSE4lJXPzHFE5gucSi08EqBnmJFM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=e+hVOipSQmnZfLe/ohLz/acV7iO6CJEPoIXjuvIilIYty+TrO+T7Ka1B89IZge+Ph\n\tMLZ/jwSca9wnYy/1LusHDZCfrCnijHCiccZl8MPt+4o+PWABB+BRVYXI/iK6Q6rQuF\n\tBsV/rbcH8WR5U2/WHpIR1RLNE3BuvbdLmmDQyXoM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"e+hVOipS\"; dkim-atps=neutral","To":"libcamera devel ","Date":"Thu, 21 Jul 2022 13:13:10 +0100","Message-Id":"<20220721121310.1286862-13-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220721121310.1286862-1-kieran.bingham@ideasonboard.com>","References":"<20220721121310.1286862-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH 12/12] ipa: ipu3: Transfer\n\tqueueRequest() call to each algorithm","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Implement the IPU3 queueRequest() function to allow each algorithm\nto process the user controls that it supports.\n\nSigned-off-by: Kieran Bingham \n---\n src/ipa/ipu3/ipu3.cpp | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)","diff":"diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 4d7a54f8d1a5..ee28044fc40e 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -620,12 +620,10 @@ void IPAIPU3::processStatsBuffer(const uint32_t frame,\n */\n void IPAIPU3::queueRequest(const uint32_t frame, const ControlList &controls)\n {\n-\t/* \\todo Start processing for 'frame' based on 'controls'. */\n \tIPU3FrameContext &frameContext = context_.frameContexts.initialise(frame);\n \n-\t/* \\todo Implement queueRequest to each algorithm. */\n-\t(void)frameContext;\n-\t(void)controls;\n+\tfor (auto const &algo : algorithms_)\n+\t\talgo->queueRequest(context_, frame, frameContext, controls);\n }\n \n /**\n","prefixes":["libcamera-devel","RFC","12/12"]}