{"id":16720,"url":"https://patchwork.libcamera.org/api/patches/16720/?format=json","web_url":"https://patchwork.libcamera.org/patch/16720/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220721121310.1286862-9-kieran.bingham@ideasonboard.com>","date":"2022-07-21T12:13:06","name":"[libcamera-devel,RFC,08/12] ipa: libipa: algorithm: prepare(): Pass frame and frame Context","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"3cc8442ded36058ad8597548e45c143d84d2ca6f","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/16720/mbox/","series":[{"id":3313,"url":"https://patchwork.libcamera.org/api/series/3313/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3313","date":"2022-07-21T12:12:58","name":"libcamera: Align IPU3 and RKISP1 interfaces","version":1,"mbox":"https://patchwork.libcamera.org/series/3313/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16720/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16720/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 956AFC3274\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 21 Jul 2022 12:13:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6370E6332D;\n\tThu, 21 Jul 2022 14:13:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B2A806330F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Jul 2022 14:13:15 +0200 (CEST)","from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 61578825;\n\tThu, 21 Jul 2022 14:13:15 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658405604;\n\tbh=TbGX0hhDtGMUTgQRABBiAeo8L5xtOC9HWEB4qh4cchE=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=XnIcTGlpEm18r1y/KH3NMH4zWkJu76VYaHFsHmLZ9iPtOy/sGeDWx8mdZTkQVyl0U\n\tfntA+3ZLedpt/+hnZoP8E1tNHe57Uto2hid/lX76GKf1t0DRMmzXEHXrF4xzaWvBBQ\n\te012IXcbe/vHhPQ5j9qCcFe21OdOvstfowe7dFm8nC5g04ovY0xY+6bpXZhcZo396G\n\tZ0RNuqeAuCS92GinYZuOlo2diINXTv3Jpvq+KjYG/Exx8I9hq4rHeRis+z+Ez5rxwV\n\tSBYSJzObWD9wyZ3UzTLuDL6T/KJG0TZlQrTCEJtsq+HRKy5Z4ihA2e7/idms1Bi7LS\n\tACHxNfp+vmy3w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658405595;\n\tbh=TbGX0hhDtGMUTgQRABBiAeo8L5xtOC9HWEB4qh4cchE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=N0b9wkMCUQFfT37JKWt4n0q7V7w5m6x6PIMDFgheEGEUOD4Nw5R9Stch7uIL4W+6P\n\tooeFCLNB2VIeVUliyalSGyHdd5Jj3Y2K1P3fUNHPA4SlTw+AqJrPn3lrTthHiReZzf\n\t2t5IEJ/qDnKG0sWIEvaSLrcEqQOoPuLcm2+yIh2Y="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"N0b9wkMC\"; dkim-atps=neutral","To":"libcamera devel <libcamera-devel@lists.libcamera.org>","Date":"Thu, 21 Jul 2022 13:13:06 +0100","Message-Id":"<20220721121310.1286862-9-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220721121310.1286862-1-kieran.bingham@ideasonboard.com>","References":"<20220721121310.1286862-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH 08/12] ipa: libipa: algorithm:\n\tprepare(): Pass frame and frame Context","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Pass the current frame number, and the current FrameContext for calls to\nprepare.\n\nUntil there is a Frame Context Queue in the RKISP1 the FrameContext will\nbe a nullptr, and must not be dereferenced until the queue is\nimplemented.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n - Obtain and use the RKISP1FrameContext Queue entry for IPARkISP1::fillParamsBuffer\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/af.cpp           | 5 ++++-\n src/ipa/ipu3/algorithms/af.h             | 4 +++-\n src/ipa/ipu3/algorithms/awb.cpp          | 5 ++++-\n src/ipa/ipu3/algorithms/awb.h            | 5 ++++-\n src/ipa/ipu3/algorithms/blc.cpp          | 6 +++++-\n src/ipa/ipu3/algorithms/blc.h            | 4 +++-\n src/ipa/ipu3/algorithms/tone_mapping.cpp | 4 ++++\n src/ipa/ipu3/algorithms/tone_mapping.h   | 3 ++-\n src/ipa/ipu3/ipu3.cpp                    | 4 +++-\n src/ipa/libipa/algorithm.cpp             | 2 ++\n src/ipa/libipa/algorithm.h               | 2 ++\n src/ipa/rkisp1/algorithms/agc.cpp        | 5 ++++-\n src/ipa/rkisp1/algorithms/agc.h          | 4 +++-\n src/ipa/rkisp1/algorithms/awb.cpp        | 5 ++++-\n src/ipa/rkisp1/algorithms/awb.h          | 4 +++-\n src/ipa/rkisp1/algorithms/blc.cpp        | 2 ++\n src/ipa/rkisp1/algorithms/blc.h          | 4 +++-\n src/ipa/rkisp1/rkisp1.cpp                | 4 +++-\n 18 files changed, 58 insertions(+), 14 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/af.cpp b/src/ipa/ipu3/algorithms/af.cpp\nindex fcbf8e557b10..1faf92969ee5 100644\n--- a/src/ipa/ipu3/algorithms/af.cpp\n+++ b/src/ipa/ipu3/algorithms/af.cpp\n@@ -116,7 +116,10 @@ Af::Af()\n /**\n  * \\copydoc libcamera::ipa::Algorithm::prepare\n  */\n-void Af::prepare(IPAContext &context, ipu3_uapi_params *params)\n+void Af::prepare(IPAContext &context,\n+\t\t [[maybe_unused]] unsigned int frame,\n+\t\t [[maybe_unused]] IPU3FrameContext &frameContext,\n+\t\t ipu3_uapi_params *params)\n {\n \tconst struct ipu3_uapi_grid_config &grid = context.configuration.af.afGrid;\n \tparams->acc_param.af.grid_cfg = grid;\ndiff --git a/src/ipa/ipu3/algorithms/af.h b/src/ipa/ipu3/algorithms/af.h\nindex 7a5aeb1b6bf4..4e2bbd08c3bf 100644\n--- a/src/ipa/ipu3/algorithms/af.h\n+++ b/src/ipa/ipu3/algorithms/af.h\n@@ -30,8 +30,10 @@ public:\n \tAf();\n \t~Af() = default;\n \n-\tvoid prepare(IPAContext &context, ipu3_uapi_params *params) override;\n \tint configure(IPAContext &context, const IPAConfigInfo &configInfo) override;\n+\tvoid prepare(IPAContext &context, unsigned int frame,\n+\t\t     IPU3FrameContext &frameContext,\n+\t\t     ipu3_uapi_params *params) override;\n \tvoid process(IPAContext &context, IPU3FrameContext &frameContext,\n \t\t     const ipu3_uapi_stats_3a *stats) override;\n \ndiff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex 45f8e5f29119..b110ad404fd1 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -430,7 +430,10 @@ constexpr uint16_t Awb::gainValue(double gain)\n /**\n  * \\copydoc libcamera::ipa::Algorithm::prepare\n  */\n-void Awb::prepare(IPAContext &context, ipu3_uapi_params *params)\n+void Awb::prepare(IPAContext &context,\n+\t\t  [[maybe_unused]] unsigned int frame,\n+\t\t  [[maybe_unused]] IPU3FrameContext &frameContext,\n+\t\t  ipu3_uapi_params *params)\n {\n \t/*\n \t * Green saturation thresholds are reduced because we are using the\ndiff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h\nindex 28e39620fd59..731e5bae17de 100644\n--- a/src/ipa/ipu3/algorithms/awb.h\n+++ b/src/ipa/ipu3/algorithms/awb.h\n@@ -39,7 +39,10 @@ public:\n \t~Awb();\n \n \tint configure(IPAContext &context, const IPAConfigInfo &configInfo) override;\n-\tvoid prepare(IPAContext &context, ipu3_uapi_params *params) override;\n+\n+\tvoid prepare(IPAContext &context, unsigned int frame,\n+\t\t     IPU3FrameContext &frameContext,\n+\t\t     ipu3_uapi_params *params) override;\n \tvoid process(IPAContext &context, IPU3FrameContext &frameContext,\n \t\t     const ipu3_uapi_stats_3a *stats) override;\n \ndiff --git a/src/ipa/ipu3/algorithms/blc.cpp b/src/ipa/ipu3/algorithms/blc.cpp\nindex 78ab7bff549f..6d1084066ed4 100644\n--- a/src/ipa/ipu3/algorithms/blc.cpp\n+++ b/src/ipa/ipu3/algorithms/blc.cpp\n@@ -39,13 +39,17 @@ BlackLevelCorrection::BlackLevelCorrection()\n /**\n  * \\brief Fill in the parameter structure, and enable black level correction\n  * \\param context The shared IPA context\n+ * \\param[in] frame The frame context sequence number\n+ * \\param[in] frameContext The Frame Context for this frame\n  * \\param params The IPU3 parameters\n  *\n  * Populate the IPU3 parameter structure with the correction values for each\n  * channel and enable the corresponding ImgU block processing.\n  */\n void BlackLevelCorrection::prepare([[maybe_unused]] IPAContext &context,\n-\t\t\t      ipu3_uapi_params *params)\n+\t\t\t\t   [[maybe_unused]] unsigned int frame,\n+\t\t\t\t   [[maybe_unused]] IPU3FrameContext &frameContext,\n+\t\t\t\t   ipu3_uapi_params *params)\n {\n \t/*\n \t * The Optical Black Level correction values\ndiff --git a/src/ipa/ipu3/algorithms/blc.h b/src/ipa/ipu3/algorithms/blc.h\nindex d8da1748baba..36388b267eea 100644\n--- a/src/ipa/ipu3/algorithms/blc.h\n+++ b/src/ipa/ipu3/algorithms/blc.h\n@@ -18,7 +18,9 @@ class BlackLevelCorrection : public Algorithm\n public:\n \tBlackLevelCorrection();\n \n-\tvoid prepare(IPAContext &context, ipu3_uapi_params *params) override;\n+\tvoid prepare(IPAContext &context, unsigned int frame,\n+\t\t     IPU3FrameContext &frameContext,\n+\t\t     ipu3_uapi_params *params) override;\n };\n \n } /* namespace ipa::ipu3::algorithms */\ndiff --git a/src/ipa/ipu3/algorithms/tone_mapping.cpp b/src/ipa/ipu3/algorithms/tone_mapping.cpp\nindex 977741c5a4d4..9ca3f471cbaf 100644\n--- a/src/ipa/ipu3/algorithms/tone_mapping.cpp\n+++ b/src/ipa/ipu3/algorithms/tone_mapping.cpp\n@@ -50,12 +50,16 @@ int ToneMapping::configure(IPAContext &context,\n /**\n  * \\brief Fill in the parameter structure, and enable gamma control\n  * \\param context The shared IPA context\n+ * \\param[in] frame The frame context sequence number\n+ * \\param[in] frameContext The Frame Context for this frame\n  * \\param params The IPU3 parameters\n  *\n  * Populate the IPU3 parameter structure with our tone mapping look up table and\n  * enable the gamma control module in the processing blocks.\n  */\n void ToneMapping::prepare([[maybe_unused]] IPAContext &context,\n+\t\t\t  [[maybe_unused]] unsigned int frame,\n+\t\t\t  [[maybe_unused]] IPU3FrameContext &frameContext,\n \t\t\t  ipu3_uapi_params *params)\n {\n \t/* Copy the calculated LUT into the parameters buffer. */\ndiff --git a/src/ipa/ipu3/algorithms/tone_mapping.h b/src/ipa/ipu3/algorithms/tone_mapping.h\nindex 8cce38c742a6..cfb3de01b7f3 100644\n--- a/src/ipa/ipu3/algorithms/tone_mapping.h\n+++ b/src/ipa/ipu3/algorithms/tone_mapping.h\n@@ -19,7 +19,8 @@ public:\n \tToneMapping();\n \n \tint configure(IPAContext &context, const IPAConfigInfo &configInfo) override;\n-\tvoid prepare(IPAContext &context, ipu3_uapi_params *params) override;\n+\tvoid prepare(IPAContext &context, unsigned int frame,\n+\t\t     IPU3FrameContext &frameContext, ipu3_uapi_params *params) override;\n \tvoid process(IPAContext &context, IPU3FrameContext &frameContext,\n \t\t     const ipu3_uapi_stats_3a *stats) override;\n \ndiff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 489e51bc6cf7..5663b1f4bb51 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -539,8 +539,10 @@ void IPAIPU3::fillParamsBuffer(const uint32_t frame, const uint32_t bufferId)\n \t */\n \tparams->use = {};\n \n+\tIPU3FrameContext frameContext = context_.frameContexts.get(frame);\n+\n \tfor (auto const &algo : algorithms_)\n-\t\talgo->prepare(context_, params);\n+\t\talgo->prepare(context_, frame, frameContext, params);\n \n \tparamsBufferReady.emit(frame);\n }\ndiff --git a/src/ipa/libipa/algorithm.cpp b/src/ipa/libipa/algorithm.cpp\nindex 8549fe3f6269..bc7c130d3e09 100644\n--- a/src/ipa/libipa/algorithm.cpp\n+++ b/src/ipa/libipa/algorithm.cpp\n@@ -70,6 +70,8 @@ namespace ipa {\n  * \\fn Algorithm::prepare()\n  * \\brief Fill the \\a params buffer with ISP processing parameters for a frame\n  * \\param[in] context The shared IPA context\n+ * \\param[in] frame The frame context sequence number\n+ * \\param[in] frameContext The Frame Context for this frame\n  * \\param[out] params The ISP specific parameters.\n  *\n  * This function is called for every frame when the camera is running before it\ndiff --git a/src/ipa/libipa/algorithm.h b/src/ipa/libipa/algorithm.h\nindex adbcf69adb4f..ce5c7cc491d8 100644\n--- a/src/ipa/libipa/algorithm.h\n+++ b/src/ipa/libipa/algorithm.h\n@@ -36,6 +36,8 @@ public:\n \t}\n \n \tvirtual void prepare([[maybe_unused]] typename Module::Context &context,\n+\t\t\t     [[maybe_unused]] unsigned int frame,\n+\t\t\t     [[maybe_unused]] typename Module::FrameContext &frameContext,\n \t\t\t     [[maybe_unused]] typename Module::Params *params)\n \t{\n \t}\ndiff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex 40d27963ef68..2d436511caf7 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -322,7 +322,10 @@ void Agc::process(IPAContext &context,\n /**\n  * \\copydoc libcamera::ipa::Algorithm::prepare\n  */\n-void Agc::prepare(IPAContext &context, rkisp1_params_cfg *params)\n+void Agc::prepare(IPAContext &context,\n+\t\t  [[maybe_unused]] unsigned int frame,\n+\t\t  [[maybe_unused]] RKISP1FrameContext &frameContext,\n+\t\t  rkisp1_params_cfg *params)\n {\n \tif (context.activeState.frameCount > 0)\n \t\treturn;\ndiff --git a/src/ipa/rkisp1/algorithms/agc.h b/src/ipa/rkisp1/algorithms/agc.h\nindex 1a291bdf3636..7844cd2e3b47 100644\n--- a/src/ipa/rkisp1/algorithms/agc.h\n+++ b/src/ipa/rkisp1/algorithms/agc.h\n@@ -28,7 +28,9 @@ public:\n \t~Agc() = default;\n \n \tint configure(IPAContext &context, const IPACameraSensorInfo &configInfo) override;\n-\tvoid prepare(IPAContext &context, rkisp1_params_cfg *params) override;\n+\tvoid prepare(IPAContext &context, unsigned int frame,\n+\t\t     RKISP1FrameContext &frameContext,\n+\t\t     rkisp1_params_cfg *params) override;\n \tvoid process(IPAContext &context, RKISP1FrameContext &frameContext,\n \t\t     const rkisp1_stat_buffer *stats) override;\n \ndiff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex 3beafb73ca33..1af6d98c5252 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -70,7 +70,10 @@ uint32_t Awb::estimateCCT(double red, double green, double blue)\n /**\n  * \\copydoc libcamera::ipa::Algorithm::prepare\n  */\n-void Awb::prepare(IPAContext &context, rkisp1_params_cfg *params)\n+void Awb::prepare(IPAContext &context,\n+\t\t  [[maybe_unused]] unsigned int frame,\n+\t\t  [[maybe_unused]] RKISP1FrameContext &frameContext,\n+\t\t  rkisp1_params_cfg *params)\n {\n \tparams->others.awb_gain_config.gain_green_b = 256 * context.activeState.awb.gains.green;\n \tparams->others.awb_gain_config.gain_blue = 256 * context.activeState.awb.gains.blue;\ndiff --git a/src/ipa/rkisp1/algorithms/awb.h b/src/ipa/rkisp1/algorithms/awb.h\nindex 259b85eebdb4..8fd5b706861a 100644\n--- a/src/ipa/rkisp1/algorithms/awb.h\n+++ b/src/ipa/rkisp1/algorithms/awb.h\n@@ -22,7 +22,9 @@ public:\n \t~Awb() = default;\n \n \tint configure(IPAContext &context, const IPACameraSensorInfo &configInfo) override;\n-\tvoid prepare(IPAContext &context, rkisp1_params_cfg *params) override;\n+\tvoid prepare(IPAContext &context, unsigned int frame,\n+\t\t     RKISP1FrameContext &frameContext,\n+\t\t     rkisp1_params_cfg *params) override;\n \tvoid process(IPAContext &context, RKISP1FrameContext &frameCtx,\n \t\t     const rkisp1_stat_buffer *stats) override;\n \ndiff --git a/src/ipa/rkisp1/algorithms/blc.cpp b/src/ipa/rkisp1/algorithms/blc.cpp\nindex 4d55a2d529cb..93c7e3145fa2 100644\n--- a/src/ipa/rkisp1/algorithms/blc.cpp\n+++ b/src/ipa/rkisp1/algorithms/blc.cpp\n@@ -66,6 +66,8 @@ int BlackLevelCorrection::init([[maybe_unused]] IPAContext &context,\n  * \\copydoc libcamera::ipa::Algorithm::prepare\n  */\n void BlackLevelCorrection::prepare(IPAContext &context,\n+\t\t\t\t   [[maybe_unused]] unsigned int frame,\n+\t\t\t\t   [[maybe_unused]] RKISP1FrameContext &frameContext,\n \t\t\t\t   rkisp1_params_cfg *params)\n {\n \tif (context.activeState.frameCount > 0)\ndiff --git a/src/ipa/rkisp1/algorithms/blc.h b/src/ipa/rkisp1/algorithms/blc.h\nindex c2649dd7736e..1b2abfeef800 100644\n--- a/src/ipa/rkisp1/algorithms/blc.h\n+++ b/src/ipa/rkisp1/algorithms/blc.h\n@@ -24,7 +24,9 @@ public:\n \t~BlackLevelCorrection() = default;\n \n \tint init(IPAContext &context, const YamlObject &tuningData) override;\n-\tvoid prepare(IPAContext &context, rkisp1_params_cfg *params) override;\n+\tvoid prepare(IPAContext &context, unsigned int frame,\n+\t\t     RKISP1FrameContext &frameContext,\n+\t\t     rkisp1_params_cfg *params) override;\n \n private:\n \tbool tuningParameters_;\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex a2b7b25a53e5..f97484ce5030 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -275,6 +275,8 @@ void IPARkISP1::queueRequest([[maybe_unused]] const uint32_t frame,\n \n void IPARkISP1::fillParamsBuffer(const uint32_t frame, const uint32_t bufferId)\n {\n+\tRKISP1FrameContext &frameContext = context_.frameContexts.get(frame);\n+\n \trkisp1_params_cfg *params =\n \t\treinterpret_cast<rkisp1_params_cfg *>(\n \t\t\tmappedBuffers_.at(bufferId).planes()[0].data());\n@@ -283,7 +285,7 @@ void IPARkISP1::fillParamsBuffer(const uint32_t frame, const uint32_t bufferId)\n \tmemset(params, 0, sizeof(*params));\n \n \tfor (auto const &algo : algorithms())\n-\t\talgo->prepare(context_, params);\n+\t\talgo->prepare(context_, frame, frameContext, params);\n \n \tparamsBufferReady.emit(frame);\n \tcontext_.activeState.frameCount++;\n","prefixes":["libcamera-devel","RFC","08/12"]}