[{"id":24058,"web_url":"https://patchwork.libcamera.org/comment/24058/","msgid":"<0bff113d-be30-fed2-6565-b7f40cc0763d@ideasonboard.com>","date":"2022-07-22T14:42:39","subject":"Re: [libcamera-devel] [RFC PATCH 03/12] libcamera: request: Add\n\tPFCError flag","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Kieran,\n\nOn 7/21/22 17:43, Kieran Bingham via libcamera-devel wrote:\n> Provide a new flag for the Request error state to indicate that a\n> per-frame control error has occurred. One or more controls set for this\n> request could not be guaranteed on this frame.\n\nI would add a line here explaining the cases in which this flag is set \nand by which component.\n\nIt would help us to be explicit enough and correspond to a cohesive \ndesign decisions we make(or made).\n\n>\n> Signed-off-by: Kieran Bingham \n> ---\n> include/libcamera/request.h | 1 +\n> src/libcamera/request.cpp | 5 +++++\n> 2 files changed, 6 insertions(+)\n>\n> diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n> index 992629e11aa4..d6d9f0d214dc 100644\n> --- a/include/libcamera/request.h\n> +++ b/include/libcamera/request.h\n> @@ -47,6 +47,7 @@ public:\n> \tenum ErrorFlag {\n> \t\tNoError = 0,\n> \t\tControlError = (1 << 0),\n> +\t\tPFCError = (1 << 1),\n> \t};\n> \n> \tusing ErrorFlags = Flags;\n> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> index 8b82757ea7e3..509ed4ca6ed5 100644\n> --- a/src/libcamera/request.cpp\n> +++ b/src/libcamera/request.cpp\n> @@ -339,10 +339,15 @@ void Request::Private::timeout()\n> * Flags to report non-fatal errors\n> * \\var Request::NoError\n> * No error\n> + *\n> * \\var Request::ControlError\n> * Control Error. At least on control was not able to be applied to the device.\n> * The application should compare the metadata to the requested control values\n> * to check which controls weren't applied.\n> + *\n> + * \\var Request::PFCError\n> + * A per-frame-control error has occured. Controls that were expected to be set\n> + * during the processing of this request were not processed in time.\n\n\nShould we have any suggestion for the application here? I am stating \nbecause I see ::ControlError has a follow up suggestion for \napplication's side.\n\nPatch as such look fine to me.\n\n> */\n> \n> /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 92B1BBD1F1\n\tfor ;\n\tFri, 22 Jul 2022 14:42:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0D04F6330F;\n\tFri, 22 Jul 2022 16:42:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DE3EC601B8\n\tfor ;\n\tFri, 22 Jul 2022 16:42:45 +0200 (CEST)","from [IPV6:2401:4900:1f3f:a2d:c6dd:7a7c:3d3c:dbb9] (unknown\n\t[IPv6:2401:4900:1f3f:a2d:c6dd:7a7c:3d3c:dbb9])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E38816D5;\n\tFri, 22 Jul 2022 16:42:44 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658500967;\n\tbh=P90nBkHuigyu6YBQapS/WyxFOK8m7MXuAwKNimqCm9k=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=i/Ejd9M7lRxXl8sRD22xTs89eNq7mSbNrPQa/lcoMoPCFTRlP+ek5hC5Yu39FR81U\n\tb+SBPvEsvqgi+Z88YNP3ZsyGxmqXENGGshq6wymF1YzRFczHFTrDJEft7vtlWNZ1j0\n\tDAA0Kiq+2ua1qILLCuGe83Tqh/fOn9S4Tl1htz5QMrHddKBJON2nUQydm5WWzse/ka\n\t0eBz9au1JY6rhR61T4M+FIOVMQ2V8B06STAjKoQs829rkdfkZSzX6L0wveXhVn7Qi2\n\tkKU1ucGOU0O6A33BhT0tJjE61IuQ7PITyD//Ew+MCSuA3ZgcTBUTjKwRpUxEZmB8J8\n\tF174AVTcwKH3w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658500965;\n\tbh=P90nBkHuigyu6YBQapS/WyxFOK8m7MXuAwKNimqCm9k=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=kvqrkqIzsFLNSaHDkBSCmOpQDrkDlCSh+5Ud9hgjODhCkij/tdObpb1iGpjduiuPm\n\tGeluIofPLc1rm/A7joIpWj8Z6q6ZIKNd4YoR4mhh+sBOKFZHMt34OnbTHj3S9jx2RR\n\tHKWmIBYtZpQjFHBljMMB9LSpYyVOCDfOZGFgjCb8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"kvqrkqIz\"; dkim-atps=neutral","Message-ID":"<0bff113d-be30-fed2-6565-b7f40cc0763d@ideasonboard.com>","Date":"Fri, 22 Jul 2022 20:12:39 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20220721121310.1286862-1-kieran.bingham@ideasonboard.com>\n\t<20220721121310.1286862-4-kieran.bingham@ideasonboard.com>","In-Reply-To":"<20220721121310.1286862-4-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [RFC PATCH 03/12] libcamera: request: Add\n\tPFCError flag","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]