[{"id":24061,"web_url":"https://patchwork.libcamera.org/comment/24061/","msgid":"<7f838109-bb1f-dad0-fc7d-7d6c125bc69e@ideasonboard.com>","date":"2022-07-22T15:30:22","subject":"Re: [libcamera-devel] [RFC PATCH 02/12] libcamera: pipeline:\n\tuvcvideo: Report control errors","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi\n\nOn 7/21/22 17:43, Kieran Bingham via libcamera-devel wrote:\n> Report an error when failing to process controls, but still allow the\n> request to process and complete where possible.\n>\n> The Request ControlError flag is raised on the request.\n>\n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=135\n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 7 +++++--\n> 1 file changed, 5 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 53b2f23ab029..1f282f26bec3 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -26,6 +26,7 @@\n> #include \"libcamera/internal/device_enumerator.h\"\n> #include \"libcamera/internal/media_device.h\"\n> #include \"libcamera/internal/pipeline_handler.h\"\n> +#include \"libcamera/internal/request.h\"\n> #include \"libcamera/internal/sysfs.h\"\n> #include \"libcamera/internal/v4l2_videodevice.h\"\n> \n> @@ -373,8 +374,10 @@ int PipelineHandlerUVC::queueRequestDevice(Camera *camera, Request *request)\n> \t}\n> \n> \tint ret = processControls(data, request);\n\n\nI kept wondering why we are processing controls here (in PH) and not in \nIPA, to later realize UVC has no IPA ;-)\n\n> -\tif (ret < 0)\n> -\t\treturn ret;\n> +\tif (ret < 0) {\n> +\t\tLOG(UVC, Error) << \"Failed to process controls\";\n> +\t\trequest->_d()->setErrorFlags(Request::ControlError);\n> +\t}\n\n\nMakes sense and as per design.\n\nReviewed-by: Umang Jain \n\n> \n> \tret = data->video_->queueBuffer(buffer);\n> \tif (ret < 0)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1BF96BE173\n\tfor ;\n\tFri, 22 Jul 2022 15:30:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 788116330F;\n\tFri, 22 Jul 2022 17:30:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E2969601B8\n\tfor ;\n\tFri, 22 Jul 2022 17:30:27 +0200 (CEST)","from [IPV6:2401:4900:1f3f:a2d:c6dd:7a7c:3d3c:dbb9] (unknown\n\t[IPv6:2401:4900:1f3f:a2d:c6dd:7a7c:3d3c:dbb9])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E54AD6D5;\n\tFri, 22 Jul 2022 17:30:26 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658503828;\n\tbh=FnoYXbBSbtcWMdNLnQVMdfs4/JIyA8AJyMgphaG16u4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=3O+OmC9fSeRWe7GkIvDgOsTT57SAEZMLUzmHat+NuLquc4AJ7xE2Uvlr2H3vVI7zh\n\teteu6JP6J9NiBXv4GIo926vxQwTPle/Sf+rD0KOg9zzGhB1Ea7BCFdbx7E4B4XWZ5c\n\tJYXaAkzX3AS/H5uiN6ZH1VZXGw4DWDUBJe/bzOiI8vYUUuFQB1ZssfLnfRLiykLmAk\n\tacNpk4/MYBOo1LBH1mxYFQ74CnoqfhVuTHmOGnBCpKclSNqAE/JdSeZ0AYWvDyJm68\n\tFw0JyoEbFliZczSo+stOXNPA3GkuBc1uU7XxyYiPwBfNNkUJs5QyZ+tPUWw5f6L3gV\n\tECeotlPMLwQJQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658503827;\n\tbh=FnoYXbBSbtcWMdNLnQVMdfs4/JIyA8AJyMgphaG16u4=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=GXlGd8165hz4bxKdB5SpH9woHhXk+bIEZONEYlPccffBcHSsiWCdawBuR7I6Z85Sb\n\tqfhPF+2ctPFo/UQNUhOKjkM/ugHY39VXRlpEks2V0/zbczaM9Mfw9LrPPgfGfLwFSB\n\tiH6LgQ2+KdKjEdDXelMhZiVh34MIkjsp14mMvk9U="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"GXlGd816\"; dkim-atps=neutral","Message-ID":"<7f838109-bb1f-dad0-fc7d-7d6c125bc69e@ideasonboard.com>","Date":"Fri, 22 Jul 2022 21:00:22 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20220721121310.1286862-1-kieran.bingham@ideasonboard.com>\n\t<20220721121310.1286862-3-kieran.bingham@ideasonboard.com>","In-Reply-To":"<20220721121310.1286862-3-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [RFC PATCH 02/12] libcamera: pipeline:\n\tuvcvideo: Report control errors","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24090,"web_url":"https://patchwork.libcamera.org/comment/24090/","msgid":"<20220725075659.nqu2u6hwqrehb5iw@uno.localdomain>","date":"2022-07-25T07:56:59","subject":"Re: [libcamera-devel] [RFC PATCH 02/12] libcamera: pipeline:\n\tuvcvideo: Report control errors","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran\n\nOn Thu, Jul 21, 2022 at 01:13:00PM +0100, Kieran Bingham via libcamera-devel wrote:\n> Report an error when failing to process controls, but still allow the\n> request to process and complete where possible.\n>\n> The Request ControlError flag is raised on the request.\n>\n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=135\n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 7 +++++--\n> 1 file changed, 5 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 53b2f23ab029..1f282f26bec3 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -26,6 +26,7 @@\n> #include \"libcamera/internal/device_enumerator.h\"\n> #include \"libcamera/internal/media_device.h\"\n> #include \"libcamera/internal/pipeline_handler.h\"\n> +#include \"libcamera/internal/request.h\"\n> #include \"libcamera/internal/sysfs.h\"\n> #include \"libcamera/internal/v4l2_videodevice.h\"\n>\n> @@ -373,8 +374,10 @@ int PipelineHandlerUVC::queueRequestDevice(Camera *camera, Request *request)\n> \t}\n>\n> \tint ret = processControls(data, request);\n> -\tif (ret < 0)\n> -\t\treturn ret;\n> +\tif (ret < 0) {\n> +\t\tLOG(UVC, Error) << \"Failed to process controls\";\n> +\t\trequest->_d()->setErrorFlags(Request::ControlError);\n\nI wonder if Request::Private::setError() wouldn't be enough (that's\nprobably a comment for patch #1).\n\nWith the confirmation that this patch introduces a behavioural change,\nas before we returned early (which I presume from the commit message\nthe change is intended).\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> +\t}\n>\n> \tret = data->video_->queueBuffer(buffer);\n> \tif (ret < 0)\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E7D3BE173\n\tfor ;\n\tMon, 25 Jul 2022 07:57:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A692063312;\n\tMon, 25 Jul 2022 09:57:02 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9ECA363309\n\tfor ;\n\tMon, 25 Jul 2022 09:57:01 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 1BA8E1C0004;\n\tMon, 25 Jul 2022 07:57:00 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658735822;\n\tbh=VOeN3QkU0UG6Tq+FtrPWnOcrLfFRwTCvadx45XFb/hM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=zJnrQuGkQqxQnw4NLBxzDGboQdExkF+8+U3J9oVey3EP2DniphfVGGMvEoWMKcCUT\n\tZQvmp4h6U4F0q/SrA6dgYUtjFgTaJrwIwdUmcuitqUJ4hDJplQWYNGLm9ngJ69IPZl\n\tnyLfjswzb0dJQi4HpA0VxxNHEDCFA1UI17jiC3z3wDMPHww6+XlC+k2YNq5I1WOgI0\n\tnzcIOR6lTTYRCnOYAlz0k6tmDATroA7N62/0TKRj6ZzcWDCvd7195lfIfUzVwPKcZz\n\tvD56gpD68bynTwQzxKEu0hjaXAbE+7ZHTb8Zsw3vXtxrSsLcL8sKEVaQCVn0rO5eyL\n\tW4Mtgba4nflLw==","Date":"Mon, 25 Jul 2022 09:56:59 +0200","To":"Kieran Bingham ","Message-ID":"<20220725075659.nqu2u6hwqrehb5iw@uno.localdomain>","References":"<20220721121310.1286862-1-kieran.bingham@ideasonboard.com>\n\t<20220721121310.1286862-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220721121310.1286862-3-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH 02/12] libcamera: pipeline:\n\tuvcvideo: Report control errors","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24103,"web_url":"https://patchwork.libcamera.org/comment/24103/","msgid":"<165876111231.3981176.10532295031811287910@Monstersaurus>","date":"2022-07-25T14:58:32","subject":"Re: [libcamera-devel] [RFC PATCH 02/12] libcamera: pipeline:\n\tuvcvideo: Report control errors","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi (2022-07-25 08:56:59)\n> Hi Kieran\n> \n> On Thu, Jul 21, 2022 at 01:13:00PM +0100, Kieran Bingham via libcamera-devel wrote:\n> > Report an error when failing to process controls, but still allow the\n> > request to process and complete where possible.\n> >\n> > The Request ControlError flag is raised on the request.\n> >\n> > Bug: https://bugs.libcamera.org/show_bug.cgi?id=135\n> > Signed-off-by: Kieran Bingham \n> > ---\n> > src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 7 +++++--\n> > 1 file changed, 5 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> > index 53b2f23ab029..1f282f26bec3 100644\n> > --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> > +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> > @@ -26,6 +26,7 @@\n> > #include \"libcamera/internal/device_enumerator.h\"\n> > #include \"libcamera/internal/media_device.h\"\n> > #include \"libcamera/internal/pipeline_handler.h\"\n> > +#include \"libcamera/internal/request.h\"\n> > #include \"libcamera/internal/sysfs.h\"\n> > #include \"libcamera/internal/v4l2_videodevice.h\"\n> >\n> > @@ -373,8 +374,10 @@ int PipelineHandlerUVC::queueRequestDevice(Camera *camera, Request *request)\n> > }\n> >\n> > int ret = processControls(data, request);\n> > - if (ret < 0)\n> > - return ret;\n> > + if (ret < 0) {\n> > + LOG(UVC, Error) << \"Failed to process controls\";\n> > + request->_d()->setErrorFlags(Request::ControlError);\n> \n> I wonder if Request::Private::setError() wouldn't be enough (that's\n> probably a comment for patch #1).\n\nDo you mean 'drop the word Flags' here too ?\n\n> \n> With the confirmation that this patch introduces a behavioural change,\n> as before we returned early (which I presume from the commit message\n> the change is intended).\n\nYes, this is very much intended behavioural change.\n\n \n> Reviewed-by: Jacopo Mondi \n\nThanks\n\n\n> \n> Thanks\n> j\n> \n> > + }\n> >\n> > ret = data->video_->queueBuffer(buffer);\n> > if (ret < 0)\n> > --\n> > 2.34.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DA18CC3275\n\tfor ;\n\tMon, 25 Jul 2022 14:58:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9C78B63312;\n\tMon, 25 Jul 2022 16:58:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DA4426330A\n\tfor ;\n\tMon, 25 Jul 2022 16:58:34 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8FB496D1;\n\tMon, 25 Jul 2022 16:58:34 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658761116;\n\tbh=E4fbk0hO3f9UkkSng7pnycys8EqLJBq8lPqIOS94Ir0=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=nSoi2uTvQVt0fnG/vfIA61IPeMH5bHBwaHfgE0T7EKYIYpxHHwsqH0DKdYGqELyYy\n\twK5zi50kcep6pmVwVaj0Ec1vuXBbFWFY3bb7KPqHKNaoIbgmTyafizIQ7lSBcqw2Ru\n\teIvkyNP7hLkf2J1S6+s+m5szOp5swW19q4wAq38dEk3tuJNcBvXhfv1eOTamrKCiMX\n\tdH5N0MTNeqeQaCaFKwo9aRDmcOBpytou0oFgvLBdo1Fljvw+sd1xOjyBTGFlI1Lli7\n\tTCcCJ/U7GN6q+CPKYTjzOebW4HWDpjiE3v02TEL67mzr02KM9pR3cDyNt2/fJ2rraf\n\tUHuMkshphAcZw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658761114;\n\tbh=E4fbk0hO3f9UkkSng7pnycys8EqLJBq8lPqIOS94Ir0=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=mnsa51sybIapxUkToAcF0n/yq9VsZGTI5btLIdpdWq66ivNYZoeIdhhwoha4SUqei\n\tHGlKnWW/b0oPwpsNEvnqQWvdCCXUBJmXFcOqw2GMKXcvEQFYA2ycjkxm9E8fn9qPKa\n\t79+QEWHHS5oi0G14C6KN1lBbBstLBgod5hTqhArw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"mnsa51sy\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220725075659.nqu2u6hwqrehb5iw@uno.localdomain>","References":"<20220721121310.1286862-1-kieran.bingham@ideasonboard.com>\n\t<20220721121310.1286862-3-kieran.bingham@ideasonboard.com>\n\t<20220725075659.nqu2u6hwqrehb5iw@uno.localdomain>","To":"Jacopo Mondi ","Date":"Mon, 25 Jul 2022 15:58:32 +0100","Message-ID":"<165876111231.3981176.10532295031811287910@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [RFC PATCH 02/12] libcamera: pipeline:\n\tuvcvideo: Report control errors","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]