[{"id":24016,"web_url":"https://patchwork.libcamera.org/comment/24016/","msgid":"<20220721074310.GH3984498@pyrite.rasen.tech>","date":"2022-07-21T07:43:10","subject":"Re: [libcamera-devel] [PATCH v2 2/4] ipa: rkisp1: Transfer\n\tqueueRequest() call to each algorithm","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Florian,\n\nOn Wed, Jul 20, 2022 at 05:42:19PM +0200, Florian Sylvestre via libcamera-devel wrote:\n> Implement rkisp1 queueRequest() function to update each algorithm with user\n> controls.\n> \n> Signed-off-by: Florian Sylvestre \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/rkisp1/rkisp1.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index a32bb9d1..34034526 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -269,10 +269,10 @@ void IPARkISP1::unmapBuffers(const std::vector &ids)\n> \t}\n> }\n> \n> -void IPARkISP1::queueRequest([[maybe_unused]] const uint32_t frame,\n> -\t\t\t [[maybe_unused]] const ControlList &controls)\n> +void IPARkISP1::queueRequest(const uint32_t frame, const ControlList &controls)\n> {\n> -\t/* \\todo Start processing for 'frame' based on 'controls'. */\n> +\tfor (auto const &algo : algorithms())\n> +\t\talgo->queueRequest(context_, frame, controls);\n> }\n> \n> void IPARkISP1::fillParamsBuffer(const uint32_t frame, const uint32_t bufferId)\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7FBD8BD1F1\n\tfor ;\n\tThu, 21 Jul 2022 07:43:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3C21A6330E;\n\tThu, 21 Jul 2022 09:43:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B1A06603F5\n\tfor ;\n\tThu, 21 Jul 2022 09:43:18 +0200 (CEST)","from pyrite.rasen.tech (softbank036240121080.bbtec.net\n\t[36.240.121.80])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 398F3496;\n\tThu, 21 Jul 2022 09:43:16 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658389400;\n\tbh=WLcp+2tC1OTWqyj+HQ2nbE6dWFmm4JmDbu1bOEVtAvs=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=h/fiOBey0yt3U6MajoOhTgRbJEol/VvIvKQI2tqdcVgsm1tbHY00NmrxVb1iDibiJ\n\tSL2Qo+NSY65FxzVEbWY7GA7VEcwsZUJkzPKErS8v3XwFYIyoOUFu9UYgpfrJof7Zvz\n\tFNK8u4P8C+ZzFyNkwKNeZtEYU+01f9ZdZDKC8qVIiQ79ljrdDK6JrUpZ6XdZK0GT1a\n\tIndbtLZWo99YMjbW0u67m9uKYMYnbCG97JE+bm8Yx5554+y+aXQ1FxTZ7rCsfcb6aI\n\tsxEhdd53soLFR4/dmQz9dBKYqeNAhk+m5fpErVmS3YPJaWz5P+ljWO3o1HhNV3l2Se\n\tRvoPAqf40PVDA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658389398;\n\tbh=WLcp+2tC1OTWqyj+HQ2nbE6dWFmm4JmDbu1bOEVtAvs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YR0BJicQ7uLe7iVw4JDO4hEr+5WJg9r40YoXCoD6pt2/BO1amEAnFlnKMQeeMuwcV\n\tV1YalJq8wU64nO4vW1+S/iOxyhYrhiSRq1KKi6iP8ECQvlrkO1jc9fpfTKDlWv+fVI\n\tsngu69hkJhFYR2vOgnfy8wPJKrLd6L/s191fIGro="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"YR0BJicQ\"; dkim-atps=neutral","Date":"Thu, 21 Jul 2022 16:43:10 +0900","To":"Florian Sylvestre ","Message-ID":"<20220721074310.GH3984498@pyrite.rasen.tech>","References":"<20220720154221.50937-1-fsylvestre@baylibre.com>\n\t<20220720154221.50937-3-fsylvestre@baylibre.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220720154221.50937-3-fsylvestre@baylibre.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/4] ipa: rkisp1: Transfer\n\tqueueRequest() call to each algorithm","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24026,"web_url":"https://patchwork.libcamera.org/comment/24026/","msgid":"<165840803737.2228597.3805279719418507365@Monstersaurus>","date":"2022-07-21T12:53:57","subject":"Re: [libcamera-devel] [PATCH v2 2/4] ipa: rkisp1: Transfer\n\tqueueRequest() call to each algorithm","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Florian Sylvestre via libcamera-devel (2022-07-20 16:42:19)\n> Implement rkisp1 queueRequest() function to update each algorithm with user\n> controls.\n> \n> Signed-off-by: Florian Sylvestre \n> Reviewed-by: Laurent Pinchart \n\nI've also picked this into my development branch, but adjusted it for\npassing the FrameContext.\n\nBut I don't mind rebasing on top of this if it goes in first.\n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/rkisp1/rkisp1.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index a32bb9d1..34034526 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -269,10 +269,10 @@ void IPARkISP1::unmapBuffers(const std::vector &ids)\n> }\n> }\n> \n> -void IPARkISP1::queueRequest([[maybe_unused]] const uint32_t frame,\n> - [[maybe_unused]] const ControlList &controls)\n> +void IPARkISP1::queueRequest(const uint32_t frame, const ControlList &controls)\n> {\n> - /* \\todo Start processing for 'frame' based on 'controls'. */\n> + for (auto const &algo : algorithms())\n> + algo->queueRequest(context_, frame, controls);\n> }\n> \n> void IPARkISP1::fillParamsBuffer(const uint32_t frame, const uint32_t bufferId)\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 58C2EBE173\n\tfor ;\n\tThu, 21 Jul 2022 12:54:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0C5FF6330F;\n\tThu, 21 Jul 2022 14:54:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 41F75601B8\n\tfor ;\n\tThu, 21 Jul 2022 14:54:00 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EEE01496;\n\tThu, 21 Jul 2022 14:53:59 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658408042;\n\tbh=RJ5jQfMYoMU4u3zFwyWmpZdDtn3Mun/oC8UBjN6wuYQ=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=gkljmSMPI93IXc+bSq508HniDf8SLgj5WddZNLgsnX9H6ZrQOpAQThKHDwfa8AXg5\n\tlGBeeJQBfQnKWOsJQWTa+lJsublE8Y3/N+5RRAFAHbDUWfilKL6iKuRYXix9WzUW95\n\tFMZBjSqo1Tnx3Ao/eR3HDLOV+qE8SUvV4cGmv1TgHg/bf6Z/BHEnY0pCQYdrHjPe+z\n\tqmaJnwzqOFFG7+KiAEPcnhnLoG4QodMOKY0R5xnGtM3x8n3h/1dwSJCdqF3zC18BqC\n\tM7ZZq4SyTVIcoPGpGw0zSHO1Ckd3lJA2zEd4srpsSe/bVWIsaT55jvnrAiyWweaLSM\n\tLvvwQV52mpCgQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658408040;\n\tbh=RJ5jQfMYoMU4u3zFwyWmpZdDtn3Mun/oC8UBjN6wuYQ=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=HDkCofRtGrG8+tB/fTqF1cDr9BbLY9mKbA6tgSRsjC3DJJ+ppgK8Lzdftb1Pn+WJ3\n\tkKe4iwWxjDyshcXX7eAYO+uyHlrPdj5Xx398g1lR/R8mTPCFgenIRc3KYu4IpL9gmd\n\tqpZlERnz8m1P+kAw1IeOWmqdiso9JmP31X64smRU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"HDkCofRt\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220720154221.50937-3-fsylvestre@baylibre.com>","References":"<20220720154221.50937-1-fsylvestre@baylibre.com>\n\t<20220720154221.50937-3-fsylvestre@baylibre.com>","To":"Florian Sylvestre ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 21 Jul 2022 13:53:57 +0100","Message-ID":"<165840803737.2228597.3805279719418507365@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2 2/4] ipa: rkisp1: Transfer\n\tqueueRequest() call to each algorithm","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]