[{"id":24010,"web_url":"https://patchwork.libcamera.org/comment/24010/","msgid":"","date":"2022-07-20T15:29:37","subject":"Re: [libcamera-devel] [PATCH] ipa: rkisp1: Drop unnecessary forward\n\tdeclarations and includes","submitter":{"id":123,"url":"https://patchwork.libcamera.org/api/people/123/","name":"Florian Sylvestre","email":"fsylvestre@baylibre.com"},"content":"Hi Laurent,\n\nOn Wed, 20 Jul 2022 at 15:08, Laurent Pinchart\n wrote:\n>\n> Forward declarations of IPACameraSensorInfo and inclusion of\n> linux/rkisp1-config.h are not needed in headers that use them only for\n> arguments to functions defined by the Algorithm base class, as inclusion\n> of algorithm.h will bring the necessary declarations for function\n> arguments. Drop them.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/rkisp1/algorithms/agc.h | 2 --\n> src/ipa/rkisp1/algorithms/awb.h | 2 --\n> src/ipa/rkisp1/algorithms/blc.h | 4 ----\n> 3 files changed, 8 deletions(-)\n>\n> diff --git a/src/ipa/rkisp1/algorithms/agc.h b/src/ipa/rkisp1/algorithms/agc.h\n> index 22c02779d311..1c9818b7db2a 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.h\n> +++ b/src/ipa/rkisp1/algorithms/agc.h\n> @@ -17,8 +17,6 @@\n>\n> namespace libcamera {\n>\n> -struct IPACameraSensorInfo;\n> -\n> namespace ipa::rkisp1::algorithms {\n>\n> class Agc : public Algorithm\n> diff --git a/src/ipa/rkisp1/algorithms/awb.h b/src/ipa/rkisp1/algorithms/awb.h\n> index 7647842f6609..667a8beb7689 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.h\n> +++ b/src/ipa/rkisp1/algorithms/awb.h\n> @@ -7,8 +7,6 @@\n>\n> #pragma once\n>\n> -#include \n> -\n> #include \"algorithm.h\"\n>\n> namespace libcamera {\n> diff --git a/src/ipa/rkisp1/algorithms/blc.h b/src/ipa/rkisp1/algorithms/blc.h\n> index c2649dd7736e..5fc3a80fb638 100644\n> --- a/src/ipa/rkisp1/algorithms/blc.h\n> +++ b/src/ipa/rkisp1/algorithms/blc.h\n> @@ -7,14 +7,10 @@\n>\n> #pragma once\n>\n> -#include \n> -\n> #include \"algorithm.h\"\n>\n> namespace libcamera {\n>\n> -struct IPACameraSensorInfo;\n> -\n> namespace ipa::rkisp1::algorithms {\n>\n> class BlackLevelCorrection : public Algorithm\n>\n> base-commit: 8b02645845bf404fba83910818b285b652f14f89\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n\nReviewed-by: Florian Sylvestre ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C0B1BE173\n\tfor ;\n\tWed, 20 Jul 2022 15:29:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E457663312;\n\tWed, 20 Jul 2022 17:29:50 +0200 (CEST)","from mail-pf1-x433.google.com (mail-pf1-x433.google.com\n\t[IPv6:2607:f8b0:4864:20::433])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5999260489\n\tfor ;\n\tWed, 20 Jul 2022 17:29:50 +0200 (CEST)","by mail-pf1-x433.google.com with SMTP id c139so10484686pfc.2\n\tfor ;\n\tWed, 20 Jul 2022 08:29:50 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658330990;\n\tbh=HTi5p/fOHmYd4+/G6Nlyc0vRkr1A5gPIaS05DlhVtAs=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=E+jI+7R+mvV7I/3Jn6hdDvyEVSeSQvMnnAMWh32KODOivZHC18PxZTEfk/ym1tpoK\n\trVQkqLov/22N7BxriZ3Y9wyZ9McdJsqVyHdK1PPyc9h/rBmBlyeBZRq5tBYPGhAM7+\n\t3uEUNnNy3lomCnV1lIGACSswjEXRqIxs32NckrO09O0zQI7G4bycNmLu5nP9pFWlD8\n\ttHwyc4snK3n+goHklWaasWBUALYQmhDuy+UPOdEurtGLGFFLIwQ1++eIBX+FLlzwZi\n\tGF1uzIHrK3Dd37IL8Ck4HR6BOu9g2oL+UnpSk/PXVtSgaLaeY/+Zbukm/VR76hbx39\n\tt2yeiCw541dVg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=baylibre-com.20210112.gappssmtp.com; s=20210112;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=nD6Hkyiq/LNtf7hWN21w3JodwI4QRdNPTpxtikK6vGk=;\n\tb=KXXLUbZ4AH221jJvzkQkg+W0oamu6ppXxJH1ONJkWx0mxukMW+/7i0pLnJOmEp7us1\n\t8lFuZXW40a208xQtABfclWbVDNBUKzWQwVhZ5P6r7VYRqPmD9LXUdGM9nolb18eHO09P\n\t+tzeYLhZ2v2AJUdxPfAk+jU45RkXzTERgL4UrKjzETSKEv3L94/dwfznEsG+BJvnl6RI\n\t8jRfrYuOY7XzT33hNoji8Ffzg0ytitHimNW8l4GAMqpPOHqLf5ySuGAkjCj+vBzfuz6N\n\t0FSYABqPPFG/iGYDkriNC68pHzzcgWMpv4Zvj5AS4BAGRryQFMpcWOx9dUotXdIZVvFK\n\tG8Zg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=baylibre-com.20210112.gappssmtp.com\n\theader.i=@baylibre-com.20210112.gappssmtp.com header.b=\"KXXLUbZ4\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=nD6Hkyiq/LNtf7hWN21w3JodwI4QRdNPTpxtikK6vGk=;\n\tb=k3MtZANOtmntJlk1AeyFwY8yIl8G/DRJgA1x808NehIckWyuC/xPDxZZO5J0jVacfE\n\tdkygRo+BhNac7SfeF014xQv8R+N8+CXlnZ52Mru8H7TgxHTnwb/LTMjiOKWcDDGrxP7b\n\t5TixWvqdfJTmG5mVc49yEv0TPKbqCZqDKcyZRdbu3WbeM4IAO9PMs6TDTeFtS61Phsim\n\tYPW4sjRJPzifMh22ZJVfkA20N9ahcgbIA5lszBy7drItyx+8yysYBrGpWTWoeTaG2kTM\n\tMHX7DX9yuuQSwyMtACRb4pNR7gBBOn8yB4pZGDMVWJ/epaiq/cEXLgiqw4W1xZBZ/lSD\n\tWGXw==","X-Gm-Message-State":"AJIora+RAOwQZM+aUt1N+7pqejIdHsR9T57PdPDGAOB1lLFODP8Lwo6W\n\tJv0W3ZUluve2rSzOY+DCGeBofvwxK7R9EjJNPBY7w62Gv8SltRz9","X-Google-Smtp-Source":"AGRyM1t32XjcSWo9BCHtziC8kbsKWkZ1JoCuawJ8bZOwcC4ExO5N4aHhGxLi3UmFvs24iVpC4B/GLGyYzZu19nOr3UI=","X-Received":"by 2002:a05:6a00:189e:b0:52a:c147:ee70 with SMTP id\n\tx30-20020a056a00189e00b0052ac147ee70mr39359899pfh.61.1658330988693;\n\tWed, 20 Jul 2022 08:29:48 -0700 (PDT)","MIME-Version":"1.0","References":"<20220720130740.15300-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220720130740.15300-1-laurent.pinchart@ideasonboard.com>","Date":"Wed, 20 Jul 2022 17:29:37 +0200","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH] ipa: rkisp1: Drop unnecessary forward\n\tdeclarations and includes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Florian Sylvestre via libcamera-devel\n\t","Reply-To":"Florian Sylvestre ","Cc":"Laurent Pinchart via libcamera-devel\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24011,"web_url":"https://patchwork.libcamera.org/comment/24011/","msgid":"<9c367542-bbaa-23b4-b3c1-97bdc5eae47b@ideasonboard.com>","date":"2022-07-20T16:43:54","subject":"Re: [libcamera-devel] [PATCH] ipa: rkisp1: Drop unnecessary forward\n\tdeclarations and includes","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hello,\n\nOn 7/20/22 18:37, Laurent Pinchart via libcamera-devel wrote:\n> Forward declarations of IPACameraSensorInfo and inclusion of\n> linux/rkisp1-config.h are not needed in headers that use them only for\n> arguments to functions defined by the Algorithm base class, as inclusion\n> of algorithm.h will bring the necessary declarations for function\n> arguments. Drop them.\n>\n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Umang Jain \n\n> ---\n> src/ipa/rkisp1/algorithms/agc.h | 2 --\n> src/ipa/rkisp1/algorithms/awb.h | 2 --\n> src/ipa/rkisp1/algorithms/blc.h | 4 ----\n> 3 files changed, 8 deletions(-)\n>\n> diff --git a/src/ipa/rkisp1/algorithms/agc.h b/src/ipa/rkisp1/algorithms/agc.h\n> index 22c02779d311..1c9818b7db2a 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.h\n> +++ b/src/ipa/rkisp1/algorithms/agc.h\n> @@ -17,8 +17,6 @@\n> \n> namespace libcamera {\n> \n> -struct IPACameraSensorInfo;\n> -\n> namespace ipa::rkisp1::algorithms {\n> \n> class Agc : public Algorithm\n> diff --git a/src/ipa/rkisp1/algorithms/awb.h b/src/ipa/rkisp1/algorithms/awb.h\n> index 7647842f6609..667a8beb7689 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.h\n> +++ b/src/ipa/rkisp1/algorithms/awb.h\n> @@ -7,8 +7,6 @@\n> \n> #pragma once\n> \n> -#include \n> -\n> #include \"algorithm.h\"\n> \n> namespace libcamera {\n> diff --git a/src/ipa/rkisp1/algorithms/blc.h b/src/ipa/rkisp1/algorithms/blc.h\n> index c2649dd7736e..5fc3a80fb638 100644\n> --- a/src/ipa/rkisp1/algorithms/blc.h\n> +++ b/src/ipa/rkisp1/algorithms/blc.h\n> @@ -7,14 +7,10 @@\n> \n> #pragma once\n> \n> -#include \n> -\n> #include \"algorithm.h\"\n> \n> namespace libcamera {\n> \n> -struct IPACameraSensorInfo;\n> -\n> namespace ipa::rkisp1::algorithms {\n> \n> class BlackLevelCorrection : public Algorithm\n>\n> base-commit: 8b02645845bf404fba83910818b285b652f14f89","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A716BD1F1\n\tfor ;\n\tWed, 20 Jul 2022 16:44:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7BBDD63312;\n\tWed, 20 Jul 2022 18:44:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3BC2060489\n\tfor ;\n\tWed, 20 Jul 2022 18:44:10 +0200 (CEST)","from [192.168.1.110] (unknown [110.226.27.196])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E92D66DB;\n\tWed, 20 Jul 2022 18:44:08 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658335451;\n\tbh=iiF12ysjWmOPN+fbmdLORWT0/jYUTVJ4W66Uk0/UJvY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=jDfD7B7Ujs56iu2HYJD1htKS46YRMVkIFh+qHjfdbAoyQK218vlqooeSoXkkTsGbJ\n\tp6pn2sUE+/zbl81jFgFnmHyyeYulExMYieuq6JFvDg4raUQa93+Wg9QcwGoVFr+dPp\n\tuZlvyhQLizFZvgHugGOTtrRvrxx+JNbvZ2JQh6DHzCw5HLla2WLrrvj0pT22ZjelMS\n\tgaRUKHj1QrfyesQqlvYhHrggorFa1ROYe6biq/jFJH5rxdJ2aF8ihg6P0MjEtvh6+t\n\tFByFCzq/52aYf704JG+d+9TpGLQ3UMdbR7EpbxuoYFt7ivd3rAxsyQjhtTc9/Q1gNM\n\t6WPfek7sqbwjA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658335449;\n\tbh=iiF12ysjWmOPN+fbmdLORWT0/jYUTVJ4W66Uk0/UJvY=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=ssOPfnWVIRrfye0t05MNqDdntVsUJc7pmbD92rNG0hfCdmWi4D9T9x9IJxZNVSPYz\n\tGFXkYt8ttRf6IJwXf63mcUuec9CM3oW+4ojikPOxwhDaesErROaPf9lZmRV64ZFr4p\n\tjNDQJcl9FC9BH1k7EhwgKTi2GqNCy6FiDGXE8DOQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ssOPfnWV\"; dkim-atps=neutral","Message-ID":"<9c367542-bbaa-23b4-b3c1-97bdc5eae47b@ideasonboard.com>","Date":"Wed, 20 Jul 2022 22:13:54 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220720130740.15300-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220720130740.15300-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] ipa: rkisp1: Drop unnecessary forward\n\tdeclarations and includes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]