[{"id":24212,"web_url":"https://patchwork.libcamera.org/comment/24212/","msgid":"<20220728081335.a2pudqmopfmmk65q@uno.localdomain>","date":"2022-07-28T08:13:35","subject":"Re: [libcamera-devel] [PATCH v5 2/2] cam: sdl_sink: Pass a\n\tSpan to SDLTexture::update()","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent\n\nOn Wed, Jul 20, 2022 at 04:03:48PM +0300, Laurent Pinchart via libcamera-devel wrote:\n> The SDLTexture::update() function isn't meant to modify the data it\n> receives. Make the Span type const to ensure this at compile time. While\n> at it, pass the Span by value instead of reference, as a Span is only a\n> pointer and size, which will fit in registers and will avoid pointer\n> dereferences in the callee.\n>\n> Signed-off-by: Laurent Pinchart \n\nLooks good\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/cam/sdl_texture.h | 2 +-\n> src/cam/sdl_texture_mjpg.cpp | 4 ++--\n> src/cam/sdl_texture_mjpg.h | 4 ++--\n> src/cam/sdl_texture_yuyv.cpp | 2 +-\n> src/cam/sdl_texture_yuyv.h | 2 +-\n> 5 files changed, 7 insertions(+), 7 deletions(-)\n>\n> diff --git a/src/cam/sdl_texture.h b/src/cam/sdl_texture.h\n> index 1d8b09288d50..f523fa5ebf51 100644\n> --- a/src/cam/sdl_texture.h\n> +++ b/src/cam/sdl_texture.h\n> @@ -17,7 +17,7 @@ public:\n> \tSDLTexture(const SDL_Rect &rect, uint32_t pixelFormat, const int pitch);\n> \tvirtual ~SDLTexture();\n> \tint create(SDL_Renderer *renderer);\n> -\tvirtual void update(const libcamera::Span &data) = 0;\n> +\tvirtual void update(libcamera::Span data) = 0;\n> \tSDL_Texture *get() const { return ptr_; }\n>\n> protected:\n> diff --git a/src/cam/sdl_texture_mjpg.cpp b/src/cam/sdl_texture_mjpg.cpp\n> index 7eddc00cd210..7542efd75d96 100644\n> --- a/src/cam/sdl_texture_mjpg.cpp\n> +++ b/src/cam/sdl_texture_mjpg.cpp\n> @@ -43,7 +43,7 @@ SDLTextureMJPG::SDLTextureMJPG(const SDL_Rect &rect)\n> {\n> }\n>\n> -int SDLTextureMJPG::decompress(const Span &data)\n> +int SDLTextureMJPG::decompress(Span data)\n> {\n> \tstruct jpeg_decompress_struct cinfo;\n>\n> @@ -76,7 +76,7 @@ int SDLTextureMJPG::decompress(const Span &data)\n> \treturn 0;\n> }\n>\n> -void SDLTextureMJPG::update(const Span &data)\n> +void SDLTextureMJPG::update(Span data)\n> {\n> \tdecompress(data);\n> \tSDL_UpdateTexture(ptr_, nullptr, rgb_.get(), pitch_);\n> diff --git a/src/cam/sdl_texture_mjpg.h b/src/cam/sdl_texture_mjpg.h\n> index 328c45a913c5..5141ed73bf70 100644\n> --- a/src/cam/sdl_texture_mjpg.h\n> +++ b/src/cam/sdl_texture_mjpg.h\n> @@ -14,10 +14,10 @@ class SDLTextureMJPG : public SDLTexture\n> public:\n> \tSDLTextureMJPG(const SDL_Rect &rect);\n>\n> -\tvoid update(const libcamera::Span &data) override;\n> +\tvoid update(libcamera::Span data) override;\n>\n> private:\n> -\tint decompress(const libcamera::Span &data);\n> +\tint decompress(libcamera::Span data);\n>\n> \tstd::unique_ptr rgb_;\n> };\n> diff --git a/src/cam/sdl_texture_yuyv.cpp b/src/cam/sdl_texture_yuyv.cpp\n> index cc161b2cfa79..637c0900edff 100644\n> --- a/src/cam/sdl_texture_yuyv.cpp\n> +++ b/src/cam/sdl_texture_yuyv.cpp\n> @@ -14,7 +14,7 @@ SDLTextureYUYV::SDLTextureYUYV(const SDL_Rect &rect)\n> {\n> }\n>\n> -void SDLTextureYUYV::update(const Span &data)\n> +void SDLTextureYUYV::update(Span data)\n> {\n> \tSDL_UpdateTexture(ptr_, &rect_, data.data(), pitch_);\n> }\n> diff --git a/src/cam/sdl_texture_yuyv.h b/src/cam/sdl_texture_yuyv.h\n> index 9f7c72f09db2..529a72d6a40e 100644\n> --- a/src/cam/sdl_texture_yuyv.h\n> +++ b/src/cam/sdl_texture_yuyv.h\n> @@ -13,5 +13,5 @@ class SDLTextureYUYV : public SDLTexture\n> {\n> public:\n> \tSDLTextureYUYV(const SDL_Rect &rect);\n> -\tvoid update(const libcamera::Span &data) override;\n> +\tvoid update(libcamera::Span data) override;\n> };\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64237BE173\n\tfor ;\n\tThu, 28 Jul 2022 08:13:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1866F63311;\n\tThu, 28 Jul 2022 10:13:39 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::223])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AE310603EB\n\tfor ;\n\tThu, 28 Jul 2022 10:13:37 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id E000560004;\n\tThu, 28 Jul 2022 08:13:36 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658996019;\n\tbh=fdNZYohxVbgVnLSvxRyxGUbG1kUKfaEbbI19Pgg1sgM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ziRm7oR9kNj/673FCU2fWsJUPDH670X69DPjw4s2DrPP2DadFntkDwm6I7gsB0QKd\n\tUdQ0ffIfUpweFl+mWgKJRHf11rbrm3b7MnR7aZYzw9Lb2L+E8s3NwlBXtCAyHTKmgl\n\t6E9EQq7a3BTiTrhfKjKvr8vh+GyAvm/ccZ41ZIsWvPaEMgbDHpY/8WPR+rTttnMzoz\n\toh9epItpHpoo6dY+rf4ysL9Ut38xhPUtjJaKTzOyZbFBOzgTFVQQ2zzxtWvLqxRbgP\n\tZy25YmwRrpckrM6i9FrOcm5kT+XBzFSwVKs4juD3Y1DSdnxqXNZBOD/ExrZ5Ly5VD1\n\t4zZR1M480NYzg==","Date":"Thu, 28 Jul 2022 10:13:35 +0200","To":"Laurent Pinchart ","Message-ID":"<20220728081335.a2pudqmopfmmk65q@uno.localdomain>","References":"<20220720130348.1337-1-laurent.pinchart@ideasonboard.com>\n\t<20220720130348.1337-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220720130348.1337-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v5 2/2] cam: sdl_sink: Pass a\n\tSpan to SDLTexture::update()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]