[{"id":23987,"web_url":"https://patchwork.libcamera.org/comment/23987/","msgid":"<20220720085640.x6pyig5vsxyh3rzf@uno.localdomain>","date":"2022-07-20T08:56:40","subject":"Re: [libcamera-devel] [PATCH] libcamera: Remove extra ':' after\n\t'\\todo'","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Wed, Jul 20, 2022 at 12:01:48AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> The doxygen '\\todo' directory doesn't need to be followed by a colon,\n> yet a few strayed occurrences have made their way in. Fix them.\n>\n> Signed-off-by: Laurent Pinchart \n\nlooks good\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> include/libcamera/internal/delayed_controls.h | 2 +-\n> src/ipa/ipu3/algorithms/agc.cpp | 2 +-\n> src/libcamera/camera.cpp | 4 ++--\n> src/libcamera/controls.cpp | 2 +-\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> src/libcamera/request.cpp | 2 +-\n> 6 files changed, 7 insertions(+), 7 deletions(-)\n>\n> diff --git a/include/libcamera/internal/delayed_controls.h b/include/libcamera/internal/delayed_controls.h\n> index f560c823d4e9..cd3ca8070278 100644\n> --- a/include/libcamera/internal/delayed_controls.h\n> +++ b/include/libcamera/internal/delayed_controls.h\n> @@ -51,7 +51,7 @@ private:\n> \t\tbool updated;\n> \t};\n>\n> -\t/* \\todo: Make the listSize configurable at instance creation time. */\n> +\t/* \\todo Make the listSize configurable at instance creation time. */\n> \tstatic constexpr int listSize = 16;\n> \tclass ControlRingBuffer : public std::array\n> \t{\n> diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\n> index f16be534dd71..5bc64ae52214 100644\n> --- a/src/ipa/ipu3/algorithms/agc.cpp\n> +++ b/src/ipa/ipu3/algorithms/agc.cpp\n> @@ -229,7 +229,7 @@ void Agc::computeExposure(IPAContext &context, IPAFrameContext *frameContext,\n>\n> \t/*\n> \t * Filter the exposure.\n> -\t * \\todo: estimate if we need to desaturate\n> +\t * \\todo estimate if we need to desaturate\n> \t */\n> \texposureValue = filterExposure(exposureValue);\n>\n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index f8150dcdc788..2a8ef60e3862 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -184,12 +184,12 @@ void CameraConfiguration::addConfiguration(const StreamConfiguration &cfg)\n> * This function adjusts the camera configuration to the closest valid\n> * configuration and returns the validation status.\n> *\n> - * \\todo: Define exactly when to return each status code. Should stream\n> + * \\todo Define exactly when to return each status code. Should stream\n> * parameters set to 0 by the caller be adjusted without returning Adjusted ?\n> * This would potentially be useful for applications but would get in the way\n> * in Camera::configure(). Do we need an extra status code to signal this ?\n> *\n> - * \\todo: Handle validation of buffers count when refactoring the buffers API.\n> + * \\todo Handle validation of buffers count when refactoring the buffers API.\n> *\n> * \\return A CameraConfiguration::Status value that describes the validation\n> * status.\n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index 03ac6345247c..840bea4b92b8 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -908,7 +908,7 @@ ControlList::ControlList(const ControlInfoMap &infoMap,\n> void ControlList::merge(const ControlList &source)\n> {\n> \t/**\n> -\t * \\todo: ASSERT that the current and source ControlList are derived\n> +\t * \\todo ASSERT that the current and source ControlList are derived\n> \t * from a compatible ControlIdMap, to prevent undefined behaviour due to\n> \t * id collisions.\n> \t *\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index d60f20b08e27..4fe52f74a68c 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -552,7 +552,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n> \t\treturn ret;\n>\n> \t/*\n> -\t * \\todo: Enable links selectively based on the requested streams.\n> +\t * \\todo Enable links selectively based on the requested streams.\n> \t * As of now, enable all links unconditionally.\n> \t * \\todo Don't configure the ImgU at all if we only have a single\n> \t * stream which is for raw capture, in which case no buffers will\n> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> index 07613cb33709..d2af1d2212ad 100644\n> --- a/src/libcamera/request.cpp\n> +++ b/src/libcamera/request.cpp\n> @@ -349,7 +349,7 @@ Request::Request(Camera *camera, uint64_t cookie)\n> \t\t\t\t camera->_d()->validator());\n>\n> \t/**\n> -\t * \\todo: Add a validator for metadata controls.\n> +\t * \\todo Add a validator for metadata controls.\n> \t */\n> \tmetadata_ = new ControlList(controls::controls);\n>\n>\n> base-commit: 62e32042aee4042b6a931bc27a6ad11384b521f5\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1404DBE173\n\tfor ;\n\tWed, 20 Jul 2022 08:56:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8162863313;\n\tWed, 20 Jul 2022 10:56:43 +0200 (CEST)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6938B60488\n\tfor ;\n\tWed, 20 Jul 2022 10:56:42 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id EB32B20016;\n\tWed, 20 Jul 2022 08:56:41 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658307403;\n\tbh=/Wz1SITtdE4swFuH13U+7v6TzZ7FqunzoWJKICm3/y4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=cR0vDi/6oT90nBIr7p628QQFOB021wYrtCUiPqg7ax4PeKxeVeI59Sjv9EZ857qrz\n\tFAG9DcoA9W80Bd5DnvK96IM02139Igy+mby6ypvS2Qw92X5tetOm7zG8ek9VO8z2IW\n\t5iBocMgsGjCrpucKhX60S0SKKdOGV1FxBkzwk9xjsSvHagBRdnOJgqbweWfWKt1wpa\n\tj7pjzvXRb7lYCHXPaEZBBD9tZqqBepbalwqBpAumJUUqb7hQN/HigHor/flXexNowu\n\ttrKxxWYjOk61/ozQZ5hRdM1+HHmG0w3mvWoAamhCZDIiNEsrlJCRfaM2MKxD9QwBBH\n\tf6FvyV7c7rqug==","Date":"Wed, 20 Jul 2022 10:56:40 +0200","To":"Laurent Pinchart ","Message-ID":"<20220720085640.x6pyig5vsxyh3rzf@uno.localdomain>","References":"<20220719210148.4588-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220719210148.4588-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Remove extra ':' after\n\t'\\todo'","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23990,"web_url":"https://patchwork.libcamera.org/comment/23990/","msgid":"<20220720091108.GC3984498@pyrite.rasen.tech>","date":"2022-07-20T09:11:08","subject":"Re: [libcamera-devel] [PATCH] libcamera: Remove extra ':' after\n\t'\\todo'","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Laurent,\n\nOn Wed, Jul 20, 2022 at 12:01:48AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> The doxygen '\\todo' directory doesn't need to be followed by a colon,\n> yet a few strayed occurrences have made their way in. Fix them.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> include/libcamera/internal/delayed_controls.h | 2 +-\n> src/ipa/ipu3/algorithms/agc.cpp | 2 +-\n> src/libcamera/camera.cpp | 4 ++--\n> src/libcamera/controls.cpp | 2 +-\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> src/libcamera/request.cpp | 2 +-\n> 6 files changed, 7 insertions(+), 7 deletions(-)\n> \n> diff --git a/include/libcamera/internal/delayed_controls.h b/include/libcamera/internal/delayed_controls.h\n> index f560c823d4e9..cd3ca8070278 100644\n> --- a/include/libcamera/internal/delayed_controls.h\n> +++ b/include/libcamera/internal/delayed_controls.h\n> @@ -51,7 +51,7 @@ private:\n> \t\tbool updated;\n> \t};\n> \n> -\t/* \\todo: Make the listSize configurable at instance creation time. */\n> +\t/* \\todo Make the listSize configurable at instance creation time. */\n> \tstatic constexpr int listSize = 16;\n> \tclass ControlRingBuffer : public std::array\n> \t{\n> diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\n> index f16be534dd71..5bc64ae52214 100644\n> --- a/src/ipa/ipu3/algorithms/agc.cpp\n> +++ b/src/ipa/ipu3/algorithms/agc.cpp\n> @@ -229,7 +229,7 @@ void Agc::computeExposure(IPAContext &context, IPAFrameContext *frameContext,\n> \n> \t/*\n> \t * Filter the exposure.\n> -\t * \\todo: estimate if we need to desaturate\n> +\t * \\todo estimate if we need to desaturate\n> \t */\n> \texposureValue = filterExposure(exposureValue);\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index f8150dcdc788..2a8ef60e3862 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -184,12 +184,12 @@ void CameraConfiguration::addConfiguration(const StreamConfiguration &cfg)\n> * This function adjusts the camera configuration to the closest valid\n> * configuration and returns the validation status.\n> *\n> - * \\todo: Define exactly when to return each status code. Should stream\n> + * \\todo Define exactly when to return each status code. Should stream\n> * parameters set to 0 by the caller be adjusted without returning Adjusted ?\n> * This would potentially be useful for applications but would get in the way\n> * in Camera::configure(). Do we need an extra status code to signal this ?\n> *\n> - * \\todo: Handle validation of buffers count when refactoring the buffers API.\n> + * \\todo Handle validation of buffers count when refactoring the buffers API.\n> *\n> * \\return A CameraConfiguration::Status value that describes the validation\n> * status.\n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index 03ac6345247c..840bea4b92b8 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -908,7 +908,7 @@ ControlList::ControlList(const ControlInfoMap &infoMap,\n> void ControlList::merge(const ControlList &source)\n> {\n> \t/**\n> -\t * \\todo: ASSERT that the current and source ControlList are derived\n> +\t * \\todo ASSERT that the current and source ControlList are derived\n> \t * from a compatible ControlIdMap, to prevent undefined behaviour due to\n> \t * id collisions.\n> \t *\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index d60f20b08e27..4fe52f74a68c 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -552,7 +552,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n> \t\treturn ret;\n> \n> \t/*\n> -\t * \\todo: Enable links selectively based on the requested streams.\n> +\t * \\todo Enable links selectively based on the requested streams.\n> \t * As of now, enable all links unconditionally.\n> \t * \\todo Don't configure the ImgU at all if we only have a single\n> \t * stream which is for raw capture, in which case no buffers will\n> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> index 07613cb33709..d2af1d2212ad 100644\n> --- a/src/libcamera/request.cpp\n> +++ b/src/libcamera/request.cpp\n> @@ -349,7 +349,7 @@ Request::Request(Camera *camera, uint64_t cookie)\n> \t\t\t\t camera->_d()->validator());\n> \n> \t/**\n> -\t * \\todo: Add a validator for metadata controls.\n> +\t * \\todo Add a validator for metadata controls.\n> \t */\n> \tmetadata_ = new ControlList(controls::controls);\n> \n> \n> base-commit: 62e32042aee4042b6a931bc27a6ad11384b521f5","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8F0EBE173\n\tfor ;\n\tWed, 20 Jul 2022 09:11:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6339D63313;\n\tWed, 20 Jul 2022 11:11:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A6AB560488\n\tfor ;\n\tWed, 20 Jul 2022 11:11:16 +0200 (CEST)","from pyrite.rasen.tech (softbank036240121080.bbtec.net\n\t[36.240.121.80])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 18F666DB;\n\tWed, 20 Jul 2022 11:11:14 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658308277;\n\tbh=0lJ6SiulXgbvAVejM4hi0wdIMgusOd+eEUqxwUwuwps=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=qVJD64KroI0OHz4CaN/48JZndLKG4p0g6tpYsjzjNMJ9fjkuWN5Bt2+nZFwNA/3oJ\n\t/7ZlCPuvwldeiU+PefofC7y/0TcBEJ6KZNoGL2xArkfWJ10SyrMEQQX7WLUjUDuKAc\n\tlxxDPltNEkPpWzynV7xVVM2nI15/3qQhxXifZypVEmnx0I+JrBkiL6OizhSYGenAy2\n\tC88zh4yop/qoOl5+K3kaHu5XGbmrvIf+GtZ9N0e/cQ2c5pvFaVsp9/wyu73EqWe58c\n\ty6FEP1318KOm3Y1ICyKA89CnrQHqNVsAkRROpRYry5UUIKfWLfUkaAU8DlEABgBEzI\n\tRblVJKqg/JxBA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658308276;\n\tbh=0lJ6SiulXgbvAVejM4hi0wdIMgusOd+eEUqxwUwuwps=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=obRqwwhG+1Vb3iD3fg19aZrE0ourCJvpNbZVFLFGzmPIDY59U0LP+5TtphkAW2Nsf\n\tUJJdkX8UwymLk8eWunLkRth2bHr9uVhSEWhfJp7L0BckXdbuaMXT7NtBLPowx6qT+Z\n\t/HpObxPXQ2S4+ci2q04OWnTXtwce6+UjGs3/RPKw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"obRqwwhG\"; dkim-atps=neutral","Date":"Wed, 20 Jul 2022 18:11:08 +0900","To":"Laurent Pinchart ","Message-ID":"<20220720091108.GC3984498@pyrite.rasen.tech>","References":"<20220719210148.4588-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220719210148.4588-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Remove extra ':' after\n\t'\\todo'","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]