[{"id":2233,"web_url":"https://patchwork.libcamera.org/comment/2233/","msgid":"<20190712083401.GI4831@pendragon.ideasonboard.com>","date":"2019-07-12T08:34:01","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: process: fix\n\tcompilation on Chromium OS","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Jul 12, 2019 at 05:29:08PM +0900, Paul Elder wrote:\n> Commit 3d20beca6616 (\"libcamera: Add Process and ProcessManager\n> classes\") causes the build to fail in the Chromium OS build environment,\n> because the return values of some system calls are ignored. Fix this.\n\nSame comments as for 2/2.\n\n> Signed-off-by: Paul Elder \n> ---\n> src/libcamera/process.cpp | 14 +++++++++++---\n> 1 file changed, 11 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\n> index 9d8829d..eccf1dd 100644\n> --- a/src/libcamera/process.cpp\n> +++ b/src/libcamera/process.cpp\n> @@ -69,7 +69,9 @@ namespace {\n> void sigact(int signal, siginfo_t *info, void *ucontext)\n> {\n> \tchar data = 0;\n> -\twrite(ProcessManager::instance()->writePipe(), &data, sizeof(data));\n> +\t/* We're in a signal handler so we can't log any message,\n> +\t * and we need to continue anyway. */\n\n\t/*\n\t * ...\n\t * ...\n\t /\n\n> +\t(void)write(ProcessManager::instance()->writePipe(), &data, sizeof(data));\n> \n> \tconst struct sigaction &oldsa = ProcessManager::instance()->oldsa();\n> \tif (oldsa.sa_flags & SA_SIGINFO) {\n> @@ -85,7 +87,11 @@ void sigact(int signal, siginfo_t *info, void *ucontext)\n> void ProcessManager::sighandler(EventNotifier *notifier)\n> {\n> \tchar data;\n> -\tread(pipe_[0], &data, sizeof(data));\n> +\tif (read(pipe_[0], &data, sizeof(data))) {\n> +\t\tLOG(Process, Error)\n> +\t\t\t<< \"failed to read byte from direct signal handler\";\n\ns/failed/Failed/\ns/from direct signal handler/from signal handler pipe/\n\nReviewed-by: Laurent Pinchart \n\n> +\t\treturn;\n> +\t}\n> \n> \tfor (auto it = processes_.begin(); it != processes_.end(); ) {\n> \t\tProcess *process = *it;\n> @@ -128,7 +134,9 @@ ProcessManager::ProcessManager()\n> \n> \tsigaction(SIGCHLD, &sa, NULL);\n> \n> -\tpipe2(pipe_, O_CLOEXEC | O_DIRECT | O_NONBLOCK);\n> +\tif (pipe2(pipe_, O_CLOEXEC | O_DIRECT | O_NONBLOCK))\n> +\t\tLOG(Process, Fatal)\n> +\t\t\t<< \"Failed to initialize pipe for signal handling\";\n> \tsigEvent_ = new EventNotifier(pipe_[0], EventNotifier::Read);\n> \tsigEvent_->activated.connect(this, &ProcessManager::sighandler);\n> }","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D01F60E40\n\tfor ;\n\tFri, 12 Jul 2019 10:34:29 +0200 (CEST)","from pendragon.ideasonboard.com (softbank126209254147.bbtec.net\n\t[126.209.254.147])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A7D912B2;\n\tFri, 12 Jul 2019 10:34:27 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562920468;\n\tbh=Pt5eRM6bHfWYCdSHwtuGMYzoP4pXlOSh/rVUeYK2F7M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=aR2XWBVHdh/eMelytKb0XXt58kDKvdJYnai8l2tHaWAEjsHMEXbl2WEev++L2XJ/G\n\tB/wtjw1b9oDoKatrrRBnRgJh8qpAda4TW7x20EyzQd4Mkgpl7ln82w/7hGNzTs+tDa\n\tZw7yGgmr/i7gDkKqgbzXbFFnDgS1o1AamYundIDA=","Date":"Fri, 12 Jul 2019 11:34:01 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190712083401.GI4831@pendragon.ideasonboard.com>","References":"<20190712082909.3811-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190712082909.3811-1-paul.elder@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: process: fix\n\tcompilation on Chromium OS","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 12 Jul 2019 08:34:29 -0000"}}]