[{"id":23969,"web_url":"https://patchwork.libcamera.org/comment/23969/","msgid":"<20220719154352.bz6eqcxajrrhmomh@uno.localdomain>","date":"2022-07-19T15:43:52","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: pipeline: uvcvideo:\n\tReport control errors","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran\n\nOn Tue, Jul 19, 2022 at 11:31:44AM +0100, Kieran Bingham via libcamera-devel wrote:\n> Report an error when failing to process controls, but still allow the\n> request to process and complete where possible.\n>\n> The Request ControlError flag is raised on the request.\n>\n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=135\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 7 +++++--\n> 1 file changed, 5 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 53b2f23ab029..1f282f26bec3 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -26,6 +26,7 @@\n> #include \"libcamera/internal/device_enumerator.h\"\n> #include \"libcamera/internal/media_device.h\"\n> #include \"libcamera/internal/pipeline_handler.h\"\n> +#include \"libcamera/internal/request.h\"\n> #include \"libcamera/internal/sysfs.h\"\n> #include \"libcamera/internal/v4l2_videodevice.h\"\n>\n> @@ -373,8 +374,10 @@ int PipelineHandlerUVC::queueRequestDevice(Camera *camera, Request *request)\n> \t}\n>\n> \tint ret = processControls(data, request);\n> -\tif (ret < 0)\n> -\t\treturn ret;\n> +\tif (ret < 0) {\n> +\t\tLOG(UVC, Error) << \"Failed to process controls\";\n> +\t\trequest->_d()->setErrorFlags(Request::ControlError);\n> +\t}\n>\n> \tret = data->video_->queueBuffer(buffer);\n> \tif (ret < 0)\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1EB9DBD1F1\n\tfor ;\n\tTue, 19 Jul 2022 15:43:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8CF7C6048A;\n\tTue, 19 Jul 2022 17:43:56 +0200 (CEST)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8AFD5603F4\n\tfor ;\n\tTue, 19 Jul 2022 17:43:54 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 151B51BF20C;\n\tTue, 19 Jul 2022 15:43:53 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658245436;\n\tbh=nP+suUw3oOTDXVgqyUf0EZR6CEbYF+PokPQ01vNX3xs=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=BP8EVSl1NNo+h0+zZYASm339FGvceov24v6NnYa6Q9ZGruItWgRxiDkOoUUDdjgVT\n\tK11G0fmH3QzBR3jIiMCpwZlrjFTCPhjStjU5O0qogj6/KTh4GBakVswRYDsNM4PhPd\n\tKYUvbvGtpOtCfkkB9OneJsaPMPya2Qabkx5YimU/lbycDW51CIOSSbyNPvuHS/6DzU\n\t8vqJaMHgCyfTNjWU1JUH4zmj1fOk65NITWpR3KklCa1CxzZw0mxBUSD5rf9BvSW3vI\n\tYa5HlVIO/3b9igcC3PzlfSJr8KzprlD0Y3zjCDt79fcxZlIlSr90S3yy4hEt88jWi+\n\tYhWkTpCaMQAtQ==","Date":"Tue, 19 Jul 2022 17:43:52 +0200","To":"Kieran Bingham ","Message-ID":"<20220719154352.bz6eqcxajrrhmomh@uno.localdomain>","References":"<20220719103144.3686313-1-kieran.bingham@ideasonboard.com>\n\t<20220719103144.3686313-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220719103144.3686313-3-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: pipeline: uvcvideo:\n\tReport control errors","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]