{"id":1668,"url":"https://patchwork.libcamera.org/api/patches/1668/?format=json","web_url":"https://patchwork.libcamera.org/patch/1668/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190711191235.25150-1-laurent.pinchart@ideasonboard.com>","date":"2019-07-11T19:12:35","name":"[libcamera-devel] libcamera: signal: Fix compilation on gcc","commit_ref":"b50c5f28b14e2fb14d4de0c088949e1405d22c6a","pull_url":null,"state":"accepted","archived":false,"hash":"2d5577e8110e5e7f52bf110a55530d60641b3991","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1668/mbox/","series":[{"id":421,"url":"https://patchwork.libcamera.org/api/series/421/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=421","date":"2019-07-11T19:12:35","name":"[libcamera-devel] libcamera: signal: Fix compilation on gcc","version":1,"mbox":"https://patchwork.libcamera.org/series/421/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1668/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1668/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 899BD60BC8\n\tfor ;\n\tThu, 11 Jul 2019 21:13:07 +0200 (CEST)","from pendragon.ideasonboard.com (softbank126163157105.bbtec.net\n\t[126.163.157.105])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4769331C\n\tfor ;\n\tThu, 11 Jul 2019 21:13:05 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562872387;\n\tbh=eUT1q7aVrnzbPZSCMkWORgeVQjwPQIRjfWyOZbK4oFc=;\n\th=From:To:Subject:Date:From;\n\tb=MqxQlnIIhjO4niXLr3mnwFkJJ7LPj8IA7pcjpTBTRpL7/i1EW4DZYEf5qzydnfDOy\n\taJxn8gVTV0boGGe5WGOo2CfEjxfX0TNcyK8iJ3bceIJ2ng6mwvXvcKVnvyIcg3YtuG\n\t1Q8K6scwmvgIvGqgdaYW/n8tortGLeckJ614BoNU=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 11 Jul 2019 22:12:35 +0300","Message-Id":"<20190711191235.25150-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.21.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: signal: Fix compilation on gcc","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 11 Jul 2019 19:13:07 -0000"},"content":"gcc complains that the recently template specialisation of the\nSlotBase::match() method is invalid as it is in a non-namespace scope.\nLuckily this can easily be fixed by removing the specialisation for the\nfully specialised implementation. As an additional safety measure, using\nstd::enable_if> on the template implementation\nensures that it will never be called for an Object instance.\n\nFixes: 56c2e653008a (\"libcamera: signal: Fix Object handling in multiple inheritance cases\")\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/signal.h | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/include/libcamera/signal.h b/include/libcamera/signal.h\nindex d3be362637f8..8f6db700cd80 100644\n--- a/include/libcamera/signal.h\n+++ b/include/libcamera/signal.h\n@@ -27,9 +27,8 @@ public:\n \t\t: obj_(obj), object_(object) {}\n \tvirtual ~SlotBase() {}\n \n-\ttemplate\n+\ttemplate::value>::type * = nullptr>\n \tbool match(T *obj) { return obj == obj_; }\n-\ttemplate<>\n \tbool match(Object *object) { return object == object_; }\n \n \tvoid disconnect(SignalBase *signal);\n","prefixes":["libcamera-devel"]}