[{"id":23962,"web_url":"https://patchwork.libcamera.org/comment/23962/","msgid":"<20220719100500.7welq63giemvmr7l@uno.localdomain>","date":"2022-07-19T10:05:00","subject":"Re: [libcamera-devel] [PATCH v2 2/2] pipeline: rkisp1: Add support\n\tfor YUV422","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Tue, Jul 19, 2022 at 04:40:13PM +0900, Paul Elder via libcamera-devel wrote:\n> YUV422 is already supported as an output format by the rkisp1 driver.\n> Add them to the pipeline handler to support them in libcamera as well.\n>\n> YVU422 is also supported by the driver, but there only exists a\n> multiplanar V4L2 format, which libcamera is currently unable to map to\n> from the libcamera YVU422 format. This will be fixed later.\n\nThat's peculiar!\n\nThe driver supports (for both the main and self path)\n\nV4L2_PIX_FMT_YUV422P,\nV4L2_PIX_FMT_YVU422M,\n\nso the YUV component ordering is supported throught the contiguous planes\nvariant, while the YVU permutation goes through non-contiguous one.\n\nIs there a reason ? Is the driver correct I wonder ?\n\n>\n> Signed-off-by: Paul Elder \n>\n> ---\n> Changes in v2:\n> - remove YVU422\n> - reorder formats\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 6 ++++--\n> 1 file changed, 4 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> index c070929d..856554b3 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> @@ -209,7 +209,7 @@ void RkISP1Path::stop()\n> namespace {\n> constexpr Size RKISP1_RSZ_MP_SRC_MIN{ 32, 16 };\n> constexpr Size RKISP1_RSZ_MP_SRC_MAX{ 4416, 3312 };\n> -constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> +constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> \tformats::YUYV,\n> \tformats::NV16,\n> \tformats::NV61,\n> @@ -217,13 +217,14 @@ constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> \tformats::NV12,\n> \tformats::YUV420,\n> \tformats::YVU420,\n> +\tformats::YUV422,\n> \tformats::R8,\n> \t/* \\todo Add support for RAW formats. */\n> };\n>\n> constexpr Size RKISP1_RSZ_SP_SRC_MIN{ 32, 16 };\n> constexpr Size RKISP1_RSZ_SP_SRC_MAX{ 1920, 1920 };\n> -constexpr std::array RKISP1_RSZ_SP_FORMATS{\n> +constexpr std::array RKISP1_RSZ_SP_FORMATS{\n> \tformats::YUYV,\n> \tformats::NV16,\n> \tformats::NV61,\n> @@ -231,6 +232,7 @@ constexpr std::array RKISP1_RSZ_SP_FORMATS{\n> \tformats::NV12,\n> \tformats::YUV420,\n> \tformats::YVU420,\n> +\tformats::YUV422,\n> \tformats::R8,\n> \tformats::RGB565,\n> \tformats::XRGB8888,\n> --\n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 29F4EBD1F1\n\tfor ;\n\tTue, 19 Jul 2022 10:05:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 850DE63312;\n\tTue, 19 Jul 2022 12:05:05 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5365860489\n\tfor ;\n\tTue, 19 Jul 2022 12:05:04 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 3FB5F6000D;\n\tTue, 19 Jul 2022 10:05:02 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658225105;\n\tbh=UotJgSY44gfsd/Do+PFN3ZwFsydB22QGzD/BpeNkf6U=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=vcA5QYzh86SkXAFsuUrMY+J5imqUdDfF5khgSc30JXNZ4xg3XMSFiuTWKFAkZyLfk\n\tpEU45Nha/Aziqxi2ntKpf8ITzx7VsAEP5AfUEXSE+Mc2E0gbqtuIOqeDwTC/FiF6iJ\n\tqQA6jVndjFe4TpF3WGO6nK+gyk2S1ZtDJaM2HyMHkR4/FEe9Ty9dM7jx8/VRXqa4ZX\n\tAD2U8rBvPykha+x0WwIo1OXgJFddgnrtWYTVrBM2XrXXHDYe7X61XsMnL/QVNHoyf5\n\t1aPZzs0oPLUV9Q8O2H0pvtL6EIkJ/V2rUfMT7biwc+vYY2cnZcgL1CfF5H3XgRZQEP\n\tpLUzcUDyMcuOg==","Date":"Tue, 19 Jul 2022 12:05:00 +0200","To":"Paul Elder ","Message-ID":"<20220719100500.7welq63giemvmr7l@uno.localdomain>","References":"<20220719074013.846726-1-paul.elder@ideasonboard.com>\n\t<20220719074013.846726-2-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220719074013.846726-2-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] pipeline: rkisp1: Add support\n\tfor YUV422","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23963,"web_url":"https://patchwork.libcamera.org/comment/23963/","msgid":"<20220719112614.GA3984498@pyrite.rasen.tech>","date":"2022-07-19T11:26:14","subject":"Re: [libcamera-devel] [PATCH v2 2/2] pipeline: rkisp1: Add support\n\tfor YUV422","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Jacopo,\n\nOn Tue, Jul 19, 2022 at 12:05:00PM +0200, Jacopo Mondi wrote:\n> Hi Paul,\n> \n> On Tue, Jul 19, 2022 at 04:40:13PM +0900, Paul Elder via libcamera-devel wrote:\n> > YUV422 is already supported as an output format by the rkisp1 driver.\n> > Add them to the pipeline handler to support them in libcamera as well.\n> >\n> > YVU422 is also supported by the driver, but there only exists a\n> > multiplanar V4L2 format, which libcamera is currently unable to map to\n> > from the libcamera YVU422 format. This will be fixed later.\n> \n> That's peculiar!\n> \n> The driver supports (for both the main and self path)\n> \n> V4L2_PIX_FMT_YUV422P,\n> V4L2_PIX_FMT_YVU422M,\n> \n> so the YUV component ordering is supported throught the contiguous planes\n> variant, while the YVU permutation goes through non-contiguous one.\n> \n> Is there a reason ? Is the driver correct I wonder ?\n\nIt's not the driver; it's that YVU422P doesn't exist as a V4L2 format.\n\n\nPaul\n\n> \n> >\n> > Signed-off-by: Paul Elder \n> >\n> > ---\n> > Changes in v2:\n> > - remove YVU422\n> > - reorder formats\n> > ---\n> > src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 6 ++++--\n> > 1 file changed, 4 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> > index c070929d..856554b3 100644\n> > --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> > +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> > @@ -209,7 +209,7 @@ void RkISP1Path::stop()\n> > namespace {\n> > constexpr Size RKISP1_RSZ_MP_SRC_MIN{ 32, 16 };\n> > constexpr Size RKISP1_RSZ_MP_SRC_MAX{ 4416, 3312 };\n> > -constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> > +constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> > \tformats::YUYV,\n> > \tformats::NV16,\n> > \tformats::NV61,\n> > @@ -217,13 +217,14 @@ constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> > \tformats::NV12,\n> > \tformats::YUV420,\n> > \tformats::YVU420,\n> > +\tformats::YUV422,\n> > \tformats::R8,\n> > \t/* \\todo Add support for RAW formats. */\n> > };\n> >\n> > constexpr Size RKISP1_RSZ_SP_SRC_MIN{ 32, 16 };\n> > constexpr Size RKISP1_RSZ_SP_SRC_MAX{ 1920, 1920 };\n> > -constexpr std::array RKISP1_RSZ_SP_FORMATS{\n> > +constexpr std::array RKISP1_RSZ_SP_FORMATS{\n> > \tformats::YUYV,\n> > \tformats::NV16,\n> > \tformats::NV61,\n> > @@ -231,6 +232,7 @@ constexpr std::array RKISP1_RSZ_SP_FORMATS{\n> > \tformats::NV12,\n> > \tformats::YUV420,\n> > \tformats::YVU420,\n> > +\tformats::YUV422,\n> > \tformats::R8,\n> > \tformats::RGB565,\n> > \tformats::XRGB8888,\n> > --\n> > 2.30.2\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E05B5BD1F1\n\tfor ;\n\tTue, 19 Jul 2022 11:26:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 421F563312;\n\tTue, 19 Jul 2022 13:26:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 712F8603F4\n\tfor ;\n\tTue, 19 Jul 2022 13:26:21 +0200 (CEST)","from pyrite.rasen.tech (softbank036240121080.bbtec.net\n\t[36.240.121.80])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EE35B6EE;\n\tTue, 19 Jul 2022 13:26:19 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658229983;\n\tbh=tNC18f5tEKdUQyAtp1b+zoWLHCpFKYU84ht9SiNWITY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Tq49zBpB80FP1Ebk7kUBL+TZWu5Pqv8XzpsprD1IXFH0mt8yoLRGhcDt2FESG0w6V\n\tbw/12kYb9M99H10BY+ib9iC0z/HKT3gNPPQ6GsCPZSkSPmjQSZsCnnqkzS1lPtwJO9\n\tls/g5W+2hEYtt4igvTmSiAU2mOzN+RlncxSCylXRzx/X/qqR1MHFXRIJZF2w83xtJO\n\tbV4UdcDMqlKdjEyn4pOd4hAqHILMoUS1Os031ejq8qsWlweCenj1ctSwS4t4kmlx3e\n\tysd/YYKDNtXDxYSIlXdwsYMG4yTCZeTTgL1i1AvTy1to7Yik4JrRph7PtERvnyScJy\n\tRbsFo2yoCbUIQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658229981;\n\tbh=tNC18f5tEKdUQyAtp1b+zoWLHCpFKYU84ht9SiNWITY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lysv++fde7oV+JEwz/A8byXIEzreiZgPyGWYrD48uFWg1ZNd86J+jAL9A44oODvl3\n\ty32QJaWDtH/g8wsGNwSsdIUdLfyRu8N4KPFkjbT/1Bu9pYt7ghTxVmZLptcvllshl6\n\tI0JE2XPPFFZ/CDqtY6jHTKEvsWp6Lc36vbMA48XU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"lysv++fd\"; dkim-atps=neutral","Date":"Tue, 19 Jul 2022 20:26:14 +0900","To":"Jacopo Mondi ","Message-ID":"<20220719112614.GA3984498@pyrite.rasen.tech>","References":"<20220719074013.846726-1-paul.elder@ideasonboard.com>\n\t<20220719074013.846726-2-paul.elder@ideasonboard.com>\n\t<20220719100500.7welq63giemvmr7l@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220719100500.7welq63giemvmr7l@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] pipeline: rkisp1: Add support\n\tfor YUV422","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23965,"web_url":"https://patchwork.libcamera.org/comment/23965/","msgid":"<20220719124033.25guchzli6rhevbr@uno.localdomain>","date":"2022-07-19T12:40:33","subject":"Re: [libcamera-devel] [PATCH v2 2/2] pipeline: rkisp1: Add support\n\tfor YUV422","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi PAul\n\nOn Tue, Jul 19, 2022 at 08:26:14PM +0900, paul.elder@ideasonboard.com wrote:\n> Hi Jacopo,\n>\n> On Tue, Jul 19, 2022 at 12:05:00PM +0200, Jacopo Mondi wrote:\n> > Hi Paul,\n> >\n> > On Tue, Jul 19, 2022 at 04:40:13PM +0900, Paul Elder via libcamera-devel wrote:\n> > > YUV422 is already supported as an output format by the rkisp1 driver.\n> > > Add them to the pipeline handler to support them in libcamera as well.\n> > >\n> > > YVU422 is also supported by the driver, but there only exists a\n> > > multiplanar V4L2 format, which libcamera is currently unable to map to\n> > > from the libcamera YVU422 format. This will be fixed later.\n> >\n> > That's peculiar!\n> >\n> > The driver supports (for both the main and self path)\n> >\n> > V4L2_PIX_FMT_YUV422P,\n> > V4L2_PIX_FMT_YVU422M,\n> >\n> > so the YUV component ordering is supported throught the contiguous planes\n> > variant, while the YVU permutation goes through non-contiguous one.\n> >\n> > Is there a reason ? Is the driver correct I wonder ?\n>\n> It's not the driver; it's that YVU422P doesn't exist as a V4L2 format.\n>\n\nOk, the real question is then what the HW supports, contiguous or\nnon-contiguous ? The fact the YUV422P varian is used when the YUV422M\nexists makes me thing also YVU422 should be reported through the 'P'\nvariant.\n\nShould the format be added to the videodev2.h header ?\n>\n> Paul\n>\n> >\n> > >\n> > > Signed-off-by: Paul Elder \n> > >\n> > > ---\n> > > Changes in v2:\n> > > - remove YVU422\n> > > - reorder formats\n> > > ---\n> > > src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 6 ++++--\n> > > 1 file changed, 4 insertions(+), 2 deletions(-)\n> > >\n> > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> > > index c070929d..856554b3 100644\n> > > --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> > > +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> > > @@ -209,7 +209,7 @@ void RkISP1Path::stop()\n> > > namespace {\n> > > constexpr Size RKISP1_RSZ_MP_SRC_MIN{ 32, 16 };\n> > > constexpr Size RKISP1_RSZ_MP_SRC_MAX{ 4416, 3312 };\n> > > -constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> > > +constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> > > \tformats::YUYV,\n> > > \tformats::NV16,\n> > > \tformats::NV61,\n> > > @@ -217,13 +217,14 @@ constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> > > \tformats::NV12,\n> > > \tformats::YUV420,\n> > > \tformats::YVU420,\n> > > +\tformats::YUV422,\n> > > \tformats::R8,\n> > > \t/* \\todo Add support for RAW formats. */\n> > > };\n> > >\n> > > constexpr Size RKISP1_RSZ_SP_SRC_MIN{ 32, 16 };\n> > > constexpr Size RKISP1_RSZ_SP_SRC_MAX{ 1920, 1920 };\n> > > -constexpr std::array RKISP1_RSZ_SP_FORMATS{\n> > > +constexpr std::array RKISP1_RSZ_SP_FORMATS{\n> > > \tformats::YUYV,\n> > > \tformats::NV16,\n> > > \tformats::NV61,\n> > > @@ -231,6 +232,7 @@ constexpr std::array RKISP1_RSZ_SP_FORMATS{\n> > > \tformats::NV12,\n> > > \tformats::YUV420,\n> > > \tformats::YVU420,\n> > > +\tformats::YUV422,\n> > > \tformats::R8,\n> > > \tformats::RGB565,\n> > > \tformats::XRGB8888,\n> > > --\n> > > 2.30.2\n> > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 43DADBE173\n\tfor ;\n\tTue, 19 Jul 2022 12:40:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ADDBF63312;\n\tTue, 19 Jul 2022 14:40:36 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C8623603F4\n\tfor ;\n\tTue, 19 Jul 2022 14:40:35 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 528A624000B;\n\tTue, 19 Jul 2022 12:40:35 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658234436;\n\tbh=9sAKuYaOMOXj0FwnPK1eykJspanzxy0CbqGrKfx7FnA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=CbyrFiDA6hD4FQVVjc0ysiLKG1icl+yLCktwMGE0OY9gZl67w5CEN4K1J7wKyK+oe\n\t3JWFDUDeOcw0POpHoQZV5irEuSG8DCETrVfS76rBWoLEDxjzyMLWLJnyIvHSzInp9W\n\tE4QLy4aNHldj0AfSXeovEsmW16mLyo+/8H+TD06IoAkYZufTJI8q/q+glHtPlS4g02\n\tVmVlIXHfALPXdPXHHAgM6LQJuxGoAJ6pQmFwQHWGtxL8RhMolivcCR4trG5ZHWhmr7\n\tb5RqLqHYC5wJlBdQLJ3MjZ40QBTV8l8s+o9PHTZjTF5Xji5Kfw+PQwW9Ctj1qdNeAh\n\tNS0fHhbD5rzzw==","Date":"Tue, 19 Jul 2022 14:40:33 +0200","To":"paul.elder@ideasonboard.com","Message-ID":"<20220719124033.25guchzli6rhevbr@uno.localdomain>","References":"<20220719074013.846726-1-paul.elder@ideasonboard.com>\n\t<20220719074013.846726-2-paul.elder@ideasonboard.com>\n\t<20220719100500.7welq63giemvmr7l@uno.localdomain>\n\t<20220719112614.GA3984498@pyrite.rasen.tech>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220719112614.GA3984498@pyrite.rasen.tech>","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] pipeline: rkisp1: Add support\n\tfor YUV422","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23966,"web_url":"https://patchwork.libcamera.org/comment/23966/","msgid":"<20220719131929.GB3984498@pyrite.rasen.tech>","date":"2022-07-19T13:19:29","subject":"Re: [libcamera-devel] [PATCH v2 2/2] pipeline: rkisp1: Add support\n\tfor YUV422","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Jacopo,\n\nOn Tue, Jul 19, 2022 at 02:40:33PM +0200, Jacopo Mondi wrote:\n> Hi PAul\n> \n> On Tue, Jul 19, 2022 at 08:26:14PM +0900, paul.elder@ideasonboard.com wrote:\n> > Hi Jacopo,\n> >\n> > On Tue, Jul 19, 2022 at 12:05:00PM +0200, Jacopo Mondi wrote:\n> > > Hi Paul,\n> > >\n> > > On Tue, Jul 19, 2022 at 04:40:13PM +0900, Paul Elder via libcamera-devel wrote:\n> > > > YUV422 is already supported as an output format by the rkisp1 driver.\n> > > > Add them to the pipeline handler to support them in libcamera as well.\n> > > >\n> > > > YVU422 is also supported by the driver, but there only exists a\n> > > > multiplanar V4L2 format, which libcamera is currently unable to map to\n> > > > from the libcamera YVU422 format. This will be fixed later.\n> > >\n> > > That's peculiar!\n> > >\n> > > The driver supports (for both the main and self path)\n> > >\n> > > V4L2_PIX_FMT_YUV422P,\n> > > V4L2_PIX_FMT_YVU422M,\n> > >\n> > > so the YUV component ordering is supported throught the contiguous planes\n> > > variant, while the YVU permutation goes through non-contiguous one.\n> > >\n> > > Is there a reason ? Is the driver correct I wonder ?\n> >\n> > It's not the driver; it's that YVU422P doesn't exist as a V4L2 format.\n> >\n> \n> Ok, the real question is then what the HW supports, contiguous or\n> non-contiguous ? The fact the YUV422P varian is used when the YUV422M\n\nBoth.\n\n> exists makes me thing also YVU422 should be reported through the 'P'\n> variant.\n> \n> Should the format be added to the videodev2.h header ?\n\nMaybe? The i.MX3x IPU dma and some Marvell display controllers define\ntheir own YVU422P formats. But also not many drivers seem to support\nYVU422M anyway? Although maybe that doesn't mean much, since YUV422M\nisn't very popular even though YUV422P is.\n\n\nPaul\n\n> >\n> > Paul\n> >\n> > >\n> > > >\n> > > > Signed-off-by: Paul Elder \n> > > >\n> > > > ---\n> > > > Changes in v2:\n> > > > - remove YVU422\n> > > > - reorder formats\n> > > > ---\n> > > > src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 6 ++++--\n> > > > 1 file changed, 4 insertions(+), 2 deletions(-)\n> > > >\n> > > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> > > > index c070929d..856554b3 100644\n> > > > --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> > > > +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> > > > @@ -209,7 +209,7 @@ void RkISP1Path::stop()\n> > > > namespace {\n> > > > constexpr Size RKISP1_RSZ_MP_SRC_MIN{ 32, 16 };\n> > > > constexpr Size RKISP1_RSZ_MP_SRC_MAX{ 4416, 3312 };\n> > > > -constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> > > > +constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> > > > \tformats::YUYV,\n> > > > \tformats::NV16,\n> > > > \tformats::NV61,\n> > > > @@ -217,13 +217,14 @@ constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> > > > \tformats::NV12,\n> > > > \tformats::YUV420,\n> > > > \tformats::YVU420,\n> > > > +\tformats::YUV422,\n> > > > \tformats::R8,\n> > > > \t/* \\todo Add support for RAW formats. */\n> > > > };\n> > > >\n> > > > constexpr Size RKISP1_RSZ_SP_SRC_MIN{ 32, 16 };\n> > > > constexpr Size RKISP1_RSZ_SP_SRC_MAX{ 1920, 1920 };\n> > > > -constexpr std::array RKISP1_RSZ_SP_FORMATS{\n> > > > +constexpr std::array RKISP1_RSZ_SP_FORMATS{\n> > > > \tformats::YUYV,\n> > > > \tformats::NV16,\n> > > > \tformats::NV61,\n> > > > @@ -231,6 +232,7 @@ constexpr std::array RKISP1_RSZ_SP_FORMATS{\n> > > > \tformats::NV12,\n> > > > \tformats::YUV420,\n> > > > \tformats::YVU420,\n> > > > +\tformats::YUV422,\n> > > > \tformats::R8,\n> > > > \tformats::RGB565,\n> > > > \tformats::XRGB8888,\n> > > > --\n> > > > 2.30.2\n> > > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A1361BE173\n\tfor ;\n\tTue, 19 Jul 2022 13:19:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ED9AD63312;\n\tTue, 19 Jul 2022 15:19:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 33AA5603F4\n\tfor ;\n\tTue, 19 Jul 2022 15:19:37 +0200 (CEST)","from pyrite.rasen.tech (softbank036240121080.bbtec.net\n\t[36.240.121.80])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9E7596EE;\n\tTue, 19 Jul 2022 15:19:35 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658236779;\n\tbh=e5KP9Dqy4/zTryi5Xy0gGeaSMBz5KqDZjR0mGJTfV2E=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=c5GGzkrzxnlaIZAYC3hkTUNMI46nmPFyPizsmNR4Y6dIQwQ274xx7SBiSviBanNjl\n\ttblLgvvsWOyuDGB2SDIMEIia/8EH1Pn5eZcf+ZMXdnl2EH7QuVTQzdUQWE10fXmItO\n\tlMAwB+jDgqQXMDTpxKobtmQV4q9EEXBPKUj7TofFwkoehenqg5HbzhnnpCDwjLJCI7\n\t3/Tm+19LdnJ5vmQMuI3pAE7ddVX0IzqfSzliOqrcwUmdXVsBNJ8KNpC7M6QZOwneUT\n\tcykbj5kJlaxy0zTD7NFcFyDhSGvmjbCNkgIJkmQLAuEHmaqfqp+VnSNgS7w+a5rjEk\n\tyyVWm4rRKvfWQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658236776;\n\tbh=e5KP9Dqy4/zTryi5Xy0gGeaSMBz5KqDZjR0mGJTfV2E=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VGx7pc27iEdF0jc2hPE5W5pElKNkt6sLnqh000r8w86FfmwtEKrSoCWsi96OOg8Id\n\tyK57E08Rk543OtbhmlStM2XQbZd13L07DDK7xbt5cH6VqDUepxTUyrk4ztz78/ldY2\n\tQK2udwzGPmmS/K1S2DGnq5RoAFq6M2DYD71nwQMc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VGx7pc27\"; dkim-atps=neutral","Date":"Tue, 19 Jul 2022 22:19:29 +0900","To":"Jacopo Mondi ","Message-ID":"<20220719131929.GB3984498@pyrite.rasen.tech>","References":"<20220719074013.846726-1-paul.elder@ideasonboard.com>\n\t<20220719074013.846726-2-paul.elder@ideasonboard.com>\n\t<20220719100500.7welq63giemvmr7l@uno.localdomain>\n\t<20220719112614.GA3984498@pyrite.rasen.tech>\n\t<20220719124033.25guchzli6rhevbr@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220719124033.25guchzli6rhevbr@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] pipeline: rkisp1: Add support\n\tfor YUV422","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23979,"web_url":"https://patchwork.libcamera.org/comment/23979/","msgid":"","date":"2022-07-19T22:41:20","subject":"Re: [libcamera-devel] [PATCH v2 2/2] pipeline: rkisp1: Add support\n\tfor YUV422","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi,\n\nOn Tue, Jul 19, 2022 at 10:19:29PM +0900, Paul Elder via libcamera-devel wrote:\n> On Tue, Jul 19, 2022 at 02:40:33PM +0200, Jacopo Mondi wrote:\n> > On Tue, Jul 19, 2022 at 08:26:14PM +0900, paul.elder@ideasonboard.com wrote:\n> > > On Tue, Jul 19, 2022 at 12:05:00PM +0200, Jacopo Mondi wrote:\n> > > > On Tue, Jul 19, 2022 at 04:40:13PM +0900, Paul Elder via libcamera-devel wrote:\n> > > > > YUV422 is already supported as an output format by the rkisp1 driver.\n> > > > > Add them to the pipeline handler to support them in libcamera as well.\n> > > > >\n> > > > > YVU422 is also supported by the driver, but there only exists a\n> > > > > multiplanar V4L2 format, which libcamera is currently unable to map to\n> > > > > from the libcamera YVU422 format. This will be fixed later.\n\nWhy is that ?\n\n> > > > That's peculiar!\n> > > >\n> > > > The driver supports (for both the main and self path)\n> > > >\n> > > > V4L2_PIX_FMT_YUV422P,\n> > > > V4L2_PIX_FMT_YVU422M,\n> > > >\n> > > > so the YUV component ordering is supported throught the contiguous planes\n> > > > variant, while the YVU permutation goes through non-contiguous one.\n> > > >\n> > > > Is there a reason ? Is the driver correct I wonder ?\n> > >\n> > > It's not the driver; it's that YVU422P doesn't exist as a V4L2 format.\n> > \n> > Ok, the real question is then what the HW supports, contiguous or\n> > non-contiguous ? The fact the YUV422P varian is used when the YUV422M\n> \n> Both.\n> \n> > exists makes me thing also YVU422 should be reported through the 'P'\n> > variant.\n> > \n> > Should the format be added to the videodev2.h header ?\n> \n> Maybe? The i.MX3x IPU dma and some Marvell display controllers define\n> their own YVU422P formats. But also not many drivers seem to support\n> YVU422M anyway? Although maybe that doesn't mean much, since YUV422M\n> isn't very popular even though YUV422P is.\n\nWe could extend V4L2 with missing contiguous planar formats indeed, but\nI'd rather see this contiguous/non-contiguous separation go away in\nV4L2. Unless there's a strong need for V4L2_PIX_FMT_YVU422P, I'd leave\nit out for now.\n\n> > > > > Signed-off-by: Paul Elder \n> > > > >\n> > > > > ---\n> > > > > Changes in v2:\n> > > > > - remove YVU422\n> > > > > - reorder formats\n> > > > > ---\n> > > > > src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 6 ++++--\n> > > > > 1 file changed, 4 insertions(+), 2 deletions(-)\n> > > > >\n> > > > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> > > > > index c070929d..856554b3 100644\n> > > > > --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> > > > > +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> > > > > @@ -209,7 +209,7 @@ void RkISP1Path::stop()\n> > > > > namespace {\n> > > > > constexpr Size RKISP1_RSZ_MP_SRC_MIN{ 32, 16 };\n> > > > > constexpr Size RKISP1_RSZ_MP_SRC_MAX{ 4416, 3312 };\n> > > > > -constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> > > > > +constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> > > > > \tformats::YUYV,\n> > > > > \tformats::NV16,\n> > > > > \tformats::NV61,\n> > > > > @@ -217,13 +217,14 @@ constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> > > > > \tformats::NV12,\n> > > > > \tformats::YUV420,\n> > > > > \tformats::YVU420,\n> > > > > +\tformats::YUV422,\n> > > > > \tformats::R8,\n> > > > > \t/* \\todo Add support for RAW formats. */\n> > > > > };\n> > > > >\n> > > > > constexpr Size RKISP1_RSZ_SP_SRC_MIN{ 32, 16 };\n> > > > > constexpr Size RKISP1_RSZ_SP_SRC_MAX{ 1920, 1920 };\n> > > > > -constexpr std::array RKISP1_RSZ_SP_FORMATS{\n> > > > > +constexpr std::array RKISP1_RSZ_SP_FORMATS{\n> > > > > \tformats::YUYV,\n> > > > > \tformats::NV16,\n> > > > > \tformats::NV61,\n> > > > > @@ -231,6 +232,7 @@ constexpr std::array RKISP1_RSZ_SP_FORMATS{\n> > > > > \tformats::NV12,\n> > > > > \tformats::YUV420,\n> > > > > \tformats::YVU420,\n> > > > > +\tformats::YUV422,\n> > > > > \tformats::R8,\n> > > > > \tformats::RGB565,\n> > > > > \tformats::XRGB8888,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6560FBD1F1\n\tfor ;\n\tTue, 19 Jul 2022 22:41:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DA04263312;\n\tWed, 20 Jul 2022 00:41:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F458603F1\n\tfor ;\n\tWed, 20 Jul 2022 00:41:54 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 880E36DB;\n\tWed, 20 Jul 2022 00:41:53 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658270515;\n\tbh=Slaw0dPAMwTCofkblqALm3SX9Rait3eKD2i22jymud8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=hj3RJy6Dbx9S/gNMkhQixTWPn6sNicXTxwpabDZ6CGksxeECGVzIcReHtj303TcGW\n\tUBbZ9/T97ZPwqH/MuJRcifmClXk6wdMHNBxN39XRh8xBWx4lU1BauEfY71aJunSLoD\n\tFH1vI2snkfOCQQr1zKpz4eR2isD1I8BReVwn14b7xndUrhpBnj9j6hf5vgwRwdgH95\n\tevWqezxP1KDUJPNCgoS3HGQ1xRCn7vetHUsmqMhCM7VUWSwNfLzthxFDymiY/Hhq1p\n\tpZ0IzgZeYjO6YM1Qta83b9rW5Ri6sa/FiBm9E5KAHfygzJ1spbiwRU4QrSAoiO/2os\n\tv5YpH5PrdPL3A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658270513;\n\tbh=Slaw0dPAMwTCofkblqALm3SX9Rait3eKD2i22jymud8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=M5wTJXeRGX8m8KhhSHG+Bo7rlWvQ/y+RsveTEkP+hzAJXgt7nOVd8yLezBdsw3R6F\n\tPWzVtznu/ekoeNt2xvdMf53M2ZIH5vMxEna8r0cXEvK1gM03cZAn3or+fzcIsbx27X\n\tMZOPfYTMfdwuzptI58fS7pdGwKmKAIMSwzFzU8gc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"M5wTJXeR\"; dkim-atps=neutral","Date":"Wed, 20 Jul 2022 01:41:20 +0300","To":"paul.elder@ideasonboard.com","Message-ID":"","References":"<20220719074013.846726-1-paul.elder@ideasonboard.com>\n\t<20220719074013.846726-2-paul.elder@ideasonboard.com>\n\t<20220719100500.7welq63giemvmr7l@uno.localdomain>\n\t<20220719112614.GA3984498@pyrite.rasen.tech>\n\t<20220719124033.25guchzli6rhevbr@uno.localdomain>\n\t<20220719131929.GB3984498@pyrite.rasen.tech>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220719131929.GB3984498@pyrite.rasen.tech>","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] pipeline: rkisp1: Add support\n\tfor YUV422","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]