[{"id":23961,"web_url":"https://patchwork.libcamera.org/comment/23961/","msgid":"<20220719100156.6lhsnt7rdv7uimgd@uno.localdomain>","date":"2022-07-19T10:01:56","subject":"Re: [libcamera-devel] [PATCH v2 1/2] pipeline: rkisp1: Add output\n\tsupport for YUV420 and YVU420","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Tue, Jul 19, 2022 at 04:40:12PM +0900, Paul Elder via libcamera-devel wrote:\n> YUV420 and YVU420 are already supported as output formats by the rkisp1\n> driver. Add them to the pipeline handler to support them in libcamera as\n> well.\n>\n> Signed-off-by: Paul Elder \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> ---\n> Changes in v2:\n> - move to after NV formats\n> - add to self path too\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 10 ++++++++--\n> 1 file changed, 8 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> index 6f175758..c070929d 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> @@ -130,6 +130,8 @@ int RkISP1Path::configure(const StreamConfiguration &config,\n> \tswitch (config.pixelFormat) {\n> \tcase formats::NV12:\n> \tcase formats::NV21:\n> +\tcase formats::YUV420:\n> +\tcase formats::YVU420:\n> \t\tispFormat.mbus_code = MEDIA_BUS_FMT_YUYV8_1_5X8;\n> \t\tbreak;\n> \tdefault:\n> @@ -207,24 +209,28 @@ void RkISP1Path::stop()\n> namespace {\n> constexpr Size RKISP1_RSZ_MP_SRC_MIN{ 32, 16 };\n> constexpr Size RKISP1_RSZ_MP_SRC_MAX{ 4416, 3312 };\n> -constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> +constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> \tformats::YUYV,\n> \tformats::NV16,\n> \tformats::NV61,\n> \tformats::NV21,\n> \tformats::NV12,\n> +\tformats::YUV420,\n> +\tformats::YVU420,\n> \tformats::R8,\n> \t/* \\todo Add support for RAW formats. */\n> };\n>\n> constexpr Size RKISP1_RSZ_SP_SRC_MIN{ 32, 16 };\n> constexpr Size RKISP1_RSZ_SP_SRC_MAX{ 1920, 1920 };\n> -constexpr std::array RKISP1_RSZ_SP_FORMATS{\n> +constexpr std::array RKISP1_RSZ_SP_FORMATS{\n> \tformats::YUYV,\n> \tformats::NV16,\n> \tformats::NV61,\n> \tformats::NV21,\n> \tformats::NV12,\n> +\tformats::YUV420,\n> +\tformats::YVU420,\n> \tformats::R8,\n> \tformats::RGB565,\n> \tformats::XRGB8888,\n> --\n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 50E90BD1F1\n\tfor ;\n\tTue, 19 Jul 2022 10:01:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C967463312;\n\tTue, 19 Jul 2022 12:01:58 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 41FBF60489\n\tfor ;\n\tTue, 19 Jul 2022 12:01:58 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id B83C0240006;\n\tTue, 19 Jul 2022 10:01:57 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658224918;\n\tbh=ziek34KrPWN72FTn54/EBC2ObVXy4dwZa28QB8beGoM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=2m6zz8qZ0rvHYAfbvVVYUrJvkvxeFyvz+Bk7LZ3/XLCkt8abFsJCmFTv2qoQobmsE\n\tagBPdXeTTNH+gO50wiY3ArpXAdZvkiYc8UhZxSeGp0qb05IXX9APG9IcqVlVKRvqB7\n\tQwco6VlqYCfv1T7ZenYdCVH42FP7jR6lumnnknpTFVd6daYqOzrJLIAm9uAEoA2qzK\n\toPSukz9aQBHMJ9Nr30kKvYPngSLzcb+7UZraL9tsCIwu/f6A1+5RwjGkVHUfjeATMQ\n\tAobBQoGNQnBQoQzpxzp7yEXFYYuoqpxs1d36ne4RAKejHdgjhVGEe9FU8+y8CV0pho\n\tmVHzV02DZgdTQ==","Date":"Tue, 19 Jul 2022 12:01:56 +0200","To":"Paul Elder ","Message-ID":"<20220719100156.6lhsnt7rdv7uimgd@uno.localdomain>","References":"<20220719074013.846726-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220719074013.846726-1-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/2] pipeline: rkisp1: Add output\n\tsupport for YUV420 and YVU420","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23978,"web_url":"https://patchwork.libcamera.org/comment/23978/","msgid":"","date":"2022-07-19T22:36:20","subject":"Re: [libcamera-devel] [PATCH v2 1/2] pipeline: rkisp1: Add output\n\tsupport for YUV420 and YVU420","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Tue, Jul 19, 2022 at 04:40:12PM +0900, Paul Elder via libcamera-devel wrote:\n> YUV420 and YVU420 are already supported as output formats by the rkisp1\n> driver. Add them to the pipeline handler to support them in libcamera as\n> well.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> Changes in v2:\n> - move to after NV formats\n> - add to self path too\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 10 ++++++++--\n> 1 file changed, 8 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> index 6f175758..c070929d 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> @@ -130,6 +130,8 @@ int RkISP1Path::configure(const StreamConfiguration &config,\n> \tswitch (config.pixelFormat) {\n> \tcase formats::NV12:\n> \tcase formats::NV21:\n> +\tcase formats::YUV420:\n> +\tcase formats::YVU420:\n> \t\tispFormat.mbus_code = MEDIA_BUS_FMT_YUYV8_1_5X8;\n> \t\tbreak;\n> \tdefault:\n> @@ -207,24 +209,28 @@ void RkISP1Path::stop()\n> namespace {\n> constexpr Size RKISP1_RSZ_MP_SRC_MIN{ 32, 16 };\n> constexpr Size RKISP1_RSZ_MP_SRC_MAX{ 4416, 3312 };\n> -constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> +constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> \tformats::YUYV,\n> \tformats::NV16,\n> \tformats::NV61,\n> \tformats::NV21,\n> \tformats::NV12,\n> +\tformats::YUV420,\n> +\tformats::YVU420,\n> \tformats::R8,\n> \t/* \\todo Add support for RAW formats. */\n> };\n> \n> constexpr Size RKISP1_RSZ_SP_SRC_MIN{ 32, 16 };\n> constexpr Size RKISP1_RSZ_SP_SRC_MAX{ 1920, 1920 };\n> -constexpr std::array RKISP1_RSZ_SP_FORMATS{\n> +constexpr std::array RKISP1_RSZ_SP_FORMATS{\n> \tformats::YUYV,\n> \tformats::NV16,\n> \tformats::NV61,\n> \tformats::NV21,\n> \tformats::NV12,\n> +\tformats::YUV420,\n> +\tformats::YVU420,\n> \tformats::R8,\n> \tformats::RGB565,\n> \tformats::XRGB8888,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 614B4BE173\n\tfor ;\n\tTue, 19 Jul 2022 22:36:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A162563312;\n\tWed, 20 Jul 2022 00:36:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 595A16048A\n\tfor ;\n\tWed, 20 Jul 2022 00:36:54 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D02376DB;\n\tWed, 20 Jul 2022 00:36:53 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658270215;\n\tbh=rWAy3S49uCzwlnEMVVm3kzy8jnyNV6d9ZGtRyvpDWbk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=bxvTB/am/T8oXek6KjXlp4tg9NyPlo1w4qGvCmnZu+qE65h7h4IHDgnhrEIQS/9F0\n\tmAQZo6lzsQNYLTZleoWTUZ8ioH3CsvXVbBx0zK6nQ3MIZbGKK5L2qKW0f4aSfUvM6l\n\tFOt4ZTjcR12CJ4cXorhGvPtUmcrO6+liDA+/Ag6Z0MNUaePVChVL0+CwuePJnVru3E\n\tofABb109CC6QUGgaGjoDh5QDOeSj+t7kbcAdzc7clyxroLeDKnUuvh/9THHnXbXf2g\n\tSWyCVKXRI02YJrrRKJZzHUBdRKaaPcHXZdPAfsTz5iyGHv/49Ju3xBg+Khy2m7YcaT\n\t4okN4IWhw7xdQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658270214;\n\tbh=rWAy3S49uCzwlnEMVVm3kzy8jnyNV6d9ZGtRyvpDWbk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Cl1zKdCis9T7PLRsHeAgqUOhXCkdNJFZLSdHJt8u5RPj83i3tqj5CkW+xmByZXoRj\n\tx3RAxD/P8B/22T6uxzKf5ZT7IdEf5s4Bcm4kCgjIuw28MUeKe1bmK9kWH15xZSi4ue\n\toZkLWBcWImfbTItqL0DmjMnmdY7rk3cRu3hmpqBA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Cl1zKdCi\"; dkim-atps=neutral","Date":"Wed, 20 Jul 2022 01:36:20 +0300","To":"Paul Elder ","Message-ID":"","References":"<20220719074013.846726-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220719074013.846726-1-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/2] pipeline: rkisp1: Add output\n\tsupport for YUV420 and YVU420","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]