[{"id":24071,"web_url":"https://patchwork.libcamera.org/comment/24071/","msgid":"<YtwmA3WSZfttCanO@pendragon.ideasonboard.com>","date":"2022-07-23T16:46:59","subject":"Re: [libcamera-devel] [PATCH v6 8/8] ipa: raspberrypi: Convert\n\texisting cameara tuning files to version 2.0","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nOn Mon, Jul 18, 2022 at 09:16:02AM +0100, Naushir Patuck via libcamera-devel wrote:\n> Use the convert_tuning.py script to convert all existing tuning files to\n> version 2.0.\n> \n> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>\n\nI've run the script locally and the result is identical to this patch,\nso\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/ipa/raspberrypi/data/imx219.json       | 824 ++++++++++---------\n>  src/ipa/raspberrypi/data/imx219_noir.json  | 686 ++++++++--------\n>  src/ipa/raspberrypi/data/imx290.json       | 322 ++++----\n>  src/ipa/raspberrypi/data/imx296.json       | 369 +++++----\n>  src/ipa/raspberrypi/data/imx378.json       | 677 +++++++++-------\n>  src/ipa/raspberrypi/data/imx477.json       | 881 ++++++++++++---------\n>  src/ipa/raspberrypi/data/imx477_noir.json  | 734 +++++++++--------\n>  src/ipa/raspberrypi/data/imx519.json       | 677 +++++++++-------\n>  src/ipa/raspberrypi/data/ov5647.json       | 824 ++++++++++---------\n>  src/ipa/raspberrypi/data/ov5647_noir.json  | 686 ++++++++--------\n>  src/ipa/raspberrypi/data/ov9281.json       | 195 +++--\n>  src/ipa/raspberrypi/data/se327m12.json     | 683 +++++++++-------\n>  src/ipa/raspberrypi/data/uncalibrated.json | 180 +++--\n>  13 files changed, 4269 insertions(+), 3469 deletions(-)","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C88FEBE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 23 Jul 2022 16:47:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4102963312;\n\tSat, 23 Jul 2022 18:47:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 76796603F8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 23 Jul 2022 18:47:03 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E3D959F7;\n\tSat, 23 Jul 2022 18:47:02 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658594824;\n\tbh=9uNiiHnjpgNNcwlf7eRB2yxd2hfBxbXx3BeuV/30S2I=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Rw3rFGl+w/asbCN4NH7w+gfPmBpZbifesnLcgJhVxMx3ZuVXT8fkJEKsHVk0Ez/g4\n\t602TEmA0/uDEUaZo1mb16/hswJmiKvmrf2mInxiby4zzmbV7JwiabNhVCySxOBNlwD\n\tl0wmiHp6eKKVJEdgzjwvu3a5DYQcrhqSSTTZuTE7jz9zaXTunIdl3fTH5caBjgpm9n\n\tVMaiVJ9ov2gZWxUS33GX8ywjkuF2Lw6JYffDFbc/t68aC3aEZGPnI99ojkKOHyVqUQ\n\tfxnfa5TGyqEmy1DKYnhIEHRi7l2txxZhuZ/EiOQOG0KPhTQ5dR8z+bWUK+wmdqGxBb\n\tVLCnt/3H+OEYQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658594823;\n\tbh=9uNiiHnjpgNNcwlf7eRB2yxd2hfBxbXx3BeuV/30S2I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BmNNIdRHtKP59imeT2/mgjPvjiUpPnz8A6RrxO7ETHKQgHzVRX6mJ+lragzB1ElHL\n\t1OU9lxRl0o9L5qEh7eqhd+KXdeEZFKxFkCxQir0SZ8iamDgGYEeoGgdGdn8RXVaVeq\n\tOvJFIiZZ0NVzs6DFCuRXt0WAmFiwT3Yp+FETBAjE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"BmNNIdRH\"; dkim-atps=neutral","Date":"Sat, 23 Jul 2022 19:46:59 +0300","To":"Naushir Patuck <naush@raspberrypi.com>","Message-ID":"<YtwmA3WSZfttCanO@pendragon.ideasonboard.com>","References":"<20220718081602.32535-1-naush@raspberrypi.com>\n\t<20220718081602.32535-9-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220718081602.32535-9-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v6 8/8] ipa: raspberrypi: Convert\n\texisting cameara tuning files to version 2.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]