{"id":16664,"url":"https://patchwork.libcamera.org/api/patches/16664/?format=json","web_url":"https://patchwork.libcamera.org/patch/16664/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220715191400.890976-10-utkarsh02t@gmail.com>","date":"2022-07-15T19:13:58","name":"[libcamera-devel,09/11] qcam: ControlFrame: Add GUI interaction to float controls","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"7707d62053b7783dababaf0439c5e7db025f11c8","submitter":{"id":114,"url":"https://patchwork.libcamera.org/api/people/114/?format=json","name":"Utkarsh Tiwari","email":"utkarsh02t@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16664/mbox/","series":[{"id":3292,"url":"https://patchwork.libcamera.org/api/series/3292/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3292","date":"2022-07-15T19:13:49","name":"Introduce control interaction to qcam","version":1,"mbox":"https://patchwork.libcamera.org/series/3292/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16664/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16664/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8780BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 15 Jul 2022 19:14:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9C8916332B;\n\tFri, 15 Jul 2022 21:14:25 +0200 (CEST)","from mail-pf1-x430.google.com (mail-pf1-x430.google.com\n\t[IPv6:2607:f8b0:4864:20::430])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2C9FE6331B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Jul 2022 21:14:22 +0200 (CEST)","by mail-pf1-x430.google.com with SMTP id 70so5436131pfx.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Jul 2022 12:14:22 -0700 (PDT)","from localhost.localdomain\n\t([2406:3003:2005:1c27:d8e8:f9ac:919c:9ac8])\n\tby smtp.gmail.com with ESMTPSA id\n\ts10-20020a170903214a00b0016be834d544sm3834315ple.237.2022.07.15.12.14.19\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 15 Jul 2022 12:14:20 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657912465;\n\tbh=1q3u56hzWWbSwzLVMLWAJHRVN22HxqG+RQBjzFsnxCU=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=WU5Qvzxd7NRMzVwZ7GnXfGiDxhtRlcEzGMe58bH23LDEv3N5fdGh7iGP/JMExMtcL\n\t+pSiSirr787nLgyr1ItURLuE66GCwUo0UN48Y5L2pDaTyDQ1qthDpauXc8gBqaq1IG\n\tcUsVBlvycGkvZ1o+sP2KKvskqTE326sy9UW+/hrFPpQ2s/2ngXcsHS38K4C6jaW0o4\n\tFPebRCDOoEy1IRQORBUZ/XepieuEDwQuRy9NMvatnWcKFhRMga8z/sVXvNHxsIO7La\n\tWBGGvcPaQUzR3NQqjImqPYk5kLtOqUAsFMJS1kU5nYnCIWQLZuqCU5trvtpwMh2z24\n\tpKeGp79NLXMxw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=FrnYJ61KYCQkWm5zhCQpwLqUo0i4PHJOlAfzOLINGFw=;\n\tb=b8ghlYVUBtkRBhMe9Xq0OZzXKzhKXD8W3X28i5Bq1vQcZvPJ0WfvKfjteI6veLDter\n\tKQsO3yj9NqpP9H3OD9N022Tm3fALJl5BkXPV/oXm3+4f4scYZHl7xQV9+wHmUUvZl3Gd\n\tI1+ambmQK8bJYX7WiM5AWnP3mAs3ms61z9Z8MqCR+6CR6DS28uE4ovtMgJESVKT8Bw5k\n\tfF3w8MHtFXl3caSyQMG/c9Hd+h8EfR+igbmuw04nuD9By9KXE3ArsWXK/4IP3eQe6lo9\n\tJ2/EmiwzFP1rWaArk6tGXCUYKmq18gghgNlSHJyjRwsx8E+8KWcouU4U+KRX+HUzHt/n\n\tEsgQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"b8ghlYVU\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=FrnYJ61KYCQkWm5zhCQpwLqUo0i4PHJOlAfzOLINGFw=;\n\tb=aF5+LEjjowhdbvWJoKlt069DdgnIhGEquK2C57zmUrIhAdwRAZ3H4AOfjCLaM7In2y\n\tWIdTekGtRgltHCX19qOqglVlGI0zQH0llqRfSeBFfto9mVh4Vz2AttUZoItachrZkKHr\n\t3bBC6XxjYXOtctLgUNqQzUztliRAdh0SsRrS+aOooJO8o4EipPW9l3sUfGK5BIFiPH4S\n\to3DT/WA2gRcfarJdr877XQSLYD06YA69I/4oq72fZf1GcuKCq8j/b1vrc5pV9bVVFizM\n\tvw5e+XJrjsBUbxJnBsbXBMhZ0lk3Re4xYQv/yQzeE0+EuSYlZyuwmCE1zixf/LVB1Bc4\n\tfSPQ==","X-Gm-Message-State":"AJIora/2dxhkDD++DIYorGapsSzNcvyoJ4RRQpzLLmK+FgAxj2HD3rda\n\tEcWssBQUPzRPiZ/sD7wuQ931B3ngCVMrNA==","X-Google-Smtp-Source":"AGRyM1tOFJB5LWAbT6/4Q8igDL66WfnffA02pKcylmLocU9JLKgXO0/Pjcx7MpDyu+PAPKQyXcbq+A==","X-Received":"by 2002:a05:6a00:bc5:b0:52b:49c9:d26c with SMTP id\n\tx5-20020a056a000bc500b0052b49c9d26cmr1139935pfu.73.1657912460498; \n\tFri, 15 Jul 2022 12:14:20 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 16 Jul 2022 03:13:58 +0800","Message-Id":"<20220715191400.890976-10-utkarsh02t@gmail.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20220715191400.890976-1-utkarsh02t@gmail.com>","References":"<20220715191400.890976-1-utkarsh02t@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 09/11] qcam: ControlFrame: Add GUI\n\tinteraction to float controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Utkarsh Tiwari via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Utkarsh Tiwari <utkarsh02t@gmail.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Add the float slider for the float controls to be able to control its\nvalue. Also display the current values for the float controls.\n\nSigned-off-by: Utkarsh Tiwari <utkarsh02t@gmail.com>\n---\n src/qcam/settings/control_frame.cpp | 21 +++++++++++++++++++++\n src/qcam/settings/control_frame.h   |  3 +++\n 2 files changed, 24 insertions(+)","diff":"diff --git a/src/qcam/settings/control_frame.cpp b/src/qcam/settings/control_frame.cpp\nindex 3ab9fdb4..10dcd05a 100644\n--- a/src/qcam/settings/control_frame.cpp\n+++ b/src/qcam/settings/control_frame.cpp\n@@ -16,6 +16,8 @@\n #include <QString>\n #include <QVBoxLayout>\n \n+#include \"slider.h\"\n+\n using namespace libcamera;\n \n ControlFrame::ControlFrame(const libcamera::ControlId *control,\n@@ -79,6 +81,19 @@ QWidget *ControlFrame::controlInteraction(QWidget *parent)\n \t\tHCheckBoxLayout->setMargin(0);\n \t\treturn containerWidget;\n \t}\n+\tcase ControlTypeFloat: {\n+\t\tfloatSlider_ = new FloatSlider;\n+\t\tfloatSlider_->setRange(controlInfo_.min().get<float>(),\n+\t\t\t\t       controlInfo_.max().get<float>());\n+\t\tfloatSlider_->setValue(controlInfo_.def().get<float>());\n+\t\tfloatSlider_->setOrientation(Qt::Orientation::Horizontal);\n+\n+\t\tconnect(floatSlider_, &FloatSlider::valueChanged,\n+\t\t\tthis, &ControlFrame::notifyControlChange);\n+\n+\t\tSliderLayout *fSliderLayout = new SliderLayout(floatSlider_, this);\n+\t\treturn fSliderLayout;\n+\t}\n \tdefault:\n \t\treturn (new QLabel(\"Currently Unavailable\"));\n \t}\n@@ -114,6 +129,9 @@ void ControlFrame::setCurrentValue(const libcamera::ControlValue controlValue)\n \t\telse\n \t\t\tcurrentValue_->setText(\"False\");\n \t\tbreak;\n+\tcase ControlTypeFloat:\n+\t\tcurrentValue_->setText(QString::number(controlValue.get<float>()));\n+\t\tbreak;\n \tdefault:\n \t\tbreak;\n \t}\n@@ -141,6 +159,9 @@ void ControlFrame::notifyControlChange()\n \t\telse\n \t\t\tcontrolValue.set<bool>(false);\n \n+\t\tbreak;\n+\tcase ControlTypeFloat:\n+\t\tcontrolValue.set<float>(floatSlider_->value());\n \t\tbreak;\n \tdefault:\n \t\t/* Nothing to emit so return */\ndiff --git a/src/qcam/settings/control_frame.h b/src/qcam/settings/control_frame.h\nindex 9c3b059b..e9e256aa 100644\n--- a/src/qcam/settings/control_frame.h\n+++ b/src/qcam/settings/control_frame.h\n@@ -15,6 +15,8 @@\n #include <QString>\n #include <QWidget>\n \n+#include \"slider.h\"\n+\n class ControlFrame : public QFrame\n {\n \tQ_OBJECT\n@@ -44,6 +46,7 @@ private:\n \n \tQCheckBox *controlCheckBox_;\n \tQLabel *currentValue_;\n+\tFloatSlider *floatSlider_;\n \n \t/* Helper Hunctions */\n \tQString getDefaultValueQStr();\n","prefixes":["libcamera-devel","09/11"]}