[{"id":24008,"web_url":"https://patchwork.libcamera.org/comment/24008/","msgid":"","date":"2022-07-20T15:12:07","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple:\n\tconverter: Handle unsupported input format","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Xavier,\n\nThank you for the patch.\n\nOn Fri, Jul 15, 2022 at 05:16:07PM +0200, Xavier Roumegue via libcamera-devel wrote:\n> SimpleConverter::formats() should return an empty vector if the input\n> format is not supported by the converter.\n> \n> Signed-off-by: Xavier Roumegue \n\nMakes sense.\n\n> ---\n> src/libcamera/pipeline/simple/converter.cpp | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\n> index 77c44fc8..19134edc 100644\n> --- a/src/libcamera/pipeline/simple/converter.cpp\n> +++ b/src/libcamera/pipeline/simple/converter.cpp\n> @@ -220,6 +220,12 @@ std::vector SimpleConverter::formats(PixelFormat input)\n> \t\treturn {};\n> \t}\n> \n> +\tif (v4l2Format.fourcc != V4L2PixelFormat::fromPixelFormat(input)) {\n> +\t\tLOG(SimplePipeline, Debug)\n> +\t\t\t<< \"Input format \" << input.toString() << \" not supported.\";\n\nPixelFormat has an operator<<(), so you can write\n\n\t\tLOG(SimplePipeline, Debug)\n\t\t\t<< \"Input format \" << input << \" not supported.\";\n\nWith this,\n\nReviewed-by: Laurent Pinchart \n\nNo need for a v2, I'll make the change when applying.\n\n> +\t\treturn {};\n> +\t}\n> +\n> \tstd::vector pixelFormats;\n> \n> \tfor (const auto &format : m2m_->capture()->formats()) {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8F558BE173\n\tfor ;\n\tWed, 20 Jul 2022 15:12:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A566E63312;\n\tWed, 20 Jul 2022 17:12:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 77C5B60489\n\tfor ;\n\tWed, 20 Jul 2022 17:12:42 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E3B656DB;\n\tWed, 20 Jul 2022 17:12:41 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658329963;\n\tbh=zWWNy/RB1pZv5NlLBmloTbQdn/SF+K19aqzmZS2Sd9w=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=lb4PMo1wKqinpDQyz4tHKDcIgUHfCld/FL1Q33cvlACX4F1j9MugzyE523T/kilQc\n\tDQMgS4zGjJEQ41ZzaMth02lEqnmmoFzHTBDHfpIq6EAlJJZld7zQYrTMTMgO4exRrE\n\tqJPOyNM3C+YRT5w84XWRIA6f/y0lkfgfnOq+B3q9PpvJ+KAU9m/kOnwrRiTGG5bfJH\n\tdZyMmGB8v0MMH58VOHni3Lxt2RNdJ+npwjhYQ634UhzVIJbdkNHho3toEt2kmjyOLK\n\tydGDKWnTlYJfTF05K74eL3l+4sU5QfTMQic4fobEnfZ4WI5CMslrWtmW5K4hCa/DVx\n\tooMIwrMXabgOw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658329962;\n\tbh=zWWNy/RB1pZv5NlLBmloTbQdn/SF+K19aqzmZS2Sd9w=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HeuzGkAFfNLgS0fCOH9ooGiTdHw/B3ctGBMUrNYOvI890A6Jg3baWqLHObXY9T1vn\n\tWTAdQSbOGMVjw0b8/2c5oteD6AZJ5uXik+vstL1ILq3xaXE/gn13KIFORzjRAogvdM\n\tB34PeJXKVipTRAJCKETh/ne2GtLZmrwGNUn/y4Mg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"HeuzGkAF\"; dkim-atps=neutral","Date":"Wed, 20 Jul 2022 18:12:07 +0300","To":"Xavier Roumegue ","Message-ID":"","References":"<20220715151607.1010433-1-xavier.roumegue@oss.nxp.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220715151607.1010433-1-xavier.roumegue@oss.nxp.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple:\n\tconverter: Handle unsupported input format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24035,"web_url":"https://patchwork.libcamera.org/comment/24035/","msgid":"<8c36ad6b-3607-a949-9c37-9576267ed37e@ideasonboard.com>","date":"2022-07-21T18:04:43","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple:\n\tconverter: Handle unsupported input format","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi,\n\nThank you for the patch,\n\nOn 7/15/22 20:46, Xavier Roumegue via libcamera-devel wrote:\n> SimpleConverter::formats() should return an empty vector if the input\n> format is not supported by the converter.\n>\n> Signed-off-by: Xavier Roumegue \n\n\nWith Laurent's suggestion applied,\n\nReviewed-by: Umang Jain \n\n> ---\n> src/libcamera/pipeline/simple/converter.cpp | 6 ++++++\n> 1 file changed, 6 insertions(+)\n>\n> diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\n> index 77c44fc8..19134edc 100644\n> --- a/src/libcamera/pipeline/simple/converter.cpp\n> +++ b/src/libcamera/pipeline/simple/converter.cpp\n> @@ -220,6 +220,12 @@ std::vector SimpleConverter::formats(PixelFormat input)\n> \t\treturn {};\n> \t}\n> \n> +\tif (v4l2Format.fourcc != V4L2PixelFormat::fromPixelFormat(input)) {\n> +\t\tLOG(SimplePipeline, Debug)\n> +\t\t\t<< \"Input format \" << input.toString() << \" not supported.\";\n> +\t\treturn {};\n> +\t}\n> +\n> \tstd::vector pixelFormats;\n> \n> \tfor (const auto &format : m2m_->capture()->formats()) {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 26CCCBD1F1\n\tfor ;\n\tThu, 21 Jul 2022 18:04:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 753486330F;\n\tThu, 21 Jul 2022 20:04:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 45669601B8\n\tfor ;\n\tThu, 21 Jul 2022 20:04:48 +0200 (CEST)","from [IPV6:2401:4900:1f3f:a2d:c6dd:7a7c:3d3c:dbb9] (unknown\n\t[IPv6:2401:4900:1f3f:a2d:c6dd:7a7c:3d3c:dbb9])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4B910496;\n\tThu, 21 Jul 2022 20:04:47 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658426689;\n\tbh=+VuRdlR0ulyfxcqEVnGOssmhxWEuSmWx5ZtbkizcAwk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=StTVktaPxLhFN5ncckIlAvJGUL1lwk1XYASGFNzrQ7WuAojtlyt75wA9tzBKw19/L\n\t19KCLldDSthjrCO8cdjac81zJSq8VOBV1SwXs9B087NEvoc3XBsuJBEcM3z2poOMhv\n\t74EE0heXuRMBzVqlWbtXPi9EjwDE5m8Q8MCBb76FSQa/unVu8WzEhEqGeiO+L4Il0w\n\t+DFCb15LyKs5C09J67WrkPqihoz3LWHSKi/boDYnvF2FD4bR+pZDZV73eV2gYoGLHM\n\tpFs9lvK5+HD6LQrL/mRRNC1XqMxiXpWExR+9dofOOQgigv5BZeEBAbSh91a+7gDN9U\n\tRzxVSCjH4Moww==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658426687;\n\tbh=+VuRdlR0ulyfxcqEVnGOssmhxWEuSmWx5ZtbkizcAwk=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=CKBria7DeAkPA2Dm97W55zMZdOuEZ3j3u3PKMAOnkPJ3Tp5UQIS73ggFqVouimvLf\n\tYc9gx72kCk/EtMACSDwGXh73zjna+VEFQEEEWVOIZpt+wvAgPqiamyuNEwq2yACFsI\n\tWziThBqS9opME4tTtCcp+QWvphOGcg6Nl6d2iks4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"CKBria7D\"; dkim-atps=neutral","Message-ID":"<8c36ad6b-3607-a949-9c37-9576267ed37e@ideasonboard.com>","Date":"Thu, 21 Jul 2022 23:34:43 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Xavier Roumegue ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220715151607.1010433-1-xavier.roumegue@oss.nxp.com>","In-Reply-To":"<20220715151607.1010433-1-xavier.roumegue@oss.nxp.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple:\n\tconverter: Handle unsupported input format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]