[{"id":23889,"web_url":"https://patchwork.libcamera.org/comment/23889/","msgid":"","date":"2022-07-14T19:47:15","subject":"Re: [libcamera-devel] [PATCH] cam: sdl: Use uint32_t in place of\n\tSDL_PixelFormatEnum","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Thu, Jul 14, 2022 at 08:24:23PM +0200, Jacopo Mondi via libcamera-devel wrote:\n> The SDL_PixelFormatEnum type has been introduced in libsdl by\n> 1a4c0d4e17e6 (\"Fixed bug 4377 - SDL_PIXELFORMAT enum is anonymous, which\n> prevents its use in a templated function\") which is only available after\n> release 2.0.10 of the library.\n> \n> Debian 10 ships libsdl at version 2.0.9 and building cam with sdl\n> support there fails with error:\n> ./src/cam/sdl_texture.h:27:8: error: ‘SDL_PixelFormatEnum’ does not name\n> a type; did you mean ‘SDL_PixelFormat’?\n> \n> Fix that by using the base type uint32_t in place of\n> SDL_PixelFormatEnum.\n> \n> Reported-by: https://buildbot.libcamera.org/#/builders/6/builds/355\n> Fixes: 11554a259f4e (\"cam: sdl_sink: Add SDL sink with initial YUYV support\")\n> Signed-off-by: Jacopo Mondi \n> ---\n> src/cam/sdl_texture.cpp | 2 +-\n> src/cam/sdl_texture.h | 4 ++--\n> 2 files changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/cam/sdl_texture.cpp b/src/cam/sdl_texture.cpp\n> index 2ca2add2f00c..02a8ff28b669 100644\n> --- a/src/cam/sdl_texture.cpp\n> +++ b/src/cam/sdl_texture.cpp\n> @@ -9,7 +9,7 @@\n> \n> #include \n> \n> -SDLTexture::SDLTexture(const SDL_Rect &rect, SDL_PixelFormatEnum pixelFormat,\n> +SDLTexture::SDLTexture(const SDL_Rect &rect, uint32_t pixelFormat,\n> \t\t const int pitch)\n> \t: ptr_(nullptr), rect_(rect), pixelFormat_(pixelFormat), pitch_(pitch)\n> {\n> diff --git a/src/cam/sdl_texture.h b/src/cam/sdl_texture.h\n> index 9097479846f7..2275b4e605d9 100644\n> --- a/src/cam/sdl_texture.h\n> +++ b/src/cam/sdl_texture.h\n> @@ -14,7 +14,7 @@\n> class SDLTexture\n> {\n> public:\n> -\tSDLTexture(const SDL_Rect &rect, SDL_PixelFormatEnum pixelFormat,\n> +\tSDLTexture(const SDL_Rect &rect, uint32_t pixelFormat,\n> \t\t const int pitch);\n\nYou could now wrap the line.\n\nReviewed-by: Laurent Pinchart \n\n> \tvirtual ~SDLTexture();\n> \tint create(SDL_Renderer *renderer);\n> @@ -24,6 +24,6 @@ public:\n> protected:\n> \tSDL_Texture *ptr_;\n> \tconst SDL_Rect rect_;\n> -\tconst SDL_PixelFormatEnum pixelFormat_;\n> +\tconst uint32_t pixelFormat_;\n> \tconst int pitch_;\n> };","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4A14ABD1F1\n\tfor ;\n\tThu, 14 Jul 2022 19:47:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A2A8C6330E;\n\tThu, 14 Jul 2022 21:47:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8BFFC6330D\n\tfor ;\n\tThu, 14 Jul 2022 21:47:47 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 04826383;\n\tThu, 14 Jul 2022 21:47:46 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657828068;\n\tbh=dHRpTtjFemnWvKGtSJHrsBnuqpCd+wTSQXcGDPagWJE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=fSJ8bAj5ykR7SlPUej9DynVW1DbOgpP3IeTdAJ98oHzXhGHHQs4m9NuFGQKMRSu5U\n\tHWVpqz3AY3yIEt1nrI1EpNeOrBMvhmeQe/Xr2eHBzR+uLeq35vwoDI06K+b4l1Mjwo\n\t+yebClvymSKieAyDJJyZOQ8ssrAiCcRhfHFXwMc9U2EiwDZ20K4IKmaKkATCC0QGQa\n\t4nWZscKN369uZlYT0cuXknl3QlnsRQ43QjWDXQYVYQshzxj3Rh+LxHaepKxcteAvNr\n\tsfF8D8jS0R7aHSrDQR2IwPAXJPxCNGA6v9dtVOdyFBZy9jb45muhQBrR1keBTgmhBc\n\tQukEdQtCSQ3Pg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657828067;\n\tbh=dHRpTtjFemnWvKGtSJHrsBnuqpCd+wTSQXcGDPagWJE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Rdvz3PCJUdO3sAXUfVbXwc/UezF8twUMjXmfXUoo4KZQHNaVRdmIhzTX9+A3QJ7qS\n\tdu9sB8XllWWnidX5U2gRidoD5jXNeJebWMQ1s+O0/MaEQa96N3lP6UbLgybBrZRTjY\n\t2NsEZga8FZswINfVWnrXuOiAE7eWlq8BDJdVPZX0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Rdvz3PCJ\"; dkim-atps=neutral","Date":"Thu, 14 Jul 2022 22:47:15 +0300","To":"Jacopo Mondi ","Message-ID":"","References":"<20220714182423.179764-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20220714182423.179764-1-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH] cam: sdl: Use uint32_t in place of\n\tSDL_PixelFormatEnum","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23914,"web_url":"https://patchwork.libcamera.org/comment/23914/","msgid":"<07b09c39-9029-e163-6234-814aa891f18f@ideasonboard.com>","date":"2022-07-15T07:59:57","subject":"Re: [libcamera-devel] [PATCH] cam: sdl: Use uint32_t in place of\n\tSDL_PixelFormatEnum","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn 7/15/22 01:17, Laurent Pinchart via libcamera-devel wrote:\n> Hi Jacopo,\n>\n> Thank you for the patch.\n>\n> On Thu, Jul 14, 2022 at 08:24:23PM +0200, Jacopo Mondi via libcamera-devel wrote:\n>> The SDL_PixelFormatEnum type has been introduced in libsdl by\n>> 1a4c0d4e17e6 (\"Fixed bug 4377 - SDL_PIXELFORMAT enum is anonymous, which\n>> prevents its use in a templated function\") which is only available after\n>> release 2.0.10 of the library.\n>>\n>> Debian 10 ships libsdl at version 2.0.9 and building cam with sdl\n>> support there fails with error:\n>> ./src/cam/sdl_texture.h:27:8: error: ‘SDL_PixelFormatEnum’ does not name\n>> a type; did you mean ‘SDL_PixelFormat’?\n>>\n>> Fix that by using the base type uint32_t in place of\n>> SDL_PixelFormatEnum.\n>>\n>> Reported-by: https://buildbot.libcamera.org/#/builders/6/builds/355\n>> Fixes: 11554a259f4e (\"cam: sdl_sink: Add SDL sink with initial YUYV support\")\n>> Signed-off-by: Jacopo Mondi \n>> ---\n>> src/cam/sdl_texture.cpp | 2 +-\n>> src/cam/sdl_texture.h | 4 ++--\n>> 2 files changed, 3 insertions(+), 3 deletions(-)\n>>\n>> diff --git a/src/cam/sdl_texture.cpp b/src/cam/sdl_texture.cpp\n>> index 2ca2add2f00c..02a8ff28b669 100644\n>> --- a/src/cam/sdl_texture.cpp\n>> +++ b/src/cam/sdl_texture.cpp\n>> @@ -9,7 +9,7 @@\n>>\n>> #include \n>>\n>> -SDLTexture::SDLTexture(const SDL_Rect &rect, SDL_PixelFormatEnum pixelFormat,\n>> +SDLTexture::SDLTexture(const SDL_Rect &rect, uint32_t pixelFormat,\n>> \t\t const int pitch)\n>> \t: ptr_(nullptr), rect_(rect), pixelFormat_(pixelFormat), pitch_(pitch)\n>> {\n>> diff --git a/src/cam/sdl_texture.h b/src/cam/sdl_texture.h\n>> index 9097479846f7..2275b4e605d9 100644\n>> --- a/src/cam/sdl_texture.h\n>> +++ b/src/cam/sdl_texture.h\n>> @@ -14,7 +14,7 @@\n>> class SDLTexture\n>> {\n>> public:\n>> -\tSDLTexture(const SDL_Rect &rect, SDL_PixelFormatEnum pixelFormat,\n>> +\tSDLTexture(const SDL_Rect &rect, uint32_t pixelFormat,\n>> \t\t const int pitch);\n> You could now wrap the line.\n>\n> Reviewed-by: Laurent Pinchart \n\n\nReviewed-by: Umang Jain \n\n>\n>> \tvirtual ~SDLTexture();\n>> \tint create(SDL_Renderer *renderer);\n>> @@ -24,6 +24,6 @@ public:\n>> protected:\n>> \tSDL_Texture *ptr_;\n>> \tconst SDL_Rect rect_;\n>> -\tconst SDL_PixelFormatEnum pixelFormat_;\n>> +\tconst uint32_t pixelFormat_;\n>> \tconst int pitch_;\n>> };","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4EA78BD1F1\n\tfor ;\n\tFri, 15 Jul 2022 08:00:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A165663312;\n\tFri, 15 Jul 2022 10:00:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 906D16330B\n\tfor ;\n\tFri, 15 Jul 2022 10:00:03 +0200 (CEST)","from [IPV6:2401:4900:1f3f:4a71:4259:9735:9699:ed7d] (unknown\n\t[IPv6:2401:4900:1f3f:4a71:4259:9735:9699:ed7d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4CE089DA;\n\tFri, 15 Jul 2022 10:00:02 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657872004;\n\tbh=UObxkWkTfuaUCkWWIvNbErl+dHcWrJP94kGZzhm4vcQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=EoRa6CzP43NpOsQPW0AvOjxv53n4PRvReJOfUhqAoUcHthk83cPEV+e+ruKToBwFK\n\tGWagyY/naHmPRiyfbdzzeVMpOm7PSc/f92f5yR5ytmHZAQniOU5NEdWUsAK0KjyKXy\n\thhSof8wtAkkA7n4rLkBAYN2OUxdte0tW7NwZNoCLL60RzT43XwG+7KIdF2996rBO7U\n\t7bIiIHWWk5G4ioW/88WzL7bRe5dkbMr3GEwNO9LkWSgp5FtXN+aAPHTyqHwHPGCCe8\n\tAykBn2TWeimMzmSm3Yf/DTtKcup98jTt7wD8JpPFyAO7wtdiaqy37v0XkmSeslMUMt\n\tqe5kUN6yL6Jeg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657872003;\n\tbh=UObxkWkTfuaUCkWWIvNbErl+dHcWrJP94kGZzhm4vcQ=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=uS9+4pxGH+550to2BrKjL100d5WUWGOchVBIWsfKKSkDuQT5mlvqG6RK/w0kDr6/D\n\t0gwxd3koXxxOIaiw+MwYzqGrxEBa7KipLy6EbpNfOfGY508EMUD+zH75nb7GdPxzY/\n\t7kLw3zxVmS+9N5wUM0+P4Pm51O+NfWRPJ9nS5jz8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"uS9+4pxG\"; dkim-atps=neutral","Message-ID":"<07b09c39-9029-e163-6234-814aa891f18f@ideasonboard.com>","Date":"Fri, 15 Jul 2022 13:29:57 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Jacopo Mondi ","References":"<20220714182423.179764-1-jacopo@jmondi.org>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] cam: sdl: Use uint32_t in place of\n\tSDL_PixelFormatEnum","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23915,"web_url":"https://patchwork.libcamera.org/comment/23915/","msgid":"<165787333528.2021905.7394858170122762360@Monstersaurus>","date":"2022-07-15T08:22:15","subject":"Re: [libcamera-devel] [PATCH] cam: sdl: Use uint32_t in place of\n\tSDL_PixelFormatEnum","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi via libcamera-devel (2022-07-14 19:24:23)\n> The SDL_PixelFormatEnum type has been introduced in libsdl by\n> 1a4c0d4e17e6 (\"Fixed bug 4377 - SDL_PIXELFORMAT enum is anonymous, which\n> prevents its use in a templated function\") which is only available after\n> release 2.0.10 of the library.\n> \n> Debian 10 ships libsdl at version 2.0.9 and building cam with sdl\n> support there fails with error:\n> ./src/cam/sdl_texture.h:27:8: error: ‘SDL_PixelFormatEnum’ does not name\n> a type; did you mean ‘SDL_PixelFormat’?\n> \n> Fix that by using the base type uint32_t in place of\n> SDL_PixelFormatEnum.\n\nIs there scope to fix this by checking the version of the header being\ncompiled and defining SDL_PixelFormatEnum instead?\n\nI would expect something in src/cam/sdl_texture.h such as:\n\n#if !SDL_VERSION_ATLEAST(2.0.10)\ntypedef uint32_t SDL_PixelFormatEnum;\n#endif\n\n\n--\nKieran\n\n\n> Reported-by: https://buildbot.libcamera.org/#/builders/6/builds/355\n> Fixes: 11554a259f4e (\"cam: sdl_sink: Add SDL sink with initial YUYV support\")\n> Signed-off-by: Jacopo Mondi \n> ---\n> src/cam/sdl_texture.cpp | 2 +-\n> src/cam/sdl_texture.h | 4 ++--\n> 2 files changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/cam/sdl_texture.cpp b/src/cam/sdl_texture.cpp\n> index 2ca2add2f00c..02a8ff28b669 100644\n> --- a/src/cam/sdl_texture.cpp\n> +++ b/src/cam/sdl_texture.cpp\n> @@ -9,7 +9,7 @@\n> \n> #include \n> \n> -SDLTexture::SDLTexture(const SDL_Rect &rect, SDL_PixelFormatEnum pixelFormat,\n> +SDLTexture::SDLTexture(const SDL_Rect &rect, uint32_t pixelFormat,\n> const int pitch)\n> : ptr_(nullptr), rect_(rect), pixelFormat_(pixelFormat), pitch_(pitch)\n> {\n> diff --git a/src/cam/sdl_texture.h b/src/cam/sdl_texture.h\n> index 9097479846f7..2275b4e605d9 100644\n> --- a/src/cam/sdl_texture.h\n> +++ b/src/cam/sdl_texture.h\n> @@ -14,7 +14,7 @@\n> class SDLTexture\n> {\n> public:\n> - SDLTexture(const SDL_Rect &rect, SDL_PixelFormatEnum pixelFormat,\n> + SDLTexture(const SDL_Rect &rect, uint32_t pixelFormat,\n> const int pitch);\n> virtual ~SDLTexture();\n> int create(SDL_Renderer *renderer);\n> @@ -24,6 +24,6 @@ public:\n> protected:\n> SDL_Texture *ptr_;\n> const SDL_Rect rect_;\n> - const SDL_PixelFormatEnum pixelFormat_;\n> + const uint32_t pixelFormat_;\n> const int pitch_;\n> };\n> --\n> 2.36.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 99415BE173\n\tfor ;\n\tFri, 15 Jul 2022 08:22:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A01C63312;\n\tFri, 15 Jul 2022 10:22:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CCBBE6330B\n\tfor ;\n\tFri, 15 Jul 2022 10:22:17 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5BB099DA;\n\tFri, 15 Jul 2022 10:22:17 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657873340;\n\tbh=19xWzGJPjWik7hWEppHwf4/qcRixQNkeRJy481aXVd8=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=YUM10FGOWtbTSj2lDTCHMO/OON8JNnu87xNoOrGQym8jQESSSBgP/gRmPdBwf1WPy\n\t1Ynwc9+89/Y58YPE3kIq9qVoPZiT+wyirDgxaAYsAHAzgLPAKiHYm1GAfACWhAM3h5\n\txoWrC97TDfw2mWj2kSAzTzmdycSA8Bd2o/yumOtlfp3yMonzUulRYDJSTs+1ETpwKx\n\t64LJaXYv7/miicporDZIJ6sxe9xXfYgEHwG6KZSEpIcGUy2iLkp/PKTBuRK6q8bfBK\n\trr6O56vpuMjd1K0DwIDiep04kKiTLOItlwIUTk2CbZoFxbH5yjGSqdyyuoj1S4qGDD\n\t5WqNJYKvLqLlQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657873337;\n\tbh=19xWzGJPjWik7hWEppHwf4/qcRixQNkeRJy481aXVd8=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=CJqnquoFTRId+ttULLckCzsSrkjw3k+DxxMIDl7JwpdjkRFeEAWSpHs/g4G3SQhyP\n\teNpb921RA0K1safHZ+R2M8tIf3bPuOsUC5c9TqbwBV5DeQOU3ZcjyMCd3KyGtZp1r2\n\tkNlBUR/glOuU/S3E03O9Wc1nIvfT89q0DUJKTbJg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"CJqnquoF\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220714182423.179764-1-jacopo@jmondi.org>","References":"<20220714182423.179764-1-jacopo@jmondi.org>","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","Date":"Fri, 15 Jul 2022 09:22:15 +0100","Message-ID":"<165787333528.2021905.7394858170122762360@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] cam: sdl: Use uint32_t in place of\n\tSDL_PixelFormatEnum","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23916,"web_url":"https://patchwork.libcamera.org/comment/23916/","msgid":"","date":"2022-07-15T08:31:08","subject":"Re: [libcamera-devel] [PATCH] cam: sdl: Use uint32_t in place of\n\tSDL_PixelFormatEnum","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Jul 15, 2022 at 09:22:15AM +0100, Kieran Bingham via libcamera-devel wrote:\n> Quoting Jacopo Mondi via libcamera-devel (2022-07-14 19:24:23)\n> > The SDL_PixelFormatEnum type has been introduced in libsdl by\n> > 1a4c0d4e17e6 (\"Fixed bug 4377 - SDL_PIXELFORMAT enum is anonymous, which\n> > prevents its use in a templated function\") which is only available after\n> > release 2.0.10 of the library.\n> > \n> > Debian 10 ships libsdl at version 2.0.9 and building cam with sdl\n> > support there fails with error:\n> > ./src/cam/sdl_texture.h:27:8: error: ‘SDL_PixelFormatEnum’ does not name\n> > a type; did you mean ‘SDL_PixelFormat’?\n> > \n> > Fix that by using the base type uint32_t in place of\n> > SDL_PixelFormatEnum.\n> \n> Is there scope to fix this by checking the version of the header being\n> compiled and defining SDL_PixelFormatEnum instead?\n> \n> I would expect something in src/cam/sdl_texture.h such as:\n> \n> #if !SDL_VERSION_ATLEAST(2.0.10)\n> typedef uint32_t SDL_PixelFormatEnum;\n> #endif\n\nIt could be done. It won't make any difference at compilation time as\nSDL_PixelFormatEnum is a plain C enum, the compiler will thus not catch\nSDLTexture::SDLTexture() being called with a wrong value, but it may\nmake it clearer to the person reading the code what type of pixel format\nis expected. I don't have any strong opinion either way.\n\n> > Reported-by: https://buildbot.libcamera.org/#/builders/6/builds/355\n> > Fixes: 11554a259f4e (\"cam: sdl_sink: Add SDL sink with initial YUYV support\")\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/cam/sdl_texture.cpp | 2 +-\n> > src/cam/sdl_texture.h | 4 ++--\n> > 2 files changed, 3 insertions(+), 3 deletions(-)\n> > \n> > diff --git a/src/cam/sdl_texture.cpp b/src/cam/sdl_texture.cpp\n> > index 2ca2add2f00c..02a8ff28b669 100644\n> > --- a/src/cam/sdl_texture.cpp\n> > +++ b/src/cam/sdl_texture.cpp\n> > @@ -9,7 +9,7 @@\n> > \n> > #include \n> > \n> > -SDLTexture::SDLTexture(const SDL_Rect &rect, SDL_PixelFormatEnum pixelFormat,\n> > +SDLTexture::SDLTexture(const SDL_Rect &rect, uint32_t pixelFormat,\n> > const int pitch)\n> > : ptr_(nullptr), rect_(rect), pixelFormat_(pixelFormat), pitch_(pitch)\n> > {\n> > diff --git a/src/cam/sdl_texture.h b/src/cam/sdl_texture.h\n> > index 9097479846f7..2275b4e605d9 100644\n> > --- a/src/cam/sdl_texture.h\n> > +++ b/src/cam/sdl_texture.h\n> > @@ -14,7 +14,7 @@\n> > class SDLTexture\n> > {\n> > public:\n> > - SDLTexture(const SDL_Rect &rect, SDL_PixelFormatEnum pixelFormat,\n> > + SDLTexture(const SDL_Rect &rect, uint32_t pixelFormat,\n> > const int pitch);\n> > virtual ~SDLTexture();\n> > int create(SDL_Renderer *renderer);\n> > @@ -24,6 +24,6 @@ public:\n> > protected:\n> > SDL_Texture *ptr_;\n> > const SDL_Rect rect_;\n> > - const SDL_PixelFormatEnum pixelFormat_;\n> > + const uint32_t pixelFormat_;\n> > const int pitch_;\n> > };\n> > --\n> > 2.36.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C995FBD1F1\n\tfor ;\n\tFri, 15 Jul 2022 08:31:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2C22E6330E;\n\tFri, 15 Jul 2022 10:31:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 261FD6330B\n\tfor ;\n\tFri, 15 Jul 2022 10:31:40 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7AAC7993;\n\tFri, 15 Jul 2022 10:31:39 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657873901;\n\tbh=qV3PgFo+kTW7Y5hu5BUAjyvS2Q8TAF+yKMyLD+gfMBo=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=m0QotlnxBkfGQ+CQOIPVjjQ0N0wuWPNCzk66NwKIjTba3UVSdm1fkskcehlqcAKbN\n\te+dITMo9TLPITuVbrkCnbZMK1yD8sIYSxg7ml0GDegTi97EZ8wLdhReRc9X3g1kC3C\n\tFYsAPrmetkysWwsag5iyhPEixppgErYD/kn1HuZ7SmL5XiBhc0pzJd6Yf2MeirRbTk\n\tV6LQm0sYfM2r9H9D0jwVO4gBoI7TmeKpwDDXNOmT3yV05kpmAEiWi2RLimneR3JLsg\n\tM/fnXi8A01Mu/ospx66NdbpwVHWNLLitUbGvs7BxpC4h5BzKDR9ND3J871gNanhRst\n\tiDrQuL9f92XTg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657873899;\n\tbh=qV3PgFo+kTW7Y5hu5BUAjyvS2Q8TAF+yKMyLD+gfMBo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fEOJWDjww45pw3wSliqeni5Obc/lu5y4mM65p20TsPYkc9jfwP/pyOEemcurBRa+F\n\tzUjeOQNmEiSJBUMUtsZJ+km9GHvIDIKF47e+fr5+BdUAUaxvEk7Zw8Zj0nMRQXiLDQ\n\t97bRtDNK3qWAbeTL7kFdGH41HIV+ezu9hyNBbf6c="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"fEOJWDjw\"; dkim-atps=neutral","Date":"Fri, 15 Jul 2022 11:31:08 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220714182423.179764-1-jacopo@jmondi.org>\n\t<165787333528.2021905.7394858170122762360@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<165787333528.2021905.7394858170122762360@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] cam: sdl: Use uint32_t in place of\n\tSDL_PixelFormatEnum","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23917,"web_url":"https://patchwork.libcamera.org/comment/23917/","msgid":"<20220715083845.mnllzkumub6styjw@uno.localdomain>","date":"2022-07-15T08:38:45","subject":"Re: [libcamera-devel] [PATCH] cam: sdl: Use uint32_t in place of\n\tSDL_PixelFormatEnum","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran\n\nOn Fri, Jul 15, 2022 at 09:22:15AM +0100, Kieran Bingham wrote:\n> Quoting Jacopo Mondi via libcamera-devel (2022-07-14 19:24:23)\n> > The SDL_PixelFormatEnum type has been introduced in libsdl by\n> > 1a4c0d4e17e6 (\"Fixed bug 4377 - SDL_PIXELFORMAT enum is anonymous, which\n> > prevents its use in a templated function\") which is only available after\n> > release 2.0.10 of the library.\n> >\n> > Debian 10 ships libsdl at version 2.0.9 and building cam with sdl\n> > support there fails with error:\n> > ./src/cam/sdl_texture.h:27:8: error: ‘SDL_PixelFormatEnum’ does not name\n> > a type; did you mean ‘SDL_PixelFormat’?\n> >\n> > Fix that by using the base type uint32_t in place of\n> > SDL_PixelFormatEnum.\n>\n> Is there scope to fix this by checking the version of the header being\n> compiled and defining SDL_PixelFormatEnum instead?\n>\n> I would expect something in src/cam/sdl_texture.h such as:\n>\n> #if !SDL_VERSION_ATLEAST(2.0.10)\n> typedef uint32_t SDL_PixelFormatEnum;\n> #endif\n>\n\nI don't see any benefit to be honest.\n\nThe library itself uses uint32 in it's public API\n\n/**\n * Convert one of the enumerated pixel formats to a bpp value and RGBA masks.\n *\n * \\param format one of the SDL_PixelFormatEnum values\n * \\param bpp a bits per pixel value; usually 15, 16, or 32\n * \\param Rmask a pointer filled in with the red mask for the format\n * \\param Gmask a pointer filled in with the green mask for the format\n * \\param Bmask a pointer filled in with the blue mask for the format\n * \\param Amask a pointer filled in with the alpha mask for the format\n * \\returns SDL_TRUE on success or SDL_FALSE if the conversion wasn't\n * possible; call SDL_GetError() for more information.\n *\n * \\since This function is available since SDL 2.0.0.\n *\n * \\sa SDL_MasksToPixelFormatEnum\n */\nextern DECLSPEC SDL_bool SDLCALL SDL_PixelFormatEnumToMasks(Uint32 format,\n int *bpp,\n Uint32 * Rmask,\n Uint32 * Gmask,\n Uint32 * Bmask,\n Uint32 * Amask);\n\n\nLooking at commit history libsdl is also progressively removing the\n\"Enum\" suffix from their defined types, I would not tie ourselves to\nsuch moving parts for no benefit.\n\n\n\n>\n> --\n> Kieran\n>\n>\n> > Reported-by: https://buildbot.libcamera.org/#/builders/6/builds/355\n> > Fixes: 11554a259f4e (\"cam: sdl_sink: Add SDL sink with initial YUYV support\")\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/cam/sdl_texture.cpp | 2 +-\n> > src/cam/sdl_texture.h | 4 ++--\n> > 2 files changed, 3 insertions(+), 3 deletions(-)\n> >\n> > diff --git a/src/cam/sdl_texture.cpp b/src/cam/sdl_texture.cpp\n> > index 2ca2add2f00c..02a8ff28b669 100644\n> > --- a/src/cam/sdl_texture.cpp\n> > +++ b/src/cam/sdl_texture.cpp\n> > @@ -9,7 +9,7 @@\n> >\n> > #include \n> >\n> > -SDLTexture::SDLTexture(const SDL_Rect &rect, SDL_PixelFormatEnum pixelFormat,\n> > +SDLTexture::SDLTexture(const SDL_Rect &rect, uint32_t pixelFormat,\n> > const int pitch)\n> > : ptr_(nullptr), rect_(rect), pixelFormat_(pixelFormat), pitch_(pitch)\n> > {\n> > diff --git a/src/cam/sdl_texture.h b/src/cam/sdl_texture.h\n> > index 9097479846f7..2275b4e605d9 100644\n> > --- a/src/cam/sdl_texture.h\n> > +++ b/src/cam/sdl_texture.h\n> > @@ -14,7 +14,7 @@\n> > class SDLTexture\n> > {\n> > public:\n> > - SDLTexture(const SDL_Rect &rect, SDL_PixelFormatEnum pixelFormat,\n> > + SDLTexture(const SDL_Rect &rect, uint32_t pixelFormat,\n> > const int pitch);\n> > virtual ~SDLTexture();\n> > int create(SDL_Renderer *renderer);\n> > @@ -24,6 +24,6 @@ public:\n> > protected:\n> > SDL_Texture *ptr_;\n> > const SDL_Rect rect_;\n> > - const SDL_PixelFormatEnum pixelFormat_;\n> > + const uint32_t pixelFormat_;\n> > const int pitch_;\n> > };\n> > --\n> > 2.36.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AC6F7BE173\n\tfor ;\n\tFri, 15 Jul 2022 08:38:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 21C106330E;\n\tFri, 15 Jul 2022 10:38:50 +0200 (CEST)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E2DE6330B\n\tfor ;\n\tFri, 15 Jul 2022 10:38:48 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id A1BA61BF203;\n\tFri, 15 Jul 2022 08:38:47 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657874330;\n\tbh=huAmYpcqIT/Mnc3nNdG+tiNnEWPj1eO8Tzn4oBvtHQQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=kYUNxCKhYK451WZFyL8vNGAd4XhT+Zw2AETPKMPqmDKyeTPIhqdfHnnow9d7ZsT+A\n\tO1kfINJoK53f/At9+Ut7g8cIET76k4IxEGCxWd6b0GEA4idlq+Bn/Po1OL7cejNzJE\n\tRBKT2WzLYmHCs+1n4+F60bbA4cVKc6amSl6V5VBdGmr2Q5AdMl85VHf2lEaEid0Hae\n\tw5sBTcrOUzJjHqiuFBTP60uyVIiYyAUdjZxazbmXXoWvTvHh9mmGybmsqx5J8uoqKA\n\tWbFny9srq0eRytEtAl8uGA8zB2eOQxrHi9xsfZAFfEMFUMJipdt/6dn42VnCXn+Pa5\n\tG/FC80XGNd7mQ==","Date":"Fri, 15 Jul 2022 10:38:45 +0200","To":"Kieran Bingham ","Message-ID":"<20220715083845.mnllzkumub6styjw@uno.localdomain>","References":"<20220714182423.179764-1-jacopo@jmondi.org>\n\t<165787333528.2021905.7394858170122762360@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<165787333528.2021905.7394858170122762360@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] cam: sdl: Use uint32_t in place of\n\tSDL_PixelFormatEnum","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23925,"web_url":"https://patchwork.libcamera.org/comment/23925/","msgid":"","date":"2022-07-15T10:43:17","subject":"Re: [libcamera-devel] [PATCH] cam: sdl: Use uint32_t in place of\n\tSDL_PixelFormatEnum","submitter":{"id":101,"url":"https://patchwork.libcamera.org/api/people/101/","name":"Eric Curtin","email":"ecurtin@redhat.com"},"content":"I have a similar opinion to Laurent on this, I prefer\nSDL_PixelFormatEnum because it's more descriptive, but happy the way\nthis patch is also.\n\nReviewed-by: Eric Curtin \n\nIs mise le meas/Regards,\n\nEric Curtin\n\nOn Fri, 15 Jul 2022 at 09:38, Jacopo Mondi via libcamera-devel\n wrote:\n>\n> Hi Kieran\n>\n> On Fri, Jul 15, 2022 at 09:22:15AM +0100, Kieran Bingham wrote:\n> > Quoting Jacopo Mondi via libcamera-devel (2022-07-14 19:24:23)\n> > > The SDL_PixelFormatEnum type has been introduced in libsdl by\n> > > 1a4c0d4e17e6 (\"Fixed bug 4377 - SDL_PIXELFORMAT enum is anonymous, which\n> > > prevents its use in a templated function\") which is only available after\n> > > release 2.0.10 of the library.\n> > >\n> > > Debian 10 ships libsdl at version 2.0.9 and building cam with sdl\n> > > support there fails with error:\n> > > ./src/cam/sdl_texture.h:27:8: error: ‘SDL_PixelFormatEnum’ does not name\n> > > a type; did you mean ‘SDL_PixelFormat’?\n> > >\n> > > Fix that by using the base type uint32_t in place of\n> > > SDL_PixelFormatEnum.\n> >\n> > Is there scope to fix this by checking the version of the header being\n> > compiled and defining SDL_PixelFormatEnum instead?\n> >\n> > I would expect something in src/cam/sdl_texture.h such as:\n> >\n> > #if !SDL_VERSION_ATLEAST(2.0.10)\n> > typedef uint32_t SDL_PixelFormatEnum;\n> > #endif\n> >\n>\n> I don't see any benefit to be honest.\n>\n> The library itself uses uint32 in it's public API\n>\n> /**\n> * Convert one of the enumerated pixel formats to a bpp value and RGBA masks.\n> *\n> * \\param format one of the SDL_PixelFormatEnum values\n> * \\param bpp a bits per pixel value; usually 15, 16, or 32\n> * \\param Rmask a pointer filled in with the red mask for the format\n> * \\param Gmask a pointer filled in with the green mask for the format\n> * \\param Bmask a pointer filled in with the blue mask for the format\n> * \\param Amask a pointer filled in with the alpha mask for the format\n> * \\returns SDL_TRUE on success or SDL_FALSE if the conversion wasn't\n> * possible; call SDL_GetError() for more information.\n> *\n> * \\since This function is available since SDL 2.0.0.\n> *\n> * \\sa SDL_MasksToPixelFormatEnum\n> */\n> extern DECLSPEC SDL_bool SDLCALL SDL_PixelFormatEnumToMasks(Uint32 format,\n> int *bpp,\n> Uint32 * Rmask,\n> Uint32 * Gmask,\n> Uint32 * Bmask,\n> Uint32 * Amask);\n>\n>\n> Looking at commit history libsdl is also progressively removing the\n> \"Enum\" suffix from their defined types, I would not tie ourselves to\n> such moving parts for no benefit.\n>\n>\n>\n> >\n> > --\n> > Kieran\n> >\n> >\n> > > Reported-by: https://buildbot.libcamera.org/#/builders/6/builds/355\n> > > Fixes: 11554a259f4e (\"cam: sdl_sink: Add SDL sink with initial YUYV support\")\n> > > Signed-off-by: Jacopo Mondi \n> > > ---\n> > > src/cam/sdl_texture.cpp | 2 +-\n> > > src/cam/sdl_texture.h | 4 ++--\n> > > 2 files changed, 3 insertions(+), 3 deletions(-)\n> > >\n> > > diff --git a/src/cam/sdl_texture.cpp b/src/cam/sdl_texture.cpp\n> > > index 2ca2add2f00c..02a8ff28b669 100644\n> > > --- a/src/cam/sdl_texture.cpp\n> > > +++ b/src/cam/sdl_texture.cpp\n> > > @@ -9,7 +9,7 @@\n> > >\n> > > #include \n> > >\n> > > -SDLTexture::SDLTexture(const SDL_Rect &rect, SDL_PixelFormatEnum pixelFormat,\n> > > +SDLTexture::SDLTexture(const SDL_Rect &rect, uint32_t pixelFormat,\n> > > const int pitch)\n> > > : ptr_(nullptr), rect_(rect), pixelFormat_(pixelFormat), pitch_(pitch)\n> > > {\n> > > diff --git a/src/cam/sdl_texture.h b/src/cam/sdl_texture.h\n> > > index 9097479846f7..2275b4e605d9 100644\n> > > --- a/src/cam/sdl_texture.h\n> > > +++ b/src/cam/sdl_texture.h\n> > > @@ -14,7 +14,7 @@\n> > > class SDLTexture\n> > > {\n> > > public:\n> > > - SDLTexture(const SDL_Rect &rect, SDL_PixelFormatEnum pixelFormat,\n> > > + SDLTexture(const SDL_Rect &rect, uint32_t pixelFormat,\n> > > const int pitch);\n> > > virtual ~SDLTexture();\n> > > int create(SDL_Renderer *renderer);\n> > > @@ -24,6 +24,6 @@ public:\n> > > protected:\n> > > SDL_Texture *ptr_;\n> > > const SDL_Rect rect_;\n> > > - const SDL_PixelFormatEnum pixelFormat_;\n> > > + const uint32_t pixelFormat_;\n> > > const int pitch_;\n> > > };\n> > > --\n> > > 2.36.1\n> > >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6E879BE173\n\tfor ;\n\tFri, 15 Jul 2022 10:43:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 018C66330E;\n\tFri, 15 Jul 2022 12:43:45 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 86F196330A\n\tfor ;\n\tFri, 15 Jul 2022 12:43:42 +0200 (CEST)","from mail-qv1-f69.google.com (mail-qv1-f69.google.com\n\t[209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-146-7bJskhLSP02fsKB8uHp_rQ-1; Fri, 15 Jul 2022 06:43:34 -0400","by mail-qv1-f69.google.com with SMTP id\n\tod5-20020a0562142f0500b00473838e0feeso2846833qvb.9\n\tfor ;\n\tFri, 15 Jul 2022 03:43:34 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657881825;\n\tbh=QZfe7X8q2p16DcLFKghEdqSvNZCoESTnsU3Pu2m/4uQ=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=y9cSID18/r4ozeKJ8Wfwrss0l04nt7IcqMG5W9Oe4xgmVsb+CL1iWyfxu2myTjtDW\n\twNJG3EunUACdEpGy5nn/2VadsSTFdJMlVhP/jt2aGk9SFPQjdZO0mTGaPr+Y5FPBN0\n\tZO0rCzzdovDZ6pKv0Xe0Yq0x9dgFSD2JyGZdGxYBYeW3DEQPC9TylrF3kcbLmRjPRB\n\tapHir+aOClVML/FZr+dnv7CrzUSGUOSV0s0JU3ibRsJe2mfDPQCI4iX8M2exCweucn\n\tJh2RYk41lRTibm1tecJLKKVt9d7FiftBAVd7Gx/AL4omKVUBar6UywzpjxDYnVtN5r\n\t0N4wdqwBjAmgA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1657881821;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=+8fn9/H6siTp58czmqlQq1eaSTZuUP2DkOzxmDBc6XY=;\n\tb=WpvKWa/9Bnzmd/59Dfygw3vB71q9O8pMprc6V+BFQMWZilNEbpfgfHvIYraq1dLutdEgvQ\n\tIHDi4/sSJeqtIaTzg1bmXkkJJZ0HSzFIGDLjLYND5Rc2anfUn/luCzQLQB/9gdQHIHmbb/\n\tignUHoILvum0eMh2Z6EzrZYIT+lxudY="],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"WpvKWa/9\"; \n\tdkim-atps=neutral","relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ecurtin@redhat.com"],"X-MC-Unique":"7bJskhLSP02fsKB8uHp_rQ-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=+8fn9/H6siTp58czmqlQq1eaSTZuUP2DkOzxmDBc6XY=;\n\tb=eCyTES28rAmzaM5onZgsI3ma+tH/qP8FHJEjEjULdXKM7mgGzibAMUw8WgE2a+0lXm\n\ttOCzK2vKlF8BW0KhJOa2umRP8iRkqqEuCeqDz74/1eh2zgXlYhefVPJjOdNplJJ26IR/\n\tbiNUYvCqPc44tGLRJqhH6LXAtoaO1rLYL/3QM4z8ulOVXZ9Gy6jwkb/TX4pZoEXPGB5H\n\tD+ijwqhjK+ciGY79FbMeDELbLDueknLyo4NdvfJ1l0y/vB9QWy+jzSfYU4nGtqQkluzi\n\tPP0cr3d/vi2H341NPyoxr7eHhqbBr7T27sqE2bjbH/D6HM4T+1/HVB8JFTVp6uzYwEPA\n\tn0hA==","X-Gm-Message-State":"AJIora+c7yZ+U+PlzULhTRSWVzYTqZYyx5R/uwwVLGZSR6G/GA48Kp1P\n\tVVj1ufkMDFb6IjYjHsRX80XSoJUQZxyvsV3ocUV9ghiS1PwVU4XVS/q7h5iwM5S6JwWZHUnSkNo\n\tyb8fhCUtDzbiFqXxUE7DPteBZOZxUYbJA4s97qfBZpSGjK4JZyg==","X-Received":["by 2002:a0c:cb86:0:b0:473:37d:9f48 with SMTP id\n\tp6-20020a0ccb86000000b00473037d9f48mr11624980qvk.81.1657881813364; \n\tFri, 15 Jul 2022 03:43:33 -0700 (PDT)","by 2002:a0c:cb86:0:b0:473:37d:9f48 with SMTP id\n\tp6-20020a0ccb86000000b00473037d9f48mr11624969qvk.81.1657881812988;\n\tFri, 15 Jul 2022 03:43:32 -0700 (PDT)"],"X-Google-Smtp-Source":"AGRyM1stLIqEiGVB8L7WTkaILkxVyb+CjeR/plF48Ov+6+bLXNYOv4vyoTYCyGwAOIuWKSaiTJwBnbz4zGugNVV78lc=","MIME-Version":"1.0","References":"<20220714182423.179764-1-jacopo@jmondi.org>\n\t<165787333528.2021905.7394858170122762360@Monstersaurus>\n\t<20220715083845.mnllzkumub6styjw@uno.localdomain>","In-Reply-To":"<20220715083845.mnllzkumub6styjw@uno.localdomain>","Date":"Fri, 15 Jul 2022 11:43:17 +0100","Message-ID":"","To":"Jacopo Mondi ","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [libcamera-devel] [PATCH] cam: sdl: Use uint32_t in place of\n\tSDL_PixelFormatEnum","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Eric Curtin via libcamera-devel ","Reply-To":"Eric Curtin ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23928,"web_url":"https://patchwork.libcamera.org/comment/23928/","msgid":"<165788288019.2228597.8693927509546393278@Monstersaurus>","date":"2022-07-15T11:01:20","subject":"Re: [libcamera-devel] [PATCH] cam: sdl: Use uint32_t in place of\n\tSDL_PixelFormatEnum","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Eric Curtin (2022-07-15 11:43:17)\n> I have a similar opinion to Laurent on this, I prefer\n> SDL_PixelFormatEnum because it's more descriptive, but happy the way\n> this patch is also.\n> \n> Reviewed-by: Eric Curtin \n> \n> Is mise le meas/Regards,\n> \n> Eric Curtin\n> \n> On Fri, 15 Jul 2022 at 09:38, Jacopo Mondi via libcamera-devel\n> wrote:\n> >\n> > Hi Kieran\n> >\n> > On Fri, Jul 15, 2022 at 09:22:15AM +0100, Kieran Bingham wrote:\n> > > Quoting Jacopo Mondi via libcamera-devel (2022-07-14 19:24:23)\n> > > > The SDL_PixelFormatEnum type has been introduced in libsdl by\n> > > > 1a4c0d4e17e6 (\"Fixed bug 4377 - SDL_PIXELFORMAT enum is anonymous, which\n> > > > prevents its use in a templated function\") which is only available after\n> > > > release 2.0.10 of the library.\n> > > >\n> > > > Debian 10 ships libsdl at version 2.0.9 and building cam with sdl\n> > > > support there fails with error:\n> > > > ./src/cam/sdl_texture.h:27:8: error: ‘SDL_PixelFormatEnum’ does not name\n> > > > a type; did you mean ‘SDL_PixelFormat’?\n> > > >\n> > > > Fix that by using the base type uint32_t in place of\n> > > > SDL_PixelFormatEnum.\n> > >\n> > > Is there scope to fix this by checking the version of the header being\n> > > compiled and defining SDL_PixelFormatEnum instead?\n> > >\n> > > I would expect something in src/cam/sdl_texture.h such as:\n> > >\n> > > #if !SDL_VERSION_ATLEAST(2.0.10)\n> > > typedef uint32_t SDL_PixelFormatEnum;\n> > > #endif\n> > >\n> >\n> > I don't see any benefit to be honest.\n> >\n> > The library itself uses uint32 in it's public API\n\nOk - my expectation was that it would persist the declaration of the\nformat. But I don't really mind either way anyway.\n\nThis one has tags - ship it ;-)\n\n--\nKieran\n\n\n> >\n> > /**\n> > * Convert one of the enumerated pixel formats to a bpp value and RGBA masks.\n> > *\n> > * \\param format one of the SDL_PixelFormatEnum values\n> > * \\param bpp a bits per pixel value; usually 15, 16, or 32\n> > * \\param Rmask a pointer filled in with the red mask for the format\n> > * \\param Gmask a pointer filled in with the green mask for the format\n> > * \\param Bmask a pointer filled in with the blue mask for the format\n> > * \\param Amask a pointer filled in with the alpha mask for the format\n> > * \\returns SDL_TRUE on success or SDL_FALSE if the conversion wasn't\n> > * possible; call SDL_GetError() for more information.\n> > *\n> > * \\since This function is available since SDL 2.0.0.\n> > *\n> > * \\sa SDL_MasksToPixelFormatEnum\n> > */\n> > extern DECLSPEC SDL_bool SDLCALL SDL_PixelFormatEnumToMasks(Uint32 format,\n> > int *bpp,\n> > Uint32 * Rmask,\n> > Uint32 * Gmask,\n> > Uint32 * Bmask,\n> > Uint32 * Amask);\n> >\n> >\n> > Looking at commit history libsdl is also progressively removing the\n> > \"Enum\" suffix from their defined types, I would not tie ourselves to\n> > such moving parts for no benefit.\n> >\n> >\n> >\n> > >\n> > > --\n> > > Kieran\n> > >\n> > >\n> > > > Reported-by: https://buildbot.libcamera.org/#/builders/6/builds/355\n> > > > Fixes: 11554a259f4e (\"cam: sdl_sink: Add SDL sink with initial YUYV support\")\n> > > > Signed-off-by: Jacopo Mondi \n> > > > ---\n> > > > src/cam/sdl_texture.cpp | 2 +-\n> > > > src/cam/sdl_texture.h | 4 ++--\n> > > > 2 files changed, 3 insertions(+), 3 deletions(-)\n> > > >\n> > > > diff --git a/src/cam/sdl_texture.cpp b/src/cam/sdl_texture.cpp\n> > > > index 2ca2add2f00c..02a8ff28b669 100644\n> > > > --- a/src/cam/sdl_texture.cpp\n> > > > +++ b/src/cam/sdl_texture.cpp\n> > > > @@ -9,7 +9,7 @@\n> > > >\n> > > > #include \n> > > >\n> > > > -SDLTexture::SDLTexture(const SDL_Rect &rect, SDL_PixelFormatEnum pixelFormat,\n> > > > +SDLTexture::SDLTexture(const SDL_Rect &rect, uint32_t pixelFormat,\n> > > > const int pitch)\n> > > > : ptr_(nullptr), rect_(rect), pixelFormat_(pixelFormat), pitch_(pitch)\n> > > > {\n> > > > diff --git a/src/cam/sdl_texture.h b/src/cam/sdl_texture.h\n> > > > index 9097479846f7..2275b4e605d9 100644\n> > > > --- a/src/cam/sdl_texture.h\n> > > > +++ b/src/cam/sdl_texture.h\n> > > > @@ -14,7 +14,7 @@\n> > > > class SDLTexture\n> > > > {\n> > > > public:\n> > > > - SDLTexture(const SDL_Rect &rect, SDL_PixelFormatEnum pixelFormat,\n> > > > + SDLTexture(const SDL_Rect &rect, uint32_t pixelFormat,\n> > > > const int pitch);\n> > > > virtual ~SDLTexture();\n> > > > int create(SDL_Renderer *renderer);\n> > > > @@ -24,6 +24,6 @@ public:\n> > > > protected:\n> > > > SDL_Texture *ptr_;\n> > > > const SDL_Rect rect_;\n> > > > - const SDL_PixelFormatEnum pixelFormat_;\n> > > > + const uint32_t pixelFormat_;\n> > > > const int pitch_;\n> > > > };\n> > > > --\n> > > > 2.36.1\n> > > >\n> >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 59628BE173\n\tfor ;\n\tFri, 15 Jul 2022 11:01:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AD8866330E;\n\tFri, 15 Jul 2022 13:01:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC50F6330A\n\tfor ;\n\tFri, 15 Jul 2022 13:01:22 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 47F04993;\n\tFri, 15 Jul 2022 13:01:22 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657882884;\n\tbh=iPcpoSyRpDB+RXqOOB7LGkr32FRCC7BxFC5hvc/4o0c=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=GTlMlu8kO53tvNnNjy57wpwzVbFYZYdakUP+Z6jXER2aM2aK4laKkg58nIckMXAUN\n\t6642fjf8VnAC0mipvYPP/Ad5S8JXfh20BC1VVPlhUlzaZMOetB0WjpMKraoIbeOKgA\n\t79UO/M+pG7PQoMzeA22qnn7hbKm3BzM4iuIf91tMh7quWANGlnx0S3Ghk7lxubHNNv\n\tXdrSvmuyY077eZUz1xX4zBkmcwy6f6downjPXA+2G6BnH5/cMzhkbjUwytdKHICsWK\n\tBqdowp+qdmNbitYNNUv1SQJ9hS4NbfEeyNYOPjztyOuwyyJ1cUFuDfvUFtZfN6I9Ru\n\tJIokB1yK2dQ4A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657882882;\n\tbh=iPcpoSyRpDB+RXqOOB7LGkr32FRCC7BxFC5hvc/4o0c=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=pvR0i7dzzoHccowFct9FqZl1+U1Ng73pbczfyHZliTRIgZWpapu1RPcxeAYMXlJJ1\n\thpJetH092aBoAbeGduPBZ60BA+xXVcs7PE0LK1OF+t5X3KncbNjM0AndfUr/VFT8Mi\n\t11OhkcOHxP9AFlhldCUR6XgLWV+R4nbzZbmQvMv8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"pvR0i7dz\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20220714182423.179764-1-jacopo@jmondi.org>\n\t<165787333528.2021905.7394858170122762360@Monstersaurus>\n\t<20220715083845.mnllzkumub6styjw@uno.localdomain>\n\t","To":"Eric Curtin , Jacopo Mondi ","Date":"Fri, 15 Jul 2022 12:01:20 +0100","Message-ID":"<165788288019.2228597.8693927509546393278@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] cam: sdl: Use uint32_t in place of\n\tSDL_PixelFormatEnum","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]