{"id":16636,"url":"https://patchwork.libcamera.org/api/patches/16636/?format=json","web_url":"https://patchwork.libcamera.org/patch/16636/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220714182423.179764-1-jacopo@jmondi.org>","date":"2022-07-14T18:24:23","name":"[libcamera-devel] cam: sdl: Use uint32_t in place of SDL_PixelFormatEnum","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"55284891fad24430aaf01921c19046b17bc08798","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16636/mbox/","series":[{"id":3286,"url":"https://patchwork.libcamera.org/api/series/3286/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3286","date":"2022-07-14T18:24:23","name":"[libcamera-devel] cam: sdl: Use uint32_t in place of SDL_PixelFormatEnum","version":1,"mbox":"https://patchwork.libcamera.org/series/3286/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16636/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16636/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB778BD1F1\n\tfor ;\n\tThu, 14 Jul 2022 18:24:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2F47763312;\n\tThu, 14 Jul 2022 20:24:31 +0200 (CEST)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::222])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 98DCB6330D\n\tfor ;\n\tThu, 14 Jul 2022 20:24:29 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 638C240004;\n\tThu, 14 Jul 2022 18:24:28 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657823071;\n\tbh=ay+U////fw/0cMy6QuRFCMWRxf9JCJFGnoVl5nASwjc=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=kzFlj0xRLxabgLDVvjh9optfPNI0a0iGE/h4SPlx7z+TZZ9IZ/vhGCOLI2GD84YT2\n\tah388r+b5VT7mzZ9P9lAm6jpED/rpL1Rrl7lqUfXxcjpyEfWTkxDmeZE+OmFTAtiD8\n\tBFWP+inAvJnLvtxP+jM+pUd08TsMkh5ZOtkWAk0P4b8gfCGEJMIAniUDl8TdYQFnJi\n\tZRrBjaEqYhybZqr2uNwfmGCuW9jP3AmaWodYtNanTcGnB4VxjaxOeDQ6PpW0WVbwPs\n\tQDacNec8hKZVTIxdncCOJ7aRUbpi1PvAXWKAq6hY74S0emc6AnGJ8ewFvl7aN969ir\n\tyNdxuy1cbkEhA==","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 14 Jul 2022 20:24:23 +0200","Message-Id":"<20220714182423.179764-1-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.36.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] cam: sdl: Use uint32_t in place of\n\tSDL_PixelFormatEnum","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The SDL_PixelFormatEnum type has been introduced in libsdl by\n1a4c0d4e17e6 (\"Fixed bug 4377 - SDL_PIXELFORMAT enum is anonymous, which\nprevents its use in a templated function\") which is only available after\nrelease 2.0.10 of the library.\n\nDebian 10 ships libsdl at version 2.0.9 and building cam with sdl\nsupport there fails with error:\n./src/cam/sdl_texture.h:27:8: error: ‘SDL_PixelFormatEnum’ does not name\na type; did you mean ‘SDL_PixelFormat’?\n\nFix that by using the base type uint32_t in place of\nSDL_PixelFormatEnum.\n\nReported-by: https://buildbot.libcamera.org/#/builders/6/builds/355\nFixes: 11554a259f4e (\"cam: sdl_sink: Add SDL sink with initial YUYV support\")\nSigned-off-by: Jacopo Mondi \n---\n src/cam/sdl_texture.cpp | 2 +-\n src/cam/sdl_texture.h | 4 ++--\n 2 files changed, 3 insertions(+), 3 deletions(-)\n\n--\n2.36.1","diff":"diff --git a/src/cam/sdl_texture.cpp b/src/cam/sdl_texture.cpp\nindex 2ca2add2f00c..02a8ff28b669 100644\n--- a/src/cam/sdl_texture.cpp\n+++ b/src/cam/sdl_texture.cpp\n@@ -9,7 +9,7 @@\n\n #include \n\n-SDLTexture::SDLTexture(const SDL_Rect &rect, SDL_PixelFormatEnum pixelFormat,\n+SDLTexture::SDLTexture(const SDL_Rect &rect, uint32_t pixelFormat,\n \t\t const int pitch)\n \t: ptr_(nullptr), rect_(rect), pixelFormat_(pixelFormat), pitch_(pitch)\n {\ndiff --git a/src/cam/sdl_texture.h b/src/cam/sdl_texture.h\nindex 9097479846f7..2275b4e605d9 100644\n--- a/src/cam/sdl_texture.h\n+++ b/src/cam/sdl_texture.h\n@@ -14,7 +14,7 @@\n class SDLTexture\n {\n public:\n-\tSDLTexture(const SDL_Rect &rect, SDL_PixelFormatEnum pixelFormat,\n+\tSDLTexture(const SDL_Rect &rect, uint32_t pixelFormat,\n \t\t const int pitch);\n \tvirtual ~SDLTexture();\n \tint create(SDL_Renderer *renderer);\n@@ -24,6 +24,6 @@ public:\n protected:\n \tSDL_Texture *ptr_;\n \tconst SDL_Rect rect_;\n-\tconst SDL_PixelFormatEnum pixelFormat_;\n+\tconst uint32_t pixelFormat_;\n \tconst int pitch_;\n };\n","prefixes":["libcamera-devel"]}