[{"id":23869,"web_url":"https://patchwork.libcamera.org/comment/23869/","msgid":"<CAEmqJPo6X4MfLo4zcGQ-n6Dg4bWZBmtLFJ7izsOiSjOLzMcCGg@mail.gmail.com>","date":"2022-07-14T09:45:01","subject":"Re: [libcamera-devel] [PATCH 1/1] ipa: raspberrypi: Update imx296\n\ttuning file","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi William,\n\nThank you for your patch.\n\nOn Thu, 14 Jul 2022 at 10:42, William Vinnicombe via libcamera-devel <\nlibcamera-devel@lists.libcamera.org> wrote:\n\n> From: William Vinnicombe <william.vinnicombe@raspberrypi.com>\n>\n> The previous tuning values for the imx296 are not accurate, and do not\n> contain awb parameters.\n>\n> Update the tuning file using the raspberrypi ctt tool to give accurate\n> values, and all required parameters.\n>\n> Signed-off-by: William Vinnicombe <william.vinnicombe@raspberrypi.com>\n>\n\nLooks good!\n\nReviewed-by: Naushir Patuck <naush@raspberrypi.com>\n\n\n\n> ---\n>  src/ipa/raspberrypi/data/imx296.json | 268 ++++++++++++++++++++++-----\n>  1 file changed, 217 insertions(+), 51 deletions(-)\n>\n> diff --git a/src/ipa/raspberrypi/data/imx296.json\n> b/src/ipa/raspberrypi/data/imx296.json\n> index 837feff5..4d9d0e8b 100644\n> --- a/src/ipa/raspberrypi/data/imx296.json\n> +++ b/src/ipa/raspberrypi/data/imx296.json\n> @@ -8,25 +8,97 @@\n>      },\n>      \"rpi.lux\":\n>      {\n> -        \"reference_shutter_speed\": 19184,\n> -        \"reference_gain\": 1.0,\n> +        \"reference_shutter_speed\": 17895,\n> +        \"reference_gain\": 1.99,\n>          \"reference_aperture\": 1.0,\n> -        \"reference_lux\": 432,\n> -        \"reference_Y\": 13773\n> +        \"reference_lux\": 1147,\n> +        \"reference_Y\": 13348\n>      },\n>      \"rpi.noise\":\n>      {\n> -        \"reference_constant\": 0,\n> -        \"reference_slope\": 2.957\n> +        \"reference_constant\": 1,\n> +        \"reference_slope\": 2.631\n>      },\n>      \"rpi.geq\":\n>      {\n> -        \"offset\": 185,\n> -        \"slope\": 0.0105\n> +        \"offset\": 182,\n> +        \"slope\": 0.0127\n>      },\n>      \"rpi.sdn\":\n>      {\n>      },\n> +    \"rpi.awb\":\n> +    {\n> +        \"priors\":\n> +        [\n> +            {\n> +                \"lux\": 0, \"prior\":\n> +                [\n> +                    2000, 1.0, 3000, 0.0, 13000, 0.0\n> +                ]\n> +            },\n> +            {\n> +                \"lux\": 800, \"prior\":\n> +                [\n> +                    2000, 0.0, 6000, 2.0, 13000, 2.0\n> +                ]\n> +            },\n> +            {\n> +                \"lux\": 1500, \"prior\":\n> +                [\n> +                    2000, 0.0, 4000, 1.0, 6000, 6.0, 6500, 7.0, 7000,\n> 1.0, 13000, 1.0\n> +                ]\n> +            }\n> +        ],\n> +        \"modes\":\n> +        {\n> +            \"auto\":\n> +            {\n> +                \"lo\": 2500,\n> +                \"hi\": 8000\n> +            },\n> +            \"incandescent\":\n> +            {\n> +                \"lo\": 2500,\n> +                \"hi\": 3000\n> +            },\n> +            \"tungsten\":\n> +            {\n> +                \"lo\": 3000,\n> +                \"hi\": 3500\n> +            },\n> +            \"fluorescent\":\n> +            {\n> +                \"lo\": 4000,\n> +                \"hi\": 4700\n> +            },\n> +            \"indoor\":\n> +            {\n> +                \"lo\": 3000,\n> +                \"hi\": 5000\n> +            },\n> +            \"daylight\":\n> +            {\n> +                \"lo\": 5500,\n> +                \"hi\": 6500\n> +            },\n> +            \"cloudy\":\n> +            {\n> +                \"lo\": 7000,\n> +                \"hi\": 8600\n> +            }\n> +        },\n> +        \"bayes\": 1,\n> +        \"ct_curve\":\n> +        [\n> +            2861.0, 0.4281, 0.2614, 2915.0, 0.4266, 0.2639, 2916.0,\n> 0.4112, 0.2913, 2934.0, 0.4099, 0.2935, 3626.0, 0.3604, 0.3777, 4617.0,\n> +            0.2776, 0.5093, 5674.0, 0.2567, 0.5409, 7617.0, 0.1789, 0.6527\n> +        ],\n> +        \"sensitivity_r\": 1.0,\n> +        \"sensitivity_b\": 1.0,\n> +        \"transverse_pos\": 0.02994,\n> +        \"transverse_neg\": 0.04332\n> +    },\n>      \"rpi.agc\":\n>      {\n>          \"metering_modes\":\n> @@ -113,65 +185,99 @@\n>      \"rpi.alsc\":\n>      {\n>          \"omega\": 1.3,\n> -        \"n_iter\": 0,\n> +        \"n_iter\": 100,\n>          \"luminance_strength\": 0.5,\n>          \"calibrations_Cr\":\n>          [\n>              {\n> -                \"ct\": 4000, \"table\":\n> -                [\n> -                    2.554, 2.554, 2.541, 2.534, 2.495, 2.506, 2.516,\n> 2.517, 2.518, 2.515, 2.513, 2.495, 2.481, 2.533, 2.533, 2.521,\n> -                    2.522, 2.534, 2.539, 2.531, 2.531, 2.506, 2.506,\n> 2.513, 2.513, 2.509, 2.498, 2.496, 2.508, 2.517, 2.521, 2.521,\n> -                    2.509, 2.517, 2.534, 2.529, 2.531, 2.521, 2.517,\n> 2.517, 2.515, 2.514, 2.506, 2.499, 2.508, 2.508, 2.521, 2.537,\n> -                    2.507, 2.508, 2.517, 2.516, 2.495, 2.487, 2.519,\n> 2.534, 2.535, 2.531, 2.499, 2.494, 2.501, 2.511, 2.526, 2.526,\n> -                    2.509, 2.517, 2.507, 2.501, 2.494, 2.519, 2.539,\n> 2.539, 2.537, 2.537, 2.533, 2.499, 2.503, 2.511, 2.529, 2.525,\n> -                    2.521, 2.522, 2.476, 2.501, 2.501, 2.539, 2.546,\n> 2.538, 2.531, 2.538, 2.541, 2.531, 2.529, 2.526, 2.529, 2.525,\n> -                    2.516, 2.519, 2.469, 2.499, 2.499, 2.543, 2.543,\n> 2.531, 2.528, 2.534, 2.541, 2.535, 2.531, 2.526, 2.531, 2.528,\n> -                    2.509, 2.515, 2.465, 2.487, 2.487, 2.539, 2.543,\n> 2.539, 2.533, 2.549, 2.542, 2.531, 2.529, 2.524, 2.532, 2.533,\n> -                    2.499, 2.499, 2.475, 2.482, 2.471, 2.509, 2.539,\n> 2.544, 2.543, 2.545, 2.533, 2.498, 2.521, 2.521, 2.537, 2.536,\n> -                    2.499, 2.488, 2.488, 2.488, 2.471, 2.462, 2.509,\n> 2.539, 2.539, 2.532, 2.498, 2.498, 2.518, 2.518, 2.539, 2.539,\n> -                    2.483, 2.484, 2.488, 2.488, 2.502, 2.496, 2.508,\n> 2.514, 2.518, 2.517, 2.521, 2.518, 2.518, 2.518, 2.525, 2.539,\n> -                    2.483, 2.487, 2.478, 2.478, 2.507, 2.509, 2.514,\n> 2.513, 2.514, 2.517, 2.536, 2.559, 2.501, 2.501, 2.503, 2.525\n> +                \"ct\": 2943, \"table\":\n> +                [\n> +                    2.153, 2.154, 2.154, 2.153, 2.153, 2.153, 2.153,\n> 2.151, 2.151, 2.149, 2.149, 2.149, 2.149, 2.149, 2.151, 2.153,\n> +                    2.154, 2.155, 2.155, 2.154, 2.154, 2.154, 2.153,\n> 2.152, 2.151, 2.149, 2.149, 2.149, 2.149, 2.149, 2.151, 2.152,\n> +                    2.155, 2.155, 2.155, 2.154, 2.154, 2.154, 2.153,\n> 2.151, 2.151, 2.149, 2.149, 2.149, 2.149, 2.149, 2.151, 2.152,\n> +                    2.154, 2.154, 2.155, 2.153, 2.153, 2.153, 2.152,\n> 2.151, 2.149, 2.149, 2.149, 2.149, 2.148, 2.148, 2.149, 2.151,\n> +                    2.153, 2.153, 2.153, 2.152, 2.152, 2.152, 2.151,\n> 2.149, 2.149, 2.149, 2.149, 2.148, 2.148, 2.148, 2.149, 2.151,\n> +                    2.153, 2.153, 2.152, 2.152, 2.152, 2.152, 2.151,\n> 2.149, 2.149, 2.148, 2.148, 2.148, 2.147, 2.147, 2.148, 2.149,\n> +                    2.152, 2.153, 2.152, 2.151, 2.151, 2.151, 2.151,\n> 2.151, 2.149, 2.148, 2.148, 2.147, 2.147, 2.147, 2.148, 2.149,\n> +                    2.152, 2.152, 2.152, 2.151, 2.151, 2.151, 2.151,\n> 2.149, 2.148, 2.147, 2.146, 2.147, 2.147, 2.148, 2.149, 2.151,\n> +                    2.152, 2.152, 2.152, 2.151, 2.151, 2.151, 2.151,\n> 2.151, 2.149, 2.147, 2.146, 2.147, 2.148, 2.149, 2.152, 2.152,\n> +                    2.152, 2.154, 2.154, 2.152, 2.152, 2.152, 2.152,\n> 2.151, 2.151, 2.149, 2.149, 2.149, 2.151, 2.152, 2.153, 2.153,\n> +                    2.155, 2.156, 2.155, 2.154, 2.152, 2.152, 2.152,\n> 2.151, 2.151, 2.149, 2.149, 2.149, 2.151, 2.152, 2.153, 2.153,\n> +                    2.155, 2.155, 2.155, 2.154, 2.152, 2.151, 2.151,\n> 2.149, 2.148, 2.148, 2.149, 2.149, 2.151, 2.152, 2.152, 2.154\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 6097, \"table\":\n> +                [\n> +                    3.604, 3.605, 3.607, 3.605, 3.604, 3.604, 3.603,\n> 3.602, 3.598, 3.594, 3.593, 3.593, 3.593, 3.593, 3.596, 3.602,\n> +                    3.604, 3.607, 3.611, 3.609, 3.609, 3.608, 3.606,\n> 3.602, 3.599, 3.596, 3.596, 3.594, 3.594, 3.594, 3.598, 3.602,\n> +                    3.606, 3.611, 3.612, 3.609, 3.611, 3.609, 3.608,\n> 3.602, 3.599, 3.597, 3.596, 3.595, 3.594, 3.594, 3.597, 3.599,\n> +                    3.606, 3.609, 3.611, 3.607, 3.607, 3.606, 3.603,\n> 3.599, 3.597, 3.595, 3.595, 3.593, 3.593, 3.592, 3.593, 3.596,\n> +                    3.604, 3.607, 3.607, 3.604, 3.603, 3.602, 3.599,\n> 3.597, 3.596, 3.595, 3.595, 3.594, 3.592, 3.591, 3.591, 3.594,\n> +                    3.606, 3.607, 3.606, 3.604, 3.602, 3.601, 3.599,\n> 3.597, 3.597, 3.596, 3.596, 3.595, 3.593, 3.591, 3.589, 3.592,\n> +                    3.604, 3.606, 3.605, 3.603, 3.602, 3.602, 3.599,\n> 3.598, 3.596, 3.595, 3.595, 3.595, 3.591, 3.589, 3.591, 3.592,\n> +                    3.604, 3.604, 3.605, 3.602, 3.601, 3.601, 3.599,\n> 3.598, 3.597, 3.595, 3.593, 3.591, 3.589, 3.591, 3.592, 3.596,\n> +                    3.604, 3.605, 3.606, 3.602, 3.601, 3.601, 3.601,\n> 3.599, 3.597, 3.595, 3.593, 3.591, 3.589, 3.594, 3.598, 3.599,\n> +                    3.609, 3.613, 3.615, 3.611, 3.609, 3.609, 3.608,\n> 3.605, 3.603, 3.599, 3.598, 3.597, 3.598, 3.601, 3.603, 3.603,\n> +                    3.613, 3.616, 3.616, 3.613, 3.609, 3.609, 3.608,\n> 3.606, 3.604, 3.602, 3.599, 3.599, 3.599, 3.602, 3.605, 3.605,\n> +                    3.615, 3.616, 3.616, 3.613, 3.611, 3.604, 3.604,\n> 3.601, 3.601, 3.599, 3.599, 3.599, 3.601, 3.602, 3.604, 3.604\n>                  ]\n>              }\n>          ],\n>          \"calibrations_Cb\":\n>          [\n>              {\n> -                \"ct\": 4000, \"table\":\n> -                [\n> -                    2.619, 2.603, 2.599, 2.597, 2.595, 2.594, 2.589,\n> 2.587, 2.586, 2.589, 2.592, 2.597, 2.601, 2.608, 2.621, 2.621,\n> -                    2.619, 2.615, 2.603, 2.601, 2.596, 2.595, 2.591,\n> 2.589, 2.589, 2.592, 2.599, 2.593, 2.601, 2.613, 2.622, 2.631,\n> -                    2.617, 2.617, 2.612, 2.611, 2.604, 2.598, 2.593,\n> 2.591, 2.592, 2.591, 2.593, 2.595, 2.599, 2.614, 2.623, 2.631,\n> -                    2.624, 2.619, 2.615, 2.612, 2.605, 2.602, 2.597,\n> 2.596, 2.592, 2.592, 2.595, 2.599, 2.602, 2.606, 2.619, 2.624,\n> -                    2.629, 2.627, 2.627, 2.617, 2.609, 2.598, 2.612,\n> 2.623, 2.615, 2.604, 2.589, 2.595, 2.599, 2.608, 2.611, 2.614,\n> -                    2.629, 2.632, 2.637, 2.627, 2.612, 2.612, 2.629,\n> 2.631, 2.628, 2.621, 2.604, 2.597, 2.598, 2.604, 2.609, 2.609,\n> -                    2.635, 2.636, 2.642, 2.628, 2.623, 2.623, 2.636,\n> 2.636, 2.634, 2.628, 2.616, 2.599, 2.597, 2.601, 2.603, 2.601,\n> -                    2.641, 2.639, 2.646, 2.632, 2.627, 2.625, 2.632,\n> 2.635, 2.634, 2.627, 2.614, 2.596, 2.595, 2.599, 2.599, 2.598,\n> -                    2.643, 2.644, 2.651, 2.649, 2.629, 2.617, 2.624,\n> 2.629, 2.625, 2.614, 2.586, 2.599, 2.595, 2.597, 2.592, 2.595,\n> -                    2.645, 2.646, 2.649, 2.649, 2.638, 2.624, 2.616,\n> 2.617, 2.609, 2.604, 2.603, 2.603, 2.595, 2.589, 2.587, 2.592,\n> -                    2.641, 2.643, 2.649, 2.647, 2.638, 2.618, 2.615,\n> 2.608, 2.602, 2.595, 2.596, 2.595, 2.593, 2.584, 2.581, 2.583,\n> -                    2.638, 2.637, 2.647, 2.634, 2.634, 2.618, 2.621,\n> 2.621, 2.611, 2.602, 2.596, 2.583, 2.581, 2.581, 2.576, 2.574\n> +                \"ct\": 2943, \"table\":\n> +                [\n> +                    3.361, 3.369, 3.379, 3.385, 3.391, 3.397, 3.401,\n> 3.401, 3.399, 3.396, 3.394, 3.391, 3.383, 3.382, 3.376, 3.375,\n> +                    3.365, 3.372, 3.381, 3.387, 3.391, 3.398, 3.403,\n> 3.403, 3.402, 3.399, 3.396, 3.392, 3.388, 3.382, 3.378, 3.374,\n> +                    3.366, 3.377, 3.384, 3.388, 3.391, 3.399, 3.403,\n> 3.405, 3.405, 3.401, 3.399, 3.393, 3.388, 3.384, 3.381, 3.374,\n> +                    3.366, 3.378, 3.385, 3.389, 3.394, 3.398, 3.402,\n> 3.405, 3.405, 3.404, 3.399, 3.393, 3.389, 3.385, 3.383, 3.369,\n> +                    3.364, 3.377, 3.383, 3.388, 3.394, 3.398, 3.401,\n> 3.404, 3.404, 3.404, 3.401, 3.394, 3.391, 3.386, 3.383, 3.371,\n> +                    3.361, 3.376, 3.381, 3.387, 3.394, 3.397, 3.401,\n> 3.402, 3.404, 3.403, 3.399, 3.397, 3.391, 3.387, 3.381, 3.371,\n> +                    3.359, 3.373, 3.379, 3.385, 3.394, 3.396, 3.399,\n> 3.401, 3.402, 3.401, 3.398, 3.396, 3.392, 3.385, 3.381, 3.371,\n> +                    3.358, 3.368, 3.376, 3.381, 3.391, 3.395, 3.397,\n> 3.399, 3.399, 3.397, 3.396, 3.392, 3.389, 3.383, 3.378, 3.365,\n> +                    3.357, 3.366, 3.373, 3.379, 3.383, 3.392, 3.394,\n> 3.396, 3.396, 3.393, 3.391, 3.388, 3.386, 3.382, 3.377, 3.365,\n> +                    3.355, 3.362, 3.369, 3.374, 3.379, 3.385, 3.391,\n> 3.393, 3.393, 3.392, 3.388, 3.385, 3.383, 3.379, 3.375, 3.362,\n> +                    3.351, 3.354, 3.363, 3.369, 3.374, 3.379, 3.385,\n> 3.387, 3.391, 3.385, 3.383, 3.382, 3.378, 3.377, 3.363, 3.361,\n> +                    3.351, 3.352, 3.357, 3.359, 3.365, 3.371, 3.374,\n> 3.375, 3.375, 3.375, 3.373, 3.367, 3.366, 3.366, 3.361, 3.362\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 6097, \"table\":\n> +                [\n> +                    1.654, 1.657, 1.662, 1.665, 1.666, 1.669, 1.671,\n> 1.672, 1.671, 1.669, 1.668, 1.666, 1.661, 1.661, 1.658, 1.656,\n> +                    1.655, 1.659, 1.663, 1.665, 1.667, 1.671, 1.672,\n> 1.672, 1.673, 1.671, 1.669, 1.667, 1.663, 1.661, 1.659, 1.656,\n> +                    1.656, 1.661, 1.665, 1.666, 1.668, 1.671, 1.673,\n> 1.673, 1.674, 1.672, 1.669, 1.668, 1.664, 1.662, 1.659, 1.656,\n> +                    1.656, 1.661, 1.665, 1.667, 1.668, 1.671, 1.673,\n> 1.674, 1.674, 1.673, 1.671, 1.668, 1.665, 1.663, 1.661, 1.655,\n> +                    1.656, 1.662, 1.665, 1.667, 1.669, 1.671, 1.673,\n> 1.673, 1.674, 1.672, 1.671, 1.668, 1.665, 1.662, 1.661, 1.656,\n> +                    1.655, 1.661, 1.664, 1.667, 1.669, 1.672, 1.672,\n> 1.673, 1.673, 1.672, 1.671, 1.669, 1.666, 1.662, 1.661, 1.656,\n> +                    1.654, 1.659, 1.663, 1.666, 1.669, 1.671, 1.672,\n> 1.673, 1.673, 1.672, 1.671, 1.669, 1.666, 1.662, 1.661, 1.655,\n> +                    1.653, 1.658, 1.662, 1.664, 1.668, 1.669, 1.672,\n> 1.672, 1.672, 1.671, 1.669, 1.667, 1.665, 1.661, 1.659, 1.653,\n> +                    1.652, 1.656, 1.659, 1.663, 1.666, 1.668, 1.669,\n> 1.671, 1.671, 1.669, 1.667, 1.665, 1.663, 1.659, 1.657, 1.653,\n> +                    1.649, 1.654, 1.658, 1.661, 1.663, 1.666, 1.668,\n> 1.669, 1.668, 1.667, 1.665, 1.663, 1.661, 1.659, 1.657, 1.651,\n> +                    1.646, 1.649, 1.654, 1.658, 1.661, 1.662, 1.664,\n> 1.665, 1.666, 1.664, 1.662, 1.661, 1.659, 1.657, 1.651, 1.648,\n> +                    1.645, 1.646, 1.651, 1.653, 1.655, 1.657, 1.659,\n> 1.659, 1.659, 1.658, 1.657, 1.656, 1.653, 1.653, 1.649, 1.648\n>                  ]\n>              }\n>          ],\n>          \"luminance_lut\":\n>          [\n> -            1.308, 1.293, 1.228, 1.175, 1.139, 1.108, 1.092, 1.082,\n> 1.082, 1.086, 1.097, 1.114, 1.149, 1.199, 1.279, 1.303,\n> -            1.293, 1.249, 1.199, 1.162, 1.136, 1.109, 1.087, 1.077,\n> 1.072, 1.081, 1.095, 1.103, 1.133, 1.172, 1.225, 1.282,\n> -            1.251, 1.212, 1.186, 1.159, 1.129, 1.114, 1.102, 1.088,\n> 1.088, 1.088, 1.095, 1.117, 1.123, 1.158, 1.198, 1.249,\n> -            1.223, 1.192, 1.177, 1.163, 1.147, 1.139, 1.132, 1.112,\n> 1.111, 1.107, 1.113, 1.118, 1.139, 1.155, 1.186, 1.232,\n> -            1.207, 1.186, 1.171, 1.162, 1.168, 1.163, 1.153, 1.138,\n> 1.129, 1.128, 1.132, 1.136, 1.149, 1.167, 1.189, 1.216,\n> -            1.198, 1.186, 1.176, 1.176, 1.177, 1.185, 1.171, 1.157,\n> 1.146, 1.144, 1.146, 1.149, 1.161, 1.181, 1.201, 1.221,\n> -            1.203, 1.181, 1.176, 1.178, 1.191, 1.189, 1.188, 1.174,\n> 1.159, 1.153, 1.158, 1.161, 1.169, 1.185, 1.211, 1.227,\n> -            1.211, 1.179, 1.177, 1.187, 1.194, 1.196, 1.194, 1.187,\n> 1.176, 1.169, 1.171, 1.171, 1.175, 1.189, 1.214, 1.226,\n> -            1.219, 1.182, 1.184, 1.191, 1.195, 1.199, 1.197, 1.194,\n> 1.188, 1.185, 1.179, 1.179, 1.182, 1.194, 1.212, 1.227,\n> -            1.237, 1.192, 1.194, 1.194, 1.198, 1.199, 1.198, 1.197,\n> 1.196, 1.193, 1.189, 1.189, 1.192, 1.203, 1.214, 1.231,\n> -            1.282, 1.199, 1.199, 1.197, 1.199, 1.199, 1.192, 1.193,\n> 1.193, 1.194, 1.196, 1.197, 1.206, 1.216, 1.228, 1.244,\n> -            1.309, 1.236, 1.204, 1.203, 1.202, 1.194, 1.194, 1.188,\n> 1.192, 1.192, 1.199, 1.201, 1.212, 1.221, 1.235, 1.247\n> +            1.054, 1.059, 1.063, 1.063, 1.063, 1.063, 1.062, 1.062,\n> 1.062, 1.062, 1.061, 1.059, 1.056, 1.052, 1.045, 1.043,\n> +            1.055, 1.061, 1.065, 1.064, 1.065, 1.064, 1.063, 1.062,\n> 1.063, 1.063, 1.061, 1.059, 1.057, 1.054, 1.049, 1.045,\n> +            1.057, 1.062, 1.064, 1.063, 1.072, 1.072, 1.072, 1.062,\n> 1.062, 1.062, 1.059, 1.058, 1.056, 1.054, 1.051, 1.047,\n> +            1.058, 1.061, 1.063, 1.061, 1.062, 1.073, 1.073, 1.059,\n> 1.058, 1.057, 1.057, 1.056, 1.055, 1.053, 1.051, 1.047,\n> +            1.057, 1.059, 1.061, 1.059, 1.059, 1.059, 1.054, 1.054,\n> 1.056, 1.056, 1.056, 1.055, 1.054, 1.052, 1.049, 1.043,\n> +            1.055, 1.057, 1.059, 1.057, 1.056, 1.052, 1.049, 1.049,\n> 1.053, 1.054, 1.054, 1.052, 1.051, 1.049, 1.043, 1.041,\n> +            1.049, 1.053, 1.054, 1.055, 1.052, 1.049, 1.045, 1.043,\n> 1.044, 1.047, 1.047, 1.046, 1.047, 1.044, 1.039, 1.035,\n> +            1.045, 1.048, 1.049, 1.053, 1.047, 1.045, 1.041, 1.039,\n> 1.041, 1.042, 1.042, 1.042, 1.041, 1.038, 1.033, 1.028,\n> +            1.032, 1.045, 1.047, 1.047, 1.042, 1.039, 1.036, 1.035,\n> 1.036, 1.037, 1.039, 1.039, 1.039, 1.034, 1.028, 1.021,\n> +            1.022, 1.031, 1.038, 1.038, 1.035, 1.034, 1.033, 1.032,\n> 1.031, 1.031, 1.037, 1.038, 1.041, 1.033, 1.021, 1.013,\n> +            1.012, 1.021, 1.025, 1.027, 1.027, 1.028, 1.028, 1.027,\n> 1.025, 1.024, 1.024, 1.029, 1.038, 1.028, 1.012, 1.004,\n> +            1.011, 1.012, 1.017, 1.021, 1.021, 1.022, 1.021, 1.021,\n> 1.021, 1.019, 1.017, 1.023, 1.028, 1.013, 1.004, 1.001\n>          ],\n> -        \"sigma\": 0.005,\n> -        \"sigma_Cb\": 0.005\n> +        \"sigma\": 0.00063,\n> +        \"sigma_Cb\": 0.00089\n>      },\n>      \"rpi.contrast\":\n>      {\n> @@ -185,6 +291,66 @@\n>              65535, 65535\n>          ]\n>      },\n> +    \"rpi.ccm\":\n> +    {\n> +        \"ccms\":\n> +        [\n> +            {\n> +                \"ct\": 2861, \"ccm\":\n> +                [\n> +                    1.61339, -0.55137, -0.06202, -0.24235, 1.42738,\n> -0.18503, 0.07817, -0.77121, 1.69304\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 2915, \"ccm\":\n> +                [\n> +                    1.64366, -0.57014, -0.07352, -0.27249, 1.48118,\n> -0.20869, 0.08973, -0.78375, 1.69402\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 2916, \"ccm\":\n> +                [\n> +                    1.59805, -0.49622, -0.10183, -0.17981, 1.25627,\n> -0.07646, -0.00104, -0.62299, 1.62404\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 2922, \"ccm\":\n> +                [\n> +                    1.61099, -0.52067, -0.09032, -0.19271, 1.28084,\n> -0.08813, 0.01453, -0.65247, 1.63794\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 2934, \"ccm\":\n> +                [\n> +                    1.60849, -0.51603, -0.09246, -0.19148, 1.28129,\n> -0.08981, 0.01142, -0.64365, 1.63224\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 3626, \"ccm\":\n> +                [\n> +                    1.62525, -0.59206, -0.03319, -0.20241, 1.42135,\n> -0.21895, 0.05845, -0.66941, 1.61096\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 4617, \"ccm\":\n> +                [\n> +                    1.62324, -0.66976, 0.04652, -0.16629, 1.56915,\n> -0.40287, 0.07878, -0.73116, 1.65238\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 5674, \"ccm\":\n> +                [\n> +                    1.66733, -0.68927, 0.02194, -0.13995, 1.47994,\n> -0.33998, 0.04474, -0.61721, 1.57247\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 7617, \"ccm\":\n> +                [\n> +                    1.53155, -0.66311, 0.13157, -0.03271, 1.65915,\n> -0.62645, 0.07635, -1.01009, 1.93374\n> +                ]\n> +            }\n> +        ]\n> +    },\n>      \"rpi.sharpen\":\n>      {\n>      }\n> --\n> 2.25.1\n>\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E7CBCBD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 14 Jul 2022 09:45:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 59F906330E;\n\tThu, 14 Jul 2022 11:45:11 +0200 (CEST)","from mail-lf1-x134.google.com (mail-lf1-x134.google.com\n\t[IPv6:2a00:1450:4864:20::134])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC93163309\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 14 Jul 2022 11:45:09 +0200 (CEST)","by mail-lf1-x134.google.com with SMTP id bu42so1962177lfb.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 14 Jul 2022 02:45:09 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657791911;\n\tbh=s4cPLblVQBKuoiirEFIrmBQDtfCi+1EAzUicCZEnW5A=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=v2gKrJc7WNwQnxXWD2UFBVTOKyeT+azzBjqkZEQvINGY+K6SB7gClBecip57z+saJ\n\tmxSGNm5kb5+X6JEnFF+APjKKCJSm6o2k5+1THZhqO++jRYTKJrylGnBe1xJkdFR2Lm\n\tCkH4jT9GeiwYY/1ItLCCLwUYxX8/7iUXxfPF8Xcjv6dukoun7jWXlhixogbqdMHQrI\n\tDaT8wLg0wd7tkJJ9Am4iVqYcnpkJWogcH3RPJ/nw8AcHd27IoyXCZu2xIaXJk2y+oE\n\tq68na0z5VicWJNhfwj1WcJo/N1G8/WK/cAeJbb5JXg4EGHSK0ALBPaqcWuIR5PkBZ6\n\tHhft9+Ev0vvaQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=fEwglgE8AHd5J+NakS6SZ/vSlzO+xEvDufk+wDefeJw=;\n\tb=lUUV0OcGYEzlLZIlrLAFvxd1uhMO7FfH1x7+UrWxoihmcpxekLYbHvy2ig4Q0M6JTU\n\tB4loz+rlM3uZ+9HlpjrcF9bmrjEVbR9rnUq+k9eFQU93kW5eqdo3Q3bUimEEKkJTdO2M\n\tdtlU5V60ojkSgVnhwEa5zoG62RGaP/wElVpcjDF0UWs4vTER9m9npqTun9v1CxjouTAi\n\tRXscTaaAHmmwb7OJdbDnO5IFG6boYVJhb0/AoeqqBAeaLDjN3UZCtrH7cKnyQpVdW7gk\n\tKO5o1cdohafCFUBxjMrFRX2S5kw7nzA1qpVnbxVrVEwDn67nlqPvZVYthdMds5v0C9Or\n\t1VoA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"lUUV0OcG\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=fEwglgE8AHd5J+NakS6SZ/vSlzO+xEvDufk+wDefeJw=;\n\tb=f0hJwNpVfZYJqfmrwpjmF08hRLTwTKcCYgZzyhhvOdyuR0usrnO2b/SGqrD6XqF+zV\n\tKyuszzXBS714H74zow3vYdqXXE9hiYOtUYiX+Loi6vBD2KSGeNMXHWmw9oaQMwYXAVMF\n\tCvym2xBci9lBXqsvcLYrNq/pXBO2RGr4ZMWWMbB2A/ddCXZ67/zN6nbGnhtLmeEAf/fP\n\tu+R01PtnDJpwfk4AE9Xpx2kdYfe1HpbwCvbcSp6QRL5g0a9gtZknmYqoOcSEflIspoJ1\n\t//yg8FrMwmoIPKGl/DQuJHR0eZgK9iCgoiqQ+sgOPP/o1CnEQWyASby7taF9SsWkLTx6\n\tsE0Q==","X-Gm-Message-State":"AJIora8q3/kIk534CpDkWHRTORLibJ61FV8NV8k2Rs5te/BXLgeZ3sLI\n\tSqc2tErejzJM7jL1m63ZUkgET5sgdp52cVBLSOhcoQ==","X-Google-Smtp-Source":"AGRyM1vlQoPtdnth+Cv3K9dAl1RdgV1qzzUCC67keAZR+QbuXOTk52l6Jto8SIVVLyHsGAzTvAsA9wfwHZSr6t3umPY=","X-Received":"by 2002:a05:6512:3ba2:b0:48a:1acd:90f2 with SMTP id\n\tg34-20020a0565123ba200b0048a1acd90f2mr730658lfv.510.1657791908860;\n\tThu, 14 Jul 2022 02:45:08 -0700 (PDT)","MIME-Version":"1.0","References":"<20220714094143.4399-1-william.vinnicombe@raspberrypi.com>\n\t<20220714094143.4399-2-william.vinnicombe@raspberrypi.com>","In-Reply-To":"<20220714094143.4399-2-william.vinnicombe@raspberrypi.com>","Date":"Thu, 14 Jul 2022 10:45:01 +0100","Message-ID":"<CAEmqJPo6X4MfLo4zcGQ-n6Dg4bWZBmtLFJ7izsOiSjOLzMcCGg@mail.gmail.com>","To":"William Vinnicombe <william.vinnicombe@raspberrypi.com>","Content-Type":"multipart/alternative; boundary=\"000000000000d6ee2005e3c0c181\"","Subject":"Re: [libcamera-devel] [PATCH 1/1] ipa: raspberrypi: Update imx296\n\ttuning file","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Naushir Patuck <naush@raspberrypi.com>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":23901,"web_url":"https://patchwork.libcamera.org/comment/23901/","msgid":"<YtCxYOESDACUu3CC@pendragon.ideasonboard.com>","date":"2022-07-15T00:14:24","subject":"Re: [libcamera-devel] [PATCH 1/1] ipa: raspberrypi: Update imx296\n\ttuning file","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi William,\n\nThank you for the patch.\n\nOn Thu, Jul 14, 2022 at 10:41:43AM +0100, William Vinnicombe via libcamera-devel wrote:\n> From: William Vinnicombe <william.vinnicombe@raspberrypi.com>\n> \n> The previous tuning values for the imx296 are not accurate, and do not\n> contain awb parameters.\n\nThere was a reason for that though, the file was meant for the\nmonochrome version of the sensor. See [1] for the full context. I'm\nactually aware of one user of this tuning file with a monochrome sensor,\nand this patch will break this use case.\n\nThis brings nack the question that we decided to leave unanswered when\nthe imx296.json file was merged: how do we deal with different modules\nthat integrated the same camera sensor ?\n\n[1] https://lists.libcamera.org/pipermail/libcamera-devel/2022-January/028756.html\n\n> Update the tuning file using the raspberrypi ctt tool to give accurate\n> values, and all required parameters.\n> \n> Signed-off-by: William Vinnicombe <william.vinnicombe@raspberrypi.com>\n> ---\n>  src/ipa/raspberrypi/data/imx296.json | 268 ++++++++++++++++++++++-----\n>  1 file changed, 217 insertions(+), 51 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/data/imx296.json b/src/ipa/raspberrypi/data/imx296.json\n> index 837feff5..4d9d0e8b 100644\n> --- a/src/ipa/raspberrypi/data/imx296.json\n> +++ b/src/ipa/raspberrypi/data/imx296.json\n> @@ -8,25 +8,97 @@\n>      },\n>      \"rpi.lux\":\n>      {\n> -        \"reference_shutter_speed\": 19184,\n> -        \"reference_gain\": 1.0,\n> +        \"reference_shutter_speed\": 17895,\n> +        \"reference_gain\": 1.99,\n>          \"reference_aperture\": 1.0,\n> -        \"reference_lux\": 432,\n> -        \"reference_Y\": 13773\n> +        \"reference_lux\": 1147,\n> +        \"reference_Y\": 13348\n>      },\n>      \"rpi.noise\":\n>      {\n> -        \"reference_constant\": 0,\n> -        \"reference_slope\": 2.957\n> +        \"reference_constant\": 1,\n> +        \"reference_slope\": 2.631\n>      },\n>      \"rpi.geq\":\n>      {\n> -        \"offset\": 185,\n> -        \"slope\": 0.0105\n> +        \"offset\": 182,\n> +        \"slope\": 0.0127\n>      },\n>      \"rpi.sdn\":\n>      {\n>      },\n> +    \"rpi.awb\":\n> +    {\n> +        \"priors\":\n> +        [\n> +            {\n> +                \"lux\": 0, \"prior\":\n> +                [\n> +                    2000, 1.0, 3000, 0.0, 13000, 0.0\n> +                ]\n> +            },\n> +            {\n> +                \"lux\": 800, \"prior\":\n> +                [\n> +                    2000, 0.0, 6000, 2.0, 13000, 2.0\n> +                ]\n> +            },\n> +            {\n> +                \"lux\": 1500, \"prior\":\n> +                [\n> +                    2000, 0.0, 4000, 1.0, 6000, 6.0, 6500, 7.0, 7000, 1.0, 13000, 1.0\n> +                ]\n> +            }\n> +        ],\n> +        \"modes\":\n> +        {\n> +            \"auto\":\n> +            {\n> +                \"lo\": 2500,\n> +                \"hi\": 8000\n> +            },\n> +            \"incandescent\":\n> +            {\n> +                \"lo\": 2500,\n> +                \"hi\": 3000\n> +            },\n> +            \"tungsten\":\n> +            {\n> +                \"lo\": 3000,\n> +                \"hi\": 3500\n> +            },\n> +            \"fluorescent\":\n> +            {\n> +                \"lo\": 4000,\n> +                \"hi\": 4700\n> +            },\n> +            \"indoor\":\n> +            {\n> +                \"lo\": 3000,\n> +                \"hi\": 5000\n> +            },\n> +            \"daylight\":\n> +            {\n> +                \"lo\": 5500,\n> +                \"hi\": 6500\n> +            },\n> +            \"cloudy\":\n> +            {\n> +                \"lo\": 7000,\n> +                \"hi\": 8600\n> +            }\n> +        },\n> +        \"bayes\": 1,\n> +        \"ct_curve\":\n> +        [\n> +            2861.0, 0.4281, 0.2614, 2915.0, 0.4266, 0.2639, 2916.0, 0.4112, 0.2913, 2934.0, 0.4099, 0.2935, 3626.0, 0.3604, 0.3777, 4617.0,\n> +            0.2776, 0.5093, 5674.0, 0.2567, 0.5409, 7617.0, 0.1789, 0.6527\n> +        ],\n> +        \"sensitivity_r\": 1.0,\n> +        \"sensitivity_b\": 1.0,\n> +        \"transverse_pos\": 0.02994,\n> +        \"transverse_neg\": 0.04332\n> +    },\n>      \"rpi.agc\":\n>      {\n>          \"metering_modes\":\n> @@ -113,65 +185,99 @@\n>      \"rpi.alsc\":\n>      {\n>          \"omega\": 1.3,\n> -        \"n_iter\": 0,\n> +        \"n_iter\": 100,\n>          \"luminance_strength\": 0.5,\n>          \"calibrations_Cr\":\n>          [\n>              {\n> -                \"ct\": 4000, \"table\":\n> -                [\n> -                    2.554, 2.554, 2.541, 2.534, 2.495, 2.506, 2.516, 2.517, 2.518, 2.515, 2.513, 2.495, 2.481, 2.533, 2.533, 2.521,\n> -                    2.522, 2.534, 2.539, 2.531, 2.531, 2.506, 2.506, 2.513, 2.513, 2.509, 2.498, 2.496, 2.508, 2.517, 2.521, 2.521,\n> -                    2.509, 2.517, 2.534, 2.529, 2.531, 2.521, 2.517, 2.517, 2.515, 2.514, 2.506, 2.499, 2.508, 2.508, 2.521, 2.537,\n> -                    2.507, 2.508, 2.517, 2.516, 2.495, 2.487, 2.519, 2.534, 2.535, 2.531, 2.499, 2.494, 2.501, 2.511, 2.526, 2.526,\n> -                    2.509, 2.517, 2.507, 2.501, 2.494, 2.519, 2.539, 2.539, 2.537, 2.537, 2.533, 2.499, 2.503, 2.511, 2.529, 2.525,\n> -                    2.521, 2.522, 2.476, 2.501, 2.501, 2.539, 2.546, 2.538, 2.531, 2.538, 2.541, 2.531, 2.529, 2.526, 2.529, 2.525,\n> -                    2.516, 2.519, 2.469, 2.499, 2.499, 2.543, 2.543, 2.531, 2.528, 2.534, 2.541, 2.535, 2.531, 2.526, 2.531, 2.528,\n> -                    2.509, 2.515, 2.465, 2.487, 2.487, 2.539, 2.543, 2.539, 2.533, 2.549, 2.542, 2.531, 2.529, 2.524, 2.532, 2.533,\n> -                    2.499, 2.499, 2.475, 2.482, 2.471, 2.509, 2.539, 2.544, 2.543, 2.545, 2.533, 2.498, 2.521, 2.521, 2.537, 2.536,\n> -                    2.499, 2.488, 2.488, 2.488, 2.471, 2.462, 2.509, 2.539, 2.539, 2.532, 2.498, 2.498, 2.518, 2.518, 2.539, 2.539,\n> -                    2.483, 2.484, 2.488, 2.488, 2.502, 2.496, 2.508, 2.514, 2.518, 2.517, 2.521, 2.518, 2.518, 2.518, 2.525, 2.539,\n> -                    2.483, 2.487, 2.478, 2.478, 2.507, 2.509, 2.514, 2.513, 2.514, 2.517, 2.536, 2.559, 2.501, 2.501, 2.503, 2.525\n> +                \"ct\": 2943, \"table\":\n> +                [\n> +                    2.153, 2.154, 2.154, 2.153, 2.153, 2.153, 2.153, 2.151, 2.151, 2.149, 2.149, 2.149, 2.149, 2.149, 2.151, 2.153,\n> +                    2.154, 2.155, 2.155, 2.154, 2.154, 2.154, 2.153, 2.152, 2.151, 2.149, 2.149, 2.149, 2.149, 2.149, 2.151, 2.152,\n> +                    2.155, 2.155, 2.155, 2.154, 2.154, 2.154, 2.153, 2.151, 2.151, 2.149, 2.149, 2.149, 2.149, 2.149, 2.151, 2.152,\n> +                    2.154, 2.154, 2.155, 2.153, 2.153, 2.153, 2.152, 2.151, 2.149, 2.149, 2.149, 2.149, 2.148, 2.148, 2.149, 2.151,\n> +                    2.153, 2.153, 2.153, 2.152, 2.152, 2.152, 2.151, 2.149, 2.149, 2.149, 2.149, 2.148, 2.148, 2.148, 2.149, 2.151,\n> +                    2.153, 2.153, 2.152, 2.152, 2.152, 2.152, 2.151, 2.149, 2.149, 2.148, 2.148, 2.148, 2.147, 2.147, 2.148, 2.149,\n> +                    2.152, 2.153, 2.152, 2.151, 2.151, 2.151, 2.151, 2.151, 2.149, 2.148, 2.148, 2.147, 2.147, 2.147, 2.148, 2.149,\n> +                    2.152, 2.152, 2.152, 2.151, 2.151, 2.151, 2.151, 2.149, 2.148, 2.147, 2.146, 2.147, 2.147, 2.148, 2.149, 2.151,\n> +                    2.152, 2.152, 2.152, 2.151, 2.151, 2.151, 2.151, 2.151, 2.149, 2.147, 2.146, 2.147, 2.148, 2.149, 2.152, 2.152,\n> +                    2.152, 2.154, 2.154, 2.152, 2.152, 2.152, 2.152, 2.151, 2.151, 2.149, 2.149, 2.149, 2.151, 2.152, 2.153, 2.153,\n> +                    2.155, 2.156, 2.155, 2.154, 2.152, 2.152, 2.152, 2.151, 2.151, 2.149, 2.149, 2.149, 2.151, 2.152, 2.153, 2.153,\n> +                    2.155, 2.155, 2.155, 2.154, 2.152, 2.151, 2.151, 2.149, 2.148, 2.148, 2.149, 2.149, 2.151, 2.152, 2.152, 2.154\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 6097, \"table\":\n> +                [\n> +                    3.604, 3.605, 3.607, 3.605, 3.604, 3.604, 3.603, 3.602, 3.598, 3.594, 3.593, 3.593, 3.593, 3.593, 3.596, 3.602,\n> +                    3.604, 3.607, 3.611, 3.609, 3.609, 3.608, 3.606, 3.602, 3.599, 3.596, 3.596, 3.594, 3.594, 3.594, 3.598, 3.602,\n> +                    3.606, 3.611, 3.612, 3.609, 3.611, 3.609, 3.608, 3.602, 3.599, 3.597, 3.596, 3.595, 3.594, 3.594, 3.597, 3.599,\n> +                    3.606, 3.609, 3.611, 3.607, 3.607, 3.606, 3.603, 3.599, 3.597, 3.595, 3.595, 3.593, 3.593, 3.592, 3.593, 3.596,\n> +                    3.604, 3.607, 3.607, 3.604, 3.603, 3.602, 3.599, 3.597, 3.596, 3.595, 3.595, 3.594, 3.592, 3.591, 3.591, 3.594,\n> +                    3.606, 3.607, 3.606, 3.604, 3.602, 3.601, 3.599, 3.597, 3.597, 3.596, 3.596, 3.595, 3.593, 3.591, 3.589, 3.592,\n> +                    3.604, 3.606, 3.605, 3.603, 3.602, 3.602, 3.599, 3.598, 3.596, 3.595, 3.595, 3.595, 3.591, 3.589, 3.591, 3.592,\n> +                    3.604, 3.604, 3.605, 3.602, 3.601, 3.601, 3.599, 3.598, 3.597, 3.595, 3.593, 3.591, 3.589, 3.591, 3.592, 3.596,\n> +                    3.604, 3.605, 3.606, 3.602, 3.601, 3.601, 3.601, 3.599, 3.597, 3.595, 3.593, 3.591, 3.589, 3.594, 3.598, 3.599,\n> +                    3.609, 3.613, 3.615, 3.611, 3.609, 3.609, 3.608, 3.605, 3.603, 3.599, 3.598, 3.597, 3.598, 3.601, 3.603, 3.603,\n> +                    3.613, 3.616, 3.616, 3.613, 3.609, 3.609, 3.608, 3.606, 3.604, 3.602, 3.599, 3.599, 3.599, 3.602, 3.605, 3.605,\n> +                    3.615, 3.616, 3.616, 3.613, 3.611, 3.604, 3.604, 3.601, 3.601, 3.599, 3.599, 3.599, 3.601, 3.602, 3.604, 3.604\n>                  ]\n>              }\n>          ],\n>          \"calibrations_Cb\":\n>          [\n>              {\n> -                \"ct\": 4000, \"table\":\n> -                [\n> -                    2.619, 2.603, 2.599, 2.597, 2.595, 2.594, 2.589, 2.587, 2.586, 2.589, 2.592, 2.597, 2.601, 2.608, 2.621, 2.621,\n> -                    2.619, 2.615, 2.603, 2.601, 2.596, 2.595, 2.591, 2.589, 2.589, 2.592, 2.599, 2.593, 2.601, 2.613, 2.622, 2.631,\n> -                    2.617, 2.617, 2.612, 2.611, 2.604, 2.598, 2.593, 2.591, 2.592, 2.591, 2.593, 2.595, 2.599, 2.614, 2.623, 2.631,\n> -                    2.624, 2.619, 2.615, 2.612, 2.605, 2.602, 2.597, 2.596, 2.592, 2.592, 2.595, 2.599, 2.602, 2.606, 2.619, 2.624,\n> -                    2.629, 2.627, 2.627, 2.617, 2.609, 2.598, 2.612, 2.623, 2.615, 2.604, 2.589, 2.595, 2.599, 2.608, 2.611, 2.614,\n> -                    2.629, 2.632, 2.637, 2.627, 2.612, 2.612, 2.629, 2.631, 2.628, 2.621, 2.604, 2.597, 2.598, 2.604, 2.609, 2.609,\n> -                    2.635, 2.636, 2.642, 2.628, 2.623, 2.623, 2.636, 2.636, 2.634, 2.628, 2.616, 2.599, 2.597, 2.601, 2.603, 2.601,\n> -                    2.641, 2.639, 2.646, 2.632, 2.627, 2.625, 2.632, 2.635, 2.634, 2.627, 2.614, 2.596, 2.595, 2.599, 2.599, 2.598,\n> -                    2.643, 2.644, 2.651, 2.649, 2.629, 2.617, 2.624, 2.629, 2.625, 2.614, 2.586, 2.599, 2.595, 2.597, 2.592, 2.595,\n> -                    2.645, 2.646, 2.649, 2.649, 2.638, 2.624, 2.616, 2.617, 2.609, 2.604, 2.603, 2.603, 2.595, 2.589, 2.587, 2.592,\n> -                    2.641, 2.643, 2.649, 2.647, 2.638, 2.618, 2.615, 2.608, 2.602, 2.595, 2.596, 2.595, 2.593, 2.584, 2.581, 2.583,\n> -                    2.638, 2.637, 2.647, 2.634, 2.634, 2.618, 2.621, 2.621, 2.611, 2.602, 2.596, 2.583, 2.581, 2.581, 2.576, 2.574\n> +                \"ct\": 2943, \"table\":\n> +                [\n> +                    3.361, 3.369, 3.379, 3.385, 3.391, 3.397, 3.401, 3.401, 3.399, 3.396, 3.394, 3.391, 3.383, 3.382, 3.376, 3.375,\n> +                    3.365, 3.372, 3.381, 3.387, 3.391, 3.398, 3.403, 3.403, 3.402, 3.399, 3.396, 3.392, 3.388, 3.382, 3.378, 3.374,\n> +                    3.366, 3.377, 3.384, 3.388, 3.391, 3.399, 3.403, 3.405, 3.405, 3.401, 3.399, 3.393, 3.388, 3.384, 3.381, 3.374,\n> +                    3.366, 3.378, 3.385, 3.389, 3.394, 3.398, 3.402, 3.405, 3.405, 3.404, 3.399, 3.393, 3.389, 3.385, 3.383, 3.369,\n> +                    3.364, 3.377, 3.383, 3.388, 3.394, 3.398, 3.401, 3.404, 3.404, 3.404, 3.401, 3.394, 3.391, 3.386, 3.383, 3.371,\n> +                    3.361, 3.376, 3.381, 3.387, 3.394, 3.397, 3.401, 3.402, 3.404, 3.403, 3.399, 3.397, 3.391, 3.387, 3.381, 3.371,\n> +                    3.359, 3.373, 3.379, 3.385, 3.394, 3.396, 3.399, 3.401, 3.402, 3.401, 3.398, 3.396, 3.392, 3.385, 3.381, 3.371,\n> +                    3.358, 3.368, 3.376, 3.381, 3.391, 3.395, 3.397, 3.399, 3.399, 3.397, 3.396, 3.392, 3.389, 3.383, 3.378, 3.365,\n> +                    3.357, 3.366, 3.373, 3.379, 3.383, 3.392, 3.394, 3.396, 3.396, 3.393, 3.391, 3.388, 3.386, 3.382, 3.377, 3.365,\n> +                    3.355, 3.362, 3.369, 3.374, 3.379, 3.385, 3.391, 3.393, 3.393, 3.392, 3.388, 3.385, 3.383, 3.379, 3.375, 3.362,\n> +                    3.351, 3.354, 3.363, 3.369, 3.374, 3.379, 3.385, 3.387, 3.391, 3.385, 3.383, 3.382, 3.378, 3.377, 3.363, 3.361,\n> +                    3.351, 3.352, 3.357, 3.359, 3.365, 3.371, 3.374, 3.375, 3.375, 3.375, 3.373, 3.367, 3.366, 3.366, 3.361, 3.362\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 6097, \"table\":\n> +                [\n> +                    1.654, 1.657, 1.662, 1.665, 1.666, 1.669, 1.671, 1.672, 1.671, 1.669, 1.668, 1.666, 1.661, 1.661, 1.658, 1.656,\n> +                    1.655, 1.659, 1.663, 1.665, 1.667, 1.671, 1.672, 1.672, 1.673, 1.671, 1.669, 1.667, 1.663, 1.661, 1.659, 1.656,\n> +                    1.656, 1.661, 1.665, 1.666, 1.668, 1.671, 1.673, 1.673, 1.674, 1.672, 1.669, 1.668, 1.664, 1.662, 1.659, 1.656,\n> +                    1.656, 1.661, 1.665, 1.667, 1.668, 1.671, 1.673, 1.674, 1.674, 1.673, 1.671, 1.668, 1.665, 1.663, 1.661, 1.655,\n> +                    1.656, 1.662, 1.665, 1.667, 1.669, 1.671, 1.673, 1.673, 1.674, 1.672, 1.671, 1.668, 1.665, 1.662, 1.661, 1.656,\n> +                    1.655, 1.661, 1.664, 1.667, 1.669, 1.672, 1.672, 1.673, 1.673, 1.672, 1.671, 1.669, 1.666, 1.662, 1.661, 1.656,\n> +                    1.654, 1.659, 1.663, 1.666, 1.669, 1.671, 1.672, 1.673, 1.673, 1.672, 1.671, 1.669, 1.666, 1.662, 1.661, 1.655,\n> +                    1.653, 1.658, 1.662, 1.664, 1.668, 1.669, 1.672, 1.672, 1.672, 1.671, 1.669, 1.667, 1.665, 1.661, 1.659, 1.653,\n> +                    1.652, 1.656, 1.659, 1.663, 1.666, 1.668, 1.669, 1.671, 1.671, 1.669, 1.667, 1.665, 1.663, 1.659, 1.657, 1.653,\n> +                    1.649, 1.654, 1.658, 1.661, 1.663, 1.666, 1.668, 1.669, 1.668, 1.667, 1.665, 1.663, 1.661, 1.659, 1.657, 1.651,\n> +                    1.646, 1.649, 1.654, 1.658, 1.661, 1.662, 1.664, 1.665, 1.666, 1.664, 1.662, 1.661, 1.659, 1.657, 1.651, 1.648,\n> +                    1.645, 1.646, 1.651, 1.653, 1.655, 1.657, 1.659, 1.659, 1.659, 1.658, 1.657, 1.656, 1.653, 1.653, 1.649, 1.648\n>                  ]\n>              }\n>          ],\n>          \"luminance_lut\":\n>          [\n> -            1.308, 1.293, 1.228, 1.175, 1.139, 1.108, 1.092, 1.082, 1.082, 1.086, 1.097, 1.114, 1.149, 1.199, 1.279, 1.303,\n> -            1.293, 1.249, 1.199, 1.162, 1.136, 1.109, 1.087, 1.077, 1.072, 1.081, 1.095, 1.103, 1.133, 1.172, 1.225, 1.282,\n> -            1.251, 1.212, 1.186, 1.159, 1.129, 1.114, 1.102, 1.088, 1.088, 1.088, 1.095, 1.117, 1.123, 1.158, 1.198, 1.249,\n> -            1.223, 1.192, 1.177, 1.163, 1.147, 1.139, 1.132, 1.112, 1.111, 1.107, 1.113, 1.118, 1.139, 1.155, 1.186, 1.232,\n> -            1.207, 1.186, 1.171, 1.162, 1.168, 1.163, 1.153, 1.138, 1.129, 1.128, 1.132, 1.136, 1.149, 1.167, 1.189, 1.216,\n> -            1.198, 1.186, 1.176, 1.176, 1.177, 1.185, 1.171, 1.157, 1.146, 1.144, 1.146, 1.149, 1.161, 1.181, 1.201, 1.221,\n> -            1.203, 1.181, 1.176, 1.178, 1.191, 1.189, 1.188, 1.174, 1.159, 1.153, 1.158, 1.161, 1.169, 1.185, 1.211, 1.227,\n> -            1.211, 1.179, 1.177, 1.187, 1.194, 1.196, 1.194, 1.187, 1.176, 1.169, 1.171, 1.171, 1.175, 1.189, 1.214, 1.226,\n> -            1.219, 1.182, 1.184, 1.191, 1.195, 1.199, 1.197, 1.194, 1.188, 1.185, 1.179, 1.179, 1.182, 1.194, 1.212, 1.227,\n> -            1.237, 1.192, 1.194, 1.194, 1.198, 1.199, 1.198, 1.197, 1.196, 1.193, 1.189, 1.189, 1.192, 1.203, 1.214, 1.231,\n> -            1.282, 1.199, 1.199, 1.197, 1.199, 1.199, 1.192, 1.193, 1.193, 1.194, 1.196, 1.197, 1.206, 1.216, 1.228, 1.244,\n> -            1.309, 1.236, 1.204, 1.203, 1.202, 1.194, 1.194, 1.188, 1.192, 1.192, 1.199, 1.201, 1.212, 1.221, 1.235, 1.247\n> +            1.054, 1.059, 1.063, 1.063, 1.063, 1.063, 1.062, 1.062, 1.062, 1.062, 1.061, 1.059, 1.056, 1.052, 1.045, 1.043,\n> +            1.055, 1.061, 1.065, 1.064, 1.065, 1.064, 1.063, 1.062, 1.063, 1.063, 1.061, 1.059, 1.057, 1.054, 1.049, 1.045,\n> +            1.057, 1.062, 1.064, 1.063, 1.072, 1.072, 1.072, 1.062, 1.062, 1.062, 1.059, 1.058, 1.056, 1.054, 1.051, 1.047,\n> +            1.058, 1.061, 1.063, 1.061, 1.062, 1.073, 1.073, 1.059, 1.058, 1.057, 1.057, 1.056, 1.055, 1.053, 1.051, 1.047,\n> +            1.057, 1.059, 1.061, 1.059, 1.059, 1.059, 1.054, 1.054, 1.056, 1.056, 1.056, 1.055, 1.054, 1.052, 1.049, 1.043,\n> +            1.055, 1.057, 1.059, 1.057, 1.056, 1.052, 1.049, 1.049, 1.053, 1.054, 1.054, 1.052, 1.051, 1.049, 1.043, 1.041,\n> +            1.049, 1.053, 1.054, 1.055, 1.052, 1.049, 1.045, 1.043, 1.044, 1.047, 1.047, 1.046, 1.047, 1.044, 1.039, 1.035,\n> +            1.045, 1.048, 1.049, 1.053, 1.047, 1.045, 1.041, 1.039, 1.041, 1.042, 1.042, 1.042, 1.041, 1.038, 1.033, 1.028,\n> +            1.032, 1.045, 1.047, 1.047, 1.042, 1.039, 1.036, 1.035, 1.036, 1.037, 1.039, 1.039, 1.039, 1.034, 1.028, 1.021,\n> +            1.022, 1.031, 1.038, 1.038, 1.035, 1.034, 1.033, 1.032, 1.031, 1.031, 1.037, 1.038, 1.041, 1.033, 1.021, 1.013,\n> +            1.012, 1.021, 1.025, 1.027, 1.027, 1.028, 1.028, 1.027, 1.025, 1.024, 1.024, 1.029, 1.038, 1.028, 1.012, 1.004,\n> +            1.011, 1.012, 1.017, 1.021, 1.021, 1.022, 1.021, 1.021, 1.021, 1.019, 1.017, 1.023, 1.028, 1.013, 1.004, 1.001\n>          ],\n> -        \"sigma\": 0.005,\n> -        \"sigma_Cb\": 0.005\n> +        \"sigma\": 0.00063,\n> +        \"sigma_Cb\": 0.00089\n>      },\n>      \"rpi.contrast\":\n>      {\n> @@ -185,6 +291,66 @@\n>              65535, 65535\n>          ]\n>      },\n> +    \"rpi.ccm\":\n> +    {\n> +        \"ccms\":\n> +        [\n> +            {\n> +                \"ct\": 2861, \"ccm\":\n> +                [\n> +                    1.61339, -0.55137, -0.06202, -0.24235, 1.42738, -0.18503, 0.07817, -0.77121, 1.69304\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 2915, \"ccm\":\n> +                [\n> +                    1.64366, -0.57014, -0.07352, -0.27249, 1.48118, -0.20869, 0.08973, -0.78375, 1.69402\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 2916, \"ccm\":\n> +                [\n> +                    1.59805, -0.49622, -0.10183, -0.17981, 1.25627, -0.07646, -0.00104, -0.62299, 1.62404\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 2922, \"ccm\":\n> +                [\n> +                    1.61099, -0.52067, -0.09032, -0.19271, 1.28084, -0.08813, 0.01453, -0.65247, 1.63794\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 2934, \"ccm\":\n> +                [\n> +                    1.60849, -0.51603, -0.09246, -0.19148, 1.28129, -0.08981, 0.01142, -0.64365, 1.63224\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 3626, \"ccm\":\n> +                [\n> +                    1.62525, -0.59206, -0.03319, -0.20241, 1.42135, -0.21895, 0.05845, -0.66941, 1.61096\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 4617, \"ccm\":\n> +                [\n> +                    1.62324, -0.66976, 0.04652, -0.16629, 1.56915, -0.40287, 0.07878, -0.73116, 1.65238\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 5674, \"ccm\":\n> +                [\n> +                    1.66733, -0.68927, 0.02194, -0.13995, 1.47994, -0.33998, 0.04474, -0.61721, 1.57247\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 7617, \"ccm\":\n> +                [\n> +                    1.53155, -0.66311, 0.13157, -0.03271, 1.65915, -0.62645, 0.07635, -1.01009, 1.93374\n> +                ]\n> +            }\n> +        ]\n> +    },\n>      \"rpi.sharpen\":\n>      {\n>      }","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 77788BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 15 Jul 2022 00:14:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA76060489;\n\tFri, 15 Jul 2022 02:14:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A261960489\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Jul 2022 02:14:55 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 218AA9DA;\n\tFri, 15 Jul 2022 02:14:55 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657844096;\n\tbh=e23GgiDzJnD7JDbHkolZgvfU1IpOSTbjE73Gpov428A=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=U6FBnxUCatZmw8E05l4sagCIMxsCIzF3Y1OPEZ5uBTBh2i2H5WCs4ldwn5HctvGnv\n\tgUVG3XENmetXoE6bN1GhnGf5lGU2dNPuVonr5bgNEanio2FxXO6EBsVYCDXyhCUeiC\n\tH2sC6+ClZT5yEIVnnUgWf3gPBnosO+K2Tqy8BXIYLPq9FzQve2+OYchZ+HReykDdYR\n\ttRLAIlodTzBGtX3JGk8TiNzYf5OdiTFQeAtfbSpGPOS/1GOkdVF0ML17oKm6gpOTCr\n\tjZgl9Vd1IVp0lsIkPuM++gFvhbcibtdMQo34q/hd/17Gw6JWfRtdCZwoWWHEX9HBpO\n\tT1SnEysGYUqLA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657844095;\n\tbh=e23GgiDzJnD7JDbHkolZgvfU1IpOSTbjE73Gpov428A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=nzSWi1gnoLcQu69rkdITzIDg6yd561S6gwzCMxSu/4fCQI09uxmxlAj6lgOOm4hG6\n\tKCgp9lb7L3kreD/vPeAg1ntS8XqwtZYhCKg+eVFPaHp8ECBuODVw6nDeHtnnzHSbRI\n\tftOTPRZl3oVS8vbZETzs8oUH2eIbBSG73f1r+ySQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"nzSWi1gn\"; dkim-atps=neutral","Date":"Fri, 15 Jul 2022 03:14:24 +0300","To":"william.vinnicombe@raspberrypi.com","Message-ID":"<YtCxYOESDACUu3CC@pendragon.ideasonboard.com>","References":"<20220714094143.4399-1-william.vinnicombe@raspberrypi.com>\n\t<20220714094143.4399-2-william.vinnicombe@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220714094143.4399-2-william.vinnicombe@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 1/1] ipa: raspberrypi: Update imx296\n\ttuning file","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":23909,"web_url":"https://patchwork.libcamera.org/comment/23909/","msgid":"<CAEmqJPrWeBiOJgfBYWforxr09X8Sk5KAiM9jUOwtH=_TjV+awg@mail.gmail.com>","date":"2022-07-15T07:24:18","subject":"Re: [libcamera-devel] [PATCH 1/1] ipa: raspberrypi: Update imx296\n\ttuning file","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nOn Fri, 15 Jul 2022 at 01:14, Laurent Pinchart via libcamera-devel <\nlibcamera-devel@lists.libcamera.org> wrote:\n\n> Hi William,\n>\n> Thank you for the patch.\n>\n> On Thu, Jul 14, 2022 at 10:41:43AM +0100, William Vinnicombe via\n> libcamera-devel wrote:\n> > From: William Vinnicombe <william.vinnicombe@raspberrypi.com>\n> >\n> > The previous tuning values for the imx296 are not accurate, and do not\n> > contain awb parameters.\n>\n> There was a reason for that though, the file was meant for the\n> monochrome version of the sensor. See [1] for the full context. I'm\n> actually aware of one user of this tuning file with a monochrome sensor,\n> and this patch will break this use case.\n>\n> This brings nack the question that we decided to leave unanswered when\n> the imx296.json file was merged: how do we deal with different modules\n> that integrated the same camera sensor ?\n>\n> [1]\n> https://lists.libcamera.org/pipermail/libcamera-devel/2022-January/028756.html\n\n\nThis is indeed a real problem now.  Our (admittedly very loose) convention\nis to have\nthe <sensor_name>.json file be the full colour variant, and any offshoot be\nnamed as\n<sensor_name>_<variant>.json.  Would we be able to give a heads-up and help\nthis\nuser switch to imx296_mono.json?  They would also benefit from the new\ntuning with\nupdated noise and sharpening IQ performance.\n\nThe difficult bit is how to choose a variant json without user\nintervention? Do we add\na variant parameter in devicetree?  Some modules may have eeproms or ids\nthat can\nstore this, but I don't think there is a mechanism to return this\ninformation to userland\nfrom v4l2...?\n\nNaush\n\n\n>\n>\n> > Update the tuning file using the raspberrypi ctt tool to give accurate\n> > values, and all required parameters.\n> >\n> > Signed-off-by: William Vinnicombe <william.vinnicombe@raspberrypi.com>\n> > ---\n> >  src/ipa/raspberrypi/data/imx296.json | 268 ++++++++++++++++++++++-----\n> >  1 file changed, 217 insertions(+), 51 deletions(-)\n> >\n> > diff --git a/src/ipa/raspberrypi/data/imx296.json\n> b/src/ipa/raspberrypi/data/imx296.json\n> > index 837feff5..4d9d0e8b 100644\n> > --- a/src/ipa/raspberrypi/data/imx296.json\n> > +++ b/src/ipa/raspberrypi/data/imx296.json\n> > @@ -8,25 +8,97 @@\n> >      },\n> >      \"rpi.lux\":\n> >      {\n> > -        \"reference_shutter_speed\": 19184,\n> > -        \"reference_gain\": 1.0,\n> > +        \"reference_shutter_speed\": 17895,\n> > +        \"reference_gain\": 1.99,\n> >          \"reference_aperture\": 1.0,\n> > -        \"reference_lux\": 432,\n> > -        \"reference_Y\": 13773\n> > +        \"reference_lux\": 1147,\n> > +        \"reference_Y\": 13348\n> >      },\n> >      \"rpi.noise\":\n> >      {\n> > -        \"reference_constant\": 0,\n> > -        \"reference_slope\": 2.957\n> > +        \"reference_constant\": 1,\n> > +        \"reference_slope\": 2.631\n> >      },\n> >      \"rpi.geq\":\n> >      {\n> > -        \"offset\": 185,\n> > -        \"slope\": 0.0105\n> > +        \"offset\": 182,\n> > +        \"slope\": 0.0127\n> >      },\n> >      \"rpi.sdn\":\n> >      {\n> >      },\n> > +    \"rpi.awb\":\n> > +    {\n> > +        \"priors\":\n> > +        [\n> > +            {\n> > +                \"lux\": 0, \"prior\":\n> > +                [\n> > +                    2000, 1.0, 3000, 0.0, 13000, 0.0\n> > +                ]\n> > +            },\n> > +            {\n> > +                \"lux\": 800, \"prior\":\n> > +                [\n> > +                    2000, 0.0, 6000, 2.0, 13000, 2.0\n> > +                ]\n> > +            },\n> > +            {\n> > +                \"lux\": 1500, \"prior\":\n> > +                [\n> > +                    2000, 0.0, 4000, 1.0, 6000, 6.0, 6500, 7.0, 7000,\n> 1.0, 13000, 1.0\n> > +                ]\n> > +            }\n> > +        ],\n> > +        \"modes\":\n> > +        {\n> > +            \"auto\":\n> > +            {\n> > +                \"lo\": 2500,\n> > +                \"hi\": 8000\n> > +            },\n> > +            \"incandescent\":\n> > +            {\n> > +                \"lo\": 2500,\n> > +                \"hi\": 3000\n> > +            },\n> > +            \"tungsten\":\n> > +            {\n> > +                \"lo\": 3000,\n> > +                \"hi\": 3500\n> > +            },\n> > +            \"fluorescent\":\n> > +            {\n> > +                \"lo\": 4000,\n> > +                \"hi\": 4700\n> > +            },\n> > +            \"indoor\":\n> > +            {\n> > +                \"lo\": 3000,\n> > +                \"hi\": 5000\n> > +            },\n> > +            \"daylight\":\n> > +            {\n> > +                \"lo\": 5500,\n> > +                \"hi\": 6500\n> > +            },\n> > +            \"cloudy\":\n> > +            {\n> > +                \"lo\": 7000,\n> > +                \"hi\": 8600\n> > +            }\n> > +        },\n> > +        \"bayes\": 1,\n> > +        \"ct_curve\":\n> > +        [\n> > +            2861.0, 0.4281, 0.2614, 2915.0, 0.4266, 0.2639, 2916.0,\n> 0.4112, 0.2913, 2934.0, 0.4099, 0.2935, 3626.0, 0.3604, 0.3777, 4617.0,\n> > +            0.2776, 0.5093, 5674.0, 0.2567, 0.5409, 7617.0, 0.1789,\n> 0.6527\n> > +        ],\n> > +        \"sensitivity_r\": 1.0,\n> > +        \"sensitivity_b\": 1.0,\n> > +        \"transverse_pos\": 0.02994,\n> > +        \"transverse_neg\": 0.04332\n> > +    },\n> >      \"rpi.agc\":\n> >      {\n> >          \"metering_modes\":\n> > @@ -113,65 +185,99 @@\n> >      \"rpi.alsc\":\n> >      {\n> >          \"omega\": 1.3,\n> > -        \"n_iter\": 0,\n> > +        \"n_iter\": 100,\n> >          \"luminance_strength\": 0.5,\n> >          \"calibrations_Cr\":\n> >          [\n> >              {\n> > -                \"ct\": 4000, \"table\":\n> > -                [\n> > -                    2.554, 2.554, 2.541, 2.534, 2.495, 2.506, 2.516,\n> 2.517, 2.518, 2.515, 2.513, 2.495, 2.481, 2.533, 2.533, 2.521,\n> > -                    2.522, 2.534, 2.539, 2.531, 2.531, 2.506, 2.506,\n> 2.513, 2.513, 2.509, 2.498, 2.496, 2.508, 2.517, 2.521, 2.521,\n> > -                    2.509, 2.517, 2.534, 2.529, 2.531, 2.521, 2.517,\n> 2.517, 2.515, 2.514, 2.506, 2.499, 2.508, 2.508, 2.521, 2.537,\n> > -                    2.507, 2.508, 2.517, 2.516, 2.495, 2.487, 2.519,\n> 2.534, 2.535, 2.531, 2.499, 2.494, 2.501, 2.511, 2.526, 2.526,\n> > -                    2.509, 2.517, 2.507, 2.501, 2.494, 2.519, 2.539,\n> 2.539, 2.537, 2.537, 2.533, 2.499, 2.503, 2.511, 2.529, 2.525,\n> > -                    2.521, 2.522, 2.476, 2.501, 2.501, 2.539, 2.546,\n> 2.538, 2.531, 2.538, 2.541, 2.531, 2.529, 2.526, 2.529, 2.525,\n> > -                    2.516, 2.519, 2.469, 2.499, 2.499, 2.543, 2.543,\n> 2.531, 2.528, 2.534, 2.541, 2.535, 2.531, 2.526, 2.531, 2.528,\n> > -                    2.509, 2.515, 2.465, 2.487, 2.487, 2.539, 2.543,\n> 2.539, 2.533, 2.549, 2.542, 2.531, 2.529, 2.524, 2.532, 2.533,\n> > -                    2.499, 2.499, 2.475, 2.482, 2.471, 2.509, 2.539,\n> 2.544, 2.543, 2.545, 2.533, 2.498, 2.521, 2.521, 2.537, 2.536,\n> > -                    2.499, 2.488, 2.488, 2.488, 2.471, 2.462, 2.509,\n> 2.539, 2.539, 2.532, 2.498, 2.498, 2.518, 2.518, 2.539, 2.539,\n> > -                    2.483, 2.484, 2.488, 2.488, 2.502, 2.496, 2.508,\n> 2.514, 2.518, 2.517, 2.521, 2.518, 2.518, 2.518, 2.525, 2.539,\n> > -                    2.483, 2.487, 2.478, 2.478, 2.507, 2.509, 2.514,\n> 2.513, 2.514, 2.517, 2.536, 2.559, 2.501, 2.501, 2.503, 2.525\n> > +                \"ct\": 2943, \"table\":\n> > +                [\n> > +                    2.153, 2.154, 2.154, 2.153, 2.153, 2.153, 2.153,\n> 2.151, 2.151, 2.149, 2.149, 2.149, 2.149, 2.149, 2.151, 2.153,\n> > +                    2.154, 2.155, 2.155, 2.154, 2.154, 2.154, 2.153,\n> 2.152, 2.151, 2.149, 2.149, 2.149, 2.149, 2.149, 2.151, 2.152,\n> > +                    2.155, 2.155, 2.155, 2.154, 2.154, 2.154, 2.153,\n> 2.151, 2.151, 2.149, 2.149, 2.149, 2.149, 2.149, 2.151, 2.152,\n> > +                    2.154, 2.154, 2.155, 2.153, 2.153, 2.153, 2.152,\n> 2.151, 2.149, 2.149, 2.149, 2.149, 2.148, 2.148, 2.149, 2.151,\n> > +                    2.153, 2.153, 2.153, 2.152, 2.152, 2.152, 2.151,\n> 2.149, 2.149, 2.149, 2.149, 2.148, 2.148, 2.148, 2.149, 2.151,\n> > +                    2.153, 2.153, 2.152, 2.152, 2.152, 2.152, 2.151,\n> 2.149, 2.149, 2.148, 2.148, 2.148, 2.147, 2.147, 2.148, 2.149,\n> > +                    2.152, 2.153, 2.152, 2.151, 2.151, 2.151, 2.151,\n> 2.151, 2.149, 2.148, 2.148, 2.147, 2.147, 2.147, 2.148, 2.149,\n> > +                    2.152, 2.152, 2.152, 2.151, 2.151, 2.151, 2.151,\n> 2.149, 2.148, 2.147, 2.146, 2.147, 2.147, 2.148, 2.149, 2.151,\n> > +                    2.152, 2.152, 2.152, 2.151, 2.151, 2.151, 2.151,\n> 2.151, 2.149, 2.147, 2.146, 2.147, 2.148, 2.149, 2.152, 2.152,\n> > +                    2.152, 2.154, 2.154, 2.152, 2.152, 2.152, 2.152,\n> 2.151, 2.151, 2.149, 2.149, 2.149, 2.151, 2.152, 2.153, 2.153,\n> > +                    2.155, 2.156, 2.155, 2.154, 2.152, 2.152, 2.152,\n> 2.151, 2.151, 2.149, 2.149, 2.149, 2.151, 2.152, 2.153, 2.153,\n> > +                    2.155, 2.155, 2.155, 2.154, 2.152, 2.151, 2.151,\n> 2.149, 2.148, 2.148, 2.149, 2.149, 2.151, 2.152, 2.152, 2.154\n> > +                ]\n> > +            },\n> > +            {\n> > +                \"ct\": 6097, \"table\":\n> > +                [\n> > +                    3.604, 3.605, 3.607, 3.605, 3.604, 3.604, 3.603,\n> 3.602, 3.598, 3.594, 3.593, 3.593, 3.593, 3.593, 3.596, 3.602,\n> > +                    3.604, 3.607, 3.611, 3.609, 3.609, 3.608, 3.606,\n> 3.602, 3.599, 3.596, 3.596, 3.594, 3.594, 3.594, 3.598, 3.602,\n> > +                    3.606, 3.611, 3.612, 3.609, 3.611, 3.609, 3.608,\n> 3.602, 3.599, 3.597, 3.596, 3.595, 3.594, 3.594, 3.597, 3.599,\n> > +                    3.606, 3.609, 3.611, 3.607, 3.607, 3.606, 3.603,\n> 3.599, 3.597, 3.595, 3.595, 3.593, 3.593, 3.592, 3.593, 3.596,\n> > +                    3.604, 3.607, 3.607, 3.604, 3.603, 3.602, 3.599,\n> 3.597, 3.596, 3.595, 3.595, 3.594, 3.592, 3.591, 3.591, 3.594,\n> > +                    3.606, 3.607, 3.606, 3.604, 3.602, 3.601, 3.599,\n> 3.597, 3.597, 3.596, 3.596, 3.595, 3.593, 3.591, 3.589, 3.592,\n> > +                    3.604, 3.606, 3.605, 3.603, 3.602, 3.602, 3.599,\n> 3.598, 3.596, 3.595, 3.595, 3.595, 3.591, 3.589, 3.591, 3.592,\n> > +                    3.604, 3.604, 3.605, 3.602, 3.601, 3.601, 3.599,\n> 3.598, 3.597, 3.595, 3.593, 3.591, 3.589, 3.591, 3.592, 3.596,\n> > +                    3.604, 3.605, 3.606, 3.602, 3.601, 3.601, 3.601,\n> 3.599, 3.597, 3.595, 3.593, 3.591, 3.589, 3.594, 3.598, 3.599,\n> > +                    3.609, 3.613, 3.615, 3.611, 3.609, 3.609, 3.608,\n> 3.605, 3.603, 3.599, 3.598, 3.597, 3.598, 3.601, 3.603, 3.603,\n> > +                    3.613, 3.616, 3.616, 3.613, 3.609, 3.609, 3.608,\n> 3.606, 3.604, 3.602, 3.599, 3.599, 3.599, 3.602, 3.605, 3.605,\n> > +                    3.615, 3.616, 3.616, 3.613, 3.611, 3.604, 3.604,\n> 3.601, 3.601, 3.599, 3.599, 3.599, 3.601, 3.602, 3.604, 3.604\n> >                  ]\n> >              }\n> >          ],\n> >          \"calibrations_Cb\":\n> >          [\n> >              {\n> > -                \"ct\": 4000, \"table\":\n> > -                [\n> > -                    2.619, 2.603, 2.599, 2.597, 2.595, 2.594, 2.589,\n> 2.587, 2.586, 2.589, 2.592, 2.597, 2.601, 2.608, 2.621, 2.621,\n> > -                    2.619, 2.615, 2.603, 2.601, 2.596, 2.595, 2.591,\n> 2.589, 2.589, 2.592, 2.599, 2.593, 2.601, 2.613, 2.622, 2.631,\n> > -                    2.617, 2.617, 2.612, 2.611, 2.604, 2.598, 2.593,\n> 2.591, 2.592, 2.591, 2.593, 2.595, 2.599, 2.614, 2.623, 2.631,\n> > -                    2.624, 2.619, 2.615, 2.612, 2.605, 2.602, 2.597,\n> 2.596, 2.592, 2.592, 2.595, 2.599, 2.602, 2.606, 2.619, 2.624,\n> > -                    2.629, 2.627, 2.627, 2.617, 2.609, 2.598, 2.612,\n> 2.623, 2.615, 2.604, 2.589, 2.595, 2.599, 2.608, 2.611, 2.614,\n> > -                    2.629, 2.632, 2.637, 2.627, 2.612, 2.612, 2.629,\n> 2.631, 2.628, 2.621, 2.604, 2.597, 2.598, 2.604, 2.609, 2.609,\n> > -                    2.635, 2.636, 2.642, 2.628, 2.623, 2.623, 2.636,\n> 2.636, 2.634, 2.628, 2.616, 2.599, 2.597, 2.601, 2.603, 2.601,\n> > -                    2.641, 2.639, 2.646, 2.632, 2.627, 2.625, 2.632,\n> 2.635, 2.634, 2.627, 2.614, 2.596, 2.595, 2.599, 2.599, 2.598,\n> > -                    2.643, 2.644, 2.651, 2.649, 2.629, 2.617, 2.624,\n> 2.629, 2.625, 2.614, 2.586, 2.599, 2.595, 2.597, 2.592, 2.595,\n> > -                    2.645, 2.646, 2.649, 2.649, 2.638, 2.624, 2.616,\n> 2.617, 2.609, 2.604, 2.603, 2.603, 2.595, 2.589, 2.587, 2.592,\n> > -                    2.641, 2.643, 2.649, 2.647, 2.638, 2.618, 2.615,\n> 2.608, 2.602, 2.595, 2.596, 2.595, 2.593, 2.584, 2.581, 2.583,\n> > -                    2.638, 2.637, 2.647, 2.634, 2.634, 2.618, 2.621,\n> 2.621, 2.611, 2.602, 2.596, 2.583, 2.581, 2.581, 2.576, 2.574\n> > +                \"ct\": 2943, \"table\":\n> > +                [\n> > +                    3.361, 3.369, 3.379, 3.385, 3.391, 3.397, 3.401,\n> 3.401, 3.399, 3.396, 3.394, 3.391, 3.383, 3.382, 3.376, 3.375,\n> > +                    3.365, 3.372, 3.381, 3.387, 3.391, 3.398, 3.403,\n> 3.403, 3.402, 3.399, 3.396, 3.392, 3.388, 3.382, 3.378, 3.374,\n> > +                    3.366, 3.377, 3.384, 3.388, 3.391, 3.399, 3.403,\n> 3.405, 3.405, 3.401, 3.399, 3.393, 3.388, 3.384, 3.381, 3.374,\n> > +                    3.366, 3.378, 3.385, 3.389, 3.394, 3.398, 3.402,\n> 3.405, 3.405, 3.404, 3.399, 3.393, 3.389, 3.385, 3.383, 3.369,\n> > +                    3.364, 3.377, 3.383, 3.388, 3.394, 3.398, 3.401,\n> 3.404, 3.404, 3.404, 3.401, 3.394, 3.391, 3.386, 3.383, 3.371,\n> > +                    3.361, 3.376, 3.381, 3.387, 3.394, 3.397, 3.401,\n> 3.402, 3.404, 3.403, 3.399, 3.397, 3.391, 3.387, 3.381, 3.371,\n> > +                    3.359, 3.373, 3.379, 3.385, 3.394, 3.396, 3.399,\n> 3.401, 3.402, 3.401, 3.398, 3.396, 3.392, 3.385, 3.381, 3.371,\n> > +                    3.358, 3.368, 3.376, 3.381, 3.391, 3.395, 3.397,\n> 3.399, 3.399, 3.397, 3.396, 3.392, 3.389, 3.383, 3.378, 3.365,\n> > +                    3.357, 3.366, 3.373, 3.379, 3.383, 3.392, 3.394,\n> 3.396, 3.396, 3.393, 3.391, 3.388, 3.386, 3.382, 3.377, 3.365,\n> > +                    3.355, 3.362, 3.369, 3.374, 3.379, 3.385, 3.391,\n> 3.393, 3.393, 3.392, 3.388, 3.385, 3.383, 3.379, 3.375, 3.362,\n> > +                    3.351, 3.354, 3.363, 3.369, 3.374, 3.379, 3.385,\n> 3.387, 3.391, 3.385, 3.383, 3.382, 3.378, 3.377, 3.363, 3.361,\n> > +                    3.351, 3.352, 3.357, 3.359, 3.365, 3.371, 3.374,\n> 3.375, 3.375, 3.375, 3.373, 3.367, 3.366, 3.366, 3.361, 3.362\n> > +                ]\n> > +            },\n> > +            {\n> > +                \"ct\": 6097, \"table\":\n> > +                [\n> > +                    1.654, 1.657, 1.662, 1.665, 1.666, 1.669, 1.671,\n> 1.672, 1.671, 1.669, 1.668, 1.666, 1.661, 1.661, 1.658, 1.656,\n> > +                    1.655, 1.659, 1.663, 1.665, 1.667, 1.671, 1.672,\n> 1.672, 1.673, 1.671, 1.669, 1.667, 1.663, 1.661, 1.659, 1.656,\n> > +                    1.656, 1.661, 1.665, 1.666, 1.668, 1.671, 1.673,\n> 1.673, 1.674, 1.672, 1.669, 1.668, 1.664, 1.662, 1.659, 1.656,\n> > +                    1.656, 1.661, 1.665, 1.667, 1.668, 1.671, 1.673,\n> 1.674, 1.674, 1.673, 1.671, 1.668, 1.665, 1.663, 1.661, 1.655,\n> > +                    1.656, 1.662, 1.665, 1.667, 1.669, 1.671, 1.673,\n> 1.673, 1.674, 1.672, 1.671, 1.668, 1.665, 1.662, 1.661, 1.656,\n> > +                    1.655, 1.661, 1.664, 1.667, 1.669, 1.672, 1.672,\n> 1.673, 1.673, 1.672, 1.671, 1.669, 1.666, 1.662, 1.661, 1.656,\n> > +                    1.654, 1.659, 1.663, 1.666, 1.669, 1.671, 1.672,\n> 1.673, 1.673, 1.672, 1.671, 1.669, 1.666, 1.662, 1.661, 1.655,\n> > +                    1.653, 1.658, 1.662, 1.664, 1.668, 1.669, 1.672,\n> 1.672, 1.672, 1.671, 1.669, 1.667, 1.665, 1.661, 1.659, 1.653,\n> > +                    1.652, 1.656, 1.659, 1.663, 1.666, 1.668, 1.669,\n> 1.671, 1.671, 1.669, 1.667, 1.665, 1.663, 1.659, 1.657, 1.653,\n> > +                    1.649, 1.654, 1.658, 1.661, 1.663, 1.666, 1.668,\n> 1.669, 1.668, 1.667, 1.665, 1.663, 1.661, 1.659, 1.657, 1.651,\n> > +                    1.646, 1.649, 1.654, 1.658, 1.661, 1.662, 1.664,\n> 1.665, 1.666, 1.664, 1.662, 1.661, 1.659, 1.657, 1.651, 1.648,\n> > +                    1.645, 1.646, 1.651, 1.653, 1.655, 1.657, 1.659,\n> 1.659, 1.659, 1.658, 1.657, 1.656, 1.653, 1.653, 1.649, 1.648\n> >                  ]\n> >              }\n> >          ],\n> >          \"luminance_lut\":\n> >          [\n> > -            1.308, 1.293, 1.228, 1.175, 1.139, 1.108, 1.092, 1.082,\n> 1.082, 1.086, 1.097, 1.114, 1.149, 1.199, 1.279, 1.303,\n> > -            1.293, 1.249, 1.199, 1.162, 1.136, 1.109, 1.087, 1.077,\n> 1.072, 1.081, 1.095, 1.103, 1.133, 1.172, 1.225, 1.282,\n> > -            1.251, 1.212, 1.186, 1.159, 1.129, 1.114, 1.102, 1.088,\n> 1.088, 1.088, 1.095, 1.117, 1.123, 1.158, 1.198, 1.249,\n> > -            1.223, 1.192, 1.177, 1.163, 1.147, 1.139, 1.132, 1.112,\n> 1.111, 1.107, 1.113, 1.118, 1.139, 1.155, 1.186, 1.232,\n> > -            1.207, 1.186, 1.171, 1.162, 1.168, 1.163, 1.153, 1.138,\n> 1.129, 1.128, 1.132, 1.136, 1.149, 1.167, 1.189, 1.216,\n> > -            1.198, 1.186, 1.176, 1.176, 1.177, 1.185, 1.171, 1.157,\n> 1.146, 1.144, 1.146, 1.149, 1.161, 1.181, 1.201, 1.221,\n> > -            1.203, 1.181, 1.176, 1.178, 1.191, 1.189, 1.188, 1.174,\n> 1.159, 1.153, 1.158, 1.161, 1.169, 1.185, 1.211, 1.227,\n> > -            1.211, 1.179, 1.177, 1.187, 1.194, 1.196, 1.194, 1.187,\n> 1.176, 1.169, 1.171, 1.171, 1.175, 1.189, 1.214, 1.226,\n> > -            1.219, 1.182, 1.184, 1.191, 1.195, 1.199, 1.197, 1.194,\n> 1.188, 1.185, 1.179, 1.179, 1.182, 1.194, 1.212, 1.227,\n> > -            1.237, 1.192, 1.194, 1.194, 1.198, 1.199, 1.198, 1.197,\n> 1.196, 1.193, 1.189, 1.189, 1.192, 1.203, 1.214, 1.231,\n> > -            1.282, 1.199, 1.199, 1.197, 1.199, 1.199, 1.192, 1.193,\n> 1.193, 1.194, 1.196, 1.197, 1.206, 1.216, 1.228, 1.244,\n> > -            1.309, 1.236, 1.204, 1.203, 1.202, 1.194, 1.194, 1.188,\n> 1.192, 1.192, 1.199, 1.201, 1.212, 1.221, 1.235, 1.247\n> > +            1.054, 1.059, 1.063, 1.063, 1.063, 1.063, 1.062, 1.062,\n> 1.062, 1.062, 1.061, 1.059, 1.056, 1.052, 1.045, 1.043,\n> > +            1.055, 1.061, 1.065, 1.064, 1.065, 1.064, 1.063, 1.062,\n> 1.063, 1.063, 1.061, 1.059, 1.057, 1.054, 1.049, 1.045,\n> > +            1.057, 1.062, 1.064, 1.063, 1.072, 1.072, 1.072, 1.062,\n> 1.062, 1.062, 1.059, 1.058, 1.056, 1.054, 1.051, 1.047,\n> > +            1.058, 1.061, 1.063, 1.061, 1.062, 1.073, 1.073, 1.059,\n> 1.058, 1.057, 1.057, 1.056, 1.055, 1.053, 1.051, 1.047,\n> > +            1.057, 1.059, 1.061, 1.059, 1.059, 1.059, 1.054, 1.054,\n> 1.056, 1.056, 1.056, 1.055, 1.054, 1.052, 1.049, 1.043,\n> > +            1.055, 1.057, 1.059, 1.057, 1.056, 1.052, 1.049, 1.049,\n> 1.053, 1.054, 1.054, 1.052, 1.051, 1.049, 1.043, 1.041,\n> > +            1.049, 1.053, 1.054, 1.055, 1.052, 1.049, 1.045, 1.043,\n> 1.044, 1.047, 1.047, 1.046, 1.047, 1.044, 1.039, 1.035,\n> > +            1.045, 1.048, 1.049, 1.053, 1.047, 1.045, 1.041, 1.039,\n> 1.041, 1.042, 1.042, 1.042, 1.041, 1.038, 1.033, 1.028,\n> > +            1.032, 1.045, 1.047, 1.047, 1.042, 1.039, 1.036, 1.035,\n> 1.036, 1.037, 1.039, 1.039, 1.039, 1.034, 1.028, 1.021,\n> > +            1.022, 1.031, 1.038, 1.038, 1.035, 1.034, 1.033, 1.032,\n> 1.031, 1.031, 1.037, 1.038, 1.041, 1.033, 1.021, 1.013,\n> > +            1.012, 1.021, 1.025, 1.027, 1.027, 1.028, 1.028, 1.027,\n> 1.025, 1.024, 1.024, 1.029, 1.038, 1.028, 1.012, 1.004,\n> > +            1.011, 1.012, 1.017, 1.021, 1.021, 1.022, 1.021, 1.021,\n> 1.021, 1.019, 1.017, 1.023, 1.028, 1.013, 1.004, 1.001\n> >          ],\n> > -        \"sigma\": 0.005,\n> > -        \"sigma_Cb\": 0.005\n> > +        \"sigma\": 0.00063,\n> > +        \"sigma_Cb\": 0.00089\n> >      },\n> >      \"rpi.contrast\":\n> >      {\n> > @@ -185,6 +291,66 @@\n> >              65535, 65535\n> >          ]\n> >      },\n> > +    \"rpi.ccm\":\n> > +    {\n> > +        \"ccms\":\n> > +        [\n> > +            {\n> > +                \"ct\": 2861, \"ccm\":\n> > +                [\n> > +                    1.61339, -0.55137, -0.06202, -0.24235, 1.42738,\n> -0.18503, 0.07817, -0.77121, 1.69304\n> > +                ]\n> > +            },\n> > +            {\n> > +                \"ct\": 2915, \"ccm\":\n> > +                [\n> > +                    1.64366, -0.57014, -0.07352, -0.27249, 1.48118,\n> -0.20869, 0.08973, -0.78375, 1.69402\n> > +                ]\n> > +            },\n> > +            {\n> > +                \"ct\": 2916, \"ccm\":\n> > +                [\n> > +                    1.59805, -0.49622, -0.10183, -0.17981, 1.25627,\n> -0.07646, -0.00104, -0.62299, 1.62404\n> > +                ]\n> > +            },\n> > +            {\n> > +                \"ct\": 2922, \"ccm\":\n> > +                [\n> > +                    1.61099, -0.52067, -0.09032, -0.19271, 1.28084,\n> -0.08813, 0.01453, -0.65247, 1.63794\n> > +                ]\n> > +            },\n> > +            {\n> > +                \"ct\": 2934, \"ccm\":\n> > +                [\n> > +                    1.60849, -0.51603, -0.09246, -0.19148, 1.28129,\n> -0.08981, 0.01142, -0.64365, 1.63224\n> > +                ]\n> > +            },\n> > +            {\n> > +                \"ct\": 3626, \"ccm\":\n> > +                [\n> > +                    1.62525, -0.59206, -0.03319, -0.20241, 1.42135,\n> -0.21895, 0.05845, -0.66941, 1.61096\n> > +                ]\n> > +            },\n> > +            {\n> > +                \"ct\": 4617, \"ccm\":\n> > +                [\n> > +                    1.62324, -0.66976, 0.04652, -0.16629, 1.56915,\n> -0.40287, 0.07878, -0.73116, 1.65238\n> > +                ]\n> > +            },\n> > +            {\n> > +                \"ct\": 5674, \"ccm\":\n> > +                [\n> > +                    1.66733, -0.68927, 0.02194, -0.13995, 1.47994,\n> -0.33998, 0.04474, -0.61721, 1.57247\n> > +                ]\n> > +            },\n> > +            {\n> > +                \"ct\": 7617, \"ccm\":\n> > +                [\n> > +                    1.53155, -0.66311, 0.13157, -0.03271, 1.65915,\n> -0.62645, 0.07635, -1.01009, 1.93374\n> > +                ]\n> > +            }\n> > +        ]\n> > +    },\n> >      \"rpi.sharpen\":\n> >      {\n> >      }\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 62EEABD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 15 Jul 2022 07:24:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CB95263312;\n\tFri, 15 Jul 2022 09:24:36 +0200 (CEST)","from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com\n\t[IPv6:2a00:1450:4864:20::22d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 705C06330B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Jul 2022 09:24:35 +0200 (CEST)","by mail-lj1-x22d.google.com with SMTP id w2so4771882ljj.7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Jul 2022 00:24:35 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657869876;\n\tbh=/6A0NIHURtnvKmMw+PUHCu4WfS+NhFUuSFoP6lzFHc4=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=OWol7/gpzBGCHRfrYFQSRrB7loARnwP3VLBy7GBfafTeBO8JpPco3KLZDs1Uakqce\n\t9MydWeouFvDEazkLM/bS35Rv5uym8n/M6CNqn56lXL9OV7ZeTAMSuK0dQxuf9jld5h\n\teOMmZZ2MosieZLz8DuuGKsW1sBHJNCJoz6GQe+9H/zrBsPUVFUED4Sm8HW0BA1Yx/i\n\t9jMObfJEQU29E1aAvpMDF70zQ9XoYDNkDV9R2qlsbaWaCbXg1hURz46o7zWRgZMgDc\n\tF78NrvyfHUOQJoY7+mzrOGVz6BWHe/367w6kcTZ4CUq1ljdhK0ytLC84Z4rNHT0MsY\n\tovHyxB9YYUzqQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=PovnuaaFwWzyhQJBffq2hbQQnmyOSFi1yaAdrK/gOy8=;\n\tb=LmYSmJz7X0bTH7goO4RQzJFYjZy355FjVAkCnclwFSrQhvdaOipDN268803giOxgtp\n\tdmEdJZoCUFrjDj3KR5CsGBT6MzLsQyWr0+ysoKerFXtKj89/2GpLXIHpReJ84T3bHz3v\n\tsyK5McOdYq1FEmuJCIzeuRwHGGNj0LauXxV/QjdMK+VpW7bBgilRLI0euipHANAv7Nko\n\t+AtgBPq/mHx3K1Df8qk9sqe1FNJ2qXt26gLMigAdFuFxoPA/EZFrCKrTUud2pvsA20Xd\n\tRBforiwx944cEt/yp54er/in9F+Q4bVgJAB3bDd1KOY5eyRznjuRsUWkUkQX2+UZrblQ\n\tir9g=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"LmYSmJz7\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=PovnuaaFwWzyhQJBffq2hbQQnmyOSFi1yaAdrK/gOy8=;\n\tb=5Zt0BA6/xfO6YVz0zBWsQUGBbzOjmcOV1D5Va8Y8BRSn0zBM1GcbWUWT4UkUxKosi/\n\tXCfI3HWn+L34jaMz+v2xcF9cGndmM8MIU1fSoR419sibEiSsXjk3l9pyxLITtbJ8rWAY\n\tjGXp61CAT/sw9dt6QoPOres5n/7YYGLA1huFy6Q/GpZ9lbxGxH+GUCLc/5yQn3jYZtuo\n\t2IV3JhlSBfBzEhLBiknbFJBagZHCh9ps3lpxoesB5as/EZ/Jsel/znJRLveToC13oAbf\n\tzGgI8ShNALpqDdBuvnspx6RoZGNpDchnjv19Mktiq9CYBq1mpkJny8ONsoroWRb30DRO\n\twyEA==","X-Gm-Message-State":"AJIora9+SbYtvIfI3of1xlVn+o/p99BKoRNRRcDhFegsRTl7jTTZrjwP\n\tXS+rDLBPAQzBQR93duPLAwAcYOjSZevxs7dwakBaSQ==","X-Google-Smtp-Source":"AGRyM1tVpeK/GRg5aH9IaUZ06r+xMmY38hxdlOm7sMp5obL/CU90hbjpPLIDZyHOrrEp9pdjtrGjMiR3+qE8R72+IZA=","X-Received":"by 2002:a2e:98da:0:b0:25d:91a7:22eb with SMTP id\n\ts26-20020a2e98da000000b0025d91a722ebmr5220285ljj.46.1657869874501;\n\tFri, 15 Jul 2022 00:24:34 -0700 (PDT)","MIME-Version":"1.0","References":"<20220714094143.4399-1-william.vinnicombe@raspberrypi.com>\n\t<20220714094143.4399-2-william.vinnicombe@raspberrypi.com>\n\t<YtCxYOESDACUu3CC@pendragon.ideasonboard.com>","In-Reply-To":"<YtCxYOESDACUu3CC@pendragon.ideasonboard.com>","Date":"Fri, 15 Jul 2022 08:24:18 +0100","Message-ID":"<CAEmqJPrWeBiOJgfBYWforxr09X8Sk5KAiM9jUOwtH=_TjV+awg@mail.gmail.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Content-Type":"multipart/alternative; boundary=\"000000000000f4363e05e3d2e873\"","Subject":"Re: [libcamera-devel] [PATCH 1/1] ipa: raspberrypi: Update imx296\n\ttuning file","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Naushir Patuck <naush@raspberrypi.com>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":23926,"web_url":"https://patchwork.libcamera.org/comment/23926/","msgid":"<CAPY8ntCkZjuxNZqOQRqdfdYm0xyjH-gN_V+G_meiO5iBJt8X1A@mail.gmail.com>","date":"2022-07-15T10:49:32","subject":"Re: [libcamera-devel] [PATCH 1/1] ipa: raspberrypi: Update imx296\n\ttuning file","submitter":{"id":27,"url":"https://patchwork.libcamera.org/api/people/27/","name":"Dave Stevenson","email":"dave.stevenson@raspberrypi.com"},"content":"Hi All\n\nOn Fri, 15 Jul 2022 at 08:24, Naushir Patuck via libcamera-devel\n<libcamera-devel@lists.libcamera.org> wrote:\n>\n> Hi Laurent,\n>\n> On Fri, 15 Jul 2022 at 01:14, Laurent Pinchart via libcamera-devel <libcamera-devel@lists.libcamera.org> wrote:\n>>\n>> Hi William,\n>>\n>> Thank you for the patch.\n>>\n>> On Thu, Jul 14, 2022 at 10:41:43AM +0100, William Vinnicombe via libcamera-devel wrote:\n>> > From: William Vinnicombe <william.vinnicombe@raspberrypi.com>\n>> >\n>> > The previous tuning values for the imx296 are not accurate, and do not\n>> > contain awb parameters.\n>>\n>> There was a reason for that though, the file was meant for the\n>> monochrome version of the sensor. See [1] for the full context. I'm\n>> actually aware of one user of this tuning file with a monochrome sensor,\n>> and this patch will break this use case.\n>>\n>> This brings nack the question that we decided to leave unanswered when\n>> the imx296.json file was merged: how do we deal with different modules\n>> that integrated the same camera sensor ?\n>>\n>> [1] https://lists.libcamera.org/pipermail/libcamera-devel/2022-January/028756.html\n>\n>\n> This is indeed a real problem now.  Our (admittedly very loose) convention is to have\n> the <sensor_name>.json file be the full colour variant, and any offshoot be named as\n> <sensor_name>_<variant>.json.  Would we be able to give a heads-up and help this\n> user switch to imx296_mono.json?  They would also benefit from the new tuning with\n> updated noise and sharpening IQ performance.\n>\n> The difficult bit is how to choose a variant json without user intervention? Do we add\n> a variant parameter in devicetree?  Some modules may have eeproms or ids that can\n> store this, but I don't think there is a mechanism to return this information to userland\n> from v4l2...?\n\nThis is going to be a recurring issue, as a very similar thing was\ntrue for imx290. There we have 2 compatible strings [1] as there isn't\na register to read for colour vs mono.\n\nThe driver has to know in order to advertise the correct MEDIA_BUS_FMT_ formats.\nDo we change the V4L2 sensor subdev name for variants (either based on\ncompatible or register) to denote an alternate tuning file? That\nshould then get magically picked up, but does it make for some\nconfusion choosing the camera helper?\n(It would be nice to have a convention, but as it will be down to the\ndriver to provide the name they could be switched around on a per\ndriver basis).\n\n  Dave\n\n[1] https://github.com/raspberrypi/linux/blob/rpi-5.15.y/drivers/media/i2c/imx290.c#L1235\n\n> Naush\n>\n>>\n>>\n>>\n>> > Update the tuning file using the raspberrypi ctt tool to give accurate\n>> > values, and all required parameters.\n>> >\n>> > Signed-off-by: William Vinnicombe <william.vinnicombe@raspberrypi.com>\n>> > ---\n>> >  src/ipa/raspberrypi/data/imx296.json | 268 ++++++++++++++++++++++-----\n>> >  1 file changed, 217 insertions(+), 51 deletions(-)\n>> >\n>> > diff --git a/src/ipa/raspberrypi/data/imx296.json b/src/ipa/raspberrypi/data/imx296.json\n>> > index 837feff5..4d9d0e8b 100644\n>> > --- a/src/ipa/raspberrypi/data/imx296.json\n>> > +++ b/src/ipa/raspberrypi/data/imx296.json\n>> > @@ -8,25 +8,97 @@\n>> >      },\n>> >      \"rpi.lux\":\n>> >      {\n>> > -        \"reference_shutter_speed\": 19184,\n>> > -        \"reference_gain\": 1.0,\n>> > +        \"reference_shutter_speed\": 17895,\n>> > +        \"reference_gain\": 1.99,\n>> >          \"reference_aperture\": 1.0,\n>> > -        \"reference_lux\": 432,\n>> > -        \"reference_Y\": 13773\n>> > +        \"reference_lux\": 1147,\n>> > +        \"reference_Y\": 13348\n>> >      },\n>> >      \"rpi.noise\":\n>> >      {\n>> > -        \"reference_constant\": 0,\n>> > -        \"reference_slope\": 2.957\n>> > +        \"reference_constant\": 1,\n>> > +        \"reference_slope\": 2.631\n>> >      },\n>> >      \"rpi.geq\":\n>> >      {\n>> > -        \"offset\": 185,\n>> > -        \"slope\": 0.0105\n>> > +        \"offset\": 182,\n>> > +        \"slope\": 0.0127\n>> >      },\n>> >      \"rpi.sdn\":\n>> >      {\n>> >      },\n>> > +    \"rpi.awb\":\n>> > +    {\n>> > +        \"priors\":\n>> > +        [\n>> > +            {\n>> > +                \"lux\": 0, \"prior\":\n>> > +                [\n>> > +                    2000, 1.0, 3000, 0.0, 13000, 0.0\n>> > +                ]\n>> > +            },\n>> > +            {\n>> > +                \"lux\": 800, \"prior\":\n>> > +                [\n>> > +                    2000, 0.0, 6000, 2.0, 13000, 2.0\n>> > +                ]\n>> > +            },\n>> > +            {\n>> > +                \"lux\": 1500, \"prior\":\n>> > +                [\n>> > +                    2000, 0.0, 4000, 1.0, 6000, 6.0, 6500, 7.0, 7000, 1.0, 13000, 1.0\n>> > +                ]\n>> > +            }\n>> > +        ],\n>> > +        \"modes\":\n>> > +        {\n>> > +            \"auto\":\n>> > +            {\n>> > +                \"lo\": 2500,\n>> > +                \"hi\": 8000\n>> > +            },\n>> > +            \"incandescent\":\n>> > +            {\n>> > +                \"lo\": 2500,\n>> > +                \"hi\": 3000\n>> > +            },\n>> > +            \"tungsten\":\n>> > +            {\n>> > +                \"lo\": 3000,\n>> > +                \"hi\": 3500\n>> > +            },\n>> > +            \"fluorescent\":\n>> > +            {\n>> > +                \"lo\": 4000,\n>> > +                \"hi\": 4700\n>> > +            },\n>> > +            \"indoor\":\n>> > +            {\n>> > +                \"lo\": 3000,\n>> > +                \"hi\": 5000\n>> > +            },\n>> > +            \"daylight\":\n>> > +            {\n>> > +                \"lo\": 5500,\n>> > +                \"hi\": 6500\n>> > +            },\n>> > +            \"cloudy\":\n>> > +            {\n>> > +                \"lo\": 7000,\n>> > +                \"hi\": 8600\n>> > +            }\n>> > +        },\n>> > +        \"bayes\": 1,\n>> > +        \"ct_curve\":\n>> > +        [\n>> > +            2861.0, 0.4281, 0.2614, 2915.0, 0.4266, 0.2639, 2916.0, 0.4112, 0.2913, 2934.0, 0.4099, 0.2935, 3626.0, 0.3604, 0.3777, 4617.0,\n>> > +            0.2776, 0.5093, 5674.0, 0.2567, 0.5409, 7617.0, 0.1789, 0.6527\n>> > +        ],\n>> > +        \"sensitivity_r\": 1.0,\n>> > +        \"sensitivity_b\": 1.0,\n>> > +        \"transverse_pos\": 0.02994,\n>> > +        \"transverse_neg\": 0.04332\n>> > +    },\n>> >      \"rpi.agc\":\n>> >      {\n>> >          \"metering_modes\":\n>> > @@ -113,65 +185,99 @@\n>> >      \"rpi.alsc\":\n>> >      {\n>> >          \"omega\": 1.3,\n>> > -        \"n_iter\": 0,\n>> > +        \"n_iter\": 100,\n>> >          \"luminance_strength\": 0.5,\n>> >          \"calibrations_Cr\":\n>> >          [\n>> >              {\n>> > -                \"ct\": 4000, \"table\":\n>> > -                [\n>> > -                    2.554, 2.554, 2.541, 2.534, 2.495, 2.506, 2.516, 2.517, 2.518, 2.515, 2.513, 2.495, 2.481, 2.533, 2.533, 2.521,\n>> > -                    2.522, 2.534, 2.539, 2.531, 2.531, 2.506, 2.506, 2.513, 2.513, 2.509, 2.498, 2.496, 2.508, 2.517, 2.521, 2.521,\n>> > -                    2.509, 2.517, 2.534, 2.529, 2.531, 2.521, 2.517, 2.517, 2.515, 2.514, 2.506, 2.499, 2.508, 2.508, 2.521, 2.537,\n>> > -                    2.507, 2.508, 2.517, 2.516, 2.495, 2.487, 2.519, 2.534, 2.535, 2.531, 2.499, 2.494, 2.501, 2.511, 2.526, 2.526,\n>> > -                    2.509, 2.517, 2.507, 2.501, 2.494, 2.519, 2.539, 2.539, 2.537, 2.537, 2.533, 2.499, 2.503, 2.511, 2.529, 2.525,\n>> > -                    2.521, 2.522, 2.476, 2.501, 2.501, 2.539, 2.546, 2.538, 2.531, 2.538, 2.541, 2.531, 2.529, 2.526, 2.529, 2.525,\n>> > -                    2.516, 2.519, 2.469, 2.499, 2.499, 2.543, 2.543, 2.531, 2.528, 2.534, 2.541, 2.535, 2.531, 2.526, 2.531, 2.528,\n>> > -                    2.509, 2.515, 2.465, 2.487, 2.487, 2.539, 2.543, 2.539, 2.533, 2.549, 2.542, 2.531, 2.529, 2.524, 2.532, 2.533,\n>> > -                    2.499, 2.499, 2.475, 2.482, 2.471, 2.509, 2.539, 2.544, 2.543, 2.545, 2.533, 2.498, 2.521, 2.521, 2.537, 2.536,\n>> > -                    2.499, 2.488, 2.488, 2.488, 2.471, 2.462, 2.509, 2.539, 2.539, 2.532, 2.498, 2.498, 2.518, 2.518, 2.539, 2.539,\n>> > -                    2.483, 2.484, 2.488, 2.488, 2.502, 2.496, 2.508, 2.514, 2.518, 2.517, 2.521, 2.518, 2.518, 2.518, 2.525, 2.539,\n>> > -                    2.483, 2.487, 2.478, 2.478, 2.507, 2.509, 2.514, 2.513, 2.514, 2.517, 2.536, 2.559, 2.501, 2.501, 2.503, 2.525\n>> > +                \"ct\": 2943, \"table\":\n>> > +                [\n>> > +                    2.153, 2.154, 2.154, 2.153, 2.153, 2.153, 2.153, 2.151, 2.151, 2.149, 2.149, 2.149, 2.149, 2.149, 2.151, 2.153,\n>> > +                    2.154, 2.155, 2.155, 2.154, 2.154, 2.154, 2.153, 2.152, 2.151, 2.149, 2.149, 2.149, 2.149, 2.149, 2.151, 2.152,\n>> > +                    2.155, 2.155, 2.155, 2.154, 2.154, 2.154, 2.153, 2.151, 2.151, 2.149, 2.149, 2.149, 2.149, 2.149, 2.151, 2.152,\n>> > +                    2.154, 2.154, 2.155, 2.153, 2.153, 2.153, 2.152, 2.151, 2.149, 2.149, 2.149, 2.149, 2.148, 2.148, 2.149, 2.151,\n>> > +                    2.153, 2.153, 2.153, 2.152, 2.152, 2.152, 2.151, 2.149, 2.149, 2.149, 2.149, 2.148, 2.148, 2.148, 2.149, 2.151,\n>> > +                    2.153, 2.153, 2.152, 2.152, 2.152, 2.152, 2.151, 2.149, 2.149, 2.148, 2.148, 2.148, 2.147, 2.147, 2.148, 2.149,\n>> > +                    2.152, 2.153, 2.152, 2.151, 2.151, 2.151, 2.151, 2.151, 2.149, 2.148, 2.148, 2.147, 2.147, 2.147, 2.148, 2.149,\n>> > +                    2.152, 2.152, 2.152, 2.151, 2.151, 2.151, 2.151, 2.149, 2.148, 2.147, 2.146, 2.147, 2.147, 2.148, 2.149, 2.151,\n>> > +                    2.152, 2.152, 2.152, 2.151, 2.151, 2.151, 2.151, 2.151, 2.149, 2.147, 2.146, 2.147, 2.148, 2.149, 2.152, 2.152,\n>> > +                    2.152, 2.154, 2.154, 2.152, 2.152, 2.152, 2.152, 2.151, 2.151, 2.149, 2.149, 2.149, 2.151, 2.152, 2.153, 2.153,\n>> > +                    2.155, 2.156, 2.155, 2.154, 2.152, 2.152, 2.152, 2.151, 2.151, 2.149, 2.149, 2.149, 2.151, 2.152, 2.153, 2.153,\n>> > +                    2.155, 2.155, 2.155, 2.154, 2.152, 2.151, 2.151, 2.149, 2.148, 2.148, 2.149, 2.149, 2.151, 2.152, 2.152, 2.154\n>> > +                ]\n>> > +            },\n>> > +            {\n>> > +                \"ct\": 6097, \"table\":\n>> > +                [\n>> > +                    3.604, 3.605, 3.607, 3.605, 3.604, 3.604, 3.603, 3.602, 3.598, 3.594, 3.593, 3.593, 3.593, 3.593, 3.596, 3.602,\n>> > +                    3.604, 3.607, 3.611, 3.609, 3.609, 3.608, 3.606, 3.602, 3.599, 3.596, 3.596, 3.594, 3.594, 3.594, 3.598, 3.602,\n>> > +                    3.606, 3.611, 3.612, 3.609, 3.611, 3.609, 3.608, 3.602, 3.599, 3.597, 3.596, 3.595, 3.594, 3.594, 3.597, 3.599,\n>> > +                    3.606, 3.609, 3.611, 3.607, 3.607, 3.606, 3.603, 3.599, 3.597, 3.595, 3.595, 3.593, 3.593, 3.592, 3.593, 3.596,\n>> > +                    3.604, 3.607, 3.607, 3.604, 3.603, 3.602, 3.599, 3.597, 3.596, 3.595, 3.595, 3.594, 3.592, 3.591, 3.591, 3.594,\n>> > +                    3.606, 3.607, 3.606, 3.604, 3.602, 3.601, 3.599, 3.597, 3.597, 3.596, 3.596, 3.595, 3.593, 3.591, 3.589, 3.592,\n>> > +                    3.604, 3.606, 3.605, 3.603, 3.602, 3.602, 3.599, 3.598, 3.596, 3.595, 3.595, 3.595, 3.591, 3.589, 3.591, 3.592,\n>> > +                    3.604, 3.604, 3.605, 3.602, 3.601, 3.601, 3.599, 3.598, 3.597, 3.595, 3.593, 3.591, 3.589, 3.591, 3.592, 3.596,\n>> > +                    3.604, 3.605, 3.606, 3.602, 3.601, 3.601, 3.601, 3.599, 3.597, 3.595, 3.593, 3.591, 3.589, 3.594, 3.598, 3.599,\n>> > +                    3.609, 3.613, 3.615, 3.611, 3.609, 3.609, 3.608, 3.605, 3.603, 3.599, 3.598, 3.597, 3.598, 3.601, 3.603, 3.603,\n>> > +                    3.613, 3.616, 3.616, 3.613, 3.609, 3.609, 3.608, 3.606, 3.604, 3.602, 3.599, 3.599, 3.599, 3.602, 3.605, 3.605,\n>> > +                    3.615, 3.616, 3.616, 3.613, 3.611, 3.604, 3.604, 3.601, 3.601, 3.599, 3.599, 3.599, 3.601, 3.602, 3.604, 3.604\n>> >                  ]\n>> >              }\n>> >          ],\n>> >          \"calibrations_Cb\":\n>> >          [\n>> >              {\n>> > -                \"ct\": 4000, \"table\":\n>> > -                [\n>> > -                    2.619, 2.603, 2.599, 2.597, 2.595, 2.594, 2.589, 2.587, 2.586, 2.589, 2.592, 2.597, 2.601, 2.608, 2.621, 2.621,\n>> > -                    2.619, 2.615, 2.603, 2.601, 2.596, 2.595, 2.591, 2.589, 2.589, 2.592, 2.599, 2.593, 2.601, 2.613, 2.622, 2.631,\n>> > -                    2.617, 2.617, 2.612, 2.611, 2.604, 2.598, 2.593, 2.591, 2.592, 2.591, 2.593, 2.595, 2.599, 2.614, 2.623, 2.631,\n>> > -                    2.624, 2.619, 2.615, 2.612, 2.605, 2.602, 2.597, 2.596, 2.592, 2.592, 2.595, 2.599, 2.602, 2.606, 2.619, 2.624,\n>> > -                    2.629, 2.627, 2.627, 2.617, 2.609, 2.598, 2.612, 2.623, 2.615, 2.604, 2.589, 2.595, 2.599, 2.608, 2.611, 2.614,\n>> > -                    2.629, 2.632, 2.637, 2.627, 2.612, 2.612, 2.629, 2.631, 2.628, 2.621, 2.604, 2.597, 2.598, 2.604, 2.609, 2.609,\n>> > -                    2.635, 2.636, 2.642, 2.628, 2.623, 2.623, 2.636, 2.636, 2.634, 2.628, 2.616, 2.599, 2.597, 2.601, 2.603, 2.601,\n>> > -                    2.641, 2.639, 2.646, 2.632, 2.627, 2.625, 2.632, 2.635, 2.634, 2.627, 2.614, 2.596, 2.595, 2.599, 2.599, 2.598,\n>> > -                    2.643, 2.644, 2.651, 2.649, 2.629, 2.617, 2.624, 2.629, 2.625, 2.614, 2.586, 2.599, 2.595, 2.597, 2.592, 2.595,\n>> > -                    2.645, 2.646, 2.649, 2.649, 2.638, 2.624, 2.616, 2.617, 2.609, 2.604, 2.603, 2.603, 2.595, 2.589, 2.587, 2.592,\n>> > -                    2.641, 2.643, 2.649, 2.647, 2.638, 2.618, 2.615, 2.608, 2.602, 2.595, 2.596, 2.595, 2.593, 2.584, 2.581, 2.583,\n>> > -                    2.638, 2.637, 2.647, 2.634, 2.634, 2.618, 2.621, 2.621, 2.611, 2.602, 2.596, 2.583, 2.581, 2.581, 2.576, 2.574\n>> > +                \"ct\": 2943, \"table\":\n>> > +                [\n>> > +                    3.361, 3.369, 3.379, 3.385, 3.391, 3.397, 3.401, 3.401, 3.399, 3.396, 3.394, 3.391, 3.383, 3.382, 3.376, 3.375,\n>> > +                    3.365, 3.372, 3.381, 3.387, 3.391, 3.398, 3.403, 3.403, 3.402, 3.399, 3.396, 3.392, 3.388, 3.382, 3.378, 3.374,\n>> > +                    3.366, 3.377, 3.384, 3.388, 3.391, 3.399, 3.403, 3.405, 3.405, 3.401, 3.399, 3.393, 3.388, 3.384, 3.381, 3.374,\n>> > +                    3.366, 3.378, 3.385, 3.389, 3.394, 3.398, 3.402, 3.405, 3.405, 3.404, 3.399, 3.393, 3.389, 3.385, 3.383, 3.369,\n>> > +                    3.364, 3.377, 3.383, 3.388, 3.394, 3.398, 3.401, 3.404, 3.404, 3.404, 3.401, 3.394, 3.391, 3.386, 3.383, 3.371,\n>> > +                    3.361, 3.376, 3.381, 3.387, 3.394, 3.397, 3.401, 3.402, 3.404, 3.403, 3.399, 3.397, 3.391, 3.387, 3.381, 3.371,\n>> > +                    3.359, 3.373, 3.379, 3.385, 3.394, 3.396, 3.399, 3.401, 3.402, 3.401, 3.398, 3.396, 3.392, 3.385, 3.381, 3.371,\n>> > +                    3.358, 3.368, 3.376, 3.381, 3.391, 3.395, 3.397, 3.399, 3.399, 3.397, 3.396, 3.392, 3.389, 3.383, 3.378, 3.365,\n>> > +                    3.357, 3.366, 3.373, 3.379, 3.383, 3.392, 3.394, 3.396, 3.396, 3.393, 3.391, 3.388, 3.386, 3.382, 3.377, 3.365,\n>> > +                    3.355, 3.362, 3.369, 3.374, 3.379, 3.385, 3.391, 3.393, 3.393, 3.392, 3.388, 3.385, 3.383, 3.379, 3.375, 3.362,\n>> > +                    3.351, 3.354, 3.363, 3.369, 3.374, 3.379, 3.385, 3.387, 3.391, 3.385, 3.383, 3.382, 3.378, 3.377, 3.363, 3.361,\n>> > +                    3.351, 3.352, 3.357, 3.359, 3.365, 3.371, 3.374, 3.375, 3.375, 3.375, 3.373, 3.367, 3.366, 3.366, 3.361, 3.362\n>> > +                ]\n>> > +            },\n>> > +            {\n>> > +                \"ct\": 6097, \"table\":\n>> > +                [\n>> > +                    1.654, 1.657, 1.662, 1.665, 1.666, 1.669, 1.671, 1.672, 1.671, 1.669, 1.668, 1.666, 1.661, 1.661, 1.658, 1.656,\n>> > +                    1.655, 1.659, 1.663, 1.665, 1.667, 1.671, 1.672, 1.672, 1.673, 1.671, 1.669, 1.667, 1.663, 1.661, 1.659, 1.656,\n>> > +                    1.656, 1.661, 1.665, 1.666, 1.668, 1.671, 1.673, 1.673, 1.674, 1.672, 1.669, 1.668, 1.664, 1.662, 1.659, 1.656,\n>> > +                    1.656, 1.661, 1.665, 1.667, 1.668, 1.671, 1.673, 1.674, 1.674, 1.673, 1.671, 1.668, 1.665, 1.663, 1.661, 1.655,\n>> > +                    1.656, 1.662, 1.665, 1.667, 1.669, 1.671, 1.673, 1.673, 1.674, 1.672, 1.671, 1.668, 1.665, 1.662, 1.661, 1.656,\n>> > +                    1.655, 1.661, 1.664, 1.667, 1.669, 1.672, 1.672, 1.673, 1.673, 1.672, 1.671, 1.669, 1.666, 1.662, 1.661, 1.656,\n>> > +                    1.654, 1.659, 1.663, 1.666, 1.669, 1.671, 1.672, 1.673, 1.673, 1.672, 1.671, 1.669, 1.666, 1.662, 1.661, 1.655,\n>> > +                    1.653, 1.658, 1.662, 1.664, 1.668, 1.669, 1.672, 1.672, 1.672, 1.671, 1.669, 1.667, 1.665, 1.661, 1.659, 1.653,\n>> > +                    1.652, 1.656, 1.659, 1.663, 1.666, 1.668, 1.669, 1.671, 1.671, 1.669, 1.667, 1.665, 1.663, 1.659, 1.657, 1.653,\n>> > +                    1.649, 1.654, 1.658, 1.661, 1.663, 1.666, 1.668, 1.669, 1.668, 1.667, 1.665, 1.663, 1.661, 1.659, 1.657, 1.651,\n>> > +                    1.646, 1.649, 1.654, 1.658, 1.661, 1.662, 1.664, 1.665, 1.666, 1.664, 1.662, 1.661, 1.659, 1.657, 1.651, 1.648,\n>> > +                    1.645, 1.646, 1.651, 1.653, 1.655, 1.657, 1.659, 1.659, 1.659, 1.658, 1.657, 1.656, 1.653, 1.653, 1.649, 1.648\n>> >                  ]\n>> >              }\n>> >          ],\n>> >          \"luminance_lut\":\n>> >          [\n>> > -            1.308, 1.293, 1.228, 1.175, 1.139, 1.108, 1.092, 1.082, 1.082, 1.086, 1.097, 1.114, 1.149, 1.199, 1.279, 1.303,\n>> > -            1.293, 1.249, 1.199, 1.162, 1.136, 1.109, 1.087, 1.077, 1.072, 1.081, 1.095, 1.103, 1.133, 1.172, 1.225, 1.282,\n>> > -            1.251, 1.212, 1.186, 1.159, 1.129, 1.114, 1.102, 1.088, 1.088, 1.088, 1.095, 1.117, 1.123, 1.158, 1.198, 1.249,\n>> > -            1.223, 1.192, 1.177, 1.163, 1.147, 1.139, 1.132, 1.112, 1.111, 1.107, 1.113, 1.118, 1.139, 1.155, 1.186, 1.232,\n>> > -            1.207, 1.186, 1.171, 1.162, 1.168, 1.163, 1.153, 1.138, 1.129, 1.128, 1.132, 1.136, 1.149, 1.167, 1.189, 1.216,\n>> > -            1.198, 1.186, 1.176, 1.176, 1.177, 1.185, 1.171, 1.157, 1.146, 1.144, 1.146, 1.149, 1.161, 1.181, 1.201, 1.221,\n>> > -            1.203, 1.181, 1.176, 1.178, 1.191, 1.189, 1.188, 1.174, 1.159, 1.153, 1.158, 1.161, 1.169, 1.185, 1.211, 1.227,\n>> > -            1.211, 1.179, 1.177, 1.187, 1.194, 1.196, 1.194, 1.187, 1.176, 1.169, 1.171, 1.171, 1.175, 1.189, 1.214, 1.226,\n>> > -            1.219, 1.182, 1.184, 1.191, 1.195, 1.199, 1.197, 1.194, 1.188, 1.185, 1.179, 1.179, 1.182, 1.194, 1.212, 1.227,\n>> > -            1.237, 1.192, 1.194, 1.194, 1.198, 1.199, 1.198, 1.197, 1.196, 1.193, 1.189, 1.189, 1.192, 1.203, 1.214, 1.231,\n>> > -            1.282, 1.199, 1.199, 1.197, 1.199, 1.199, 1.192, 1.193, 1.193, 1.194, 1.196, 1.197, 1.206, 1.216, 1.228, 1.244,\n>> > -            1.309, 1.236, 1.204, 1.203, 1.202, 1.194, 1.194, 1.188, 1.192, 1.192, 1.199, 1.201, 1.212, 1.221, 1.235, 1.247\n>> > +            1.054, 1.059, 1.063, 1.063, 1.063, 1.063, 1.062, 1.062, 1.062, 1.062, 1.061, 1.059, 1.056, 1.052, 1.045, 1.043,\n>> > +            1.055, 1.061, 1.065, 1.064, 1.065, 1.064, 1.063, 1.062, 1.063, 1.063, 1.061, 1.059, 1.057, 1.054, 1.049, 1.045,\n>> > +            1.057, 1.062, 1.064, 1.063, 1.072, 1.072, 1.072, 1.062, 1.062, 1.062, 1.059, 1.058, 1.056, 1.054, 1.051, 1.047,\n>> > +            1.058, 1.061, 1.063, 1.061, 1.062, 1.073, 1.073, 1.059, 1.058, 1.057, 1.057, 1.056, 1.055, 1.053, 1.051, 1.047,\n>> > +            1.057, 1.059, 1.061, 1.059, 1.059, 1.059, 1.054, 1.054, 1.056, 1.056, 1.056, 1.055, 1.054, 1.052, 1.049, 1.043,\n>> > +            1.055, 1.057, 1.059, 1.057, 1.056, 1.052, 1.049, 1.049, 1.053, 1.054, 1.054, 1.052, 1.051, 1.049, 1.043, 1.041,\n>> > +            1.049, 1.053, 1.054, 1.055, 1.052, 1.049, 1.045, 1.043, 1.044, 1.047, 1.047, 1.046, 1.047, 1.044, 1.039, 1.035,\n>> > +            1.045, 1.048, 1.049, 1.053, 1.047, 1.045, 1.041, 1.039, 1.041, 1.042, 1.042, 1.042, 1.041, 1.038, 1.033, 1.028,\n>> > +            1.032, 1.045, 1.047, 1.047, 1.042, 1.039, 1.036, 1.035, 1.036, 1.037, 1.039, 1.039, 1.039, 1.034, 1.028, 1.021,\n>> > +            1.022, 1.031, 1.038, 1.038, 1.035, 1.034, 1.033, 1.032, 1.031, 1.031, 1.037, 1.038, 1.041, 1.033, 1.021, 1.013,\n>> > +            1.012, 1.021, 1.025, 1.027, 1.027, 1.028, 1.028, 1.027, 1.025, 1.024, 1.024, 1.029, 1.038, 1.028, 1.012, 1.004,\n>> > +            1.011, 1.012, 1.017, 1.021, 1.021, 1.022, 1.021, 1.021, 1.021, 1.019, 1.017, 1.023, 1.028, 1.013, 1.004, 1.001\n>> >          ],\n>> > -        \"sigma\": 0.005,\n>> > -        \"sigma_Cb\": 0.005\n>> > +        \"sigma\": 0.00063,\n>> > +        \"sigma_Cb\": 0.00089\n>> >      },\n>> >      \"rpi.contrast\":\n>> >      {\n>> > @@ -185,6 +291,66 @@\n>> >              65535, 65535\n>> >          ]\n>> >      },\n>> > +    \"rpi.ccm\":\n>> > +    {\n>> > +        \"ccms\":\n>> > +        [\n>> > +            {\n>> > +                \"ct\": 2861, \"ccm\":\n>> > +                [\n>> > +                    1.61339, -0.55137, -0.06202, -0.24235, 1.42738, -0.18503, 0.07817, -0.77121, 1.69304\n>> > +                ]\n>> > +            },\n>> > +            {\n>> > +                \"ct\": 2915, \"ccm\":\n>> > +                [\n>> > +                    1.64366, -0.57014, -0.07352, -0.27249, 1.48118, -0.20869, 0.08973, -0.78375, 1.69402\n>> > +                ]\n>> > +            },\n>> > +            {\n>> > +                \"ct\": 2916, \"ccm\":\n>> > +                [\n>> > +                    1.59805, -0.49622, -0.10183, -0.17981, 1.25627, -0.07646, -0.00104, -0.62299, 1.62404\n>> > +                ]\n>> > +            },\n>> > +            {\n>> > +                \"ct\": 2922, \"ccm\":\n>> > +                [\n>> > +                    1.61099, -0.52067, -0.09032, -0.19271, 1.28084, -0.08813, 0.01453, -0.65247, 1.63794\n>> > +                ]\n>> > +            },\n>> > +            {\n>> > +                \"ct\": 2934, \"ccm\":\n>> > +                [\n>> > +                    1.60849, -0.51603, -0.09246, -0.19148, 1.28129, -0.08981, 0.01142, -0.64365, 1.63224\n>> > +                ]\n>> > +            },\n>> > +            {\n>> > +                \"ct\": 3626, \"ccm\":\n>> > +                [\n>> > +                    1.62525, -0.59206, -0.03319, -0.20241, 1.42135, -0.21895, 0.05845, -0.66941, 1.61096\n>> > +                ]\n>> > +            },\n>> > +            {\n>> > +                \"ct\": 4617, \"ccm\":\n>> > +                [\n>> > +                    1.62324, -0.66976, 0.04652, -0.16629, 1.56915, -0.40287, 0.07878, -0.73116, 1.65238\n>> > +                ]\n>> > +            },\n>> > +            {\n>> > +                \"ct\": 5674, \"ccm\":\n>> > +                [\n>> > +                    1.66733, -0.68927, 0.02194, -0.13995, 1.47994, -0.33998, 0.04474, -0.61721, 1.57247\n>> > +                ]\n>> > +            },\n>> > +            {\n>> > +                \"ct\": 7617, \"ccm\":\n>> > +                [\n>> > +                    1.53155, -0.66311, 0.13157, -0.03271, 1.65915, -0.62645, 0.07635, -1.01009, 1.93374\n>> > +                ]\n>> > +            }\n>> > +        ]\n>> > +    },\n>> >      \"rpi.sharpen\":\n>> >      {\n>> >      }\n>>\n>> --\n>> Regards,\n>>\n>> Laurent Pinchart","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6CC35BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 15 Jul 2022 10:49:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D48536330E;\n\tFri, 15 Jul 2022 12:49:50 +0200 (CEST)","from mail-ed1-x529.google.com (mail-ed1-x529.google.com\n\t[IPv6:2a00:1450:4864:20::529])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F34AF6330A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Jul 2022 12:49:48 +0200 (CEST)","by mail-ed1-x529.google.com with SMTP id w12so5747989edd.13\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Jul 2022 03:49:48 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657882190;\n\tbh=G6/cHRXN8udastUbP4nUMj3Sd64xlY2Ib1Nxm4zzwmQ=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=DOqQZysuM8940NS4FZGTtVUx0OrIzYNxogLa/04zEwxMtSGfF9lsa/K6JZ50TRVfi\n\tS1yE+4pQzRkS+YOGz0fx+VDvLrEvzEXL5qSvDy/jTl/pvo8r0GQvhPwsjtJXTXVxXv\n\t8W967lF9mV3igiluAXEg+yb8BekXJpagwEYYv1o9SL7+hbgAm7THRbucY4dIKEtJQz\n\tRBO6Zwy+aS5fmH05ir5BHYGPKsKW9r+rV0Uk6e+TX5Y4G1eqHSFllEImkl+Xpu/AeF\n\tr24yGCiKahWZINAFKsYeRqW7nzMdXIWPwg/enTOERBF0yHa/miFuGKSWovhKIysp1i\n\tmwuUuWeteiQuw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=bK5sEfBqHp2pkIAJ95sQc2mZB5YaLwYlFttfWinvaMY=;\n\tb=JMZ8OIG6lRcv+XP49zAtWPd2bcZLFoFf1g+HntQUyGmRmRoJnawMRnOdUIDgUD1t+O\n\tDegwvehmaTBKomMigEB9YdgUCXSP9EpT6oGf24E8c2stWNBqazcWV0yAT32MgYoBDQxE\n\tNMvXn6l3hN33TtRx/FlrGO3c+UZToiV96pRkt4lp6srk6q4aqemcE1XOY+f1Iif4tO7K\n\tF9SbRHtA0dTQYHlNUnLNu3h+pGnMWFR12ClRAoQJYxg1gwMnQgGFlgSp6e18WaifEwfY\n\tvyMmhG0GDptEj99HPWviC1U7+mMILsc+ZBRm4Zq8gTNZ47nKTCyqbe+QAsM1WNYotB5i\n\tGw0w=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"JMZ8OIG6\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=bK5sEfBqHp2pkIAJ95sQc2mZB5YaLwYlFttfWinvaMY=;\n\tb=zxGT+nlepgXJ/rjtlcQTwBPdHsR9ZQJkYS8pW2VaTpUD/4q8oDpoEXiKCW8ftz4T6c\n\tvXEBBSSKJ4W38wmTIv+zoF5hayw661j2DP3rcnav2GQAOxqCRZX+9roSX6s5+PQ3u5Ui\n\tF1YJRAsyKWXipMsc6E3NqHK00ZaVsZn21Tn3uMjTXLrfMPzCyEhyII/lqhDxA11qjODb\n\to5Uc5EVPra5ZpY8Dz6v5uity06dONMklN34SJYcoepE15/3k3LvbjdPsFkDppv5hTmm5\n\t2l5yQtfajQGqpE1lJy46YeVRJraaQ34wG56aYszmh6Fftxr2QVts0LR7LY7YJEmacaaX\n\tXb7A==","X-Gm-Message-State":"AJIora8zLTZFCZpBniJdkh9omj7fiSOEInE3TeyyNkA4Vdgn5ledMF4e\n\ttCIELOlc0l3xRFpWYmnbNySUZhU3CmPhDc0Q3mbatPd5PbG5xg==","X-Google-Smtp-Source":"AGRyM1tcAUGUoJinAOwzTRzGzrGFs5z4O5Z0vP1xdJ72KmUhro8V4/SZKAdhm40lXrpZQIUnW+SFFKJfSAqGywiZtAk=","X-Received":"by 2002:a05:6402:3311:b0:43a:8714:d486 with SMTP id\n\te17-20020a056402331100b0043a8714d486mr18074459eda.136.1657882188444;\n\tFri, 15 Jul 2022 03:49:48 -0700 (PDT)","MIME-Version":"1.0","References":"<20220714094143.4399-1-william.vinnicombe@raspberrypi.com>\n\t<20220714094143.4399-2-william.vinnicombe@raspberrypi.com>\n\t<YtCxYOESDACUu3CC@pendragon.ideasonboard.com>\n\t<CAEmqJPrWeBiOJgfBYWforxr09X8Sk5KAiM9jUOwtH=_TjV+awg@mail.gmail.com>","In-Reply-To":"<CAEmqJPrWeBiOJgfBYWforxr09X8Sk5KAiM9jUOwtH=_TjV+awg@mail.gmail.com>","Date":"Fri, 15 Jul 2022 11:49:32 +0100","Message-ID":"<CAPY8ntCkZjuxNZqOQRqdfdYm0xyjH-gN_V+G_meiO5iBJt8X1A@mail.gmail.com>","To":"Naushir Patuck <naush@raspberrypi.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 1/1] ipa: raspberrypi: Update imx296\n\ttuning file","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Dave Stevenson via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Dave Stevenson <dave.stevenson@raspberrypi.com>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":23929,"web_url":"https://patchwork.libcamera.org/comment/23929/","msgid":"<CAPY8ntDZgkxN2cxRmT4ed=E3SrPyh_Ci38vEWdAW=DiCb4OK9w@mail.gmail.com>","date":"2022-07-15T11:01:33","subject":"Re: [libcamera-devel] [PATCH 1/1] ipa: raspberrypi: Update imx296\n\ttuning file","submitter":{"id":27,"url":"https://patchwork.libcamera.org/api/people/27/","name":"Dave Stevenson","email":"dave.stevenson@raspberrypi.com"},"content":"On Fri, 15 Jul 2022 at 11:49, Dave Stevenson\n<dave.stevenson@raspberrypi.com> wrote:\n>\n> Hi All\n>\n> On Fri, 15 Jul 2022 at 08:24, Naushir Patuck via libcamera-devel\n> <libcamera-devel@lists.libcamera.org> wrote:\n> >\n> > Hi Laurent,\n> >\n> > On Fri, 15 Jul 2022 at 01:14, Laurent Pinchart via libcamera-devel <libcamera-devel@lists.libcamera.org> wrote:\n> >>\n> >> Hi William,\n> >>\n> >> Thank you for the patch.\n> >>\n> >> On Thu, Jul 14, 2022 at 10:41:43AM +0100, William Vinnicombe via libcamera-devel wrote:\n> >> > From: William Vinnicombe <william.vinnicombe@raspberrypi.com>\n> >> >\n> >> > The previous tuning values for the imx296 are not accurate, and do not\n> >> > contain awb parameters.\n> >>\n> >> There was a reason for that though, the file was meant for the\n> >> monochrome version of the sensor. See [1] for the full context. I'm\n> >> actually aware of one user of this tuning file with a monochrome sensor,\n> >> and this patch will break this use case.\n> >>\n> >> This brings nack the question that we decided to leave unanswered when\n> >> the imx296.json file was merged: how do we deal with different modules\n> >> that integrated the same camera sensor ?\n> >>\n> >> [1] https://lists.libcamera.org/pipermail/libcamera-devel/2022-January/028756.html\n> >\n> >\n> > This is indeed a real problem now.  Our (admittedly very loose) convention is to have\n> > the <sensor_name>.json file be the full colour variant, and any offshoot be named as\n> > <sensor_name>_<variant>.json.  Would we be able to give a heads-up and help this\n> > user switch to imx296_mono.json?  They would also benefit from the new tuning with\n> > updated noise and sharpening IQ performance.\n> >\n> > The difficult bit is how to choose a variant json without user intervention? Do we add\n> > a variant parameter in devicetree?  Some modules may have eeproms or ids that can\n> > store this, but I don't think there is a mechanism to return this information to userland\n> > from v4l2...?\n>\n> This is going to be a recurring issue, as a very similar thing was\n> true for imx290. There we have 2 compatible strings [1] as there isn't\n> a register to read for colour vs mono.\n>\n> The driver has to know in order to advertise the correct MEDIA_BUS_FMT_ formats.\n> Do we change the V4L2 sensor subdev name for variants (either based on\n> compatible or register) to denote an alternate tuning file? That\n> should then get magically picked up, but does it make for some\n> confusion choosing the camera helper?\n> (It would be nice to have a convention, but as it will be down to the\n> driver to provide the name they could be switched around on a per\n> driver basis).\n\nReplying to myself as I'm noticing the patches to the mainline ov9282\ndrivers to support ov9281 - that's another case where we could do with\nagreeing to deviate from just using the driver name.\n\nRPi have a downstream ov9281 driver, but the mainline one will\ncurrently use the module name, so won't match. OV9281 and OV9282\napparently have differing CRA characteristics, so will potentially\nwant slightly different tunings should we wish to support both.\nAdding a nice way to use the compatible string or custom suffix would\nbe very useful.\n\n>   Dave\n>\n> [1] https://github.com/raspberrypi/linux/blob/rpi-5.15.y/drivers/media/i2c/imx290.c#L1235\n>\n> > Naush\n> >\n> >>\n> >>\n> >>\n> >> > Update the tuning file using the raspberrypi ctt tool to give accurate\n> >> > values, and all required parameters.\n> >> >\n> >> > Signed-off-by: William Vinnicombe <william.vinnicombe@raspberrypi.com>\n> >> > ---\n> >> >  src/ipa/raspberrypi/data/imx296.json | 268 ++++++++++++++++++++++-----\n> >> >  1 file changed, 217 insertions(+), 51 deletions(-)\n> >> >\n> >> > diff --git a/src/ipa/raspberrypi/data/imx296.json b/src/ipa/raspberrypi/data/imx296.json\n> >> > index 837feff5..4d9d0e8b 100644\n> >> > --- a/src/ipa/raspberrypi/data/imx296.json\n> >> > +++ b/src/ipa/raspberrypi/data/imx296.json\n> >> > @@ -8,25 +8,97 @@\n> >> >      },\n> >> >      \"rpi.lux\":\n> >> >      {\n> >> > -        \"reference_shutter_speed\": 19184,\n> >> > -        \"reference_gain\": 1.0,\n> >> > +        \"reference_shutter_speed\": 17895,\n> >> > +        \"reference_gain\": 1.99,\n> >> >          \"reference_aperture\": 1.0,\n> >> > -        \"reference_lux\": 432,\n> >> > -        \"reference_Y\": 13773\n> >> > +        \"reference_lux\": 1147,\n> >> > +        \"reference_Y\": 13348\n> >> >      },\n> >> >      \"rpi.noise\":\n> >> >      {\n> >> > -        \"reference_constant\": 0,\n> >> > -        \"reference_slope\": 2.957\n> >> > +        \"reference_constant\": 1,\n> >> > +        \"reference_slope\": 2.631\n> >> >      },\n> >> >      \"rpi.geq\":\n> >> >      {\n> >> > -        \"offset\": 185,\n> >> > -        \"slope\": 0.0105\n> >> > +        \"offset\": 182,\n> >> > +        \"slope\": 0.0127\n> >> >      },\n> >> >      \"rpi.sdn\":\n> >> >      {\n> >> >      },\n> >> > +    \"rpi.awb\":\n> >> > +    {\n> >> > +        \"priors\":\n> >> > +        [\n> >> > +            {\n> >> > +                \"lux\": 0, \"prior\":\n> >> > +                [\n> >> > +                    2000, 1.0, 3000, 0.0, 13000, 0.0\n> >> > +                ]\n> >> > +            },\n> >> > +            {\n> >> > +                \"lux\": 800, \"prior\":\n> >> > +                [\n> >> > +                    2000, 0.0, 6000, 2.0, 13000, 2.0\n> >> > +                ]\n> >> > +            },\n> >> > +            {\n> >> > +                \"lux\": 1500, \"prior\":\n> >> > +                [\n> >> > +                    2000, 0.0, 4000, 1.0, 6000, 6.0, 6500, 7.0, 7000, 1.0, 13000, 1.0\n> >> > +                ]\n> >> > +            }\n> >> > +        ],\n> >> > +        \"modes\":\n> >> > +        {\n> >> > +            \"auto\":\n> >> > +            {\n> >> > +                \"lo\": 2500,\n> >> > +                \"hi\": 8000\n> >> > +            },\n> >> > +            \"incandescent\":\n> >> > +            {\n> >> > +                \"lo\": 2500,\n> >> > +                \"hi\": 3000\n> >> > +            },\n> >> > +            \"tungsten\":\n> >> > +            {\n> >> > +                \"lo\": 3000,\n> >> > +                \"hi\": 3500\n> >> > +            },\n> >> > +            \"fluorescent\":\n> >> > +            {\n> >> > +                \"lo\": 4000,\n> >> > +                \"hi\": 4700\n> >> > +            },\n> >> > +            \"indoor\":\n> >> > +            {\n> >> > +                \"lo\": 3000,\n> >> > +                \"hi\": 5000\n> >> > +            },\n> >> > +            \"daylight\":\n> >> > +            {\n> >> > +                \"lo\": 5500,\n> >> > +                \"hi\": 6500\n> >> > +            },\n> >> > +            \"cloudy\":\n> >> > +            {\n> >> > +                \"lo\": 7000,\n> >> > +                \"hi\": 8600\n> >> > +            }\n> >> > +        },\n> >> > +        \"bayes\": 1,\n> >> > +        \"ct_curve\":\n> >> > +        [\n> >> > +            2861.0, 0.4281, 0.2614, 2915.0, 0.4266, 0.2639, 2916.0, 0.4112, 0.2913, 2934.0, 0.4099, 0.2935, 3626.0, 0.3604, 0.3777, 4617.0,\n> >> > +            0.2776, 0.5093, 5674.0, 0.2567, 0.5409, 7617.0, 0.1789, 0.6527\n> >> > +        ],\n> >> > +        \"sensitivity_r\": 1.0,\n> >> > +        \"sensitivity_b\": 1.0,\n> >> > +        \"transverse_pos\": 0.02994,\n> >> > +        \"transverse_neg\": 0.04332\n> >> > +    },\n> >> >      \"rpi.agc\":\n> >> >      {\n> >> >          \"metering_modes\":\n> >> > @@ -113,65 +185,99 @@\n> >> >      \"rpi.alsc\":\n> >> >      {\n> >> >          \"omega\": 1.3,\n> >> > -        \"n_iter\": 0,\n> >> > +        \"n_iter\": 100,\n> >> >          \"luminance_strength\": 0.5,\n> >> >          \"calibrations_Cr\":\n> >> >          [\n> >> >              {\n> >> > -                \"ct\": 4000, \"table\":\n> >> > -                [\n> >> > -                    2.554, 2.554, 2.541, 2.534, 2.495, 2.506, 2.516, 2.517, 2.518, 2.515, 2.513, 2.495, 2.481, 2.533, 2.533, 2.521,\n> >> > -                    2.522, 2.534, 2.539, 2.531, 2.531, 2.506, 2.506, 2.513, 2.513, 2.509, 2.498, 2.496, 2.508, 2.517, 2.521, 2.521,\n> >> > -                    2.509, 2.517, 2.534, 2.529, 2.531, 2.521, 2.517, 2.517, 2.515, 2.514, 2.506, 2.499, 2.508, 2.508, 2.521, 2.537,\n> >> > -                    2.507, 2.508, 2.517, 2.516, 2.495, 2.487, 2.519, 2.534, 2.535, 2.531, 2.499, 2.494, 2.501, 2.511, 2.526, 2.526,\n> >> > -                    2.509, 2.517, 2.507, 2.501, 2.494, 2.519, 2.539, 2.539, 2.537, 2.537, 2.533, 2.499, 2.503, 2.511, 2.529, 2.525,\n> >> > -                    2.521, 2.522, 2.476, 2.501, 2.501, 2.539, 2.546, 2.538, 2.531, 2.538, 2.541, 2.531, 2.529, 2.526, 2.529, 2.525,\n> >> > -                    2.516, 2.519, 2.469, 2.499, 2.499, 2.543, 2.543, 2.531, 2.528, 2.534, 2.541, 2.535, 2.531, 2.526, 2.531, 2.528,\n> >> > -                    2.509, 2.515, 2.465, 2.487, 2.487, 2.539, 2.543, 2.539, 2.533, 2.549, 2.542, 2.531, 2.529, 2.524, 2.532, 2.533,\n> >> > -                    2.499, 2.499, 2.475, 2.482, 2.471, 2.509, 2.539, 2.544, 2.543, 2.545, 2.533, 2.498, 2.521, 2.521, 2.537, 2.536,\n> >> > -                    2.499, 2.488, 2.488, 2.488, 2.471, 2.462, 2.509, 2.539, 2.539, 2.532, 2.498, 2.498, 2.518, 2.518, 2.539, 2.539,\n> >> > -                    2.483, 2.484, 2.488, 2.488, 2.502, 2.496, 2.508, 2.514, 2.518, 2.517, 2.521, 2.518, 2.518, 2.518, 2.525, 2.539,\n> >> > -                    2.483, 2.487, 2.478, 2.478, 2.507, 2.509, 2.514, 2.513, 2.514, 2.517, 2.536, 2.559, 2.501, 2.501, 2.503, 2.525\n> >> > +                \"ct\": 2943, \"table\":\n> >> > +                [\n> >> > +                    2.153, 2.154, 2.154, 2.153, 2.153, 2.153, 2.153, 2.151, 2.151, 2.149, 2.149, 2.149, 2.149, 2.149, 2.151, 2.153,\n> >> > +                    2.154, 2.155, 2.155, 2.154, 2.154, 2.154, 2.153, 2.152, 2.151, 2.149, 2.149, 2.149, 2.149, 2.149, 2.151, 2.152,\n> >> > +                    2.155, 2.155, 2.155, 2.154, 2.154, 2.154, 2.153, 2.151, 2.151, 2.149, 2.149, 2.149, 2.149, 2.149, 2.151, 2.152,\n> >> > +                    2.154, 2.154, 2.155, 2.153, 2.153, 2.153, 2.152, 2.151, 2.149, 2.149, 2.149, 2.149, 2.148, 2.148, 2.149, 2.151,\n> >> > +                    2.153, 2.153, 2.153, 2.152, 2.152, 2.152, 2.151, 2.149, 2.149, 2.149, 2.149, 2.148, 2.148, 2.148, 2.149, 2.151,\n> >> > +                    2.153, 2.153, 2.152, 2.152, 2.152, 2.152, 2.151, 2.149, 2.149, 2.148, 2.148, 2.148, 2.147, 2.147, 2.148, 2.149,\n> >> > +                    2.152, 2.153, 2.152, 2.151, 2.151, 2.151, 2.151, 2.151, 2.149, 2.148, 2.148, 2.147, 2.147, 2.147, 2.148, 2.149,\n> >> > +                    2.152, 2.152, 2.152, 2.151, 2.151, 2.151, 2.151, 2.149, 2.148, 2.147, 2.146, 2.147, 2.147, 2.148, 2.149, 2.151,\n> >> > +                    2.152, 2.152, 2.152, 2.151, 2.151, 2.151, 2.151, 2.151, 2.149, 2.147, 2.146, 2.147, 2.148, 2.149, 2.152, 2.152,\n> >> > +                    2.152, 2.154, 2.154, 2.152, 2.152, 2.152, 2.152, 2.151, 2.151, 2.149, 2.149, 2.149, 2.151, 2.152, 2.153, 2.153,\n> >> > +                    2.155, 2.156, 2.155, 2.154, 2.152, 2.152, 2.152, 2.151, 2.151, 2.149, 2.149, 2.149, 2.151, 2.152, 2.153, 2.153,\n> >> > +                    2.155, 2.155, 2.155, 2.154, 2.152, 2.151, 2.151, 2.149, 2.148, 2.148, 2.149, 2.149, 2.151, 2.152, 2.152, 2.154\n> >> > +                ]\n> >> > +            },\n> >> > +            {\n> >> > +                \"ct\": 6097, \"table\":\n> >> > +                [\n> >> > +                    3.604, 3.605, 3.607, 3.605, 3.604, 3.604, 3.603, 3.602, 3.598, 3.594, 3.593, 3.593, 3.593, 3.593, 3.596, 3.602,\n> >> > +                    3.604, 3.607, 3.611, 3.609, 3.609, 3.608, 3.606, 3.602, 3.599, 3.596, 3.596, 3.594, 3.594, 3.594, 3.598, 3.602,\n> >> > +                    3.606, 3.611, 3.612, 3.609, 3.611, 3.609, 3.608, 3.602, 3.599, 3.597, 3.596, 3.595, 3.594, 3.594, 3.597, 3.599,\n> >> > +                    3.606, 3.609, 3.611, 3.607, 3.607, 3.606, 3.603, 3.599, 3.597, 3.595, 3.595, 3.593, 3.593, 3.592, 3.593, 3.596,\n> >> > +                    3.604, 3.607, 3.607, 3.604, 3.603, 3.602, 3.599, 3.597, 3.596, 3.595, 3.595, 3.594, 3.592, 3.591, 3.591, 3.594,\n> >> > +                    3.606, 3.607, 3.606, 3.604, 3.602, 3.601, 3.599, 3.597, 3.597, 3.596, 3.596, 3.595, 3.593, 3.591, 3.589, 3.592,\n> >> > +                    3.604, 3.606, 3.605, 3.603, 3.602, 3.602, 3.599, 3.598, 3.596, 3.595, 3.595, 3.595, 3.591, 3.589, 3.591, 3.592,\n> >> > +                    3.604, 3.604, 3.605, 3.602, 3.601, 3.601, 3.599, 3.598, 3.597, 3.595, 3.593, 3.591, 3.589, 3.591, 3.592, 3.596,\n> >> > +                    3.604, 3.605, 3.606, 3.602, 3.601, 3.601, 3.601, 3.599, 3.597, 3.595, 3.593, 3.591, 3.589, 3.594, 3.598, 3.599,\n> >> > +                    3.609, 3.613, 3.615, 3.611, 3.609, 3.609, 3.608, 3.605, 3.603, 3.599, 3.598, 3.597, 3.598, 3.601, 3.603, 3.603,\n> >> > +                    3.613, 3.616, 3.616, 3.613, 3.609, 3.609, 3.608, 3.606, 3.604, 3.602, 3.599, 3.599, 3.599, 3.602, 3.605, 3.605,\n> >> > +                    3.615, 3.616, 3.616, 3.613, 3.611, 3.604, 3.604, 3.601, 3.601, 3.599, 3.599, 3.599, 3.601, 3.602, 3.604, 3.604\n> >> >                  ]\n> >> >              }\n> >> >          ],\n> >> >          \"calibrations_Cb\":\n> >> >          [\n> >> >              {\n> >> > -                \"ct\": 4000, \"table\":\n> >> > -                [\n> >> > -                    2.619, 2.603, 2.599, 2.597, 2.595, 2.594, 2.589, 2.587, 2.586, 2.589, 2.592, 2.597, 2.601, 2.608, 2.621, 2.621,\n> >> > -                    2.619, 2.615, 2.603, 2.601, 2.596, 2.595, 2.591, 2.589, 2.589, 2.592, 2.599, 2.593, 2.601, 2.613, 2.622, 2.631,\n> >> > -                    2.617, 2.617, 2.612, 2.611, 2.604, 2.598, 2.593, 2.591, 2.592, 2.591, 2.593, 2.595, 2.599, 2.614, 2.623, 2.631,\n> >> > -                    2.624, 2.619, 2.615, 2.612, 2.605, 2.602, 2.597, 2.596, 2.592, 2.592, 2.595, 2.599, 2.602, 2.606, 2.619, 2.624,\n> >> > -                    2.629, 2.627, 2.627, 2.617, 2.609, 2.598, 2.612, 2.623, 2.615, 2.604, 2.589, 2.595, 2.599, 2.608, 2.611, 2.614,\n> >> > -                    2.629, 2.632, 2.637, 2.627, 2.612, 2.612, 2.629, 2.631, 2.628, 2.621, 2.604, 2.597, 2.598, 2.604, 2.609, 2.609,\n> >> > -                    2.635, 2.636, 2.642, 2.628, 2.623, 2.623, 2.636, 2.636, 2.634, 2.628, 2.616, 2.599, 2.597, 2.601, 2.603, 2.601,\n> >> > -                    2.641, 2.639, 2.646, 2.632, 2.627, 2.625, 2.632, 2.635, 2.634, 2.627, 2.614, 2.596, 2.595, 2.599, 2.599, 2.598,\n> >> > -                    2.643, 2.644, 2.651, 2.649, 2.629, 2.617, 2.624, 2.629, 2.625, 2.614, 2.586, 2.599, 2.595, 2.597, 2.592, 2.595,\n> >> > -                    2.645, 2.646, 2.649, 2.649, 2.638, 2.624, 2.616, 2.617, 2.609, 2.604, 2.603, 2.603, 2.595, 2.589, 2.587, 2.592,\n> >> > -                    2.641, 2.643, 2.649, 2.647, 2.638, 2.618, 2.615, 2.608, 2.602, 2.595, 2.596, 2.595, 2.593, 2.584, 2.581, 2.583,\n> >> > -                    2.638, 2.637, 2.647, 2.634, 2.634, 2.618, 2.621, 2.621, 2.611, 2.602, 2.596, 2.583, 2.581, 2.581, 2.576, 2.574\n> >> > +                \"ct\": 2943, \"table\":\n> >> > +                [\n> >> > +                    3.361, 3.369, 3.379, 3.385, 3.391, 3.397, 3.401, 3.401, 3.399, 3.396, 3.394, 3.391, 3.383, 3.382, 3.376, 3.375,\n> >> > +                    3.365, 3.372, 3.381, 3.387, 3.391, 3.398, 3.403, 3.403, 3.402, 3.399, 3.396, 3.392, 3.388, 3.382, 3.378, 3.374,\n> >> > +                    3.366, 3.377, 3.384, 3.388, 3.391, 3.399, 3.403, 3.405, 3.405, 3.401, 3.399, 3.393, 3.388, 3.384, 3.381, 3.374,\n> >> > +                    3.366, 3.378, 3.385, 3.389, 3.394, 3.398, 3.402, 3.405, 3.405, 3.404, 3.399, 3.393, 3.389, 3.385, 3.383, 3.369,\n> >> > +                    3.364, 3.377, 3.383, 3.388, 3.394, 3.398, 3.401, 3.404, 3.404, 3.404, 3.401, 3.394, 3.391, 3.386, 3.383, 3.371,\n> >> > +                    3.361, 3.376, 3.381, 3.387, 3.394, 3.397, 3.401, 3.402, 3.404, 3.403, 3.399, 3.397, 3.391, 3.387, 3.381, 3.371,\n> >> > +                    3.359, 3.373, 3.379, 3.385, 3.394, 3.396, 3.399, 3.401, 3.402, 3.401, 3.398, 3.396, 3.392, 3.385, 3.381, 3.371,\n> >> > +                    3.358, 3.368, 3.376, 3.381, 3.391, 3.395, 3.397, 3.399, 3.399, 3.397, 3.396, 3.392, 3.389, 3.383, 3.378, 3.365,\n> >> > +                    3.357, 3.366, 3.373, 3.379, 3.383, 3.392, 3.394, 3.396, 3.396, 3.393, 3.391, 3.388, 3.386, 3.382, 3.377, 3.365,\n> >> > +                    3.355, 3.362, 3.369, 3.374, 3.379, 3.385, 3.391, 3.393, 3.393, 3.392, 3.388, 3.385, 3.383, 3.379, 3.375, 3.362,\n> >> > +                    3.351, 3.354, 3.363, 3.369, 3.374, 3.379, 3.385, 3.387, 3.391, 3.385, 3.383, 3.382, 3.378, 3.377, 3.363, 3.361,\n> >> > +                    3.351, 3.352, 3.357, 3.359, 3.365, 3.371, 3.374, 3.375, 3.375, 3.375, 3.373, 3.367, 3.366, 3.366, 3.361, 3.362\n> >> > +                ]\n> >> > +            },\n> >> > +            {\n> >> > +                \"ct\": 6097, \"table\":\n> >> > +                [\n> >> > +                    1.654, 1.657, 1.662, 1.665, 1.666, 1.669, 1.671, 1.672, 1.671, 1.669, 1.668, 1.666, 1.661, 1.661, 1.658, 1.656,\n> >> > +                    1.655, 1.659, 1.663, 1.665, 1.667, 1.671, 1.672, 1.672, 1.673, 1.671, 1.669, 1.667, 1.663, 1.661, 1.659, 1.656,\n> >> > +                    1.656, 1.661, 1.665, 1.666, 1.668, 1.671, 1.673, 1.673, 1.674, 1.672, 1.669, 1.668, 1.664, 1.662, 1.659, 1.656,\n> >> > +                    1.656, 1.661, 1.665, 1.667, 1.668, 1.671, 1.673, 1.674, 1.674, 1.673, 1.671, 1.668, 1.665, 1.663, 1.661, 1.655,\n> >> > +                    1.656, 1.662, 1.665, 1.667, 1.669, 1.671, 1.673, 1.673, 1.674, 1.672, 1.671, 1.668, 1.665, 1.662, 1.661, 1.656,\n> >> > +                    1.655, 1.661, 1.664, 1.667, 1.669, 1.672, 1.672, 1.673, 1.673, 1.672, 1.671, 1.669, 1.666, 1.662, 1.661, 1.656,\n> >> > +                    1.654, 1.659, 1.663, 1.666, 1.669, 1.671, 1.672, 1.673, 1.673, 1.672, 1.671, 1.669, 1.666, 1.662, 1.661, 1.655,\n> >> > +                    1.653, 1.658, 1.662, 1.664, 1.668, 1.669, 1.672, 1.672, 1.672, 1.671, 1.669, 1.667, 1.665, 1.661, 1.659, 1.653,\n> >> > +                    1.652, 1.656, 1.659, 1.663, 1.666, 1.668, 1.669, 1.671, 1.671, 1.669, 1.667, 1.665, 1.663, 1.659, 1.657, 1.653,\n> >> > +                    1.649, 1.654, 1.658, 1.661, 1.663, 1.666, 1.668, 1.669, 1.668, 1.667, 1.665, 1.663, 1.661, 1.659, 1.657, 1.651,\n> >> > +                    1.646, 1.649, 1.654, 1.658, 1.661, 1.662, 1.664, 1.665, 1.666, 1.664, 1.662, 1.661, 1.659, 1.657, 1.651, 1.648,\n> >> > +                    1.645, 1.646, 1.651, 1.653, 1.655, 1.657, 1.659, 1.659, 1.659, 1.658, 1.657, 1.656, 1.653, 1.653, 1.649, 1.648\n> >> >                  ]\n> >> >              }\n> >> >          ],\n> >> >          \"luminance_lut\":\n> >> >          [\n> >> > -            1.308, 1.293, 1.228, 1.175, 1.139, 1.108, 1.092, 1.082, 1.082, 1.086, 1.097, 1.114, 1.149, 1.199, 1.279, 1.303,\n> >> > -            1.293, 1.249, 1.199, 1.162, 1.136, 1.109, 1.087, 1.077, 1.072, 1.081, 1.095, 1.103, 1.133, 1.172, 1.225, 1.282,\n> >> > -            1.251, 1.212, 1.186, 1.159, 1.129, 1.114, 1.102, 1.088, 1.088, 1.088, 1.095, 1.117, 1.123, 1.158, 1.198, 1.249,\n> >> > -            1.223, 1.192, 1.177, 1.163, 1.147, 1.139, 1.132, 1.112, 1.111, 1.107, 1.113, 1.118, 1.139, 1.155, 1.186, 1.232,\n> >> > -            1.207, 1.186, 1.171, 1.162, 1.168, 1.163, 1.153, 1.138, 1.129, 1.128, 1.132, 1.136, 1.149, 1.167, 1.189, 1.216,\n> >> > -            1.198, 1.186, 1.176, 1.176, 1.177, 1.185, 1.171, 1.157, 1.146, 1.144, 1.146, 1.149, 1.161, 1.181, 1.201, 1.221,\n> >> > -            1.203, 1.181, 1.176, 1.178, 1.191, 1.189, 1.188, 1.174, 1.159, 1.153, 1.158, 1.161, 1.169, 1.185, 1.211, 1.227,\n> >> > -            1.211, 1.179, 1.177, 1.187, 1.194, 1.196, 1.194, 1.187, 1.176, 1.169, 1.171, 1.171, 1.175, 1.189, 1.214, 1.226,\n> >> > -            1.219, 1.182, 1.184, 1.191, 1.195, 1.199, 1.197, 1.194, 1.188, 1.185, 1.179, 1.179, 1.182, 1.194, 1.212, 1.227,\n> >> > -            1.237, 1.192, 1.194, 1.194, 1.198, 1.199, 1.198, 1.197, 1.196, 1.193, 1.189, 1.189, 1.192, 1.203, 1.214, 1.231,\n> >> > -            1.282, 1.199, 1.199, 1.197, 1.199, 1.199, 1.192, 1.193, 1.193, 1.194, 1.196, 1.197, 1.206, 1.216, 1.228, 1.244,\n> >> > -            1.309, 1.236, 1.204, 1.203, 1.202, 1.194, 1.194, 1.188, 1.192, 1.192, 1.199, 1.201, 1.212, 1.221, 1.235, 1.247\n> >> > +            1.054, 1.059, 1.063, 1.063, 1.063, 1.063, 1.062, 1.062, 1.062, 1.062, 1.061, 1.059, 1.056, 1.052, 1.045, 1.043,\n> >> > +            1.055, 1.061, 1.065, 1.064, 1.065, 1.064, 1.063, 1.062, 1.063, 1.063, 1.061, 1.059, 1.057, 1.054, 1.049, 1.045,\n> >> > +            1.057, 1.062, 1.064, 1.063, 1.072, 1.072, 1.072, 1.062, 1.062, 1.062, 1.059, 1.058, 1.056, 1.054, 1.051, 1.047,\n> >> > +            1.058, 1.061, 1.063, 1.061, 1.062, 1.073, 1.073, 1.059, 1.058, 1.057, 1.057, 1.056, 1.055, 1.053, 1.051, 1.047,\n> >> > +            1.057, 1.059, 1.061, 1.059, 1.059, 1.059, 1.054, 1.054, 1.056, 1.056, 1.056, 1.055, 1.054, 1.052, 1.049, 1.043,\n> >> > +            1.055, 1.057, 1.059, 1.057, 1.056, 1.052, 1.049, 1.049, 1.053, 1.054, 1.054, 1.052, 1.051, 1.049, 1.043, 1.041,\n> >> > +            1.049, 1.053, 1.054, 1.055, 1.052, 1.049, 1.045, 1.043, 1.044, 1.047, 1.047, 1.046, 1.047, 1.044, 1.039, 1.035,\n> >> > +            1.045, 1.048, 1.049, 1.053, 1.047, 1.045, 1.041, 1.039, 1.041, 1.042, 1.042, 1.042, 1.041, 1.038, 1.033, 1.028,\n> >> > +            1.032, 1.045, 1.047, 1.047, 1.042, 1.039, 1.036, 1.035, 1.036, 1.037, 1.039, 1.039, 1.039, 1.034, 1.028, 1.021,\n> >> > +            1.022, 1.031, 1.038, 1.038, 1.035, 1.034, 1.033, 1.032, 1.031, 1.031, 1.037, 1.038, 1.041, 1.033, 1.021, 1.013,\n> >> > +            1.012, 1.021, 1.025, 1.027, 1.027, 1.028, 1.028, 1.027, 1.025, 1.024, 1.024, 1.029, 1.038, 1.028, 1.012, 1.004,\n> >> > +            1.011, 1.012, 1.017, 1.021, 1.021, 1.022, 1.021, 1.021, 1.021, 1.019, 1.017, 1.023, 1.028, 1.013, 1.004, 1.001\n> >> >          ],\n> >> > -        \"sigma\": 0.005,\n> >> > -        \"sigma_Cb\": 0.005\n> >> > +        \"sigma\": 0.00063,\n> >> > +        \"sigma_Cb\": 0.00089\n> >> >      },\n> >> >      \"rpi.contrast\":\n> >> >      {\n> >> > @@ -185,6 +291,66 @@\n> >> >              65535, 65535\n> >> >          ]\n> >> >      },\n> >> > +    \"rpi.ccm\":\n> >> > +    {\n> >> > +        \"ccms\":\n> >> > +        [\n> >> > +            {\n> >> > +                \"ct\": 2861, \"ccm\":\n> >> > +                [\n> >> > +                    1.61339, -0.55137, -0.06202, -0.24235, 1.42738, -0.18503, 0.07817, -0.77121, 1.69304\n> >> > +                ]\n> >> > +            },\n> >> > +            {\n> >> > +                \"ct\": 2915, \"ccm\":\n> >> > +                [\n> >> > +                    1.64366, -0.57014, -0.07352, -0.27249, 1.48118, -0.20869, 0.08973, -0.78375, 1.69402\n> >> > +                ]\n> >> > +            },\n> >> > +            {\n> >> > +                \"ct\": 2916, \"ccm\":\n> >> > +                [\n> >> > +                    1.59805, -0.49622, -0.10183, -0.17981, 1.25627, -0.07646, -0.00104, -0.62299, 1.62404\n> >> > +                ]\n> >> > +            },\n> >> > +            {\n> >> > +                \"ct\": 2922, \"ccm\":\n> >> > +                [\n> >> > +                    1.61099, -0.52067, -0.09032, -0.19271, 1.28084, -0.08813, 0.01453, -0.65247, 1.63794\n> >> > +                ]\n> >> > +            },\n> >> > +            {\n> >> > +                \"ct\": 2934, \"ccm\":\n> >> > +                [\n> >> > +                    1.60849, -0.51603, -0.09246, -0.19148, 1.28129, -0.08981, 0.01142, -0.64365, 1.63224\n> >> > +                ]\n> >> > +            },\n> >> > +            {\n> >> > +                \"ct\": 3626, \"ccm\":\n> >> > +                [\n> >> > +                    1.62525, -0.59206, -0.03319, -0.20241, 1.42135, -0.21895, 0.05845, -0.66941, 1.61096\n> >> > +                ]\n> >> > +            },\n> >> > +            {\n> >> > +                \"ct\": 4617, \"ccm\":\n> >> > +                [\n> >> > +                    1.62324, -0.66976, 0.04652, -0.16629, 1.56915, -0.40287, 0.07878, -0.73116, 1.65238\n> >> > +                ]\n> >> > +            },\n> >> > +            {\n> >> > +                \"ct\": 5674, \"ccm\":\n> >> > +                [\n> >> > +                    1.66733, -0.68927, 0.02194, -0.13995, 1.47994, -0.33998, 0.04474, -0.61721, 1.57247\n> >> > +                ]\n> >> > +            },\n> >> > +            {\n> >> > +                \"ct\": 7617, \"ccm\":\n> >> > +                [\n> >> > +                    1.53155, -0.66311, 0.13157, -0.03271, 1.65915, -0.62645, 0.07635, -1.01009, 1.93374\n> >> > +                ]\n> >> > +            }\n> >> > +        ]\n> >> > +    },\n> >> >      \"rpi.sharpen\":\n> >> >      {\n> >> >      }\n> >>\n> >> --\n> >> Regards,\n> >>\n> >> Laurent Pinchart","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 72C68BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 15 Jul 2022 11:01:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2D18763312;\n\tFri, 15 Jul 2022 13:01:51 +0200 (CEST)","from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com\n\t[IPv6:2a00:1450:4864:20::52d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16D3F6330A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Jul 2022 13:01:50 +0200 (CEST)","by mail-ed1-x52d.google.com with SMTP id r18so5792426edb.9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Jul 2022 04:01:50 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657882911;\n\tbh=ium0yH4Mk+3C5qDz4Ck6AHCQVxI7ttd/Hoi5w7dMLS0=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=B8XbWNEXKIaZoaQ3CWfhQ+0ALQwwwh2qwFc1BgTLbq9v9+IhwaCbRGj4zqtWTbrl0\n\tz64HC54xViCF8hJQafVN/gua8AbVsJM2mGQkciOYutZY0deJfeUJfceiGBmxwEegY9\n\tGgRApn7qscLEld/ZDZeSC9tY02j+8y1T94Ji/x+htOZIDM97HJt88z/I1x2q45FPLI\n\tC5hv44tl8WGKRBj2sK9CsmuGkv4dxPQrb7uVPqQylPjkLFFLctw0C91IzOqSaw31TN\n\t4Nm5GERzegGyxuMZLf0nbNVv9x1ns1nFV+uZPUzx0OGI9R2SsMwBAL2uWba1fnqkKp\n\tJOpzb7fQxINVg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=9mGpXjYrrVzqg/h1xLv3vDCWNZFUl6hspeRY531FyeE=;\n\tb=L80AgysVrDI9qIV7GPnqWtlLFYJk7IopeiP63Y8nBIsyL77/qcpvXgeMfYPgqlOwj9\n\txdpfqPzpMzEwOZvkWxIwGG1fL0Xvubk3/LOIFobjwmzZRzqI7ETB+9Kq00R+ebaHIjPu\n\tqfV5qU2kngVdSPmYXOTZICQOXeGhh77RxSUlwuRyO9Q2wgMwd+w2aMDnyZmiF6aRYhvw\n\t6n+4W9L9k40N1A1bJ+030o0GBRCghEk7hOTY6jm9jyjID/r1B67/XWTohznx42YA1Jzv\n\tKwZI3fseMI2xXPeFDDF7y9SnrhAHR+4W0xd2HtnguZLJoQxvZzS42Ws1ue4258vs9aar\n\tOKag=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"L80AgysV\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=9mGpXjYrrVzqg/h1xLv3vDCWNZFUl6hspeRY531FyeE=;\n\tb=Woz0DLIXvb8On2Vt1ESsYbF/OgULGpNXQ3dzzMF2ff/k1Fpo90ery/zop8suPH80Kc\n\tkL2Qt2p3V/WlptOB8hn1UpJP7feBYr6AGaNA6TMC6m214Hxjy1j0yGb1t8byqyVX3hXS\n\tchYc7MajXIKH09SSn8Gom5MqWyJb/jJnAQ3Fj0fI3LxDbYDv590VzsROgEbXeO3oeadr\n\twHeOlgmnFpBbbpo58ULhY4hIxuEvUSvQWa137umSPi8N6Vq9Smpn/mjQ1IERn+yqjzl3\n\tV9EiqkCCwxmC8JHtqWYPlrXyIHlFwRh+wwpccjk4Lu+nDHFPJSvmGKsxQg2uKDPKzEyt\n\t86pA==","X-Gm-Message-State":"AJIora+aFyBhy0cWA0oVej1CkEj2BFcqhO0tVNP1i3MRPIaHBMo8vI5H\n\tc5kHXIl7VfWJU5AaVFtwpl5CCSZqId0fShlO4SVgFA==","X-Google-Smtp-Source":"AGRyM1sSe2kPSeBEEloFx7cvLGflaM1gkbgOUB25yqF2d0MJdPcNk7APjc6wYIXo16jABib9JVoNb6g4rNxSixw4JUw=","X-Received":"by 2002:a05:6402:42d3:b0:435:2c49:313d with SMTP id\n\ti19-20020a05640242d300b004352c49313dmr17773908edc.86.1657882909484;\n\tFri, 15 Jul 2022 04:01:49 -0700 (PDT)","MIME-Version":"1.0","References":"<20220714094143.4399-1-william.vinnicombe@raspberrypi.com>\n\t<20220714094143.4399-2-william.vinnicombe@raspberrypi.com>\n\t<YtCxYOESDACUu3CC@pendragon.ideasonboard.com>\n\t<CAEmqJPrWeBiOJgfBYWforxr09X8Sk5KAiM9jUOwtH=_TjV+awg@mail.gmail.com>\n\t<CAPY8ntCkZjuxNZqOQRqdfdYm0xyjH-gN_V+G_meiO5iBJt8X1A@mail.gmail.com>","In-Reply-To":"<CAPY8ntCkZjuxNZqOQRqdfdYm0xyjH-gN_V+G_meiO5iBJt8X1A@mail.gmail.com>","Date":"Fri, 15 Jul 2022 12:01:33 +0100","Message-ID":"<CAPY8ntDZgkxN2cxRmT4ed=E3SrPyh_Ci38vEWdAW=DiCb4OK9w@mail.gmail.com>","To":"Naushir Patuck <naush@raspberrypi.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 1/1] ipa: raspberrypi: Update imx296\n\ttuning file","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Dave Stevenson via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Dave Stevenson <dave.stevenson@raspberrypi.com>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]