{"id":16613,"url":"https://patchwork.libcamera.org/api/patches/16613/?format=json","web_url":"https://patchwork.libcamera.org/patch/16613/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220713092159.9014-4-naush@raspberrypi.com>","date":"2022-07-13T09:21:54","name":"[libcamera-devel,v4,3/8] ipa: raspberrypi: Replace tabs with spaces in tuning data files","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e5ea42059c8f912924c244a2825de92aad5d9d91","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16613/mbox/","series":[{"id":3277,"url":"https://patchwork.libcamera.org/api/series/3277/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3277","date":"2022-07-13T09:21:51","name":"Replace boost JSON parser with libyaml in Raspberry Pi IPA","version":4,"mbox":"https://patchwork.libcamera.org/series/3277/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16613/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16613/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5D622BD1F1\n\tfor ;\n\tWed, 13 Jul 2022 09:22:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DCF616331F;\n\tWed, 13 Jul 2022 11:22:21 +0200 (CEST)","from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com\n\t[IPv6:2a00:1450:4864:20::42e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F0EA6330F\n\tfor ;\n\tWed, 13 Jul 2022 11:22:17 +0200 (CEST)","by mail-wr1-x42e.google.com with SMTP id d16so14588022wrv.10\n\tfor ;\n\tWed, 13 Jul 2022 02:22:17 -0700 (PDT)","from naush-laptop.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tbd20-20020a05600c1f1400b0039747cf8354sm1514778wmb.39.2022.07.13.02.22.16\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 13 Jul 2022 02:22:16 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657704142;\n\tbh=0VsX8zS1TV4woGZ66Yu7QUH0/Sz2R0YuZN0OvQ6ZI7U=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=tQtE5Yt+gu+Tpbe5Zw36CmZhNWZM1JP8yZNvrCGE5QgNSFaw7gkUqfB3GRSSCzUOm\n\tUiV34kAi5i6yEnY4OuCv8mBvg3yPQU9VJ92o8ELXaJvcSvTgSlWwLwpIwyQIHgqoVL\n\tvvEe4RpUp4Bl1BtWC6hgFYWNvecsWhWCbV2a/BmWE2z20imufkPUHdv8w1lLeON6Eb\n\tb4c1COT9zryvhHqwFHJHX9y8JEBCg5wtEXsU8Z1hCD0WAreBhbnyXCEo73sMPaUhJ2\n\tfL5o4eh5W5g1BxWIXEiaK8z8x0jNUiaKw5NrsOn3z8p0czKT+gFW5hDMaItogP2gb3\n\tswU2bmxQMEO8Q==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=XCiwtG7VvuAf9YF+a6FSlaeIMH3IKq7Wra9RxO0LF7g=;\n\tb=YVgeJmcWyn1VcBsZgO75hQ0K0hnVIDyMFWLZUHyBjowq4cXY2cteRiQH/QbAX8vfCH\n\trIyW60w0wRq3DdhMR/Z2t9xTabvDXbdydxd5SAgx3Ey6SH/4JOrheYMa9DuMevmscidY\n\tEzHo7PHAJatJPfafbv5Hx2JklQgeiiwVd9LKH5msPkLlnf5pKOIBBS9AejpsbEkUQSk1\n\tJIKOISV2bfi2tFtttbEwS+FWtXOHrvCG/haHeXZeku4vWSwftgXjNV3h++EI0BgG0Yon\n\ts85HiSb9fAxTnCPnnBSXuwR3K1AQBjfZq1cmkqtQiZmGYwJIDgLBwKupASFJ787VmSuA\n\toTfw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"YVgeJmcW\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=XCiwtG7VvuAf9YF+a6FSlaeIMH3IKq7Wra9RxO0LF7g=;\n\tb=pjCA1PoxGCt3oQT3vnqJJ8qR5jQLGme7szczwPs4KsI/i4KOG5l+NU63s3z4r4ibse\n\tENFmNXZsL+NhtqZPgZIPwovqt1HTz3G5IESfk6MANEm9PfMdSp9UNZpyJsYk3LfXWnf0\n\t+jqYIWGsBmsXwKcq4sgN91vWUGbL2OGdOjovhoadZ4b+zSPhiWDOlaoNynPTxFkKeZ0M\n\tnr5vikDTc7dQWQ3ZCGT9qbu4nWhGSyYJhaNqFCwyHu3C7zl3f+JGeSTFCSpMH5SXCy1Z\n\tSFgIXn4k7+tgfMy469wlTCFdgk5+eYzxvXjluSobMwsu13LEr6HMXptFiiAhGuaKpyUy\n\tr9MQ==","X-Gm-Message-State":"AJIora9lB+JYQCGlDo1tX7e7G9XhXBm790Cd9S3vmUM6c/D5gaT6yP0l\n\t4KyZHcvWRc3zb+1R5yL4A6L59jwnHFO4GQ==","X-Google-Smtp-Source":"AGRyM1tDjFnUw/KKJCoJ8VsMr0DCGFg3hBzfkv4eYfyrwlcRmxs2YaLPQA7aJnpClxeVuBpytmxAQA==","X-Received":"by 2002:adf:e652:0:b0:21d:6e43:3ec4 with SMTP id\n\tb18-20020adfe652000000b0021d6e433ec4mr2436576wrn.358.1657704136750; \n\tWed, 13 Jul 2022 02:22:16 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 13 Jul 2022 10:21:54 +0100","Message-Id":"<20220713092159.9014-4-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20220713092159.9014-1-naush@raspberrypi.com>","References":"<20220713092159.9014-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 3/8] ipa: raspberrypi: Replace tabs\n\twith spaces in tuning data files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Laurent Pinchart \n\nTuning data files mostly use spaces for indentation, with occasional\nstray tabs. Use spaces consistently. This allows parsing the tuning\nfiles with libyaml, preparing to replace the dependency on boost.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Naushir Patuck \nTested-by: Naushir Patuck \n---\n src/ipa/raspberrypi/data/imx219.json | 8 ++++----\n src/ipa/raspberrypi/data/imx219_noir.json | 10 +++++-----\n src/ipa/raspberrypi/data/imx290.json | 18 +++++++++---------\n src/ipa/raspberrypi/data/imx477.json | 8 ++++----\n src/ipa/raspberrypi/data/imx477_noir.json | 10 +++++-----\n src/ipa/raspberrypi/data/ov5647.json | 10 +++++-----\n src/ipa/raspberrypi/data/ov5647_noir.json | 12 ++++++------\n src/ipa/raspberrypi/data/se327m12.json | 6 +++---\n 8 files changed, 41 insertions(+), 41 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/data/imx219.json b/src/ipa/raspberrypi/data/imx219.json\nindex de59d9363be4..4e24c5d57da1 100644\n--- a/src/ipa/raspberrypi/data/imx219.json\n+++ b/src/ipa/raspberrypi/data/imx219.json\n@@ -189,10 +189,10 @@\n ]\n }\n ],\n-\t \"shadows\":\n-\t [\n-\t\t{\n-\t\t \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n+ \"shadows\":\n+ [\n+ {\n+ \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n [\n 0, 0.17, 1000, 0.17\n ]\ndiff --git a/src/ipa/raspberrypi/data/imx219_noir.json b/src/ipa/raspberrypi/data/imx219_noir.json\nindex 9a3f03ec86f4..1835ec3df63b 100644\n--- a/src/ipa/raspberrypi/data/imx219_noir.json\n+++ b/src/ipa/raspberrypi/data/imx219_noir.json\n@@ -31,7 +31,7 @@\n },\n \"rpi.awb\":\n {\n-\t\"bayes\": 0\n+ \"bayes\": 0\n },\n \"rpi.agc\":\n {\n@@ -121,10 +121,10 @@\n ]\n }\n ],\n-\t \"shadows\":\n-\t [\n-\t\t{\n-\t\t \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n+ \"shadows\":\n+ [\n+ {\n+ \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n [\n 0, 0.17, 1000, 0.17\n ]\ndiff --git a/src/ipa/raspberrypi/data/imx290.json b/src/ipa/raspberrypi/data/imx290.json\nindex 20b45c1684c2..1363bab71340 100644\n--- a/src/ipa/raspberrypi/data/imx290.json\n+++ b/src/ipa/raspberrypi/data/imx290.json\n@@ -29,11 +29,11 @@\n },\n \"rpi.awb\":\n {\n-\t\"bayes\": 0\n+ \"bayes\": 0\n },\n \"rpi.agc\":\n {\n-\t\"speed\": 0.2,\n+ \"speed\": 0.2,\n \"metering_modes\":\n {\n \"matrix\":\n@@ -150,14 +150,14 @@\n \"rpi.ccm\":\n {\n \"ccms\":\n-\t[\n+ [\n {\n-\t\t\"ct\": 3900, \"ccm\":\n-\t\t[\n-\t\t 1.54659, -0.17707, -0.36953, -0.51471, 1.72733, -0.21262, 0.06667, -0.92279, 1.85612\n-\t\t]\n-\t }\n-\t]\n+ \"ct\": 3900, \"ccm\":\n+ [\n+ 1.54659, -0.17707, -0.36953, -0.51471, 1.72733, -0.21262, 0.06667, -0.92279, 1.85612\n+ ]\n+ }\n+ ]\n },\n \"rpi.focus\":\n {\ndiff --git a/src/ipa/raspberrypi/data/imx477.json b/src/ipa/raspberrypi/data/imx477.json\nindex d07febd283ed..0f389661c246 100644\n--- a/src/ipa/raspberrypi/data/imx477.json\n+++ b/src/ipa/raspberrypi/data/imx477.json\n@@ -189,10 +189,10 @@\n ]\n }\n ],\n-\t \"shadows\":\n-\t [\n-\t\t{\n-\t\t \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n+ \"shadows\":\n+ [\n+ {\n+ \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n [\n 0, 0.17, 1000, 0.17\n ]\ndiff --git a/src/ipa/raspberrypi/data/imx477_noir.json b/src/ipa/raspberrypi/data/imx477_noir.json\nindex 7d4fc7dab9fd..a379d780d966 100644\n--- a/src/ipa/raspberrypi/data/imx477_noir.json\n+++ b/src/ipa/raspberrypi/data/imx477_noir.json\n@@ -31,7 +31,7 @@\n },\n \"rpi.awb\":\n {\n-\t\"bayes\": 0\n+ \"bayes\": 0\n },\n \"rpi.agc\":\n {\n@@ -121,10 +121,10 @@\n ]\n }\n ],\n-\t \"shadows\":\n-\t [\n-\t\t{\n-\t\t \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n+ \"shadows\":\n+ [\n+ {\n+ \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n [\n 0, 0.17, 1000, 0.17\n ]\ndiff --git a/src/ipa/raspberrypi/data/ov5647.json b/src/ipa/raspberrypi/data/ov5647.json\nindex 24bc06fb6114..e65f9385d970 100644\n--- a/src/ipa/raspberrypi/data/ov5647.json\n+++ b/src/ipa/raspberrypi/data/ov5647.json\n@@ -189,10 +189,10 @@\n ]\n }\n ],\n-\t \"shadows\":\n-\t [\n-\t\t{\n-\t\t \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n+ \"shadows\":\n+ [\n+ {\n+ \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n [\n 0, 0.17, 1000, 0.17\n ]\n@@ -203,7 +203,7 @@\n [\n 0, 0.16, 1000, 0.165, 10000, 0.17\n ],\n-\t\"base_ev\": 1.25\n+ \"base_ev\": 1.25\n },\n \"rpi.alsc\":\n {\ndiff --git a/src/ipa/raspberrypi/data/ov5647_noir.json b/src/ipa/raspberrypi/data/ov5647_noir.json\nindex 1c628ed13f19..dad73a5e8cd9 100644\n--- a/src/ipa/raspberrypi/data/ov5647_noir.json\n+++ b/src/ipa/raspberrypi/data/ov5647_noir.json\n@@ -31,7 +31,7 @@\n },\n \"rpi.awb\":\n {\n-\t\"bayes\": 0\n+ \"bayes\": 0\n },\n \"rpi.agc\":\n {\n@@ -121,10 +121,10 @@\n ]\n }\n ],\n-\t \"shadows\":\n-\t [\n-\t\t{\n-\t\t \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n+ \"shadows\":\n+ [\n+ {\n+ \"bound\": \"LOWER\", \"q_lo\": 0.0, \"q_hi\": 0.5, \"y_target\":\n [\n 0, 0.17, 1000, 0.17\n ]\n@@ -135,7 +135,7 @@\n [\n 0, 0.16, 1000, 0.165, 10000, 0.17\n ],\n-\t\"base_ev\": 1.25\n+ \"base_ev\": 1.25\n },\n \"rpi.alsc\":\n {\ndiff --git a/src/ipa/raspberrypi/data/se327m12.json b/src/ipa/raspberrypi/data/se327m12.json\nindex 94af2239f700..5b1ac2ce3bf8 100644\n--- a/src/ipa/raspberrypi/data/se327m12.json\n+++ b/src/ipa/raspberrypi/data/se327m12.json\n@@ -334,8 +334,8 @@\n },\n \"rpi.sharpen\":\n {\n-\t\"threshold\": 2.0,\n-\t\"strength\": 0.5,\n-\t\"limit\": 0.5\n+ \"threshold\": 2.0,\n+ \"strength\": 0.5,\n+ \"limit\": 0.5\n }\n }\n","prefixes":["libcamera-devel","v4","3/8"]}