[{"id":23888,"web_url":"https://patchwork.libcamera.org/comment/23888/","msgid":"<20220714184807.tdxqmgtvbzji4j3a@uno.localdomain>","date":"2022-07-14T18:48:07","subject":"Re: [libcamera-devel] [PATCH v2 07/11] ipa: rkisp1: Add OV5675\n\ttuning file","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Daniel,\n\nOn Wed, Jul 13, 2022 at 10:43:13AM +0200, Daniel Semkowicz via libcamera-devel wrote:\n> Add the OV5675 tuning file with default values and enabled AF algorithm.\n\nHave you checked in the datasheet ? Otherwise it's fine to have\nplace-holders for the time being, but let's record it in a \\todo note.\n\n>\n> Signed-off-by: Daniel Semkowicz \n> ---\n> src/ipa/rkisp1/data/meson.build | 1 +\n> src/ipa/rkisp1/data/ov5675.yaml | 12 ++++++++++++\n> 2 files changed, 13 insertions(+)\n> create mode 100644 src/ipa/rkisp1/data/ov5675.yaml\n>\n> diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build\n> index c3b4e388..03d71cbf 100644\n> --- a/src/ipa/rkisp1/data/meson.build\n> +++ b/src/ipa/rkisp1/data/meson.build\n> @@ -3,6 +3,7 @@\n> conf_files = files([\n> 'imx219.yaml',\n> 'ov5640.yaml',\n> + 'ov5675.yaml',\n> 'uncalibrated.yaml',\n> ])\n>\n> diff --git a/src/ipa/rkisp1/data/ov5675.yaml b/src/ipa/rkisp1/data/ov5675.yaml\n> new file mode 100644\n> index 00000000..82b2caaf\n> --- /dev/null\n> +++ b/src/ipa/rkisp1/data/ov5675.yaml\n> @@ -0,0 +1,12 @@\n> +---\n> +version: 1\n> +algorithms:\n> + - Af:\n> + - Agc:\n> + - Awb:\n> + - BlackLevelCorrection:\n> + R: 256\n> + Gr: 256\n> + Gb: 256\n> + B: 256\n> +...\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4D1C6BE173\n\tfor ;\n\tThu, 14 Jul 2022 18:48:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 095EE63312;\n\tThu, 14 Jul 2022 20:48:11 +0200 (CEST)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B61C6330D\n\tfor ;\n\tThu, 14 Jul 2022 20:48:09 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id DDF3F20002;\n\tThu, 14 Jul 2022 18:48:08 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657824491;\n\tbh=bXHNbgXv4FhySGa/1PIAl0SC7K/FX9QiaAku4sOeYsc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Ojksm0JQmJMyZi9CCbnoBe69aniZSrrMeMnQy3taUsrh2pCChi+H3MuZNRS/f6lgJ\n\tXFzOJ1f+DYinoYkf09HM5RigjNAqJ5TLIQQtxiC9gKAqE29b0O4RPeoH3Q1p4kyYCu\n\teaAv0fUNiWkxkpC5O7sLcOEtEvThIE8VdAt39cJq3dYZqzQ+KlzKQWtMsO0T5rgnwi\n\tyqeG7rFUH5OnVBsrRepJxiNyke0ekMVovzdsvB8YVplEbxOf8IRcsm1eUGC3zZADz0\n\t5fZRx7XOIKsnFokWglNnI+p98bBF8qYx1coDMRc23i6PgKvHGwQz/QYemhq5iESrft\n\tA7i1PTDV8iGPg==","Date":"Thu, 14 Jul 2022 20:48:07 +0200","To":"Daniel Semkowicz ","Message-ID":"<20220714184807.tdxqmgtvbzji4j3a@uno.localdomain>","References":"<20220713084317.24268-1-dse@thaumatec.com>\n\t<20220713084317.24268-8-dse@thaumatec.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220713084317.24268-8-dse@thaumatec.com>","Subject":"Re: [libcamera-devel] [PATCH v2 07/11] ipa: rkisp1: Add OV5675\n\ttuning file","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23955,"web_url":"https://patchwork.libcamera.org/comment/23955/","msgid":"","date":"2022-07-18T15:50:38","subject":"Re: [libcamera-devel] [PATCH v2 07/11] ipa: rkisp1: Add OV5675\n\ttuning file","submitter":{"id":126,"url":"https://patchwork.libcamera.org/api/people/126/","name":"Daniel Semkowicz","email":"dse@thaumatec.com"},"content":"Hi Jacopo,\n\nOn Thu, Jul 14, 2022 at 8:48 PM Jacopo Mondi wrote:\n>\n> Hi Daniel,\n>\n> On Wed, Jul 13, 2022 at 10:43:13AM +0200, Daniel Semkowicz via libcamera-devel wrote:\n> > Add the OV5675 tuning file with default values and enabled AF algorithm.\n>\n> Have you checked in the datasheet ? Otherwise it's fine to have\n> place-holders for the time being, but let's record it in a \\todo note.\n\nNo, I just used the default values. These are used even if no parameters\nare supplied in the tuning file, so maybe I should remove them from the\nfile, as it can be misleading that these are the measured values.\n\nBest regards\nDaniel\n\n>\n> >\n> > Signed-off-by: Daniel Semkowicz \n> > ---\n> > src/ipa/rkisp1/data/meson.build | 1 +\n> > src/ipa/rkisp1/data/ov5675.yaml | 12 ++++++++++++\n> > 2 files changed, 13 insertions(+)\n> > create mode 100644 src/ipa/rkisp1/data/ov5675.yaml\n> >\n> > diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build\n> > index c3b4e388..03d71cbf 100644\n> > --- a/src/ipa/rkisp1/data/meson.build\n> > +++ b/src/ipa/rkisp1/data/meson.build\n> > @@ -3,6 +3,7 @@\n> > conf_files = files([\n> > 'imx219.yaml',\n> > 'ov5640.yaml',\n> > + 'ov5675.yaml',\n> > 'uncalibrated.yaml',\n> > ])\n> >\n> > diff --git a/src/ipa/rkisp1/data/ov5675.yaml b/src/ipa/rkisp1/data/ov5675.yaml\n> > new file mode 100644\n> > index 00000000..82b2caaf\n> > --- /dev/null\n> > +++ b/src/ipa/rkisp1/data/ov5675.yaml\n> > @@ -0,0 +1,12 @@\n> > +---\n> > +version: 1\n> > +algorithms:\n> > + - Af:\n> > + - Agc:\n> > + - Awb:\n> > + - BlackLevelCorrection:\n> > + R: 256\n> > + Gr: 256\n> > + Gb: 256\n> > + B: 256\n> > +...\n> > --\n> > 2.34.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ACD61BD1F1\n\tfor ;\n\tMon, 18 Jul 2022 15:50:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 438406330E;\n\tMon, 18 Jul 2022 17:50:52 +0200 (CEST)","from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com\n\t[IPv6:2a00:1450:4864:20::12c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4E1906048B\n\tfor ;\n\tMon, 18 Jul 2022 17:50:50 +0200 (CEST)","by mail-lf1-x12c.google.com with SMTP id n18so20088699lfq.1\n\tfor ;\n\tMon, 18 Jul 2022 08:50:50 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658159452;\n\tbh=zc4/qBTJtrAp9idRp32EPUgMrrVu6l9KJX5CKJDj6RQ=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=dGolIM33JKVZrLHbdolGGhktJVznlaaU8PW7t25C5JFhVcOBa3pk+wd059RFQmkIM\n\toMaDZBaVE36jQaqPP5XY8amYUzLANtba76QfeCfduW93U24UYyIa2t4lNrxsuVHkdV\n\t73a4fw7OUZ5TrG0xdPFg/yZOyP6rZN/d/+GLKj7FhLY6nFotzlJoahHJIIdVCH2wn0\n\tZPi4nWKHBQuQampVxFbo6+NuuFgwE4GqlmRKSXGNl8I3YfaQwwN6tvCmitXhyNITjn\n\tN21/DzEXtOE8vLhfZ0yltXF+mt5mnqnUkbg3ML2jEXOabmgYDECkRKuae7nfJNen95\n\tyc8Vk3mHrY3kQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=thaumatec-com.20210112.gappssmtp.com; s=20210112;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=Yp/rLzDFoyyvuqI15zdBpcSqwvBYiifdLQIKIaKw8P4=;\n\tb=6cwpq5f2T1CXoFt9vtSeydEo839mWJuIXMmD0AOKHc4LeGVFK2s6E1B2yhbUT00hfV\n\tU1vpLEsyoUUcRyCOmLbUMcY1cQpOK8ErDY4yJ7HId7HEj++uypZPbQl/Bn2rO1ets5CN\n\t/FBkcKWee+XPaF1iMSZg8qbPg9m8XgP4iXPniaA929QsQChPZdLLynhJxSJheawGRJJl\n\tY+3dweyDETe3YvMj3hjDvB3HMl1FU8eS96RHADEVFuqWIEDZC70lcX5sxhG2TQXKNKqg\n\tmCZkIlHZPdEJDiXQL1zZJqL/LmFZGYjEZsoKMolbqOM156N2LNv+PWMwRYZyity62OeU\n\tafZg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=thaumatec-com.20210112.gappssmtp.com\n\theader.i=@thaumatec-com.20210112.gappssmtp.com header.b=\"6cwpq5f2\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=Yp/rLzDFoyyvuqI15zdBpcSqwvBYiifdLQIKIaKw8P4=;\n\tb=6Q6WOH+qRKKG0h7MPy9R7uWbVIRKzAEq8L9cYS9IvXx9xXsW0KO+dhgCXaue3y0fs5\n\tXdUefocyRZYQcTZBunFosEYD5cceW/kvyX5ZVkHGMxcYNFd2pet7FxdBSGA0tiN4uhCa\n\twojN0t64oUlaNStAl7udqGtc8DAgau2NQOImkzbqDobCM95TVJefBUs1wLORGd8YEte3\n\tES5yLcSkYnWKJDzfBN7cHwLmZnv0jKsYnQq5pbEn1yhw06EcLYdBPS624hSMYB12QPz1\n\tBnxtiCXdBSSlimjKwGHHPNndwDojbyMmW8XzXDzINw2EZHoCA2Q5lZC/vNcUEerLPPE+\n\to96Q==","X-Gm-Message-State":"AJIora8+5jjJE1c/3xPq1s0QywcMts6Q+hfXR3sw9OhXBy3pMH6biQbx\n\tn0OGZQ1giZNVQsQV/JR0E90fHMoN5IsBn+924Vi0VQ==","X-Google-Smtp-Source":"AGRyM1uPVsopss5HUR5Ssfzo+OZrEuooYtp7YtZkMMhlb1lq43WIRNrVaC0zjtCTSldDS68HVb/y082X8ED560TwrRU=","X-Received":"by 2002:a05:6512:3f14:b0:47d:e011:f19b with SMTP id\n\ty20-20020a0565123f1400b0047de011f19bmr14385751lfa.427.1658159449700;\n\tMon, 18 Jul 2022 08:50:49 -0700 (PDT)","MIME-Version":"1.0","References":"<20220713084317.24268-1-dse@thaumatec.com>\n\t<20220713084317.24268-8-dse@thaumatec.com>\n\t<20220714184807.tdxqmgtvbzji4j3a@uno.localdomain>","In-Reply-To":"<20220714184807.tdxqmgtvbzji4j3a@uno.localdomain>","Date":"Mon, 18 Jul 2022 17:50:38 +0200","Message-ID":"","To":"Jacopo Mondi ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v2 07/11] ipa: rkisp1: Add OV5675\n\ttuning file","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Daniel Semkowicz via libcamera-devel\n\t","Reply-To":"Daniel Semkowicz ","Cc":"Jacopo Mondi via libcamera-devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]