{"id":16592,"url":"https://patchwork.libcamera.org/api/patches/16592/?format=json","web_url":"https://patchwork.libcamera.org/patch/16592/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220711153711.36679-6-rishikeshdonadkar@gmail.com>","date":"2022-07-11T15:37:11","name":"[libcamera-devel,v3,5/5] gstreamer: Reset the colorSpace if not the same after validation.","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b82ec4108a553a589d88c677880489ef4c93765c","submitter":{"id":118,"url":"https://patchwork.libcamera.org/api/people/118/?format=json","name":"Rishikesh Donadkar","email":"rishikeshdonadkar@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16592/mbox/","series":[{"id":3270,"url":"https://patchwork.libcamera.org/api/series/3270/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3270","date":"2022-07-11T15:37:06","name":"Add colorimetry support to libcamera gstreamer element.","version":3,"mbox":"https://patchwork.libcamera.org/series/3270/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16592/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16592/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CD146BE173\n\tfor ;\n\tMon, 11 Jul 2022 15:38:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8F1BC6330F;\n\tMon, 11 Jul 2022 17:38:33 +0200 (CEST)","from mail-pl1-x632.google.com (mail-pl1-x632.google.com\n\t[IPv6:2607:f8b0:4864:20::632])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 247506330B\n\tfor ;\n\tMon, 11 Jul 2022 17:38:32 +0200 (CEST)","by mail-pl1-x632.google.com with SMTP id z1so4758503plb.1\n\tfor ;\n\tMon, 11 Jul 2022 08:38:32 -0700 (PDT)","from localhost.localdomain ([103.124.170.70])\n\tby smtp.googlemail.com with ESMTPSA id\n\tu18-20020a17090a891200b001ef87123615sm4891268pjn.37.2022.07.11.08.38.28\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 11 Jul 2022 08:38:30 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657553913;\n\tbh=kULF7VbtYaBkYNMW7DM8pQM1bmJ1OtrgmprKdtBkR1M=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=oHVdDBHv4nSSPlTC/bW2wAMIrAh3XGBTyDd9KnE80bAtFh+h2P8oOFR9EtDZ3WMU2\n\t5Y9MfT9vEFhSVXCiKe6WAPGmzV55H7O+AnyAWpMHeQ0d2jx4sagYbiUx7pPe+EBtgD\n\tNIlPhbIqNCEy98OgD0FkaeVD3hqylPOkBMYQToNbXFszXBOrtHXP/jE6TU+tj4BZK/\n\tasVMEtojr84TqW50J8EWWe5BwahuokIQ3KgY7C+/B4Hnb99VQEfM528AernrfuvOHy\n\tx6chcIw2tn+ciV+hgi0FZSrmnwHQCD6+ZkjuFYTla967VvecECu145/JTEGEvduwy/\n\tz9TIqaBbg5Ang==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=OaNc6z+asGLANI8tRcf6ua0YOq+0JYVVlhWAGFupSDY=;\n\tb=JBFNrrpgpoTJDZgARMKOkt68W8MQBXcna5bBPf41U7yQwYocH3brC6XbDe2l4m5fL4\n\thArYGmLU/WgUlYol+j6CyaQXIByRlpmY8QsOea6plHN0xbIEcMni80VcHM4psSbyccSB\n\t5LtJzwjHD6dOkc1WCltmW6/Pkp7OHaaI46owtHcNsrSLDYuaE2j3eTzTF2Cy3XTQNJBl\n\tE55hFcjbifpKvix6eAwcdXt41XwJDdZjy0TD7eY7adNp6UHaJQdyN3swEAkrytoGliPR\n\tb39Hnmf/rwdkmkKeIhH43l9sZf+vm7GnmVaI+xt11WyHtP9j+ovk8nKe829OChApXp+9\n\t4iag=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"JBFNrrpg\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=OaNc6z+asGLANI8tRcf6ua0YOq+0JYVVlhWAGFupSDY=;\n\tb=3vOr6LqZzJvG4N5Tg34x3SpwG/MV0Hn9phqWpBi6Ij6ZbNsU8WEvrSVK1XzW7xKTHa\n\toXykKzKYXML+NEaNJG5JxfiVb1PxTBFAQrxY61e5c0hB6Rk1jrFl0QrMeCov4o59Y/QN\n\tWQlcoEiOr0eD40pc5RMeJVpDZpxr6ivEdBnO9rXg9jPqDkzLx3Hyc6h9kOrg4QaAsJ8o\n\tbyuTaXxAy/V7LyXmWTMgYq7k/Oq0er9WNMaEP83GvqH4cMezAjO1H3Mf/+bfEPvQMm83\n\t95fuddHDWluHHiYjJZLNf/lzUEm66D0eIWN5p2QL/FeQUGj5tJimAJH+kMQvvLa2udde\n\tShSA==","X-Gm-Message-State":"AJIora/aAP+6MZIv+TxdR2TvHrFGxISL3scstZz21jVIxuc5wCELArYg\n\t2Tf0/8kLMJE6jjjMXDZSTjm3CcsoUEU=","X-Google-Smtp-Source":"AGRyM1ssmrDqfSTYiw27oyw+Bur5uWJowdKL1cZUrI6LwwxR/IS9bvg1EbmH5xbuw42AXDXnO7H9BQ==","X-Received":"by 2002:a17:902:b198:b0:16c:1c13:cd8d with SMTP id\n\ts24-20020a170902b19800b0016c1c13cd8dmr19183286plr.92.1657553910529; \n\tMon, 11 Jul 2022 08:38:30 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 11 Jul 2022 21:07:11 +0530","Message-Id":"<20220711153711.36679-6-rishikeshdonadkar@gmail.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20220711153711.36679-1-rishikeshdonadkar@gmail.com>","References":"<20220711153711.36679-1-rishikeshdonadkar@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 5/5] gstreamer: Reset the colorSpace if\n\tnot the same after validation.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Rishikesh Donadkar via libcamera-devel\n\t","Reply-To":"Rishikesh Donadkar ","Cc":"Rishikesh Donadkar ,\n\tnicolas.dufresne@collabora.com, vedantparanjape160201@gmail.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If the colorSpace set in the previous patch is not same after validation,\nReset the colorSpace to the previous value that was present before applying the\nrequested colorspace.\n\nSigned-off-by: Rishikesh Donadkar \n---\n src/gstreamer/gstlibcamerasrc.cpp | 12 ++++++++++++\n 1 file changed, 12 insertions(+)","diff":"diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex a7a0c440..6cb631df 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -461,6 +461,8 @@ gst_libcamera_src_task_enter(GstTask *task, [[maybe_unused]] GThread *thread,\n \tGstLibcameraSrcState *state = self->state;\n \tGstFlowReturn flow_ret = GST_FLOW_OK;\n \tgint ret;\n+\tstd::vector> prevColorSpaces;\n+\tstd::vector> appliedColorSpaces;\n \n \tGST_DEBUG_OBJECT(self, \"Streaming thread has started\");\n \n@@ -501,9 +503,13 @@ gst_libcamera_src_task_enter(GstTask *task, [[maybe_unused]] GThread *thread,\n \t\t\tbreak;\n \t\t}\n \n+\t\t/*Store the colorSpaces applied pew pad. */\n+\t\tprevColorSpaces.push_back(stream_cfg.colorSpace);\n+\n \t\t/* Fixate caps and configure the stream. */\n \t\tcaps = gst_caps_make_writable(caps);\n \t\tgst_libcamera_configure_stream_from_caps(stream_cfg, caps);\n+\t\tappliedColorSpaces.push_back(stream_cfg.colorSpace);\n \t}\n \n \tif (flow_ret != GST_FLOW_OK)\n@@ -515,6 +521,12 @@ gst_libcamera_src_task_enter(GstTask *task, [[maybe_unused]] GThread *thread,\n \t\tgoto done;\n \t}\n \n+\tfor (gsize i = 0; i < state->srcpads_.size(); i++) {\n+\t\tStreamConfiguration &stream_cfg = state->config_->at(i);\n+\n+\t\tif (stream_cfg.colorSpace != appliedColorSpaces[i])\n+\t\t\tstream_cfg.colorSpace = prevColorSpaces[i];\n+\t}\n \t/*\n \t * Regardless if it has been modified, create clean caps and push the\n \t * caps event. Downstream will decide if the caps are acceptable.\n","prefixes":["libcamera-devel","v3","5/5"]}