[{"id":23808,"web_url":"https://patchwork.libcamera.org/comment/23808/","msgid":"<Ysn27N0D7Q/a+6iw@pendragon.ideasonboard.com>","date":"2022-07-09T21:45:16","subject":"Re: [libcamera-devel] [PATCH 1/2] utils: ipu3-unpack: Fix error\n\tstring","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Sat, Jul 09, 2022 at 03:58:37AM +0530, Umang Jain via libcamera-devel wrote:\n> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  utils/ipu3/ipu3-unpack.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/utils/ipu3/ipu3-unpack.c b/utils/ipu3/ipu3-unpack.c\n> index 2dce1038..9d2c1200 100644\n> --- a/utils/ipu3/ipu3-unpack.c\n> +++ b/utils/ipu3/ipu3-unpack.c\n> @@ -79,7 +79,7 @@ int main(int argc, char *argv[])\n>  \n>  \t\tret = write(out_fd, out_data, 50);\n>  \t\tif (ret < -1) {\n> -\t\t\tfprintf(stderr, \"Failed to read input data: %s\\n\",\n> +\t\t\tfprintf(stderr, \"Failed to write output data: %s\\n\",\n>  \t\t\t\tstrerror(errno));\n>  \t\t\tgoto done;\n>  \t\t}","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 72A6BBE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat,  9 Jul 2022 21:45:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA64E63312;\n\tSat,  9 Jul 2022 23:45:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 50A7F60406\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat,  9 Jul 2022 23:45:44 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CAFC247C;\n\tSat,  9 Jul 2022 23:45:43 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657403145;\n\tbh=UOX3BxqYsSVkLIJmNxH2dpqOWS4i+h4TpN4KxiN5TCQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=3EnmgP3HieqX923JvEQlmZEdIhoWweaUrKeyAIVx+LUjdFCCtPrR4aQ/OBIhzvipY\n\t/7tfSBcBhQSPOyuMxOjUY0kJpW04HshNgdc5X+/wwxThjwTOzoj4ytrMkCJWLtdbH5\n\tWWwRBDdiMrOSXs2+8ZuABfRESHdLp5DtV31BxtC/nVnQ3qnITznQxRnZVsdvE6VuGv\n\tPty/5dMUNlqvVbfW7/+CokH4QKtkkzHnw3zR4KvYLnvRbxUyaClh0FAm2+MYscNVhb\n\t+1odgs2xNi2bzwk07RylY9j+TEBuHnr2QINLcmBc+kTqhDNSY0FhR7XYsBUQb5KaHY\n\taMvEa8/7YCCXw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657403144;\n\tbh=UOX3BxqYsSVkLIJmNxH2dpqOWS4i+h4TpN4KxiN5TCQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=epMuUvQCXhaoOPT0XVcPZbnRQnIT1TtLWCTwJVayV0sYJqAY+tifMuItrEx7g4CfF\n\tK8kX+vm6i7/Ak88lxmFemZ1QDPdeZI4bbgBYHuXV1V9JC6t0AnvcvWUxx9MVtEegJd\n\tplZCIE1MV2aRWvN3Td1BXnA5CvGCWZzoPD4mPbFM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"epMuUvQC\"; dkim-atps=neutral","Date":"Sun, 10 Jul 2022 00:45:16 +0300","To":"Umang Jain <umang.jain@ideasonboard.com>","Message-ID":"<Ysn27N0D7Q/a+6iw@pendragon.ideasonboard.com>","References":"<20220708222838.370187-1-umang.jain@ideasonboard.com>\n\t<20220708222838.370187-2-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220708222838.370187-2-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] utils: ipu3-unpack: Fix error\n\tstring","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]