[{"id":23801,"web_url":"https://patchwork.libcamera.org/comment/23801/","msgid":"","date":"2022-07-07T21:33:45","subject":"Re: [libcamera-devel] [PATCH 3/4] pipeline: rkisp1: Add support for\n\tYUV422 and YVU422","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Jul 08, 2022 at 12:03:09AM +0900, Paul Elder via libcamera-devel wrote:\n> YUV422 and YVU422 are already supported as output formats by the rkisp1\n> driver. Add them to the pipeline handler to support them in libcamera as\n> well.\n> \n> Signed-off-by: Paul Elder \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> index c34e4147..24ff62e1 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> @@ -209,10 +209,12 @@ void RkISP1Path::stop()\n> namespace {\n> constexpr Size RKISP1_RSZ_MP_SRC_MIN{ 32, 16 };\n> constexpr Size RKISP1_RSZ_MP_SRC_MAX{ 4416, 3312 };\n> -constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> +constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> \tformats::YUYV,\n> \tformats::YUV420,\n> \tformats::YVU420,\n> +\tformats::YUV422,\n> +\tformats::YVU422,\n> \tformats::NV16,\n> \tformats::NV61,\n> \tformats::NV21,\n\nAs for patch 1/4, I think you need to add these to the selfpath too.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 19CB9BD1F1\n\tfor ;\n\tThu, 7 Jul 2022 21:34:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AE7496330E;\n\tThu, 7 Jul 2022 23:34:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 496AA60400\n\tfor ;\n\tThu, 7 Jul 2022 23:34:12 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D67B5D00;\n\tThu, 7 Jul 2022 23:34:11 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657229653;\n\tbh=fRkhO4Oz/9E2usm9Exr2uD+3G6WNZWRJtkNRHqYiLVU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Vu3oq+rB+rCwnpg5Z2rRGFyAhTnfq54P+J6qKKhIJ/4z7TRHlHVt3exuc22msIiRR\n\tm9PHhyT9Za3EjM4eE4gsDGU4THKfBRzPd5oCr0O4+ecOjcRXjSZGRXvw2kJxjjAZYj\n\t8GdMrYl+PpHTorfRw0/LBHkU9vi45RMr44GyvajL+WZOASDZbPl+RqLiJU7HEikotI\n\t2YM4SasYW0iWnyemfKMaHabcxJibzVdwNmr86gc7KUC1kfVVfN//WllqDTdqYyybZ7\n\ttHjpl+uYRfEP3p+Udo1vFDW3Ip3qbjxzGV+us9qyqr8cW2peSQVjDf0zhnOkI6PVvz\n\txvGufhdv9A8FA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657229652;\n\tbh=fRkhO4Oz/9E2usm9Exr2uD+3G6WNZWRJtkNRHqYiLVU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hsYmvqOOQ+EgmEY9w3RifxUuhMs2Iy2HbeXcRg3Vg9O46TjtrDbzJpP42sSGyo7bR\n\tHO3JvIyZ9cTf/wzONZLZv4Kw6zsx2ajd3MAnfVpBKP6Vpg5e0JmlQaMDTThz2R5YV0\n\tJ8Xk2G8V8mIcVD1xavChj3UWA5GGk+bHB46Hy4Ts="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"hsYmvqOO\"; dkim-atps=neutral","Date":"Fri, 8 Jul 2022 00:33:45 +0300","To":"Paul Elder ","Message-ID":"","References":"<20220707150310.3645858-1-paul.elder@ideasonboard.com>\n\t<20220707150310.3645858-4-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220707150310.3645858-4-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 3/4] pipeline: rkisp1: Add support for\n\tYUV422 and YVU422","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]