[{"id":23798,"web_url":"https://patchwork.libcamera.org/comment/23798/","msgid":"","date":"2022-07-07T21:16:18","subject":"Re: [libcamera-devel] [PATCH 1/4] pipeline: rkisp1: Add output\n\tsupport for YUV420 and YVU420","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Jul 08, 2022 at 12:03:07AM +0900, Paul Elder via libcamera-devel wrote:\n> YUV420 and YVU420 are already supported as output formats by the rkisp1\n> driver. Add them to the pipeline handler to support them in libcamera as\n> well.\n> \n> Signed-off-by: Paul Elder \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> index 6f175758..c34e4147 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> @@ -130,6 +130,8 @@ int RkISP1Path::configure(const StreamConfiguration &config,\n> \tswitch (config.pixelFormat) {\n> \tcase formats::NV12:\n> \tcase formats::NV21:\n> +\tcase formats::YUV420:\n> +\tcase formats::YVU420:\n> \t\tispFormat.mbus_code = MEDIA_BUS_FMT_YUYV8_1_5X8;\n> \t\tbreak;\n> \tdefault:\n> @@ -207,8 +209,10 @@ void RkISP1Path::stop()\n> namespace {\n> constexpr Size RKISP1_RSZ_MP_SRC_MIN{ 32, 16 };\n> constexpr Size RKISP1_RSZ_MP_SRC_MAX{ 4416, 3312 };\n> -constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> +constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> \tformats::YUYV,\n> +\tformats::YUV420,\n> +\tformats::YVU420,\n\nI'd move those after the NV formats, to order them from 1 to 3 planes.\n\n> \tformats::NV16,\n> \tformats::NV61,\n> \tformats::NV21,\n\nShouldn't YUV420 and YVU420 be added to the selfpath formats too ?","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1C20ABE173\n\tfor ;\n\tThu, 7 Jul 2022 21:16:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 743906043F;\n\tThu, 7 Jul 2022 23:16:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1745760400\n\tfor ;\n\tThu, 7 Jul 2022 23:16:45 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 79087D00;\n\tThu, 7 Jul 2022 23:16:44 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657228606;\n\tbh=V0jY46zcu/aArLCJQW83mu5b/D0tuZLL08MUNhn2qaw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=nIn43fjUs9JSgUuG+L0aRxi15+m+TdvDq8Kn/Vm9J3wKNpHveLwtyXdDjbSppBgqA\n\tLRthk2KWQPvsUHtkrLLHewpuN0AGmWHEeTx3HHU7x8YuCHwbKzzgqWrrVzGf+VRLmi\n\tVAffiQae84qsZ7+LQrtUcUqPpTs6bjlu+hb39N4P3znMTAysfeZDQRiWP5Lx/TtNke\n\tpBby4w2Tn0yC7VkMofDRJShNBjzr6K2hTQl4wfW+FeITFHd6Yab2xBnKqVj14dCCsC\n\tLKHP0EYELkBhlphmMku96EuygBVosWO6rOfv4k5PqD+xmWrKnJKZhNL9f6yPRJmyXt\n\tynte5dYlfsQ5w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657228604;\n\tbh=V0jY46zcu/aArLCJQW83mu5b/D0tuZLL08MUNhn2qaw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fiq+5kTFTqdk15GAT1NJqDEck6phlrkRnK0vLr3FcFR3su9LFO2DoSjQUouyCPf3J\n\tfQSz7UYP1JtkQEBsTbE1Jnem58Qu5nzjyjK7ES8rcYDQLWOXBPkjQDTW866bepxB2V\n\to2NMH3hOJQEpMFe1TmNrdeee16+FKiil6g79vWRs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"fiq+5kTF\"; dkim-atps=neutral","Date":"Fri, 8 Jul 2022 00:16:18 +0300","To":"Paul Elder ","Message-ID":"","References":"<20220707150310.3645858-1-paul.elder@ideasonboard.com>\n\t<20220707150310.3645858-2-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220707150310.3645858-2-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/4] pipeline: rkisp1: Add output\n\tsupport for YUV420 and YVU420","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]