[{"id":23764,"web_url":"https://patchwork.libcamera.org/comment/23764/","msgid":"","date":"2022-07-06T09:15:39","subject":"Re: [libcamera-devel] [PATCH v2] qcam: main_window: Fix include\n\tordering","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Jul 06, 2022 at 10:10:09AM +0100, Kieran Bingham via libcamera-devel wrote:\n> Fix the sort order of the Qt headers to match the expected\n> sort from clang-format.\n\nDid you mean \"the expected order\" ?\n\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> v2:\n> - Update .cpp file as well\n> \n> src/qcam/main_window.cpp | 1 +\n> src/qcam/main_window.h | 17 +++++++++--------\n> 2 files changed, 10 insertions(+), 8 deletions(-)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index dd0e51f55b70..7433d647e8a0 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -29,6 +29,7 @@\n> #include \n> \n> #include \"../cam/image.h\"\n> +\n> #include \"dng_writer.h\"\n> #ifndef QT_NO_OPENGL\n> #include \"viewfinder_gl.h\"\n> diff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\n> index 3fbe872c0b5b..fc70920f990c 100644\n> --- a/src/qcam/main_window.h\n> +++ b/src/qcam/main_window.h\n> @@ -10,14 +10,6 @@\n> #include \n> #include \n> \n> -#include \n> -#include \n> -#include \n> -#include \n> -#include \n> -#include \n> -#include \n> -\n> #include \n> #include \n> #include \n> @@ -26,7 +18,16 @@\n> #include \n> #include \n> \n> +#include \n> +#include \n> +#include \n> +#include \n> +#include \n> +#include \n> +#include \n> +\n> #include \"../cam/stream_options.h\"\n> +\n> #include \"viewfinder.h\"\n> \n> class QAction;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5FC98BD1F1\n\tfor ;\n\tWed, 6 Jul 2022 09:16:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2E73A63315;\n\tWed, 6 Jul 2022 11:16:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1769D6330F\n\tfor ;\n\tWed, 6 Jul 2022 11:16:04 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A2B4230A;\n\tWed, 6 Jul 2022 11:16:03 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657098965;\n\tbh=VgCDPuuuFi7knleYCacliCNUa/iPlIjw5ijBE+ITXfM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=jeteQJof2Txsouc0jtir/mwNDzW2EmKZd5V8gHaNDCNa6eEwnVwigyRJGajpPnCC7\n\tccBXGVeMPj/aIYriKTXg/Bc4gu7J/+FMi/5/r5Q2/lLO/qy911pAN4MpZghIKwdRDe\n\tXoDhgLCr0AbAdJryrBNjG4592hqUAgoEiyslANpTrFtjbLpwJiKb5Jypa964aETKZ3\n\tMyzxVB7DPhx7bHx7ivvUc2BJesvIAZsqswHuTAMSPspfgMuRpRqInalwEhP2BfsM5S\n\txcSvIHnQORYnfJYRVYd+vdpUNvZp2t4o3FVOs1mSS3V3Lltcz+TmFBap2o67R8JQS8\n\tW09ofmXfoqFzQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657098963;\n\tbh=VgCDPuuuFi7knleYCacliCNUa/iPlIjw5ijBE+ITXfM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VHyxJABd0PBWYttm79V+w5GCnOVrJdZ3wtxgy407IXSI0aTQJYZMkrwDpDhgnKLdA\n\t3qCAIx+WNn6qkMbpVaAfNFFW7lB3kcKW18+2/WzCJBak5u3WXURrdwOqy99iv1KM8w\n\t0Hg0mPwkusK7jb7KvkmCZbZBY2Mf+n3tFXuB7H/Y="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VHyxJABd\"; dkim-atps=neutral","Date":"Wed, 6 Jul 2022 12:15:39 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220706091009.2752567-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220706091009.2752567-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2] qcam: main_window: Fix include\n\tordering","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23769,"web_url":"https://patchwork.libcamera.org/comment/23769/","msgid":"<165710907007.2021905.17871641042027842428@Monstersaurus>","date":"2022-07-06T12:04:30","subject":"Re: [libcamera-devel] [PATCH v2] qcam: main_window: Fix include\n\tordering","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2022-07-06 10:15:39)\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Wed, Jul 06, 2022 at 10:10:09AM +0100, Kieran Bingham via libcamera-devel wrote:\n> > Fix the sort order of the Qt headers to match the expected\n> > sort from clang-format.\n> \n> Did you mean \"the expected order\" ?\n\nWell, the \"expected sort order\" yes.\n\n> \n> > Signed-off-by: Kieran Bingham \n> \n> Reviewed-by: Laurent Pinchart \n> \n> > ---\n> > v2:\n> > - Update .cpp file as well\n> > \n> > src/qcam/main_window.cpp | 1 +\n> > src/qcam/main_window.h | 17 +++++++++--------\n> > 2 files changed, 10 insertions(+), 8 deletions(-)\n> > \n> > diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> > index dd0e51f55b70..7433d647e8a0 100644\n> > --- a/src/qcam/main_window.cpp\n> > +++ b/src/qcam/main_window.cpp\n> > @@ -29,6 +29,7 @@\n> > #include \n> > \n> > #include \"../cam/image.h\"\n> > +\n> > #include \"dng_writer.h\"\n> > #ifndef QT_NO_OPENGL\n> > #include \"viewfinder_gl.h\"\n> > diff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\n> > index 3fbe872c0b5b..fc70920f990c 100644\n> > --- a/src/qcam/main_window.h\n> > +++ b/src/qcam/main_window.h\n> > @@ -10,14 +10,6 @@\n> > #include \n> > #include \n> > \n> > -#include \n> > -#include \n> > -#include \n> > -#include \n> > -#include \n> > -#include \n> > -#include \n> > -\n> > #include \n> > #include \n> > #include \n> > @@ -26,7 +18,16 @@\n> > #include \n> > #include \n> > \n> > +#include \n> > +#include \n> > +#include \n> > +#include \n> > +#include \n> > +#include \n> > +#include \n> > +\n> > #include \"../cam/stream_options.h\"\n> > +\n> > #include \"viewfinder.h\"\n> > \n> > class QAction;\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7E858BE173\n\tfor ;\n\tWed, 6 Jul 2022 12:04:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B9D9563310;\n\tWed, 6 Jul 2022 14:04:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0A65860403\n\tfor ;\n\tWed, 6 Jul 2022 14:04:33 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 80A1530A;\n\tWed, 6 Jul 2022 14:04:32 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657109073;\n\tbh=51AQAudo2Wqi+cM6ETJuShIC7zxSuBNkny1dHSiowGc=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=XmHPoCGMzsSdfkD+hMRg7l76z+W32xwtaxKS6Ioudt3Jlho91sQZZ0Z4A6uwIp6Ym\n\tVDlPz/hePGu+W/rqvQMGVDA9ytomGpice2gUNXHoGzhiY44TRhbXcCF98trOl1upZu\n\tYYMOtXBdceVc9yG8dq1Bh6Q0u3rHsbBXpBvjRfHUjA51M1/vcqJ3NtfQ1voI5MZcHm\n\tUnvguR+vLz+FNH4nGYUPFOJul2G96WpXkd6YVjyQ636kvQfnZLp9/aaiymuHnLgBUs\n\tDRKw64Bv0P4ZGDsGTE3zYmHXREMMCU4pmYRr33DSU82XtD6kRirBD4VgmqlPx0Dhq4\n\tk/CpcZaOl7BfQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657109072;\n\tbh=51AQAudo2Wqi+cM6ETJuShIC7zxSuBNkny1dHSiowGc=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Y/V0V80ALCGggVLUGINwstBjNSRXaOoVunyJgCVHfd9e70C15AXlJOCHpEOMovtil\n\t3+dAoQbeC6WC1QUryXVGAFNeaTS1CzIBOYJawXW2skiLVnqPqKe5sO5LJlcgLmeRQp\n\tTxBx7hvHAsjPI2LcvI7e+hyrA4jha44+l+KxVQsA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Y/V0V80A\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20220706091009.2752567-1-kieran.bingham@ideasonboard.com>\n\t","To":"Laurent Pinchart ","Date":"Wed, 06 Jul 2022 13:04:30 +0100","Message-ID":"<165710907007.2021905.17871641042027842428@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2] qcam: main_window: Fix include\n\tordering","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]