[{"id":23749,"web_url":"https://patchwork.libcamera.org/comment/23749/","msgid":"<165704842097.2431158.16992840557332572584@Monstersaurus>","date":"2022-07-05T19:13:40","subject":"Re: [libcamera-devel] [PATCH] test: delayed_controls: Remove\n\tsequenceOffset","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nQuoting Jacopo Mondi via libcamera-devel (2022-07-05 19:43:50)\n> Commit 6f539a6d2fa9 (\"delayed_controls: Remove reduandant firstSequence_\")\n> removed support for frame number start offset from the DelayedControls\n> class, as it is now guaranteed that the first sequence number as it comes\n> from the V4L2VideoDevice will always be 0.\n> \n> However the delayed_controls.cpp unit still has two tests that passes\n> a non-zero first sequence number to the DelayedControl class, causing\n> the test to spin forever and consequentially fail.\n> \n\nAyeee, I can't believe I missed this. I must have glanced too casually\nat the test results and placed more attention on the fact that CTS had\nsucceed!\n\n> Remove the two tests from the unit to fix this.\n> \n> The first removed test was testing the class against frame start\n> sequence numbers greater than zero and can safely be removed.\n> \n> The second test was instead validating the class against sequence number\n> overflow, which is now not possible to test anymore as the DelayedControls\n> class now assumes 0 as first frame sequence number.\n\nHrm ... that's a bit of a shame, but I don't think it's too troublesome\njust yet.\n\n\nReviewed-by: Kieran Bingham \n\n> Fixes: 6f539a6d2fa9 (\"delayed_controls: Remove reduandant firstSequence_\")\n> Signed-off-by: Jacopo Mondi \n> ---\n> test/delayed_controls.cpp | 23 ++++++-----------------\n> 1 file changed, 6 insertions(+), 17 deletions(-)\n> \n> diff --git a/test/delayed_controls.cpp b/test/delayed_controls.cpp\n> index c6f195b7bc7f..a8ce9828d73d 100644\n> --- a/test/delayed_controls.cpp\n> +++ b/test/delayed_controls.cpp\n> @@ -155,7 +155,7 @@ protected:\n> return TestPass;\n> }\n> \n> - int dualControlsWithDelay(uint32_t startOffset)\n> + int dualControlsWithDelay()\n> {\n> static const unsigned int maxDelay = 2;\n> \n> @@ -175,25 +175,24 @@ protected:\n> delayed->reset();\n> \n> /* Trigger the first frame start event */\n> - delayed->applyControls(startOffset);\n> + delayed->applyControls(0);\n> \n> /* Test dual control with delay. */\n> for (unsigned int i = 1; i < 100; i++) {\n> - uint32_t frame = startOffset + i;\n> int32_t value = 10 + i;\n> \n> ctrls.set(V4L2_CID_BRIGHTNESS, value);\n> ctrls.set(V4L2_CID_CONTRAST, value + 1);\n> delayed->push(ctrls);\n> \n> - delayed->applyControls(frame);\n> + delayed->applyControls(i);\n> \n> - ControlList result = delayed->get(frame);\n> + ControlList result = delayed->get(i);\n> int32_t brightness = result.get(V4L2_CID_BRIGHTNESS).get();\n> int32_t contrast = result.get(V4L2_CID_CONTRAST).get();\n> if (brightness != expected || contrast != expected + 1) {\n> cerr << \"Failed dual controls\"\n> - << \" frame \" << frame\n> + << \" frame \" << i\n> << \" brightness \" << brightness\n> << \" contrast \" << contrast\n> << \" expected \" << expected\n> @@ -283,17 +282,7 @@ protected:\n> return ret;\n> \n> /* Test dual controls with different delays. */\n> - ret = dualControlsWithDelay(0);\n> - if (ret)\n> - return ret;\n> -\n> - /* Test dual controls with non-zero sequence start. */\n> - ret = dualControlsWithDelay(10000);\n> - if (ret)\n> - return ret;\n> -\n> - /* Test dual controls with sequence number wraparound. */\n> - ret = dualControlsWithDelay(UINT32_MAX - 50);\n> + ret = dualControlsWithDelay();\n> if (ret)\n> return ret;\n> \n> -- \n> 2.36.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3CA11BD1F1\n\tfor ;\n\tTue, 5 Jul 2022 19:13:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F55F6330C;\n\tTue, 5 Jul 2022 21:13:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3633861FB0\n\tfor ;\n\tTue, 5 Jul 2022 21:13:44 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A19756BB;\n\tTue, 5 Jul 2022 21:13:43 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657048425;\n\tbh=GGs31WnLYmG1LAQvytUaGwEqsmH8dYLkMmMAK7G1QyE=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=zac4eoU/f/K+Y5qodz4koYyyKrdkATLQ304Nv8Z33ueyjoWds/Zu5gdinRU+NA8Cm\n\tkUHcoqgo9z0YRlNnnmholUpCDrgWjpouDeGEvvOpalRRqMRQmFwl76DH1aMllx0H2z\n\tN5i1sDpIzTWgA+EA4yKouxDTy6qkt1jPOoeYsGvmiLlzVLubxx2S/dyM4rJVSarzsl\n\tOqUObqAdpXd6UNUjNF94DeP0Ssu7naT7oUe/eOadU+U43T6ElCj8MO7Yfy4mXvDxCH\n\t66Rjkx0zyjvu13/1bk3RBCgrlXOfPH9lMSAr48hxhDXWF1EalY8+W0sZox10XWtOWZ\n\tNchv0rMt1GN3g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657048423;\n\tbh=GGs31WnLYmG1LAQvytUaGwEqsmH8dYLkMmMAK7G1QyE=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=b9PUSh+D5Vp+6R0HitPyCtSwZC2dI1E+sxfRcfjo68BKarSuARMqXvB/ZeHUsNNuG\n\t5nWm1T42j3IKaPd7XX98x588xROSC5ptG83dKdgjBGLe956Gzoe9P1B8SS9NfkuZ5n\n\t2at8+YLhxsSe6dR4fRWRyHHcWpwfcl0uDOXvM3s8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"b9PUSh+D\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220705184350.31369-1-jacopo@jmondi.org>","References":"<20220705184350.31369-1-jacopo@jmondi.org>","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","Date":"Tue, 05 Jul 2022 20:13:40 +0100","Message-ID":"<165704842097.2431158.16992840557332572584@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] test: delayed_controls: Remove\n\tsequenceOffset","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23750,"web_url":"https://patchwork.libcamera.org/comment/23750/","msgid":"","date":"2022-07-05T20:22:40","subject":"Re: [libcamera-devel] [PATCH] test: delayed_controls: Remove\n\tsequenceOffset","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Jul 05, 2022 at 08:43:50PM +0200, Jacopo Mondi via libcamera-devel wrote:\n> Commit 6f539a6d2fa9 (\"delayed_controls: Remove reduandant firstSequence_\")\n> removed support for frame number start offset from the DelayedControls\n> class, as it is now guaranteed that the first sequence number as it comes\n> from the V4L2VideoDevice will always be 0.\n> \n> However the delayed_controls.cpp unit still has two tests that passes\n> a non-zero first sequence number to the DelayedControl class, causing\n> the test to spin forever and consequentially fail.\n> \n> Remove the two tests from the unit to fix this.\n> \n> The first removed test was testing the class against frame start\n> sequence numbers greater than zero and can safely be removed.\n> \n> The second test was instead validating the class against sequence number\n> overflow, which is now not possible to test anymore as the DelayedControls\n> class now assumes 0 as first frame sequence number.\n> \n> Fixes: 6f539a6d2fa9 (\"delayed_controls: Remove reduandant firstSequence_\")\n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> test/delayed_controls.cpp | 23 ++++++-----------------\n> 1 file changed, 6 insertions(+), 17 deletions(-)\n> \n> diff --git a/test/delayed_controls.cpp b/test/delayed_controls.cpp\n> index c6f195b7bc7f..a8ce9828d73d 100644\n> --- a/test/delayed_controls.cpp\n> +++ b/test/delayed_controls.cpp\n> @@ -155,7 +155,7 @@ protected:\n> \t\treturn TestPass;\n> \t}\n> \n> -\tint dualControlsWithDelay(uint32_t startOffset)\n> +\tint dualControlsWithDelay()\n> \t{\n> \t\tstatic const unsigned int maxDelay = 2;\n> \n> @@ -175,25 +175,24 @@ protected:\n> \t\tdelayed->reset();\n> \n> \t\t/* Trigger the first frame start event */\n> -\t\tdelayed->applyControls(startOffset);\n> +\t\tdelayed->applyControls(0);\n> \n> \t\t/* Test dual control with delay. */\n> \t\tfor (unsigned int i = 1; i < 100; i++) {\n> -\t\t\tuint32_t frame = startOffset + i;\n> \t\t\tint32_t value = 10 + i;\n> \n> \t\t\tctrls.set(V4L2_CID_BRIGHTNESS, value);\n> \t\t\tctrls.set(V4L2_CID_CONTRAST, value + 1);\n> \t\t\tdelayed->push(ctrls);\n> \n> -\t\t\tdelayed->applyControls(frame);\n> +\t\t\tdelayed->applyControls(i);\n> \n> -\t\t\tControlList result = delayed->get(frame);\n> +\t\t\tControlList result = delayed->get(i);\n> \t\t\tint32_t brightness = result.get(V4L2_CID_BRIGHTNESS).get();\n> \t\t\tint32_t contrast = result.get(V4L2_CID_CONTRAST).get();\n> \t\t\tif (brightness != expected || contrast != expected + 1) {\n> \t\t\t\tcerr << \"Failed dual controls\"\n> -\t\t\t\t << \" frame \" << frame\n> +\t\t\t\t << \" frame \" << i\n> \t\t\t\t << \" brightness \" << brightness\n> \t\t\t\t << \" contrast \" << contrast\n> \t\t\t\t << \" expected \" << expected\n> @@ -283,17 +282,7 @@ protected:\n> \t\t\treturn ret;\n> \n> \t\t/* Test dual controls with different delays. */\n> -\t\tret = dualControlsWithDelay(0);\n> -\t\tif (ret)\n> -\t\t\treturn ret;\n> -\n> -\t\t/* Test dual controls with non-zero sequence start. */\n> -\t\tret = dualControlsWithDelay(10000);\n> -\t\tif (ret)\n> -\t\t\treturn ret;\n> -\n> -\t\t/* Test dual controls with sequence number wraparound. */\n> -\t\tret = dualControlsWithDelay(UINT32_MAX - 50);\n> +\t\tret = dualControlsWithDelay();\n> \t\tif (ret)\n> \t\t\treturn ret;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DDB91BE173\n\tfor ;\n\tTue, 5 Jul 2022 20:23:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2E4C963310;\n\tTue, 5 Jul 2022 22:23:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3D8B561FB0\n\tfor ;\n\tTue, 5 Jul 2022 22:23:05 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 96D116BB;\n\tTue, 5 Jul 2022 22:23:04 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657052586;\n\tbh=E1D1f/1FnuBy5uv/PmjhE0iTEk5NnAAM78D8NDb4BNE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Xyzt54JGh/uTNwL1dABdereSRyebLukjw+dgEErEr5XOwres1BWRHW0INnEHheVkq\n\tZ+0IhWZ4Dn1GbgY01HLkiEQxgfnat7oe7jlxfP7MYrxuJjb4/m4rFSAFyFvB0Zl9J1\n\tS+yLoYN4lIxJQl5LYxlg4SUTlovBL1nlc0zRT8lb01Fwu6MZs8iZUNRCSHF8Y8FZmm\n\th2haCwVEhwxRh+sgeHxwtxKvfpSF9QgDnnkGJbIVCJzgoOPZgfY6WANr6HGGqwySUR\n\tH5PdZ/VIbCMNAP6xrnfiP8wlFVG+m7xnVyfLfRJRVnafY8CEtD5JbofzdjtIOen/kb\n\tm6lwy5m1zA1bw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657052584;\n\tbh=E1D1f/1FnuBy5uv/PmjhE0iTEk5NnAAM78D8NDb4BNE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=AGkCF196Kl3vCFWl3n0bHl41iO2BbcpvYdSFxnLS/QsnnoEtsjdczvhYEEro2RQqg\n\tl5rmrbThKDdMLs273dCK7FVobPZrgaiFhb21kuMkeL0tJ+EQmB8bK0+TL0HTRs4lZs\n\tw14PFFqQO01NhZZ4QVCLsn7T8Wtw1NrdI7P41K4o="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"AGkCF196\"; dkim-atps=neutral","Date":"Tue, 5 Jul 2022 23:22:40 +0300","To":"Jacopo Mondi ","Message-ID":"","References":"<20220705184350.31369-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220705184350.31369-1-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH] test: delayed_controls: Remove\n\tsequenceOffset","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23751,"web_url":"https://patchwork.libcamera.org/comment/23751/","msgid":"","date":"2022-07-05T20:28:36","subject":"Re: [libcamera-devel] [PATCH] test: delayed_controls: Remove\n\tsequenceOffset","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Tue, Jul 05, 2022 at 08:13:40PM +0100, Kieran Bingham via libcamera-devel wrote:\n> Hi Jacopo,\n> \n> Quoting Jacopo Mondi via libcamera-devel (2022-07-05 19:43:50)\n> > Commit 6f539a6d2fa9 (\"delayed_controls: Remove reduandant firstSequence_\")\n> > removed support for frame number start offset from the DelayedControls\n> > class, as it is now guaranteed that the first sequence number as it comes\n> > from the V4L2VideoDevice will always be 0.\n> > \n> > However the delayed_controls.cpp unit still has two tests that passes\n> > a non-zero first sequence number to the DelayedControl class, causing\n> > the test to spin forever and consequentially fail.\n> \n> Ayeee, I can't believe I missed this. I must have glanced too casually\n> at the test results and placed more attention on the fact that CTS had\n> succeed!\n\nAre there unit tests that normally fail for you ?\n\n> > Remove the two tests from the unit to fix this.\n> > \n> > The first removed test was testing the class against frame start\n> > sequence numbers greater than zero and can safely be removed.\n> > \n> > The second test was instead validating the class against sequence number\n> > overflow, which is now not possible to test anymore as the DelayedControls\n> > class now assumes 0 as first frame sequence number.\n> \n> Hrm ... that's a bit of a shame, but I don't think it's too troublesome\n> just yet.\n> \n> \n> Reviewed-by: Kieran Bingham \n> \n> > Fixes: 6f539a6d2fa9 (\"delayed_controls: Remove reduandant firstSequence_\")\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > test/delayed_controls.cpp | 23 ++++++-----------------\n> > 1 file changed, 6 insertions(+), 17 deletions(-)\n> > \n> > diff --git a/test/delayed_controls.cpp b/test/delayed_controls.cpp\n> > index c6f195b7bc7f..a8ce9828d73d 100644\n> > --- a/test/delayed_controls.cpp\n> > +++ b/test/delayed_controls.cpp\n> > @@ -155,7 +155,7 @@ protected:\n> > return TestPass;\n> > }\n> > \n> > - int dualControlsWithDelay(uint32_t startOffset)\n> > + int dualControlsWithDelay()\n> > {\n> > static const unsigned int maxDelay = 2;\n> > \n> > @@ -175,25 +175,24 @@ protected:\n> > delayed->reset();\n> > \n> > /* Trigger the first frame start event */\n> > - delayed->applyControls(startOffset);\n> > + delayed->applyControls(0);\n> > \n> > /* Test dual control with delay. */\n> > for (unsigned int i = 1; i < 100; i++) {\n> > - uint32_t frame = startOffset + i;\n> > int32_t value = 10 + i;\n> > \n> > ctrls.set(V4L2_CID_BRIGHTNESS, value);\n> > ctrls.set(V4L2_CID_CONTRAST, value + 1);\n> > delayed->push(ctrls);\n> > \n> > - delayed->applyControls(frame);\n> > + delayed->applyControls(i);\n> > \n> > - ControlList result = delayed->get(frame);\n> > + ControlList result = delayed->get(i);\n> > int32_t brightness = result.get(V4L2_CID_BRIGHTNESS).get();\n> > int32_t contrast = result.get(V4L2_CID_CONTRAST).get();\n> > if (brightness != expected || contrast != expected + 1) {\n> > cerr << \"Failed dual controls\"\n> > - << \" frame \" << frame\n> > + << \" frame \" << i\n> > << \" brightness \" << brightness\n> > << \" contrast \" << contrast\n> > << \" expected \" << expected\n> > @@ -283,17 +282,7 @@ protected:\n> > return ret;\n> > \n> > /* Test dual controls with different delays. */\n> > - ret = dualControlsWithDelay(0);\n> > - if (ret)\n> > - return ret;\n> > -\n> > - /* Test dual controls with non-zero sequence start. */\n> > - ret = dualControlsWithDelay(10000);\n> > - if (ret)\n> > - return ret;\n> > -\n> > - /* Test dual controls with sequence number wraparound. */\n> > - ret = dualControlsWithDelay(UINT32_MAX - 50);\n> > + ret = dualControlsWithDelay();\n> > if (ret)\n> > return ret;\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CD5A2BD1F1\n\tfor ;\n\tTue, 5 Jul 2022 20:29:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 27A536330C;\n\tTue, 5 Jul 2022 22:29:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AADA561FB0\n\tfor ;\n\tTue, 5 Jul 2022 22:29:00 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EF97D6BB;\n\tTue, 5 Jul 2022 22:28:59 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657052942;\n\tbh=cNptpEvtG6oBuiXyyxACSPK0GRQ35HNEMYWtPwKaEpM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=HQMa/UbFufiQX4DWqLdK+O4WUGg5OquDwNzX1S7grsrzs+0wHJ3ZzYQt+j3CQlmUi\n\tr0tafsUGceSv8YSCWmLm0laEpHOI4PKLzzyUz09CXrdNQrdaq3Y4oJ69QKyihOl2kf\n\tJjjCuUkWyCW2jyfh7XX1i2E51xmQEUPTp/a3MjADo8dKcVSNegfuDErQyGWOagpbFw\n\tn5VUj+KUelRZ5thQZ4oo9omQBztF9IAsh5bL7PuYzsAmqa8XAh+efkpqfh9dTXY4om\n\tTUvIGy5Ben/Vk7sTrs87Cw1nrq8LiEDTr7SExJcOa70pcqSPdQbYs3LUAJhpDexmcd\n\tHz+wzOB0ydGOQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657052940;\n\tbh=cNptpEvtG6oBuiXyyxACSPK0GRQ35HNEMYWtPwKaEpM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=eD5Yiw3SBHcKuE8rkUi3HGY6cA1DgP0pPHOFV38u8ETEBsvzEOrZxxFUFjhMOI1if\n\t3ypETtgzBqxspJuAUf4EPUY16KZBBpReef5sZLJaRwt6zNQxOUnDZ81durua/j2dsq\n\tR8mW3UalsOnsSky8KnhAXveTOCBk+0gUa1C3nEb0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"eD5Yiw3S\"; dkim-atps=neutral","Date":"Tue, 5 Jul 2022 23:28:36 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220705184350.31369-1-jacopo@jmondi.org>\n\t<165704842097.2431158.16992840557332572584@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<165704842097.2431158.16992840557332572584@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] test: delayed_controls: Remove\n\tsequenceOffset","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]