[{"id":23758,"web_url":"https://patchwork.libcamera.org/comment/23758/","msgid":"","date":"2022-07-05T20:59:59","subject":"Re: [libcamera-devel] [PATCH 3/3] qcam: viewfinder_qt: Support X\n\tRGB variants","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Jul 05, 2022 at 04:31:11PM +0100, Kieran Bingham via libcamera-devel wrote:\n> Support the X variants of the RGB pixel formats\n> along side the equivalent Alpha component based versions.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/qcam/viewfinder_qt.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/qcam/viewfinder_qt.cpp b/src/qcam/viewfinder_qt.cpp\n> index 27955e3f9593..14ecd70a839e 100644\n> --- a/src/qcam/viewfinder_qt.cpp\n> +++ b/src/qcam/viewfinder_qt.cpp\n> @@ -28,8 +28,10 @@ static const QMap nativeFormats\n> {\n> #if QT_VERSION >= QT_VERSION_CHECK(5, 2, 0)\n> \t{ libcamera::formats::ABGR8888, QImage::Format_RGBA8888 },\n> +\t{ libcamera::formats::XBGR8888, QImage::Format_RGBA8888 },\n\nThere's a QImage::Format_RGBX8888 format which may be better suited\n(perhaps for both libcamera::formats::ABGR8888 and\nlibcamera::formats::XBGR8888).\n\n> #endif\n> \t{ libcamera::formats::ARGB8888, QImage::Format_RGB32 },\n> +\t{ libcamera::formats::XRGB8888, QImage::Format_RGB32 },\n\nWill Qt ignore the alpha channel when rendering ?\n\n> #if QT_VERSION >= QT_VERSION_CHECK(5, 14, 0)\n> \t{ libcamera::formats::RGB888, QImage::Format_BGR888 },\n> #endif","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A25B7BE173\n\tfor ;\n\tTue, 5 Jul 2022 21:00:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 032FD63310;\n\tTue, 5 Jul 2022 23:00:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BCFF961FB0\n\tfor ;\n\tTue, 5 Jul 2022 23:00:24 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2ED886BB;\n\tTue, 5 Jul 2022 23:00:24 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657054826;\n\tbh=WDGffshq0/X4UOJg+Rng4rM2Aw1ErJsig6kt0zMhmc4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=1AL39lWJkSsjXJMvCGGPN3sE98sW2FdU9j0ZWUMjT0+sq3JYZmCod4YBzsHGUnp8j\n\tiXPQfBxkS9khB7lsuKvl4ZxXJM5IjDG8p55amNN02gOTfLQeFQIDLtluowj8F41bk4\n\tuLjiQyVdYLMDyBUwWLhvAeLt2FbvjYMuhju5Fpbd0evW2kVTRBjxe2waRCcLoS/PBr\n\tYLw352E1ynB+oIoPYkS6XNuBG8BJ5DN6oRcOjGB+hIKhH2aCqWvjAzKNx4+SsM9MQJ\n\tx0eW0jb5S036fohxX3scKq39pe+aO0oJyEsX4kwizY2TwPUvA8kDFx1R5lKcGw4pHW\n\tj0zNiHvT6zlxA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657054824;\n\tbh=WDGffshq0/X4UOJg+Rng4rM2Aw1ErJsig6kt0zMhmc4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hl+LSZkVq3rjH2+/ozrcVQX30H816bFPBNPITvGlrVfwHUSVBrOwOd7UUwAsrGu2U\n\tGUrPnxTI4hr/qWBgD4y1Y8gxsPns4bD1mlKOffYf4b+6dPcbvM6QmpIxrxzKSWAzX6\n\t/w4sgSSTw00jz/g9UZwlsD9F9pUzU15iXTTnDr58="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"hl+LSZkV\"; dkim-atps=neutral","Date":"Tue, 5 Jul 2022 23:59:59 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220705153111.2338369-1-kieran.bingham@ideasonboard.com>\n\t<20220705153111.2338369-4-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220705153111.2338369-4-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 3/3] qcam: viewfinder_qt: Support X\n\tRGB variants","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23761,"web_url":"https://patchwork.libcamera.org/comment/23761/","msgid":"<165709783909.2021905.10424570327292226400@Monstersaurus>","date":"2022-07-06T08:57:19","subject":"Re: [libcamera-devel] [PATCH 3/3] qcam: viewfinder_qt: Support X\n\tRGB variants","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2022-07-05 21:59:59)\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Tue, Jul 05, 2022 at 04:31:11PM +0100, Kieran Bingham via libcamera-devel wrote:\n> > Support the X variants of the RGB pixel formats\n> > along side the equivalent Alpha component based versions.\n> > \n> > Signed-off-by: Kieran Bingham \n> > ---\n> > src/qcam/viewfinder_qt.cpp | 2 ++\n> > 1 file changed, 2 insertions(+)\n> > \n> > diff --git a/src/qcam/viewfinder_qt.cpp b/src/qcam/viewfinder_qt.cpp\n> > index 27955e3f9593..14ecd70a839e 100644\n> > --- a/src/qcam/viewfinder_qt.cpp\n> > +++ b/src/qcam/viewfinder_qt.cpp\n> > @@ -28,8 +28,10 @@ static const QMap nativeFormats\n> > {\n> > #if QT_VERSION >= QT_VERSION_CHECK(5, 2, 0)\n> > { libcamera::formats::ABGR8888, QImage::Format_RGBA8888 },\n> > + { libcamera::formats::XBGR8888, QImage::Format_RGBA8888 },\n> \n> There's a QImage::Format_RGBX8888 format which may be better suited\n> (perhaps for both libcamera::formats::ABGR8888 and\n> libcamera::formats::XBGR8888).\n\nIn these formats, (in this patch) both of these when tested with vivid\nshow a 'transparent' frame. I.e. it's not visible, but working.\n\nWith QImage::Format_RGBX8888 - it's much better. I'll update to use\nthat. We want to ignore the Alpha channel in our case.\n\n> \n> > #endif\n> > { libcamera::formats::ARGB8888, QImage::Format_RGB32 },\n> > + { libcamera::formats::XRGB8888, QImage::Format_RGB32 },\n> \n> Will Qt ignore the alpha channel when rendering ?\n\nBoth of these function with an image displayed from vivid. (I.e. leads\nme to believe that the Alpha is ignored, but I haven't read the Qt\ncode).\n\n> \n> > #if QT_VERSION >= QT_VERSION_CHECK(5, 14, 0)\n> > { libcamera::formats::RGB888, QImage::Format_BGR888 },\n> > #endif\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C4CA1BD1F1\n\tfor ;\n\tWed, 6 Jul 2022 08:57:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5391C6330C;\n\tWed, 6 Jul 2022 10:57:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF13E60400\n\tfor ;\n\tWed, 6 Jul 2022 10:57:21 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 596B930A;\n\tWed, 6 Jul 2022 10:57:21 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657097844;\n\tbh=4t7XB6lZOa+Mg3qErSs9p4kWydsXtGIxChsbuyq26/0=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ac/+BesTOId+u+9D0Iq/B+ok1sTvqtBzAe/DrhM4yC+mhhyVxlIyLnm6zCdf+hfSo\n\tdiwOLUmMxYxSgHJVam22gikhPZO8QggmxrVJmK2ZPSU7rXdeTy/sAiNsUfaqkcZXXR\n\tQCOkd/A4FLPW6jVahhuO4hwk22t3LGHkPJSCkFj9eHAyiRoHFu/OCd00IFNKHptGRv\n\t/bjAYT+DuTY8T6MN8f988WUfPcL2Pk4M6ubFGJii4r1fBFsqHJ4N2r9bT4/5pYxtt+\n\tOoqqZno1dArOJbmUVwXK5ctTbIV6yxTfCpsliDLyn+LRBfz25JbKcNplqvcAycy3Aj\n\tyT6j5rDyECieQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657097841;\n\tbh=4t7XB6lZOa+Mg3qErSs9p4kWydsXtGIxChsbuyq26/0=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=LOxYXa/oU27OcNQG7fzHxbQ2z0oM5Pq6vplsXRCLKqfDuGEinTLRQ4F8/vwgZpwAg\n\tWSC5IbUO3uBaQ0qUuODGFeHVnHSzYpBhgVVG0/fjcbz+GZblo6n3T7/WCK9/Y8z3/c\n\ti/TLjwIs0L8LnR9QAx43Sdh8rHt4f8wUNJMXpRug="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"LOxYXa/o\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20220705153111.2338369-1-kieran.bingham@ideasonboard.com>\n\t<20220705153111.2338369-4-kieran.bingham@ideasonboard.com>\n\t","To":"Laurent Pinchart ","Date":"Wed, 06 Jul 2022 09:57:19 +0100","Message-ID":"<165709783909.2021905.10424570327292226400@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 3/3] qcam: viewfinder_qt: Support X\n\tRGB variants","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23763,"web_url":"https://patchwork.libcamera.org/comment/23763/","msgid":"","date":"2022-07-06T09:14:11","subject":"Re: [libcamera-devel] [PATCH 3/3] qcam: viewfinder_qt: Support X\n\tRGB variants","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Wed, Jul 06, 2022 at 09:57:19AM +0100, Kieran Bingham wrote:\n> Quoting Laurent Pinchart (2022-07-05 21:59:59)\n> > On Tue, Jul 05, 2022 at 04:31:11PM +0100, Kieran Bingham via libcamera-devel wrote:\n> > > Support the X variants of the RGB pixel formats\n> > > along side the equivalent Alpha component based versions.\n> > > \n> > > Signed-off-by: Kieran Bingham \n> > > ---\n> > > src/qcam/viewfinder_qt.cpp | 2 ++\n> > > 1 file changed, 2 insertions(+)\n> > > \n> > > diff --git a/src/qcam/viewfinder_qt.cpp b/src/qcam/viewfinder_qt.cpp\n> > > index 27955e3f9593..14ecd70a839e 100644\n> > > --- a/src/qcam/viewfinder_qt.cpp\n> > > +++ b/src/qcam/viewfinder_qt.cpp\n> > > @@ -28,8 +28,10 @@ static const QMap nativeFormats\n> > > {\n> > > #if QT_VERSION >= QT_VERSION_CHECK(5, 2, 0)\n> > > { libcamera::formats::ABGR8888, QImage::Format_RGBA8888 },\n> > > + { libcamera::formats::XBGR8888, QImage::Format_RGBA8888 },\n> > \n> > There's a QImage::Format_RGBX8888 format which may be better suited\n> > (perhaps for both libcamera::formats::ABGR8888 and\n> > libcamera::formats::XBGR8888).\n> \n> In these formats, (in this patch) both of these when tested with vivid\n> show a 'transparent' frame. I.e. it's not visible, but working.\n> \n> With QImage::Format_RGBX8888 - it's much better. I'll update to use\n> that. We want to ignore the Alpha channel in our case.\n> \n> > \n> > > #endif\n> > > { libcamera::formats::ARGB8888, QImage::Format_RGB32 },\n> > > + { libcamera::formats::XRGB8888, QImage::Format_RGB32 },\n> > \n> > Will Qt ignore the alpha channel when rendering ?\n> \n> Both of these function with an image displayed from vivid. (I.e. leads\n> me to believe that the Alpha is ignored, but I haven't read the Qt\n> code).\n\nAccording to https://doc.qt.io/qt-5/qimage.html#Format-enum,\nQImage::Format_RGB32 is defined as \"The image is stored using a 32-bit\nRGB format (0xffRRGGBB)\" and QImage::Format_RGBX8888 as \"The image is\nstored using a 32-bit byte-ordered RGB(x) format (8-8-8-8). This is the\nsame as the Format_RGBA8888 except alpha must always be 255.\". That's\ncertainly better than the alpha-enabled equivalents, it's just a bit of\na shame that the documentation doesn't state that implementations must\nignore the alpha component.\n\n> > > #if QT_VERSION >= QT_VERSION_CHECK(5, 14, 0)\n> > > { libcamera::formats::RGB888, QImage::Format_BGR888 },\n> > > #endif","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 24FE8BD1F1\n\tfor ;\n\tWed, 6 Jul 2022 09:14:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 92BC363312;\n\tWed, 6 Jul 2022 11:14:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3CA206330C\n\tfor ;\n\tWed, 6 Jul 2022 11:14:37 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9CB3C593;\n\tWed, 6 Jul 2022 11:14:36 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657098878;\n\tbh=oWE/cGWIN2aiLLwixNuX90W0XSOMthzVZZqg9cnUbRg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=oUz1+lZdcHdAz2UUyzz3oBQoqWQFcxslwUZpeQI93jFyhIKwCdJrEe6v5tUXJSOtG\n\tsa377iIel0SyoVs66hrKkHSALiuIbjJxePcF0gJPjyfxDeayoKzoy2a9RzDPPt2pG2\n\t7YuJIT66zQ5+uIxl35wsEWPcZfyA9bNlMvld8wO3fNahpYB27289TxxGa7TPzQ2rlE\n\tuNrS/DGwodV02dfvN8tWoJ1RoUn81nqJ5n2kgusOGvFWhBdx07gIrFSQnGGWPL+mGW\n\t5igoB+xjuykDsVWbOWUQvBUYUDFbnbNFOFXUHuJ8EF6GnAzHLFtQN6SfC8XniAd6/d\n\tK/C3wewjHaZaw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657098876;\n\tbh=oWE/cGWIN2aiLLwixNuX90W0XSOMthzVZZqg9cnUbRg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wmqhllAOph8eNZhEDkRLOMFgEGZI33/KDiGerA2+WbAXjh/hzQYCgtDXKq4vG0OzI\n\tT963659OLiNoimRwl6v/YK0x4PUDi3DqVwMDv5AmMvV17DX2UVNPSrUrIy8ZumCPL5\n\tbYhhVrRUQcdql9rVlztCHCf851rbEu+VcyDuT8s0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"wmqhllAO\"; dkim-atps=neutral","Date":"Wed, 6 Jul 2022 12:14:11 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220705153111.2338369-1-kieran.bingham@ideasonboard.com>\n\t<20220705153111.2338369-4-kieran.bingham@ideasonboard.com>\n\t\n\t<165709783909.2021905.10424570327292226400@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<165709783909.2021905.10424570327292226400@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH 3/3] qcam: viewfinder_qt: Support X\n\tRGB variants","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]