[{"id":23757,"web_url":"https://patchwork.libcamera.org/comment/23757/","msgid":"","date":"2022-07-05T20:57:01","subject":"Re: [libcamera-devel] [PATCH 2/3] qcam: format_converter: Support X\n\tRGB variants","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Jul 05, 2022 at 04:31:10PM +0100, Kieran Bingham via libcamera-devel wrote:\n> Support the X variants of the RGB pixel formats\n> along side the equivalent Alpha component based versions.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/qcam/format_converter.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/qcam/format_converter.cpp b/src/qcam/format_converter.cpp\n> index d4d3223bc698..9331da0ce7a3 100644\n> --- a/src/qcam/format_converter.cpp\n> +++ b/src/qcam/format_converter.cpp\n> @@ -93,6 +93,7 @@ int FormatConverter::configure(const libcamera::PixelFormat &format,\n> \t\tbpp_ = 3;\n> \t\tbreak;\n> \tcase libcamera::formats::ARGB8888:\n> +\tcase libcamera::formats::XRGB8888:\n> \t\tformatFamily_ = RGB;\n> \t\tr_pos_ = 2;\n> \t\tg_pos_ = 1;\n> @@ -100,6 +101,7 @@ int FormatConverter::configure(const libcamera::PixelFormat &format,\n> \t\tbpp_ = 4;\n> \t\tbreak;\n> \tcase libcamera::formats::RGBA8888:\n> +\tcase libcamera::formats::RGBX8888:\n> \t\tformatFamily_ = RGB;\n> \t\tr_pos_ = 3;\n> \t\tg_pos_ = 2;\n> @@ -107,6 +109,7 @@ int FormatConverter::configure(const libcamera::PixelFormat &format,\n> \t\tbpp_ = 4;\n> \t\tbreak;\n> \tcase libcamera::formats::ABGR8888:\n> +\tcase libcamera::formats::XBGR8888:\n> \t\tformatFamily_ = RGB;\n> \t\tr_pos_ = 0;\n> \t\tg_pos_ = 1;\n> @@ -114,6 +117,7 @@ int FormatConverter::configure(const libcamera::PixelFormat &format,\n> \t\tbpp_ = 4;\n> \t\tbreak;\n> \tcase libcamera::formats::BGRA8888:\n> +\tcase libcamera::formats::BGRX8888:\n> \t\tformatFamily_ = RGB;\n> \t\tr_pos_ = 1;\n> \t\tg_pos_ = 2;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 84840BE173\n\tfor ;\n\tTue, 5 Jul 2022 20:57:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 410486330C;\n\tTue, 5 Jul 2022 22:57:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 31F2561FB0\n\tfor ;\n\tTue, 5 Jul 2022 22:57:26 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BCE9F6BB;\n\tTue, 5 Jul 2022 22:57:25 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657054648;\n\tbh=mNp19ottD62UbpaE7gGnxXpZgxowGN9BfHk6KviDIBo=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=N6rBzoIW4HQ0k8iaH6sLQJ//zdcddK5GDZ0zcK442eDiEJ2f2nNCt1RY525payYK7\n\t0jSSChfOW8RLw3hhIl+YBmCRRWDwEeOsUHY2rJIKYRwPgkkTNVuJ78p6zrFXIUV9aB\n\tnBJg2QMkXHotJCzSRv2k6Pz5GYwJdKvopnICZYp4HEqCXfJKEzuZjDxQ9vcu+2FQuc\n\t44c3FgxWeDTLKtvouglcPkjTslT0ZijRy8Md/mf27lBg7i2sOvam/T1bnf6eDNVTjJ\n\txnV3dWN2+2ckwc6domOoTWFQW3X3RVUbK62E4bxSDsk7vj1xf/gmXUpL/SfGk5x4eO\n\tLw+6UDJrDwmXA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657054645;\n\tbh=mNp19ottD62UbpaE7gGnxXpZgxowGN9BfHk6KviDIBo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HmRsGd0D4P7YCf5xYRwWyA8dvKj/elJ2rITlqNfBQzsNtYTC0gCpqYES97teb1CWL\n\tkMdYCWPpPwfLuvu2blxAkPGf6Mrs/QSyWTz/5oDeLwbzoeHDgv1HFNcTrJvTKbbwoM\n\tbs/uvBRtY3IASbpWAuyuKwsEeAygAvt/SYpolgdw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"HmRsGd0D\"; dkim-atps=neutral","Date":"Tue, 5 Jul 2022 23:57:01 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220705153111.2338369-1-kieran.bingham@ideasonboard.com>\n\t<20220705153111.2338369-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220705153111.2338369-3-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/3] qcam: format_converter: Support X\n\tRGB variants","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]