[{"id":23756,"web_url":"https://patchwork.libcamera.org/comment/23756/","msgid":"","date":"2022-07-05T20:56:39","subject":"Re: [libcamera-devel] [PATCH 1/3] qcam: viewfinder_qt: Fix include\n\torders","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Jul 05, 2022 at 04:31:09PM +0100, Kieran Bingham via libcamera-devel wrote:\n> Update the header orders to match the code style as decreed by\n> clang-format.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/qcam/viewfinder_qt.cpp | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/qcam/viewfinder_qt.cpp b/src/qcam/viewfinder_qt.cpp\n> index 6844f998bbe0..27955e3f9593 100644\n> --- a/src/qcam/viewfinder_qt.cpp\n> +++ b/src/qcam/viewfinder_qt.cpp\n> @@ -11,6 +11,8 @@\n> #include \n> #include \n> \n> +#include \n> +\n> #include \n> #include \n> #include \n> @@ -18,9 +20,8 @@\n> #include \n> #include \n> \n> -#include \n> -\n> #include \"../cam/image.h\"\n> +\n> #include \"format_converter.h\"\n> \n> static const QMap nativeFormats","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0351FBE173\n\tfor ;\n\tTue, 5 Jul 2022 20:57:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B2B0063310;\n\tTue, 5 Jul 2022 22:57:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0ECC861FB0\n\tfor ;\n\tTue, 5 Jul 2022 22:57:04 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 851CB6BB;\n\tTue, 5 Jul 2022 22:57:03 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657054625;\n\tbh=Ya4jpNvKyyEwhbmgw7ei+HO8S8DcVCwQanH3/ZWJZfY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=P9AZ+lgJgYeZpoBKiMccrtrH+iR+HdC5ClbJSpidnC3FdIb4DDMJ4LXr+DmuiVSo1\n\tWM5Y38cJgqtMwzx8jlRvy96CdmtGhl8vcMTxqYa+BxxQp4wiYbj31V1zFW2IkhSVmK\n\t7t3/ztbV3hyeHnUlWfGXa3yeKAjPthT3MBnDWVFkGLS1dkgObxn2Ax0N+tJVVhJq7L\n\t+toQ5hL4eyByxjdAhRf/JEUFzS1JuKP8yhgSaLfV2VGL7Qo6qVQvjm04rr9Tr58mE1\n\thT/0wCRCRTcGsx5KI3BAD7be8bRd4ZSi9/PmLdzUg5bQvJVIbSu6QPag/sqRjGa1Zz\n\twKj0TO1G4LxrA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657054623;\n\tbh=Ya4jpNvKyyEwhbmgw7ei+HO8S8DcVCwQanH3/ZWJZfY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ktoIuRDhMcW9Nr9yQNn33KOhbgSWtDpQd2oBhuu7kAU6O4eyQOCC/1WEGROlZZcyh\n\te4N+trG2+VDn3KbKVwg/OHoEztLH7fx2d0DhjWzR0ZKYwNmkZcLQcxvkgGPt4JW0W1\n\twOcv72Vg0IfeqG29e5KthAnKqs4Ui3Adt8UmluR0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ktoIuRDh\"; dkim-atps=neutral","Date":"Tue, 5 Jul 2022 23:56:39 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220705153111.2338369-1-kieran.bingham@ideasonboard.com>\n\t<20220705153111.2338369-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220705153111.2338369-2-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/3] qcam: viewfinder_qt: Fix include\n\torders","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]