{"id":16540,"url":"https://patchwork.libcamera.org/api/patches/16540/?format=json","web_url":"https://patchwork.libcamera.org/patch/16540/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220704233217.54769-4-Rauch.Christian@gmx.de>","date":"2022-07-04T23:32:16","name":"[libcamera-devel,v9,3/4] libcamera: controls: Generate fixed- and variable-sized Span Controls","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"abbda95a9e49e6401aeb5995bb1b3e26a6a73a0c","submitter":{"id":111,"url":"https://patchwork.libcamera.org/api/people/111/?format=json","name":"Christian Rauch","email":"Rauch.Christian@gmx.de"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16540/mbox/","series":[{"id":3250,"url":"https://patchwork.libcamera.org/api/series/3250/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3250","date":"2022-07-04T23:32:13","name":"generate and use fixed-sized Span Control types","version":9,"mbox":"https://patchwork.libcamera.org/series/3250/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16540/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16540/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F7C5BE173\n\tfor ;\n\tMon, 4 Jul 2022 23:32:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EEC7863313;\n\tTue, 5 Jul 2022 01:32:37 +0200 (CEST)","from mout.gmx.net (mout.gmx.net [212.227.15.15])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 58ED36042E\n\tfor ;\n\tTue, 5 Jul 2022 01:32:34 +0200 (CEST)","from localhost.localdomain ([92.18.80.244]) by mail.gmx.net\n\t(mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id\n\t1M5QJD-1o9L2C3i1l-001P19; Tue, 05 Jul 2022 01:32:34 +0200"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656977558;\n\tbh=UqwmX7+yMaOqSyR96KduBQpxFaCTOfHvdMO6MxtFX8g=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=j/5/Ay9DMIMPDKqIYF82sj5wp7/+83u7f/qDN4KVtpSjVpfMuxg1k4VzazkvthQop\n\tvkXQF7A2bgu0xNRSvTwtSqF9rDjD2tEEFZiS3kprZ8qjop8WNP5JEBE1JVU9WJ59bL\n\tl5rk3KEue3X55my7/L6l35LCut3OaFNWLLQFQY53A7poAibjqhZiR0nZ24CFb19YMs\n\tumr1XnL7rSGW//tpK02l7s6NxHPldDRjjXboT237uhNdPH4VpEhls24ClxG710djFw\n\tnSxgULanotBuuvBxo30Ki/bcmphOMHM2GTmzmt0+8bAK4egx8yXvV7YS8P/Ae+2WlK\n\tl7T4SgOfWFJ9w==","v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1656977554;\n\tbh=UqwmX7+yMaOqSyR96KduBQpxFaCTOfHvdMO6MxtFX8g=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References;\n\tb=IBGXHTrizAYQflxUJXHl32cJijLfpSiuGjPic9up9ypsZZlBCFbDI/ZkLnUbjVmHH\n\tm4NN00Cu997VaFWLu+O36BXsi1eFwnUAdFaH2sX/4HRYGt99zl5cVKJtAv5dcAnNVq\n\toMmsUcpeprE8PFgqfRCVPzq7s49Xgoim3QAZ2wpA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"IBGXHTri\"; dkim-atps=neutral","X-UI-Sender-Class":"01bb95c1-4bf8-414a-932a-4f6e2808ef9c","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 5 Jul 2022 00:32:16 +0100","Message-Id":"<20220704233217.54769-4-Rauch.Christian@gmx.de>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220704233217.54769-1-Rauch.Christian@gmx.de>","References":"<20220704233217.54769-1-Rauch.Christian@gmx.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:w5qMBf2rLPmRmaGHONqhxzM+PR2cqmKzyuaorhqo6JhWh+COwX3\n\t2T9FOXVDtvhte+XyFk15yqSjSBNHvg8NF4+Ucb7GeNwyapGVHNfVndM5Vko89JPMVkCYdUz\n\t4aYs+fggbgqC8+ZG4rHeEfypRQ8EL9/gJZiOMZDl4XGdvTpMQGRvLZU5jBQy8ocR7tbqAkH\n\tTj5mZYgfIihINtGfbmBug==","X-Spam-Flag":"NO","X-UI-Out-Filterresults":"notjunk:1; V03:K0:DXLRsWq7lck=:Uc3EziPeJ2Q093N92i6l/p\n\tpkA3MukjmKGL7eYwLznzSbAXGJLhyjDgak75lXVzpyr3kqNZEIEQ/075WyMBlmOUqwlZX9yq+\n\tHgGYMwMdXPsBdpDu7aGNDl9b/ln3+RUIvJeXQTHakaCC5yzVqfdeiMxKy9C22oBkeYVIkpDZP\n\t4zHi70eFoTcZ8b+v5fZQrcJJxrzzPi/0HArQCrNTrl8JKK6s8aVkWnSpH3pi8yVD5xNdIdzug\n\tQpzPus4vSyKWJnp18VyoyRqEFxKNxdzyVOTU/i/IdIJR9XP1mUNqWKfTpT9cSRWC7fjlGbIV+\n\t6UQtCYeZCoAK53XanBjdlBEtb6f6gSE8vJHgX1iAhuL1sqwH9FczUHqHg0yXPrWVe33yDnc92\n\tWjOtybfqNYSdF5k0aM0Hr5pMxhmKAEST9T18SabFsAO+t8jCgsuwfFIsRoIgX2dBv6EwsHCAQ\n\tn6NZXh2VsK8A1ONZjapxVylH4quBr2+SUTlMaRcSQWDmo1iReMn5bKraZB6B7p1yIrcdOmYCl\n\tc4CF+VKsqU4Bd91CFsj9n7xVTLu5SByM4ot1pYLDrtEOnnZzgIhvJukc8PZivO9Rv/WExHG1i\n\tCK4QrsyQ5rfADlEJ99uroIrZiqFHejNMfi+YIgFK7Vs4Gj0qHqRfho5UHDqRhavJrvCWFvaum\n\tCv1fSOin39DqXoM2YzixdkslAJ9SQU31JDZI+WdrAiggIQQKQJZ2eePURK8dhZCzt9ED/Cvrz\n\tGKQ4RqcdJYzBtfkD/jsyhYPWeqhGlppZ1VVcYyaNBmk4MCrCneRbHdB3wkkkJo4h/Pee3IxFI\n\tcwXw/8EACICZ86UMW1/xSmpCVM1wcbk6vqz5xn70BHxKZ05hcIAAvtyDH/W0jXYdBJLRw4IwR\n\tAnyh0MLb5Rkeks/Hc3l41QJDyoRmu/9G/rhSxoC/SOxX7KoIvH29d5c38GTheT1MylGcQYxyC\n\tRHVP1KtUwlCWupgf7IaeS64w//Azh/UVBksghq7MJ9+YiBj+M47Btl+aNE3FPAJ2AW/CTutEz\n\tvlF2m95zuciSW9HAJxrP1l1e/RtZMn801Scy30beNmcGmukKYlVUAW3xOSQLP81d0dC7vl07x\n\tpC5+uZ2n5qpW8c8GuK0P3IMa/6CHwy7rIq+4BZdqN8Bt5Zyc10pXOf/YQ==","Subject":"[libcamera-devel] [PATCH v9 3/4] libcamera: controls: Generate\n\tfixed- and variable-sized Span Controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Christian Rauch via libcamera-devel\n\t","Reply-To":"Christian Rauch ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This defines Controls with a 'size' as either variable-sized Span or as\nfixed-sized Span.\n\nSigned-off-by: Christian Rauch \nReviewed-by: Jacopo Mondi \n---\n utils/gen-controls.py | 32 ++++++++++++++++++++++----------\n 1 file changed, 22 insertions(+), 10 deletions(-)\n\n--\n2.34.1","diff":"diff --git a/utils/gen-controls.py b/utils/gen-controls.py\nindex 3f99b5e2..46ba4394 100755\n--- a/utils/gen-controls.py\n+++ b/utils/gen-controls.py\n@@ -7,6 +7,8 @@\n # gen-controls.py - Generate control definitions from YAML\n\n import argparse\n+from functools import reduce\n+import operator\n import string\n import sys\n import yaml\n@@ -22,6 +24,24 @@ def format_description(description):\n return '\\n'.join([(line and ' * ' or ' *') + line for line in description])\n\n\n+def get_ctrl_type(ctrl):\n+ ctrl_type = ctrl['type']\n+ ctrl_size_arr = ctrl.get('size')\n+\n+ if ctrl_type == 'string':\n+ return 'std::string'\n+ elif ctrl_size_arr is not None:\n+ if len(ctrl_size_arr) > 0:\n+ # fixed-sized Span\n+ ctrl_span_size = reduce(operator.mul, ctrl_size_arr)\n+ return f\"Span\"\n+ else:\n+ # variable-sized Span\n+ return f\"Span\"\n+ else:\n+ return ctrl_type\n+\n+\n def generate_cpp(controls):\n enum_doc_start_template = string.Template('''/**\n * \\\\enum ${name}Enum\n@@ -50,11 +70,7 @@ ${description}\n name, ctrl = ctrl.popitem()\n id_name = snake_case(name).upper()\n\n- ctrl_type = ctrl['type']\n- if ctrl_type == 'string':\n- ctrl_type = 'std::string'\n- elif ctrl.get('size'):\n- ctrl_type = 'Span' % ctrl_type\n+ ctrl_type = get_ctrl_type(ctrl)\n\n info = {\n 'name': name,\n@@ -135,11 +151,7 @@ def generate_h(controls):\n\n ids.append('\\t' + id_name + ' = ' + str(id_value) + ',')\n\n- ctrl_type = ctrl['type']\n- if ctrl_type == 'string':\n- ctrl_type = 'std::string'\n- elif ctrl.get('size'):\n- ctrl_type = 'Span' % ctrl_type\n+ ctrl_type = get_ctrl_type(ctrl)\n\n info = {\n 'name': name,\n","prefixes":["libcamera-devel","v9","3/4"]}