[{"id":23728,"web_url":"https://patchwork.libcamera.org/comment/23728/","msgid":"<YsNpqKQOW6mwDy2j@pendragon.ideasonboard.com>","date":"2022-07-04T22:28:56","subject":"Re: [libcamera-devel] PinePhone needs S_FRAME_INTERVAL","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Pavel,\n\nOn Tue, Jul 05, 2022 at 12:15:49AM +0200, Pavel Machek wrote:\n> Hi!\n> \n> It looks I solved another mystery: Top resolution was not available,\n> and depending on order of commands, sometimes 1280x720 was not\n> available, either.\n> \n> So I took a look into megapixels, and mystery solved -- libcamera is\n> not setting frame intervals at all.\n> \n> AFAICT that needs to happen. PinePhone needs lower fps for top\n> resolution, but an use high fps for lower resolutions...\n> \n> This is obviosly a hack, but we need something like that.\n\nVIDIOC_SUBDEV_S_FRAME_INTERVAL is deprecated for camera sensors and\nshould never have been used. Frame rates are controlled through the\npixel clock and the horizontal and vertical blanking values. If a sensor\ndriver requires VIDIOC_SUBDEV_S_FRAME_INTERVAL, then it should be fixed.\n\n> commit 66616c78007c08fcd3fde66888c2210a392b184e\n> Author: Pavel Machek <pavel@ucw.cz>\n> Date:   Mon Jul 4 23:54:22 2022 +0200\n> \n>     S_FRAME_INTERVAL is needed, or things don't work.\n> \n> index fba90e20..0ee6ac30 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -452,6 +452,21 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n>  \t\t\t     Whence whence)\n>  {\n>  \tstruct v4l2_subdev_format subdevFmt = {};\n> +\n> +\t{\n> +\t  struct v4l2_subdev_frame_interval interval = {};\n> +                interval.pad = 0;\n> +                interval.interval.numerator = 1;\n> +                interval.interval.denominator = 10;\n> +                if (int ret = ioctl(VIDIOC_SUBDEV_S_FRAME_INTERVAL,\n> +                           &interval) == -1) {\n> +\t\t\tLOG(V4L2, Error)\n> +\t\t\t  << \"Unable to set frame interval on pad \" << pad\n> +\t\t\t  << \": \" << strerror(-ret);\n> +                        return ret;\n> +                }\n> +\n> +\t}\n>  \tsubdevFmt.which = whence == ActiveFormat ? V4L2_SUBDEV_FORMAT_ACTIVE\n>  \t\t\t: V4L2_SUBDEV_FORMAT_TRY;\n>  \tsubdevFmt.pad = pad;\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9BB92BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon,  4 Jul 2022 22:29:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 043AB60BFB;\n\tTue,  5 Jul 2022 00:29:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C9ABC6054A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  5 Jul 2022 00:29:19 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 375CC6D7;\n\tTue,  5 Jul 2022 00:29:19 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656973762;\n\tbh=O3twYVgCKE4aik4l36G230K2rCZG7clPBhwIGrTdSXI=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=QX6BBfBJp9V9C1SWliCDmmx2DquM+syFzOSwjRhms9BGHqq6XNhwmr+zw/w6KAnO7\n\tVVsdnsxa8fmobJ8UZ0goZtRkrlZ1B2EN6vCzdmDw+i3UY2FnaUrAd0kxes74rhlrcj\n\tBj+2QBnSZbzjjVHhRFNnMx5S1RFI5+FDknthF1saBV8b98VspiLUTBbTwwT/0ujey8\n\thq5jNJdI8xCDni9rYUZ18UA1t/QQ52TgFOkeL9YxGNbEyP5xKw/za5NKaw4SD8alGR\n\tHO5C6vwjsPm7L5soKdn1E9f/JkXtATy2We+gcuSWy+w3OAfDgrK7OjCSdyP+7eOLC/\n\tj0PTsGxKxOMaw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656973759;\n\tbh=O3twYVgCKE4aik4l36G230K2rCZG7clPBhwIGrTdSXI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mE8v9OSXuSI4aCh7hTIRS+cDMoba4VqNvozG8eYc/qf0Z3TNPNFOzMWP2yPMmxQ1Q\n\toOTUbuNhON31AZxyxe/rYD8iOyUV6Qpo0MJ95psh0p6GnkRgCZ+L2XE5/t66eDHqIn\n\tqgyiRVO8bOxbVfPag5bIEHTHP43yxlTh+wQIY+CE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"mE8v9OSX\"; dkim-atps=neutral","Date":"Tue, 5 Jul 2022 01:28:56 +0300","To":"Pavel Machek <pavel@ucw.cz>","Message-ID":"<YsNpqKQOW6mwDy2j@pendragon.ideasonboard.com>","References":"<20220701211120.GB18840@duo.ucw.cz>\n\t<279b87a6-2209-e4d1-6342-12253258b59f@riseup.net>\n\t<YsGe984b7/ShqZXw@pendragon.ideasonboard.com>\n\t<9a63e90b-5da6-2915-462e-70b2f61d1867@riseup.net>\n\t<20220703155800.GA11658@amd>\n\t<70821a87-8ea5-1583-daa3-ce1531977ce7@riseup.net>\n\t<d37fdb5f-79a6-56be-274f-12a5852836fc@riseup.net>\n\t<20220704161526.GA23964@amd>\n\t<YsMZOLfuXkjw6h+G@pendragon.ideasonboard.com>\n\t<20220704221548.GB8002@amd>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220704221548.GB8002@amd>","Subject":"Re: [libcamera-devel] PinePhone needs S_FRAME_INTERVAL","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"martijn@brixit.nl, libcamera-devel@lists.libcamera.org, jozef@mlich.cz","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":23734,"web_url":"https://patchwork.libcamera.org/comment/23734/","msgid":"<20220705071744.ud723w23mpzru5qw@uno.localdomain>","date":"2022-07-05T07:17:44","subject":"Re: [libcamera-devel] PinePhone needs S_FRAME_INTERVAL","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Pavel,\n\nOn Tue, Jul 05, 2022 at 12:15:49AM +0200, Pavel Machek via libcamera-devel wrote:\n> Hi!\n>\n> It looks I solved another mystery: Top resolution was not available,\n> and depending on order of commands, sometimes 1280x720 was not\n> available, either.\n>\n> So I took a look into megapixels, and mystery solved -- libcamera is\n> not setting frame intervals at all.\n>\n> AFAICT that needs to happen. PinePhone needs lower fps for top\n> resolution, but an use high fps for lower resolutions...\n>\n> This is obviosly a hack, but we need something like that.\n>\n\nCan I ask a stupid question ? Is the sun6i a parallel or CSI-2\nreceiver ? If you're using my ov5640 branch (patches will land\nupstream in 5.20) the need to set frame_interval to work around a\ndriver deficiency is now only for parallel setups. CSI-2 platforms have\nbeen switched to use VBLANK to control the frame rate.\n\nFor reference:\nhttps://git.sr.ht/~jmondi_/linux/tree/jmondi/media-master/ov5640-v7\n\n> Best regards,\n> \t\t\t\t\t\t\tPavel\n>\n> commit 66616c78007c08fcd3fde66888c2210a392b184e\n> Author: Pavel Machek <pavel@ucw.cz>\n> Date:   Mon Jul 4 23:54:22 2022 +0200\n>\n>     S_FRAME_INTERVAL is needed, or things don't work.\n>\n> index fba90e20..0ee6ac30 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -452,6 +452,21 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n>  \t\t\t     Whence whence)\n>  {\n>  \tstruct v4l2_subdev_format subdevFmt = {};\n> +\n> +\t{\n> +\t  struct v4l2_subdev_frame_interval interval = {};\n> +                interval.pad = 0;\n> +                interval.interval.numerator = 1;\n> +                interval.interval.denominator = 10;\n> +                if (int ret = ioctl(VIDIOC_SUBDEV_S_FRAME_INTERVAL,\n> +                           &interval) == -1) {\n> +\t\t\tLOG(V4L2, Error)\n> +\t\t\t  << \"Unable to set frame interval on pad \" << pad\n> +\t\t\t  << \": \" << strerror(-ret);\n> +                        return ret;\n> +                }\n> +\n> +\t}\n>  \tsubdevFmt.which = whence == ActiveFormat ? V4L2_SUBDEV_FORMAT_ACTIVE\n>  \t\t\t: V4L2_SUBDEV_FORMAT_TRY;\n>  \tsubdevFmt.pad = pad;\n>\n> --\n> People of Russia, stop Putin before his war on Ukraine escalates.","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 40D50BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  5 Jul 2022 07:17:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AB0176330C;\n\tTue,  5 Jul 2022 09:17:48 +0200 (CEST)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3BD0360401\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  5 Jul 2022 09:17:47 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id ED91F1BF213;\n\tTue,  5 Jul 2022 07:17:45 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657005468;\n\tbh=WzlokoD455JE1uz9+oktNfVy6BYqu9vb6yQ8GvItg6s=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=wxN8zz7+raQ9qJ8moGt9iZKxwqwOSx5VRf6TaNPX+uSmkFKN1ZEgHzfhcoslcxnn8\n\t+NZRBAhdAAZdvzztriUQaiPPEtDxeF0kqtsIx/ZnLN57QtKbvEcfXZ1W3Jdvot8Cu+\n\tyq9Bi01I4vFtoRRvZjjeBOCYp0B00cBnbk3YK7wSBj6zjtnlG+MfCxljaIM5alQI9O\n\tM/j/c2zplDqd0yTsOvV0W93ZHABJLC8pYTuRvIMOkIqUYA8146v9VqydMFLcSXpHAV\n\tg9X4guTatPcYN8V3IwFwa+wKghJRAGv2/g2xVz+hQqVYlP+dS4w/iiFi147slJXFXM\n\t+otpQ/AxKGwRA==","Date":"Tue, 5 Jul 2022 09:17:44 +0200","To":"Pavel Machek <pavel@ucw.cz>","Message-ID":"<20220705071744.ud723w23mpzru5qw@uno.localdomain>","References":"<20220701211120.GB18840@duo.ucw.cz>\n\t<279b87a6-2209-e4d1-6342-12253258b59f@riseup.net>\n\t<YsGe984b7/ShqZXw@pendragon.ideasonboard.com>\n\t<9a63e90b-5da6-2915-462e-70b2f61d1867@riseup.net>\n\t<20220703155800.GA11658@amd>\n\t<70821a87-8ea5-1583-daa3-ce1531977ce7@riseup.net>\n\t<d37fdb5f-79a6-56be-274f-12a5852836fc@riseup.net>\n\t<20220704161526.GA23964@amd>\n\t<YsMZOLfuXkjw6h+G@pendragon.ideasonboard.com>\n\t<20220704221548.GB8002@amd>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"btdafkvjmvbhfn7k\"","Content-Disposition":"inline","In-Reply-To":"<20220704221548.GB8002@amd>","Subject":"Re: [libcamera-devel] PinePhone needs S_FRAME_INTERVAL","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Jacopo Mondi <jacopo@jmondi.org>","Cc":"martijn@brixit.nl, libcamera-devel@lists.libcamera.org, jozef@mlich.cz","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":23754,"web_url":"https://patchwork.libcamera.org/comment/23754/","msgid":"<20220705204950.GA3682@amd>","date":"2022-07-05T20:49:50","subject":"Re: [libcamera-devel] PinePhone needs S_FRAME_INTERVAL","submitter":{"id":49,"url":"https://patchwork.libcamera.org/api/people/49/","name":"Pavel Machek","email":"pavel@ucw.cz"},"content":"Hi!\n\n> > It looks I solved another mystery: Top resolution was not available,\n> > and depending on order of commands, sometimes 1280x720 was not\n> > available, either.\n> > \n> > So I took a look into megapixels, and mystery solved -- libcamera is\n> > not setting frame intervals at all.\n> > \n> > AFAICT that needs to happen. PinePhone needs lower fps for top\n> > resolution, but an use high fps for lower resolutions...\n> > \n> > This is obviosly a hack, but we need something like that.\n> \n> VIDIOC_SUBDEV_S_FRAME_INTERVAL is deprecated for camera sensors and\n> should never have been used. Frame rates are controlled through the\n> pixel clock and the horizontal and vertical blanking values. If a sensor\n> driver requires VIDIOC_SUBDEV_S_FRAME_INTERVAL, then it should be\n> fixed.\n\nHmm. I can't really change the kernel at the moment.\n\nBut... However you call frames per second, it is quite an important\nparameter that needs to be controlled by the user, no? Is there plan\nto include it in the stream options\n\n  -s, --stream key=value[,key=value,...] ...            Set configuration of a camera stream\n            height=integer                                Height in pixels\n\t    pixelformat=string                            Pixel format name\n\t    role=string                                   Role for the stream (viewfinder, video, still, raw)\n\t    width=integer                                 Width in pixels\n\t\t\t\t\t  \nConfusing thing for me is that without S_FRAME_INTERVAL being set\nexplicitely, old value was being used, leading to\nhard-to-understand/debug problems. I guess that is no longer going to\nbe a problem with fixed kernel drivers.\n\nBest regards,\n\t\t\t\t\t\t\t\tPavel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D311DBD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  5 Jul 2022 20:49:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 199D763310;\n\tTue,  5 Jul 2022 22:49:53 +0200 (CEST)","from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D00261FB0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  5 Jul 2022 22:49:51 +0200 (CEST)","by jabberwock.ucw.cz (Postfix, from userid 1017)\n\tid CEF611C0001; Tue,  5 Jul 2022 22:49:50 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657054193;\n\tbh=OzujbvF0lBj3iiJ635V5pHfrCnjiHR6z5FOIgcnDD84=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=GGJzzBh5z3OlLXBEzL2Xth3SV4GPzKAZlT1jVM+b982nuzmK0aIhwePYhLZ8IJsIj\n\t8lC4/rPmPzhB+u+7/9FQA2y8kYFTiHc0bjAI19bBLBHOVAvAnSXtQklLybcZ2CdG8j\n\txIACj/7xGP8Gj1WFiQX8t56DBaz7DCiw5l0dbrAucuGkM/nCg6VcazOsnQCinYe+eJ\n\tMBO16xkd9PIQ5RXcMILntl94gUW8kS5qB5yqEjFOD24hK41vDmTG2JmmU1BkFp2lnX\n\t+PBho17rF8VcL+VGUw/GfOYwAQ+YWF8F441mXKT8Rz3QWJmdTlHefrmzPsxq1ru/oO\n\to00/eh1w+axhA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1;\n\tt=1657054190;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=iW+wiRw7Byc75y1YYQQGEvApABXH0e6sWHXz4RZCGWU=;\n\tb=NZ+C+d6eXUeZ6vzCaRxFEAInLyJxMz0iZIc4GzW/RLWdD8VvNKRO1lR/OkGjDLeudkwfAk\n\tsyGVS+Scgwte01ix8brCe+XJ88dYPD0jpxiiwF91l13BSXe2JMwxulKlg5uxx0LdnAzrAO\n\tyk6uWmtbFLCxtbbn4AzfmpuMIbUG1dc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ucw.cz header.i=@ucw.cz\n\theader.b=\"NZ+C+d6e\"; dkim-atps=neutral","Date":"Tue, 5 Jul 2022 22:49:50 +0200","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Message-ID":"<20220705204950.GA3682@amd>","References":"<279b87a6-2209-e4d1-6342-12253258b59f@riseup.net>\n\t<YsGe984b7/ShqZXw@pendragon.ideasonboard.com>\n\t<9a63e90b-5da6-2915-462e-70b2f61d1867@riseup.net>\n\t<20220703155800.GA11658@amd>\n\t<70821a87-8ea5-1583-daa3-ce1531977ce7@riseup.net>\n\t<d37fdb5f-79a6-56be-274f-12a5852836fc@riseup.net>\n\t<20220704161526.GA23964@amd>\n\t<YsMZOLfuXkjw6h+G@pendragon.ideasonboard.com>\n\t<20220704221548.GB8002@amd>\n\t<YsNpqKQOW6mwDy2j@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"gBBFr7Ir9EOA20Yy\"","Content-Disposition":"inline","In-Reply-To":"<YsNpqKQOW6mwDy2j@pendragon.ideasonboard.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Subject":"Re: [libcamera-devel] PinePhone needs S_FRAME_INTERVAL","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Pavel Machek via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Pavel Machek <pavel@ucw.cz>","Cc":"martijn@brixit.nl, libcamera-devel@lists.libcamera.org, jozef@mlich.cz","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":23755,"web_url":"https://patchwork.libcamera.org/comment/23755/","msgid":"<20220705205606.GB3682@amd>","date":"2022-07-05T20:56:06","subject":"Re: [libcamera-devel] PinePhone needs S_FRAME_INTERVAL","submitter":{"id":49,"url":"https://patchwork.libcamera.org/api/people/49/","name":"Pavel Machek","email":"pavel@ucw.cz"},"content":"Hi!\n\n> > It looks I solved another mystery: Top resolution was not available,\n> > and depending on order of commands, sometimes 1280x720 was not\n> > available, either.\n> >\n> > So I took a look into megapixels, and mystery solved -- libcamera is\n> > not setting frame intervals at all.\n> >\n> > AFAICT that needs to happen. PinePhone needs lower fps for top\n> > resolution, but an use high fps for lower resolutions...\n> >\n> > This is obviosly a hack, but we need something like that.\n> >\n> \n> Can I ask a stupid question ? Is the sun6i a parallel or CSI-2\n> receiver ? If you're using my ov5640 branch (patches will land\n> upstream in 5.20) the need to set frame_interval to work around a\n> driver deficiency is now only for parallel setups. CSI-2 platforms have\n> been switched to use VBLANK to control the frame rate.\n\nI'm not really sure how to tell the difference. media-ctl mentions\ncsi:\n\nmobian@mobian:~/g/libcamera$ sudo media-ctl -p -d /dev/media1\nMedia controller API version 5.15.44\n\nMedia device information\n------------------------\ndriver          sun6i-csi\nmodel           Allwinner Video Capture Device\nserial\nbus info        platform:1cb0000.csi\nhw revision     0x0\ndriver version  5.15.44\n\nDevice topology\n- entity 1: sun6i-csi (1 pad, 2 links)\n type Node subtype V4L flags 0\n device node name /dev/video2\n pad0: Sink\n <- \"gc2145 3-003c\":0 []\n <- \"ov5640 3-004c\":0 [ENABLED]\n\t\t\t\t\t\t   \nI'm using \"Linux mobian 5.15-sunxi64 #1 SMP Tue Jun 7 01:08:50 UTC 2022\naarch64 GNU/Linux\" kernel from mobian, and can not really change it\neasily at the moment.\n\nBest regards,\n\t\t\t\t\t\t\t\tPavel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C8D43BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  5 Jul 2022 20:56:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0F0BB63310;\n\tTue,  5 Jul 2022 22:56:09 +0200 (CEST)","from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CFA9261FB0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  5 Jul 2022 22:56:07 +0200 (CEST)","by jabberwock.ucw.cz (Postfix, from userid 1017)\n\tid 74F651C0001; Tue,  5 Jul 2022 22:56:07 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657054569;\n\tbh=ZvuujhXEiNjI8I+0C289B2tNR4MqG/u0NGKEa25LtVg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=bmwZPTS/Rj64k3YUfzwuLMj4OfLiVSsEFsgnETbB/S0JKp+BEVXyHQDDMFtH8I2+1\n\tzguS1eq3zU0BKgFJ5RK3CAGr2PG7z7P8mLsgySV3/dfTvh/H5JZSN3qf8Y5Tpz21uf\n\tRJPysI92HdDxHlStQ5ZCrcla47XwSfEDMaQgJEhWnxLSkE5kUYF/lLmR5BcCx/ucE+\n\tPE/NR8wD02UkDtfUOjhjW1Ks9ny+y4IiUyzMNHiVhLRSa+d7T4914ErTZ9ZGkzAwPR\n\tHnSPI68HszUQhPAq8JOGY5wIPUXbAm/f64mddayQmL1TqiRhdEhO+C22SqyYtX80nj\n\tikbAUIXqO3NgA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1;\n\tt=1657054567;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=Uu7OT3wht1uGxbjvbkqCWpN85JiMVd+wcPxut8Pq4JA=;\n\tb=BVo+d94wEcEt4DTK1zv7N9IcO0o9pkttzURElbi/ld0UFnJ+Fw40S7izsq9qnSiviun+ZR\n\tO1oSafVc+r5JZkhlouyXjDDyizY4LxhiKLJ108uKRi25CnN5OZJqjVYtoTKVSBR31j7JRV\n\tDEe2voodb6oHhyRqSAtpD5bwXaYCxWw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ucw.cz header.i=@ucw.cz\n\theader.b=\"BVo+d94w\"; dkim-atps=neutral","Date":"Tue, 5 Jul 2022 22:56:06 +0200","To":"Jacopo Mondi <jacopo@jmondi.org>","Message-ID":"<20220705205606.GB3682@amd>","References":"<279b87a6-2209-e4d1-6342-12253258b59f@riseup.net>\n\t<YsGe984b7/ShqZXw@pendragon.ideasonboard.com>\n\t<9a63e90b-5da6-2915-462e-70b2f61d1867@riseup.net>\n\t<20220703155800.GA11658@amd>\n\t<70821a87-8ea5-1583-daa3-ce1531977ce7@riseup.net>\n\t<d37fdb5f-79a6-56be-274f-12a5852836fc@riseup.net>\n\t<20220704161526.GA23964@amd>\n\t<YsMZOLfuXkjw6h+G@pendragon.ideasonboard.com>\n\t<20220704221548.GB8002@amd>\n\t<20220705071744.ud723w23mpzru5qw@uno.localdomain>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"WhfpMioaduB5tiZL\"","Content-Disposition":"inline","In-Reply-To":"<20220705071744.ud723w23mpzru5qw@uno.localdomain>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Subject":"Re: [libcamera-devel] PinePhone needs S_FRAME_INTERVAL","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Pavel Machek via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Pavel Machek <pavel@ucw.cz>","Cc":"martijn@brixit.nl, libcamera-devel@lists.libcamera.org, jozef@mlich.cz","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":23759,"web_url":"https://patchwork.libcamera.org/comment/23759/","msgid":"<20220706064315.dygscxj22t45cp2h@uno.localdomain>","date":"2022-07-06T06:43:15","subject":"Re: [libcamera-devel] PinePhone needs S_FRAME_INTERVAL","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Pavel,\n\nOn Tue, Jul 05, 2022 at 10:56:06PM +0200, Pavel Machek wrote:\n> Hi!\n>\n> > > It looks I solved another mystery: Top resolution was not available,\n> > > and depending on order of commands, sometimes 1280x720 was not\n> > > available, either.\n> > >\n> > > So I took a look into megapixels, and mystery solved -- libcamera is\n> > > not setting frame intervals at all.\n> > >\n> > > AFAICT that needs to happen. PinePhone needs lower fps for top\n> > > resolution, but an use high fps for lower resolutions...\n> > >\n> > > This is obviosly a hack, but we need something like that.\n> > >\n> >\n> > Can I ask a stupid question ? Is the sun6i a parallel or CSI-2\n> > receiver ? If you're using my ov5640 branch (patches will land\n> > upstream in 5.20) the need to set frame_interval to work around a\n> > driver deficiency is now only for parallel setups. CSI-2 platforms have\n> > been switched to use VBLANK to control the frame rate.\n>\n> I'm not really sure how to tell the difference. media-ctl mentions\n> csi:\n\nNo worries, if you can't update the kernel it doesn't make a\ndifference. I thought you were using the same kernel as Rafael with\nthe ov5640 patches in. If you're on the current driver version you\nneed the awkward s_frame_interval dance.\n\n>\n> mobian@mobian:~/g/libcamera$ sudo media-ctl -p -d /dev/media1\n> Media controller API version 5.15.44\n>\n> Media device information\n> ------------------------\n> driver          sun6i-csi\n> model           Allwinner Video Capture Device\n> serial\n> bus info        platform:1cb0000.csi\n> hw revision     0x0\n> driver version  5.15.44\n>\n> Device topology\n> - entity 1: sun6i-csi (1 pad, 2 links)\n>  type Node subtype V4L flags 0\n>  device node name /dev/video2\n>  pad0: Sink\n>  <- \"gc2145 3-003c\":0 []\n>  <- \"ov5640 3-004c\":0 [ENABLED]\n>\n> I'm using \"Linux mobian 5.15-sunxi64 #1 SMP Tue Jun 7 01:08:50 UTC 2022\n> aarch64 GNU/Linux\" kernel from mobian, and can not really change it\n> easily at the moment.\n>\n> Best regards,\n> \t\t\t\t\t\t\t\tPavel\n> --\n> People of Russia, stop Putin before his war on Ukraine escalates.","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ED60FBD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  6 Jul 2022 06:43:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2658263310;\n\tWed,  6 Jul 2022 08:43:20 +0200 (CEST)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 587956048D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  6 Jul 2022 08:43:18 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id E08CE20009;\n\tWed,  6 Jul 2022 06:43:16 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657089800;\n\tbh=hK7ElkT7RENnPikwAmLuD5X4BzwKreJ6l2BADRncdH0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=NnMSf6fldhJ6nrMi+TU1yVa4HpXneJN0Mv3MVPtFCV3mJqH/f5KOzwyVwFFERPeAR\n\trcxT+pNtIcp7EqHbMhb4wnDRQt6J07Fh7GbvliQihGKfr9TWjR2/lm6wuT+YSez6Z6\n\tAv2jD9C3mI1pGIBKy4oM1LPOXdU/45OBrLB1o1ZWQ9TjzaZOzHcGapwMg8DQJj+PDP\n\t4fV6jXEMkXUyLVulFhLQbfPNKI9EjgxIrI4tIx3me3JZo7dZZVbSuUW9RCHjZs+Z1z\n\tApq38IL/WlL7mbTg6RExj45Z1odwpM/Eog1O+4rma6R0Fxm3IKhaq483Kph/LAzefj\n\tX2FB45kLc5tSg==","Date":"Wed, 6 Jul 2022 08:43:15 +0200","To":"Pavel Machek <pavel@ucw.cz>","Message-ID":"<20220706064315.dygscxj22t45cp2h@uno.localdomain>","References":"<YsGe984b7/ShqZXw@pendragon.ideasonboard.com>\n\t<9a63e90b-5da6-2915-462e-70b2f61d1867@riseup.net>\n\t<20220703155800.GA11658@amd>\n\t<70821a87-8ea5-1583-daa3-ce1531977ce7@riseup.net>\n\t<d37fdb5f-79a6-56be-274f-12a5852836fc@riseup.net>\n\t<20220704161526.GA23964@amd>\n\t<YsMZOLfuXkjw6h+G@pendragon.ideasonboard.com>\n\t<20220704221548.GB8002@amd>\n\t<20220705071744.ud723w23mpzru5qw@uno.localdomain>\n\t<20220705205606.GB3682@amd>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"irvdohficphmbpzq\"","Content-Disposition":"inline","In-Reply-To":"<20220705205606.GB3682@amd>","Subject":"Re: [libcamera-devel] PinePhone needs S_FRAME_INTERVAL","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Jacopo Mondi <jacopo@jmondi.org>","Cc":"martijn@brixit.nl, libcamera-devel@lists.libcamera.org, jozef@mlich.cz","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":23773,"web_url":"https://patchwork.libcamera.org/comment/23773/","msgid":"<20220706181617.GB13702@amd>","date":"2022-07-06T18:16:17","subject":"Re: [libcamera-devel] PinePhone needs S_FRAME_INTERVAL","submitter":{"id":49,"url":"https://patchwork.libcamera.org/api/people/49/","name":"Pavel Machek","email":"pavel@ucw.cz"},"content":"Hi!\n\n> > > Can I ask a stupid question ? Is the sun6i a parallel or CSI-2\n> > > receiver ? If you're using my ov5640 branch (patches will land\n> > > upstream in 5.20) the need to set frame_interval to work around a\n> > > driver deficiency is now only for parallel setups. CSI-2 platforms have\n> > > been switched to use VBLANK to control the frame rate.\n> >\n> > I'm not really sure how to tell the difference. media-ctl mentions\n> > csi:\n> \n> No worries, if you can't update the kernel it doesn't make a\n> difference. I thought you were using the same kernel as Rafael with\n> the ov5640 patches in. If you're on the current driver version you\n> need the awkward s_frame_interval dance.\n\nRafael is developing Maemo Leste, and I'm currently using Mobian.\n\nIf it is easy to boot Leste from SD card, I may try that, but not this\nweek. I'm actually using Leste on Droid4 and would not mind same\nsystem on both.\n\nBest regards,\n\t\t\t\t\t\t\t\tPavel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0B6AABD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  6 Jul 2022 18:16:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5A6F463310;\n\tWed,  6 Jul 2022 20:16:19 +0200 (CEST)","from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4EACB60403\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  6 Jul 2022 20:16:18 +0200 (CEST)","by jabberwock.ucw.cz (Postfix, from userid 1017)\n\tid EE48D1C0002; Wed,  6 Jul 2022 20:16:17 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657131379;\n\tbh=DDPlaGOHU2vN7TJqirtRXTJzAxRJ1L72fOLOSBzluro=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=vzU7xIlywwdq8owbI9EwDpNmMWShLxIV+S9bi99QKr1rzY/9q9sQwoIRACh0sIU4t\n\tMorrhiQhTJ6FfFsBVP4p2NsMHpY0rQzgpJuUGTy1ttYg4VBEJIIodeLN+YdgES6Bkq\n\tUJr3jFnBP5G/vPlF4nns0uopg5+4WnEVM6FjKmO5yBhmifRT9A6pYDqzD4Cf0PlbAe\n\twGqm6MvqTzdUUDTABaFHk9LOESkSHK8VA+pzZXtExHQ2R3qgPtzJZqf18OYKSMRRIt\n\t+yXsdNTiQyiKEAJCVUW6DuDL1OpjZiacgobLBQN5itUTUijDWC3wvZ+iivlSYs9lBT\n\t/ItDwhGSRqS1g==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1;\n\tt=1657131377;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=y+n82Z/AUhaYZcES3JFpU/twceQo9bZ64QdAHNCnR0Q=;\n\tb=LTz/TCSsttqtIk7xgRAIsAAytfq6goDjJAkYL0ResmOQRG9sYKxGDkpO3IblWQXokCWP9K\n\tIufQ23IhI2ZxsD7hZvqGCP6RLlzDEl5Vm7oGnduoRN9QZfnyQHLbuSvhyGJpU85xqExEp4\n\tkEAUYgvKnWGAA6Ur0ydyWCzvfPIGuzU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ucw.cz header.i=@ucw.cz\n\theader.b=\"LTz/TCSs\"; dkim-atps=neutral","Date":"Wed, 6 Jul 2022 20:16:17 +0200","To":"Jacopo Mondi <jacopo@jmondi.org>","Message-ID":"<20220706181617.GB13702@amd>","References":"<9a63e90b-5da6-2915-462e-70b2f61d1867@riseup.net>\n\t<20220703155800.GA11658@amd>\n\t<70821a87-8ea5-1583-daa3-ce1531977ce7@riseup.net>\n\t<d37fdb5f-79a6-56be-274f-12a5852836fc@riseup.net>\n\t<20220704161526.GA23964@amd>\n\t<YsMZOLfuXkjw6h+G@pendragon.ideasonboard.com>\n\t<20220704221548.GB8002@amd>\n\t<20220705071744.ud723w23mpzru5qw@uno.localdomain>\n\t<20220705205606.GB3682@amd>\n\t<20220706064315.dygscxj22t45cp2h@uno.localdomain>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"+pHx0qQiF2pBVqBT\"","Content-Disposition":"inline","In-Reply-To":"<20220706064315.dygscxj22t45cp2h@uno.localdomain>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Subject":"Re: [libcamera-devel] PinePhone needs S_FRAME_INTERVAL","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Pavel Machek via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Pavel Machek <pavel@ucw.cz>","Cc":"martijn@brixit.nl, libcamera-devel@lists.libcamera.org, jozef@mlich.cz","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":23804,"web_url":"https://patchwork.libcamera.org/comment/23804/","msgid":"<20220708125100.GA17589@amd>","date":"2022-07-08T12:51:00","subject":"[libcamera-devel] GStreamer libcamerasrc started working on\n\tPinePhone was Re: PinePhone needs S_FRAME_INTERVAL","submitter":{"id":49,"url":"https://patchwork.libcamera.org/api/people/49/","name":"Pavel Machek","email":"pavel@ucw.cz"},"content":"Hi!\n\n> > AFAICT that needs to happen. PinePhone needs lower fps for top\n> > resolution, but an use high fps for lower resolutions...\n> > \n> > This is obviosly a hack, but we need something like that.\n> \n> VIDIOC_SUBDEV_S_FRAME_INTERVAL is deprecated for camera sensors and\n> should never have been used. Frame rates are controlled through the\n> pixel clock and the horizontal and vertical blanking values. If a sensor\n> driver requires VIDIOC_SUBDEV_S_FRAME_INTERVAL, then it should be\n> fixed.\n\nI guess I know understand why VIDIOC_SUBDEV_S_FRAME_INTERVAL is bad\nidea. Still we may want stream option to select lower fps when\nrequested.\n\nAnyway libcamerasrc started working for me. I set\nVIDIOC_SUBDEV_S_FRAME_INTERVAL to 1/60, that may be related.\n\nexport GST_DEBUG=libcamera*:7\nexport GST_PLUGIN_PATH=$(pwd)/build/src/gstreamer\ngst-launch-1.0 libcamerasrc camera-name=/base/i2c-csi/rear-camera@4c !\n'video/x-raw,format=YUY2,width=640,height=480' ! autovideosink\n\nProduces image with obivous errors, but other settings with 1/30\nworked ok. Let me verify...\n\ngst-launch-1.0 libcamerasrc camera-name=/base/i2c-csi/rear-camera@4c !\n'video/x-raw,format=YUY2,width=1280,height=720' ! autovideosink\n\nThis one works. There's slight color change between left and right\nhalf of the image, not sure what I should think about it.\n\nBest regards,\n\t\t\t\t\t\t\t\tPavel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 71D6CBE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri,  8 Jul 2022 12:51:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BC0E763312;\n\tFri,  8 Jul 2022 14:51:02 +0200 (CEST)","from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C3096330D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  8 Jul 2022 14:51:01 +0200 (CEST)","by jabberwock.ucw.cz (Postfix, from userid 1017)\n\tid 245671C0002; Fri,  8 Jul 2022 14:51:01 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657284662;\n\tbh=JeZQPxSOhcJtTMvHw7gb4ZlZIO8bKnbtKpyfrJ5iahU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=m6+jpFNoUcAGGqtBvmnsJJXy0gnmL7DQvdLrbJUsjkkXi+zlEBLuzVOTeYc/B3XLj\n\tNivVmPa5sxiwVCmhjAoX6fI2gI4K9dzFIFlfv9Bn+uL8rNrN6RI4TAAUMXmtxZTgaS\n\t9tV/JWZ4gRG45LM1R+daAkyy/xE8ODZW2q1AOMN5tLqvUw8AkV+8UJklz87Hnxk8s9\n\tFrQhKOvWjN0pa7x0u+YMCpSnBhi25/CvqoSxKj4cZ+MC1AikYy0QkpFrBs5NTckogf\n\twZrS8+9XCUaXLuPQdcd7sMuo/farMfLuZK4F3xycPPxDnlUSaDaz8kieN4v5F/RcJ5\n\tEH8RisEmpXw7w==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1;\n\tt=1657284661;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=XBghIvkfaaC9/i5o2lwaLEnIMrwpH7WH5O67Qi0F3g8=;\n\tb=N4Eq8zCpgu+rkWBN+91qeCk0X62CXEwAfI1cgi09qTCVQDv9Sob5Cu3lq8KE4yTcpup5+z\n\t4xnhvU6lfldhLBzQrOwQyuBFKgBHtrUXHZ5I6Dt73tJuL4vqqdDbDHtjfaGyrZQsNb5fCP\n\t+klICU9MBrBrmSAtqKjBRbzc1q0TOEs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ucw.cz header.i=@ucw.cz\n\theader.b=\"N4Eq8zCp\"; dkim-atps=neutral","Date":"Fri, 8 Jul 2022 14:51:00 +0200","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Message-ID":"<20220708125100.GA17589@amd>","References":"<279b87a6-2209-e4d1-6342-12253258b59f@riseup.net>\n\t<YsGe984b7/ShqZXw@pendragon.ideasonboard.com>\n\t<9a63e90b-5da6-2915-462e-70b2f61d1867@riseup.net>\n\t<20220703155800.GA11658@amd>\n\t<70821a87-8ea5-1583-daa3-ce1531977ce7@riseup.net>\n\t<d37fdb5f-79a6-56be-274f-12a5852836fc@riseup.net>\n\t<20220704161526.GA23964@amd>\n\t<YsMZOLfuXkjw6h+G@pendragon.ideasonboard.com>\n\t<20220704221548.GB8002@amd>\n\t<YsNpqKQOW6mwDy2j@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"Nq2Wo0NMKNjxTN9z\"","Content-Disposition":"inline","In-Reply-To":"<YsNpqKQOW6mwDy2j@pendragon.ideasonboard.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Subject":"[libcamera-devel] GStreamer libcamerasrc started working on\n\tPinePhone was Re: PinePhone needs S_FRAME_INTERVAL","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Pavel Machek via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Pavel Machek <pavel@ucw.cz>","Cc":"martijn@brixit.nl, libcamera-devel@lists.libcamera.org, jozef@mlich.cz","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]