[{"id":23851,"web_url":"https://patchwork.libcamera.org/comment/23851/","msgid":"","date":"2022-07-13T01:10:39","subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: rkisp1: Transfer\n\tqueueRequest() call to each algorithm","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Florian,\n\nThank you for the patch.\n\nOn Mon, Jul 04, 2022 at 05:23:16PM +0200, Florian Sylvestre via libcamera-devel wrote:\n> Implement rkisp1 queueRequest() function to update each algorithm with user\n> controls.\n> \n> Signed-off-by: Florian Sylvestre \n> ---\n> src/ipa/rkisp1/rkisp1.cpp | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index a32bb9d1..9b0d675c 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -270,9 +270,10 @@ void IPARkISP1::unmapBuffers(const std::vector &ids)\n> }\n> \n> void IPARkISP1::queueRequest([[maybe_unused]] const uint32_t frame,\n\nYou can drop this [[maybe_unused]] too.\n\nReviewed-by: Laurent Pinchart \n\n> -\t\t\t [[maybe_unused]] const ControlList &controls)\n> +\t\t\t const ControlList &controls)\n> {\n> -\t/* \\todo Start processing for 'frame' based on 'controls'. */\n> +\tfor (auto const &algo : algorithms())\n> +\t\talgo->queueRequest(context_, frame, controls);\n> }\n> \n> void IPARkISP1::fillParamsBuffer(const uint32_t frame, const uint32_t bufferId)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9B683BE173\n\tfor ;\n\tWed, 13 Jul 2022 01:11:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5F8A86330F;\n\tWed, 13 Jul 2022 03:11:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E10AC6048B\n\tfor ;\n\tWed, 13 Jul 2022 03:11:08 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8112A305;\n\tWed, 13 Jul 2022 03:11:08 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657674670;\n\tbh=pi7Nitt+poaXmnMu6BiQ5r0r3TmBRMy86YEgX+mkw4I=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=PSeNf0aFt7D0mLeeKLV8BC8RlOK87Qjjd2ytdpyfFyO4824MxqEm0gEKqKKUOXKsm\n\tsooqjtlTzmVg9v27P+EVZeYVZmf62sY1OsNrQgisPk9Vf72YVYoorDsfsdBXo747Ru\n\tfbYntJWlm3TZHXXdcL7WY6LsTUOgJLbNrwsKmCNflvYDpB2JrhwON98mrIZTHuDZlS\n\tgYG6lttffYeXz9FFYOP1tkVxvYyck5DnkWnNmiWixQm9D0IRDHoxoN5Gg1U8MZoV1s\n\tGgIJbHnI/UahGEmnmxgeaBcwiArZbEsV7bnfYQ3U0Ua47Dr9T3ofkvb/pRDSOozEK9\n\tv4ygOvUH2JCDA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657674668;\n\tbh=pi7Nitt+poaXmnMu6BiQ5r0r3TmBRMy86YEgX+mkw4I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mxXfnWwGsaZcpImTTpDlReuqHf1nT46tja6k0MqLlz6ChSJTlgHw8IUqAB6FkUZVp\n\tMZBrF4OXScmv0qVLLCyvCbK71EOVSoKvWuGrnC7BM0bu2b4YSeB6dITmgB+1lwBiLn\n\t17EAP/iNpKy8g9dvKSMdqj5dZyKG1ei5zVv1Wlrs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"mxXfnWwG\"; dkim-atps=neutral","Date":"Wed, 13 Jul 2022 04:10:39 +0300","To":"Florian Sylvestre ","Message-ID":"","References":"<20220704152318.221213-1-fsylvestre@baylibre.com>\n\t<20220704152318.221213-3-fsylvestre@baylibre.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220704152318.221213-3-fsylvestre@baylibre.com>","Subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: rkisp1: Transfer\n\tqueueRequest() call to each algorithm","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23921,"web_url":"https://patchwork.libcamera.org/comment/23921/","msgid":"<165787621740.1177852.8401183469808535342@Monstersaurus>","date":"2022-07-15T09:10:17","subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: rkisp1: Transfer\n\tqueueRequest() call to each algorithm","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-07-13 02:10:39)\n> Hi Florian,\n> \n> Thank you for the patch.\n> \n> On Mon, Jul 04, 2022 at 05:23:16PM +0200, Florian Sylvestre via libcamera-devel wrote:\n> > Implement rkisp1 queueRequest() function to update each algorithm with user\n> > controls.\n> > \n> > Signed-off-by: Florian Sylvestre \n> > ---\n> > src/ipa/rkisp1/rkisp1.cpp | 5 +++--\n> > 1 file changed, 3 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> > index a32bb9d1..9b0d675c 100644\n> > --- a/src/ipa/rkisp1/rkisp1.cpp\n> > +++ b/src/ipa/rkisp1/rkisp1.cpp\n> > @@ -270,9 +270,10 @@ void IPARkISP1::unmapBuffers(const std::vector &ids)\n> > }\n> > \n> > void IPARkISP1::queueRequest([[maybe_unused]] const uint32_t frame,\n> \n> You can drop this [[maybe_unused]] too.\n> \n> Reviewed-by: Laurent Pinchart \n> \n> > - [[maybe_unused]] const ControlList &controls)\n> > + const ControlList &controls)\n> > {\n> > - /* \\todo Start processing for 'frame' based on 'controls'. */\n\nAs mentioned in the API implementation for algo->queueRequest() - I\nbelieve this should be obtaining and passing the FrameContext.\n\nThe action of passing these controls - is all state that needs to be\ndetermined at later processing, so I believe it has to be done through\nthe queue.\n\nIf this is just passed as a nullptr here for now, I'm fine with that as\nI don't think a FrameContext has been established for the RKISP yet.\n(But we could also put one in as part of this series, or on top).\n\n\nWith that,\n\nReviewed-by: Kieran Bingham \n\n> > + for (auto const &algo : algorithms())\n> > + algo->queueRequest(context_, frame, controls);\n> > }\n> > \n> > void IPARkISP1::fillParamsBuffer(const uint32_t frame, const uint32_t bufferId)\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A05BFBE173\n\tfor ;\n\tFri, 15 Jul 2022 09:10:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D9B7463312;\n\tFri, 15 Jul 2022 11:10:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 938B76330B\n\tfor ;\n\tFri, 15 Jul 2022 11:10:20 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0F0B6993;\n\tFri, 15 Jul 2022 11:10:20 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657876221;\n\tbh=oc+0BK6Gibx4AIuJXVKOCygUw+Guy6JvmMC+Z274mI8=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=mfkyOvV0EA6b7N++rmBgTBw0nbYF8ceVKJMJ9c/YlIYBW80ZwKVHFyHz015BzNnIK\n\tccC/VfIjhco3rmL7fJpcMAklpuUATpA/xQxa4SXnbNzIz7uzOFFdqc0an4XaS9y1rP\n\tGESZJXw7vYknkOq4s5Mdo233OEv5t7jySKjz1eSgJFeBDyyZ4IjZ1hOC1jD7KXvalm\n\tWVtzTnjzaN1HNBAj4seO9kZFGkq0hLXctA+5YsYYLKbVUP6b2eQXx9GmCrxCvyDB70\n\tJt2d42D354fqOr5sluRVa+5kPuUiUJAHM3i71hxJe6YF+6gq2l03NLbHSG5eEtsnMf\n\tbrovEYBqhUyKA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657876220;\n\tbh=oc+0BK6Gibx4AIuJXVKOCygUw+Guy6JvmMC+Z274mI8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=CF+9HpPcu8NtnbwmccpuDrtQTELYrgSWpAMY8RkdnQ0P9/mLLaUkeP2yfs/LWbYOV\n\tn192w1FAqfgTecdFu32A686pre4s17+EczMhV9zCN7XKDbnTrqedrBviECRmzR/gQ9\n\tZl3VnRiTkDtMdS1V+x3glV9Tsnjsh1n57pTOhB8w="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"CF+9HpPc\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20220704152318.221213-1-fsylvestre@baylibre.com>\n\t<20220704152318.221213-3-fsylvestre@baylibre.com>\n\t","To":"Florian Sylvestre ,\n\tLaurent Pinchart ,\n\tLaurent Pinchart via libcamera-devel\n\t","Date":"Fri, 15 Jul 2022 10:10:17 +0100","Message-ID":"<165787621740.1177852.8401183469808535342@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: rkisp1: Transfer\n\tqueueRequest() call to each algorithm","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]