[{"id":24355,"web_url":"https://patchwork.libcamera.org/comment/24355/","msgid":"<20220803144847.GM311202@pyrite.rasen.tech>","date":"2022-08-03T14:48:47","subject":"Re: [libcamera-devel] [PATCH 8/9] fixup: Minor changes in\n\tExposureTimeMode","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Fri, Jul 01, 2022 at 05:47:00PM +0200, Jacopo Mondi wrote:\n> slightly modify the ExposureTime modes description.\n> \n> Signed-off-by: Jacopo Mondi \n\nAcked-by: Paul Elder \n\n> ---\n> src/libcamera/control_ids.yaml | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index 225377cf9e76..1f22b9b35036 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -260,20 +260,20 @@ controls:\n> value: 0\n> description: |\n> The exposure time will be calculated automatically and set by the\n> - AE algorithm. If ExposureTime is set while this mode is active, it\n> - will be ignored, and it will also not be retained.\n> + AE algorithm.\n> +\n> + If ExposureTime is set while this mode is active, it will be\n> + ignored, and it will also not be retained.\n> - name: ExposureTimeModeManual\n> value: 1\n> description: |\n> - The exposure time will not be updated by the AE algorithm. It will\n> - come from the last calculated value when the mode was Auto, or from\n> - the value specified in ExposureTime.\n> + The exposure time will not be updated by the AE algorithm.\n> \n> When transitioning from Auto to Manual mode, the last computed\n> exposure value is used until a new value is specified through the\n> ExposureTime control. If an ExposureTime value is specified in the\n> same request where the ExposureTimeMode is changed from Auto to\n> - Manual, the provided ExposureTime is applied.\n> + Manual, the provided ExposureTime is applied immediately.\n> \n> - AnalogueGain:\n> type: float\n> -- \n> 2.36.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 666EEC3272\n\tfor ;\n\tWed, 3 Aug 2022 14:48:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C3B6861FAE;\n\tWed, 3 Aug 2022 16:48:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E6809603E6\n\tfor ;\n\tWed, 3 Aug 2022 16:48:54 +0200 (CEST)","from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B42D98B;\n\tWed, 3 Aug 2022 16:48:53 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659538136;\n\tbh=Md7ERgXEZJ+CAUJmlraYGwkbutoOB63cpROGZXRS1NY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Hk4NMLFN8eHq8VeIRlzZdLYyjH2Cve3a7ud/tRXW9xljiHVdGlEwQ/ViHIFf/rNTd\n\t5bQoDcblTePJHmLUGsnZc4eCAHpAIqd6J1qtLJfZZjoN0Xl5IPlyjrtGnFY8so86fU\n\tVwk7/lCGQ1uOpHok9zYuKIdSoISCfQMuaaVpnvfegEV+P26+VEAeKkQrt35wy02tCa\n\tvSztrHxKbkCRlZ8cgJNkK1G/+0owt55nMLS8Lsg6OObucg+yigXVBh/HB7YE/1kkny\n\topUL6xuEZlYVYjtqsrkaKjHa6vsWsXvP17RP9ZClHjDz4EkK5pk9eewqIYqhowmhw4\n\tSGQ5JFBPXG5sg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659538134;\n\tbh=Md7ERgXEZJ+CAUJmlraYGwkbutoOB63cpROGZXRS1NY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=r66LM+PhiLgNpXq1meFcxDK278VcAQgoFFfarhQI38EEc/Lws+4TfruFHltD5mPA0\n\tSKNmn8cKT04BFxGGUJwoDkxbaYGJCVu+IYZoOsR/WQOTPhum0LtVmY9rdroJJbNO7i\n\tlyOF6Zbd/ZydVAU5+3h2n/ZCbFzu+3fGDrcUwrf4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"r66LM+Ph\"; dkim-atps=neutral","Date":"Wed, 3 Aug 2022 23:48:47 +0900","To":"Jacopo Mondi ","Message-ID":"<20220803144847.GM311202@pyrite.rasen.tech>","References":"<20220518134728.777709-2-paul.elder@ideasonboard.com>\n\t<20220701154701.354052-1-jacopo@jmondi.org>\n\t<20220701154701.354052-8-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220701154701.354052-8-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 8/9] fixup: Minor changes in\n\tExposureTimeMode","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]