{"id":16517,"url":"https://patchwork.libcamera.org/api/patches/16517/?format=json","web_url":"https://patchwork.libcamera.org/patch/16517/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220701154701.354052-7-jacopo@jmondi.org>","date":"2022-07-01T15:46:59","name":"[libcamera-devel,7/9] fixup: Rework flickerless transition mode","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"390a37b9236ab17e771ca1753ca0e51f9390e959","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16517/mbox/","series":[{"id":3243,"url":"https://patchwork.libcamera.org/api/series/3243/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3243","date":"2022-07-01T15:46:53","name":"[libcamera-devel,1/9] controls: Reorganize the AE-related controls","version":1,"mbox":"https://patchwork.libcamera.org/series/3243/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16517/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16517/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D8550BD808\n\tfor ;\n\tFri, 1 Jul 2022 15:47:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5EA7F6565A;\n\tFri, 1 Jul 2022 17:47:16 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::224])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5DDFD65657\n\tfor ;\n\tFri, 1 Jul 2022 17:47:12 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id B88DCE0004;\n\tFri, 1 Jul 2022 15:47:11 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656690436;\n\tbh=An79EAGbcDFs93+ldfHlsveAiD+Llm2IFFTPo8gfAh8=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=sRL9Z6nCK3KTK/ElKqBm6bu+/S9NBJ99Gkc+RjpWbp9kLt1AlkVmQx3lukDa9GSvI\n\tvvKhgDlHK8HU+qxEUoxHxnX97Yf5Mfs+XbQTMKs2dPk40BfUhPlKYmgRcJICNF4Ib/\n\tc7U1GaudBxYqeuQDFIIHff0Osx1DxO+JnJXe8GSUxzciehL6lQQZ552nsRhXerhj2W\n\t0g9UBhfkle+Ly5NdphiCMqO9lYtawssgSHBmkly1p+o3KNbOGgp4sX08s4C97/T3Pb\n\tVVTfuyS1cCmVdEzlBTy6OV3gFHhnvXe9vwru2ipzVJVjbuDC7fMB4KLI3dwplpKgo+\n\tda7+OlyeEU7ng==","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 1 Jul 2022 17:46:59 +0200","Message-Id":"<20220701154701.354052-7-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.36.1","In-Reply-To":"<20220701154701.354052-1-jacopo@jmondi.org>","References":"<20220518134728.777709-2-paul.elder@ideasonboard.com>\n\t<20220701154701.354052-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 7/9] fixup: Rework flickerless transition\n\tmode","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Re-work the introduction text.\n\nThis might seems arbitrary but the new text provides a bit more context.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/control_ids.yaml | 32 ++++++++++++++++++++++++--------\n 1 file changed, 24 insertions(+), 8 deletions(-)","diff":"diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex e6676a149795..225377cf9e76 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -218,19 +218,35 @@ controls:\n The set of ExposureTimeMode modes that are supported by the camera must\n have an intersection with the supported set of AnalogueGainMode modes.\n \n- As it takes a few frames to apply the exposure time, there is a period of\n- time between submitting a request with ExposureTimeMode set to Manual\n- and the exposure time component of the AE actually being disabled,\n- during which the AE algorithm can still update the exposure time. If an\n- application is switching from automatic and manual control and wishes\n- to eliminate any flicker during the switch, the following procedure is\n- recommended.\n+ Flickerless exposure mode transitions\n+\n+ Applications that transition from ExposureTimeModeAuto to the direct\n+ control of the exposure time should aim to do so by selecting an\n+ ExposureTime value as close as possible to the last value computed by\n+ the auto exposure algorithm in order to avoid any visible flickering.\n+\n+ To select the correct value to use as ExposureTime value, applications\n+ should accommodate the natural delay in applying controls caused by the\n+ capture pipeline frame depth.\n+\n+ When switching to manual exposure mode, applications should not\n+ immediately specify an ExposureTime value in the same request where\n+ ExposureTimeMode is set to Manual. They should instead wait for the\n+ first Request where ExposureTimeMode is reported as\n+ ExposureTimeModeManual in the Request metadata, and use the reported\n+ ExposureTime to populate the control value in the next Request to be\n+ queued to the Camera.\n+\n+ The implementation of the auto-exposure algorithm should equally try to\n+ minimize flickering and when transitioning from manual exposure mode to\n+ auto exposure use the last value provided by the application as starting\n+ point.\n \n 1. Start with ExposureTimeMode set to Auto\n \n 2. Set ExposureTimeMode to Manual\n \n- 3. Wait for the first request to be output that has ExposureTimeMode\n+ 3. Wait for the first completed request that has ExposureTimeMode\n set to Manual\n \n 4. Copy the value reported in ExposureTime into a new request, and\n","prefixes":["libcamera-devel","7/9"]}