[{"id":24352,"web_url":"https://patchwork.libcamera.org/comment/24352/","msgid":"<20220803142256.GJ311202@pyrite.rasen.tech>","date":"2022-08-03T14:22:56","subject":"Re: [libcamera-devel] [PATCH 6/9] fixup: Reword ExposureTimeMode","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Jacopo,\n\nOn Fri, Jul 01, 2022 at 05:46:58PM +0200, Jacopo Mondi wrote:\n> Slightly reword the first part of the control definition.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/control_ids.yaml | 16 +++++-----------\n> 1 file changed, 5 insertions(+), 11 deletions(-)\n> \n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index b062b7e234a6..e6676a149795 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -203,21 +203,15 @@ controls:\n> Controls the source of the exposure time that is applied to the image\n> sensor. When set to Auto, the AE algorithm computes the exposure time\n> and configures the image sensor accordingly. When set to Manual,\n> - exposure time specified in ExposureTime is applied to the image sensor.\n> - If ExposureTime is not set, then the value last computed by the AE\n> - algorithm when the mode was Auto will be used.\n> + the value of the ExposureTime control is used.\n> \n> - If ExposureTime is not set and the mode is ExposureTimeModeManual and\n> - AE was never Auto (either because the camera started in Manual mode,\n> + When transitioning from Auto to Manual mode and no ExposureTime control\n> + is provided by the application, the last value computed by the AE\n> + algorithm when the mode was Auto will be used. If the ExposureTimeMode\n> + was never set to Auto (either because the camera started in Manual mode,\n> or Auto is not supported by the camera), the camera should use a\n> best-effort default value.\n> \n> - When ExposureTimeMode is set Auto, the value set in ExposureTime is\n> - ignored and is not retained.\n\nI think this part should explicitly be kept in some form.\n\nThe rest looks good.\n\n\nPaul\n\n\n> This means that if ExposureTimeMode is set\n> - to Manual and ExposureTime is not also set, the exposure time that\n> - was last computed by the AE algorithm while the mode was Auto will be\n> - applied to the sensor.\n> -\n> If ExposureTimeModeManual is supported, the ExposureTime control must\n> also be supported.\n> \n> -- \n> 2.36.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DA1E7C3272\n\tfor ;\n\tWed, 3 Aug 2022 14:23:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6BFCA63310;\n\tWed, 3 Aug 2022 16:23:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 402E1603E6\n\tfor ;\n\tWed, 3 Aug 2022 16:23:03 +0200 (CEST)","from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D46368B;\n\tWed, 3 Aug 2022 16:23:01 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659536584;\n\tbh=BmdhsVu64doM44fVVkPfCIMOMJHI2YeR9fg1pAh1HOE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Ttwpyw4gDC6+5qijwj4JzRT1JMb9abtSaekFDhMiEe8cBemg0FJqOCuJzF05VowQS\n\tdHN5S8/82ujw/rB+IPgQ8bseEcdmeT/enaZag8f/T8mvlyz6nHGUGY8fDjUFwd09uE\n\trabQImdOYHELiL5PGggpUU7kjY8RMDKcIHIfc+DmoAyKZ83KMnu8l1H0CtHLfGUvX/\n\tMr7ZMX1PensYKe4nZuF6K92kAlCuOnwtpWUXWvTPgxTmfcEqKUUMxPeyY/nftO513U\n\tXBivREZZK8mzModn5f2BeroTML/tkW5m5WETcItkYXINVcBlSar/kA+nJ35GgXImDK\n\t9lotAyXrywPJw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659536582;\n\tbh=BmdhsVu64doM44fVVkPfCIMOMJHI2YeR9fg1pAh1HOE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fuCD0ozBhzOrvhj/Sv1J5CQepXVyIENhR0Sg8zo8urU1Fic44z3krOLJ2tT2BFV6Q\n\tnKUax46oektSgKPBit4CimM3E5URLJMzcQAxmkptrPKf4OT1bLHkiBK4fNeVf9Smjn\n\tRKMMYfVagwXvqFby9+wnlkCPIhVb0qLkFErgamH4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"fuCD0ozB\"; dkim-atps=neutral","Date":"Wed, 3 Aug 2022 23:22:56 +0900","To":"Jacopo Mondi ","Message-ID":"<20220803142256.GJ311202@pyrite.rasen.tech>","References":"<20220518134728.777709-2-paul.elder@ideasonboard.com>\n\t<20220701154701.354052-1-jacopo@jmondi.org>\n\t<20220701154701.354052-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220701154701.354052-6-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 6/9] fixup: Reword ExposureTimeMode","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24354,"web_url":"https://patchwork.libcamera.org/comment/24354/","msgid":"<20220803144737.GL311202@pyrite.rasen.tech>","date":"2022-08-03T14:47:37","subject":"Re: [libcamera-devel] [PATCH 6/9] fixup: Reword ExposureTimeMode","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Wed, Aug 03, 2022 at 11:22:56PM +0900, Paul Elder via libcamera-devel wrote:\n> Hi Jacopo,\n> \n> On Fri, Jul 01, 2022 at 05:46:58PM +0200, Jacopo Mondi wrote:\n> > Slightly reword the first part of the control definition.\n> > \n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/libcamera/control_ids.yaml | 16 +++++-----------\n> > 1 file changed, 5 insertions(+), 11 deletions(-)\n> > \n> > diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> > index b062b7e234a6..e6676a149795 100644\n> > --- a/src/libcamera/control_ids.yaml\n> > +++ b/src/libcamera/control_ids.yaml\n> > @@ -203,21 +203,15 @@ controls:\n> > Controls the source of the exposure time that is applied to the image\n> > sensor. When set to Auto, the AE algorithm computes the exposure time\n> > and configures the image sensor accordingly. When set to Manual,\n> > - exposure time specified in ExposureTime is applied to the image sensor.\n> > - If ExposureTime is not set, then the value last computed by the AE\n> > - algorithm when the mode was Auto will be used.\n> > + the value of the ExposureTime control is used.\n> > \n> > - If ExposureTime is not set and the mode is ExposureTimeModeManual and\n> > - AE was never Auto (either because the camera started in Manual mode,\n> > + When transitioning from Auto to Manual mode and no ExposureTime control\n> > + is provided by the application, the last value computed by the AE\n> > + algorithm when the mode was Auto will be used. If the ExposureTimeMode\n> > + was never set to Auto (either because the camera started in Manual mode,\n> > or Auto is not supported by the camera), the camera should use a\n> > best-effort default value.\n> > \n> > - When ExposureTimeMode is set Auto, the value set in ExposureTime is\n> > - ignored and is not retained.\n> \n> I think this part should explicitly be kept in some form.\n\nOh, I forgot, it's in the enum value description.\n\n\nAcked-by: Paul Elder \n\n> \n> The rest looks good.\n> \n> \n> \n> > This means that if ExposureTimeMode is set\n> > - to Manual and ExposureTime is not also set, the exposure time that\n> > - was last computed by the AE algorithm while the mode was Auto will be\n> > - applied to the sensor.\n> > -\n> > If ExposureTimeModeManual is supported, the ExposureTime control must\n> > also be supported.\n> > \n> > -- \n> > 2.36.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A9944C3272\n\tfor ;\n\tWed, 3 Aug 2022 14:47:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2173263310;\n\tWed, 3 Aug 2022 16:47:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 68A35603E6\n\tfor ;\n\tWed, 3 Aug 2022 16:47:44 +0200 (CEST)","from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0DD698B;\n\tWed, 3 Aug 2022 16:47:42 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659538065;\n\tbh=VKQA55/uc/uA4bqKZEkC3q8XsxdR4XWoubaEiKvpvTY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Mp7F3aq0do4PrZjKpxii6GY7xQ1EdcMjoucV4dg03J9DoNtkxsupFvSOMJdW2kDTv\n\tb18ONx4q5P8fvcJ3mqlwgGelvFsoS3DjpLrGy8sEjYMfc2DZgBUG568e1SBwr0wDn2\n\tKt3vnujUCQ1iKcBQFrT2nrlwdqUeLg4a3wknK5kKYD5HseN+qBCWpSctJqpvrX6aCc\n\tb8Snq2QQW283xsgflvGiY4rpXB4I1Ca29Luoezxv7BYxmNVPhhcbHWw413e3jhwvZa\n\twRaEHJc8Z/9fsr+Dga0HSjYWFpbO65c5/qvW5UsykoWqq/Hu0lyze4un0VpryXvb/R\n\t0MdhJ/p55I2KQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659538064;\n\tbh=VKQA55/uc/uA4bqKZEkC3q8XsxdR4XWoubaEiKvpvTY=;\n\th=Date:From:To:Subject:References:In-Reply-To:From;\n\tb=iz1JQYdLPhWE0qhIHd6QX13db+BKw7BYWuFfILtpWfGx5ro5POhAAujXkXImeYvyh\n\txi2NloXKww0aTgfoR3lCL/UC7aRlsqSxsRjL03PwOVtdX9S3iEm9yZPb9gtbT5e3k9\n\tFfBZqQI6J/3kpMMeMSWPKy5gcMuWO3vLJ6BknFqk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"iz1JQYdL\"; dkim-atps=neutral","Date":"Wed, 3 Aug 2022 23:47:37 +0900","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","Message-ID":"<20220803144737.GL311202@pyrite.rasen.tech>","References":"<20220518134728.777709-2-paul.elder@ideasonboard.com>\n\t<20220701154701.354052-1-jacopo@jmondi.org>\n\t<20220701154701.354052-6-jacopo@jmondi.org>\n\t<20220803142256.GJ311202@pyrite.rasen.tech>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220803142256.GJ311202@pyrite.rasen.tech>","Subject":"Re: [libcamera-devel] [PATCH 6/9] fixup: Reword ExposureTimeMode","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]