[{"id":24351,"web_url":"https://patchwork.libcamera.org/comment/24351/","msgid":"<20220803140919.GI311202@pyrite.rasen.tech>","date":"2022-08-03T14:09:19","subject":"Re: [libcamera-devel] [PATCH 5/9] fixup: Capitalize \"Auto\"","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Fri, Jul 01, 2022 at 05:46:57PM +0200, Jacopo Mondi wrote:\n> The \"Auto\" and \"Manual\" terms when used to refer to control modes are\n> keywords and should be captitalized.\n> \n> Signed-off-by: Jacopo Mondi \n\nAcked-by: Paul Elder \n\n> ---\n> src/libcamera/control_ids.yaml | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index d50df8bcad28..b062b7e234a6 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -170,7 +170,7 @@ controls:\n> description: |\n> Specify an Exposure Value (EV) parameter. The EV parameter will only be\n> applied if the AE algorithm is currently enabled, that is, at least one\n> - of AnalogueGainMode and ExposureTimeMode are auto.\n> + of AnalogueGainMode and ExposureTimeMode are in Auto mode.\n> \n> By convention EV adjusts the exposure as log2. For example\n> EV = [-2, -1, 0.5, 0, 0.5, 1, 2] results in an exposure adjustment\n> -- \n> 2.36.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 503C1BE173\n\tfor ;\n\tWed, 3 Aug 2022 14:09:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0C32761FAE;\n\tWed, 3 Aug 2022 16:09:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3797D603E6\n\tfor ;\n\tWed, 3 Aug 2022 16:09:27 +0200 (CEST)","from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 03C3C8B;\n\tWed, 3 Aug 2022 16:09:25 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659535769;\n\tbh=+1/H0TYZS4cSvcWokmeFTEC5/VtU72rrdsK1WPPx6xQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=xkxy9iMDT3sCzOg36hhk+r2A0X2cLebn1EU0eGpULiKMeqla0GYygIaRPFAKynauU\n\tZBPklPS6UaxyyZQlhY7HZxnt6rtJ5KkZeTUrb2jT/lQSKXCP33pctjSFPPGV5cqfCW\n\t6EQKgOzvtbMR2z7IPC93opfSJKqeDwQswKCTL8FCV5BIMfmoY33nSeeXK6LgDLS3Fi\n\tBwJnhrKIq8JFUwav9DG5k6jYE/F7fVIJJQ7uF31R9ehw/gidYTPEWMeu9teJImiAip\n\twQyQkAGVbUQTUoSm/V4AS0m6hwELbAuXYYf9aX4u1r7m45Z2ntb+YKHEMoG4NWP4ab\n\tE/IbDOQfBGSIg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659535767;\n\tbh=+1/H0TYZS4cSvcWokmeFTEC5/VtU72rrdsK1WPPx6xQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RqzN/kpAUP5GR5Q/CT+3AphgBie/1ApIcd3lltfkuaCibmGByWc0HxDZU2JpZNXLp\n\tmT29yEDlMq2NcU07T6C1qZq3TvRD+9Sm7FqI5KcseP4jZ4Nvgj+KrK22UXYKr9TBYp\n\tkpdz87DpqhJw+eOciihjv4qaaKwAUsdJrebwcxAU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"RqzN/kpA\"; dkim-atps=neutral","Date":"Wed, 3 Aug 2022 23:09:19 +0900","To":"Jacopo Mondi ","Message-ID":"<20220803140919.GI311202@pyrite.rasen.tech>","References":"<20220518134728.777709-2-paul.elder@ideasonboard.com>\n\t<20220701154701.354052-1-jacopo@jmondi.org>\n\t<20220701154701.354052-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220701154701.354052-5-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 5/9] fixup: Capitalize \"Auto\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]