[{"id":24688,"web_url":"https://patchwork.libcamera.org/comment/24688/","msgid":"","date":"2022-08-18T21:01:51","subject":"Re: [libcamera-devel] [PATCH v3 13/17] py: unittests.py: Use new\n\tevents support","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Fri, Jul 01, 2022 at 11:45:17AM +0300, Tomi Valkeinen wrote:\n\nA commit message would be nice.\n\n> Signed-off-by: Tomi Valkeinen \n> ---\n> test/py/unittests.py | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/test/py/unittests.py b/test/py/unittests.py\n> index 794e46be..fab791d1 100755\n> --- a/test/py/unittests.py\n> +++ b/test/py/unittests.py\n> @@ -201,9 +201,9 @@ class SimpleCaptureMethods(CameraTesterBase):\n> if not events:\n> continue\n> \n> - ready_reqs = cm.get_ready_requests()\n> -\n> - reqs += ready_reqs\n> + for ev in cm.get_events():\n> + self.assertEqual(ev.type, libcam.Event.Type.RequestCompleted)\n\nWe'll get test failures if a camera is connected while the test is\nrunning, or if any other type of event occurs. That's something we need\nto solve, but I'm fine if you want to delay that a bit.\n\nReviewed-by: Laurent Pinchart \n\n> + reqs.append(ev.request)\n> \n> if len(reqs) == num_bufs:\n> break\n> @@ -267,9 +267,9 @@ class SimpleCaptureMethods(CameraTesterBase):\n> while running:\n> events = sel.select()\n> for key, _ in events:\n> - ready_reqs = cm.get_ready_requests()\n> -\n> - reqs += ready_reqs\n> + for ev in cm.get_events():\n> + self.assertEqual(ev.type, libcam.Event.Type.RequestCompleted)\n> + reqs.append(ev.request)\n> \n> if len(reqs) == num_bufs:\n> running = False","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A36B7BE173\n\tfor ;\n\tThu, 18 Aug 2022 21:01:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 15DF161FC0;\n\tThu, 18 Aug 2022 23:01:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8BB1161FA7\n\tfor ;\n\tThu, 18 Aug 2022 23:01:55 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C0BC08B;\n\tThu, 18 Aug 2022 23:01:54 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660856517;\n\tbh=l5hGxOxyuwynJ8cStWrorOefF0U52zLTVcq9zu/RyUM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=yXsNaPxSl1FVd3d4bi2crAOG+ygjuouI74z45sikRDMfVSmE84ADwdK/JYC5rWt3M\n\tC6m1B9hENNHDo3NDO35gifpt7l0tYSsw8OICpQhk05SJw1g28fbd+JS2Bu3Bpq7yY/\n\tCeDlgcA20KKWxcUBFdIYoMNTvWKQjMnfdhwo/w+79Z7gm6Zwe6ktoBO5kjjksy1llH\n\tz8MILQpLYm7nzrNJ3jDBbOUWQfMU2hussrLf9WyBLMEelz0xtVOKdp+6/94E+GHHLf\n\tS5iPqM5A5iTsORflleonsT33R68gmGJP3pZmhTBVOmtV7Y7jhIY/ac8c1Jpk1rtbML\n\teO7XDZ+PJIkSA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660856515;\n\tbh=l5hGxOxyuwynJ8cStWrorOefF0U52zLTVcq9zu/RyUM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZhrTDQO+e1XjvnKFt1g/KZ3+MJMHUfZe3IMQdAEeCk+vwNPRv1QimeuZAgRIiFUZc\n\trwo1gY7Nqf3jEdAzlBcp7Udc+KG3meNOBykWYxc1vkAbcIXG4LZKSYIZDhRcH6kaOp\n\tJy3zwAWjGp0fx8Y29cR9Ig+DzZpsLN5iDnupSLSI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ZhrTDQO+\"; dkim-atps=neutral","Date":"Fri, 19 Aug 2022 00:01:51 +0300","To":"Tomi Valkeinen ","Message-ID":"","References":"<20220701084521.31831-1-tomi.valkeinen@ideasonboard.com>\n\t<20220701084521.31831-14-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220701084521.31831-14-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 13/17] py: unittests.py: Use new\n\tevents support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24793,"web_url":"https://patchwork.libcamera.org/comment/24793/","msgid":"<92bd15dc-1464-2ba3-6f4c-0f1e7851bb54@ideasonboard.com>","date":"2022-08-26T12:33:00","subject":"Re: [libcamera-devel] [PATCH v3 13/17] py: unittests.py: Use new\n\tevents support","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"content":"On 19/08/2022 00:01, Laurent Pinchart wrote:\n> Hi Tomi,\n> \n> Thank you for the patch.\n> \n> On Fri, Jul 01, 2022 at 11:45:17AM +0300, Tomi Valkeinen wrote:\n> \n> A commit message would be nice.\n> \n>> Signed-off-by: Tomi Valkeinen \n>> ---\n>> test/py/unittests.py | 12 ++++++------\n>> 1 file changed, 6 insertions(+), 6 deletions(-)\n>>\n>> diff --git a/test/py/unittests.py b/test/py/unittests.py\n>> index 794e46be..fab791d1 100755\n>> --- a/test/py/unittests.py\n>> +++ b/test/py/unittests.py\n>> @@ -201,9 +201,9 @@ class SimpleCaptureMethods(CameraTesterBase):\n>> if not events:\n>> continue\n>> \n>> - ready_reqs = cm.get_ready_requests()\n>> -\n>> - reqs += ready_reqs\n>> + for ev in cm.get_events():\n>> + self.assertEqual(ev.type, libcam.Event.Type.RequestCompleted)\n> \n> We'll get test failures if a camera is connected while the test is\n> running, or if any other type of event occurs. That's something we need\n> to solve, but I'm fine if you want to delay that a bit.\n\nThat is true, but... Maybe that can be considered a valid thing to fail \non. Unittests need to expect a certain kind of running environment, and \nI think it's a valid requirement that cameras are not being attached and \nremoved while the tests are running.\n\n Tomi","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2F4D8C0DA4\n\tfor ;\n\tFri, 26 Aug 2022 12:33:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AF5CC61FC0;\n\tFri, 26 Aug 2022 14:33:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 616F161FA2\n\tfor ;\n\tFri, 26 Aug 2022 14:33:04 +0200 (CEST)","from [192.168.1.111] (91-158-154-79.elisa-laajakaista.fi\n\t[91.158.154.79])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 62BED3F1;\n\tFri, 26 Aug 2022 14:33:03 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661517185;\n\tbh=Y0IkLLpd7PXT/CR4ye5jLfjJEt/e3/Oi+WoGa53RDZk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=bf49i/haAamR8RG7DmvdTycYCySL1Lz78N/SpVxnqO26Vz+DQEdUtw22ZDn/DHg7S\n\twefHN4zwQpJFyBBMwGkeqmlwOxrQ9/6ZBmZZtm6SHkJu+ID5pSS7KGTzXzMW14cAIk\n\tIZGrMcXHmugv2RwZOWs65qQqkoPFviC0zRzBm+FMF4jwvIeavFLgZSCuxH56futLrG\n\tjfevaom328E11BxglGGnDSKUmlM8SVwlFKs/TGxarzkr7/i5br6XkQjNVjCrRqTiDt\n\tVMITscFs8Jk7PJ1qr9ksTM/+x463T31NJxcXgshf3zzgvi92z3/IcptfkL0RRPQNZS\n\tNhcBoMeXfC33g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661517183;\n\tbh=Y0IkLLpd7PXT/CR4ye5jLfjJEt/e3/Oi+WoGa53RDZk=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=oH0pJtdE+RRsN2q2slAvPxJ+sDZjODsYy1+p+WzNniaoIYbTrNF4YvrV6ctrtq5wJ\n\t+RSZQtzsN65C7Km8esD9xQ+Y/W6CgShsulEIZ1VsZ1c26S+fADRC4zjq9CwHzxHxrR\n\txe22SsEE2uySW2F5YU/WA/xz0LEwL+Po6LjtQn9I="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"oH0pJtdE\"; dkim-atps=neutral","Message-ID":"<92bd15dc-1464-2ba3-6f4c-0f1e7851bb54@ideasonboard.com>","Date":"Fri, 26 Aug 2022 15:33:00 +0300","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.11.0","Content-Language":"en-US","To":"Laurent Pinchart ","References":"<20220701084521.31831-1-tomi.valkeinen@ideasonboard.com>\n\t<20220701084521.31831-14-tomi.valkeinen@ideasonboard.com>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v3 13/17] py: unittests.py: Use new\n\tevents support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]